)]}'
{"modules/openstack_project/manifests/static.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"042f74b4d27feebfd1d01219baab5e631546bc6c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"  }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  ::httpd::vhost { \"logs.opendev.org\":"},{"line_number":221,"context_line":"    port       \u003d\u003e 80,"},{"line_number":222,"context_line":"    priority   \u003d\u003e \u002750\u0027,"},{"line_number":223,"context_line":"    ssl        \u003d\u003e true,"},{"line_number":224,"context_line":"    docroot    \u003d\u003e \u0027/srv/static/logs\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_a3d8b452","line":221,"range":{"start_line":221,"start_character":18,"end_line":221,"end_character":20},"updated":"2019-07-31 21:04:54.000000000","message":"Nit making this 443 might be a useful hint to readers that this vhost actually does ssl.","commit_id":"6e85e2f8cbfa0218af18576a1ebe6af56a884de5"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"924d8ae7b2f2da000ff44684d8a3985a406e3271","unresolved":false,"context_lines":[{"line_number":218,"context_line":"  }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  ::httpd::vhost { \"logs.opendev.org\":"},{"line_number":221,"context_line":"    port       \u003d\u003e 80,"},{"line_number":222,"context_line":"    priority   \u003d\u003e \u002750\u0027,"},{"line_number":223,"context_line":"    ssl        \u003d\u003e true,"},{"line_number":224,"context_line":"    docroot    \u003d\u003e \u0027/srv/static/logs\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_430a2079","line":221,"updated":"2019-07-31 21:08:18.000000000","message":"Yep.","commit_id":"6e85e2f8cbfa0218af18576a1ebe6af56a884de5"}],"modules/openstack_project/templates/logs.vhost.erb":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"fa4f5f6a4c8c460caa17f26feaa81bb89305569b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  RewriteEngine On"},{"line_number":17,"context_line":"  RewriteCond %{HTTP_HOST} !\u003c%\u003d @vhost_name %\u003e$ [NC]"},{"line_number":18,"context_line":"  RewriteRule ^/(.*)$ http://\u003c%\u003d @vhost_name %\u003e/$1 [L,R\u003d301]"},{"line_number":19,"context_line":"\u003c% end -%\u003e"},{"line_number":20,"context_line":"  DocumentRoot \u003c%\u003d @docroot %\u003e"},{"line_number":21,"context_line":"  \u003cDirectory \u003c%\u003d @docroot %\u003e\u003e"},{"line_number":22,"context_line":"    Options Indexes FollowSymLinks MultiViews"}],"source_content_type":"application/x-erb","patch_set":1,"id":"7faddb67_8306d885","line":19,"updated":"2019-07-31 21:06:44.000000000","message":"I think it\u0027s here because if there are no aliases then the redirect rules for non-canonical names are useless.","commit_id":"6e85e2f8cbfa0218af18576a1ebe6af56a884de5"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"924d8ae7b2f2da000ff44684d8a3985a406e3271","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  RewriteEngine On"},{"line_number":17,"context_line":"  RewriteCond %{HTTP_HOST} !\u003c%\u003d @vhost_name %\u003e$ [NC]"},{"line_number":18,"context_line":"  RewriteRule ^/(.*)$ http://\u003c%\u003d @vhost_name %\u003e/$1 [L,R\u003d301]"},{"line_number":19,"context_line":"\u003c% end -%\u003e"},{"line_number":20,"context_line":"  DocumentRoot \u003c%\u003d @docroot %\u003e"},{"line_number":21,"context_line":"  \u003cDirectory \u003c%\u003d @docroot %\u003e\u003e"},{"line_number":22,"context_line":"    Options Indexes FollowSymLinks MultiViews"}],"source_content_type":"application/x-erb","patch_set":1,"id":"7faddb67_630f1c88","line":19,"updated":"2019-07-31 21:08:18.000000000","message":"Oh yeah, i didn\u0027t see that when i copypastad.","commit_id":"6e85e2f8cbfa0218af18576a1ebe6af56a884de5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"042f74b4d27feebfd1d01219baab5e631546bc6c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  RewriteEngine On"},{"line_number":17,"context_line":"  RewriteCond %{HTTP_HOST} !\u003c%\u003d @vhost_name %\u003e$ [NC]"},{"line_number":18,"context_line":"  RewriteRule ^/(.*)$ http://\u003c%\u003d @vhost_name %\u003e/$1 [L,R\u003d301]"},{"line_number":19,"context_line":"\u003c% end -%\u003e"},{"line_number":20,"context_line":"  DocumentRoot \u003c%\u003d @docroot %\u003e"},{"line_number":21,"context_line":"  \u003cDirectory \u003c%\u003d @docroot %\u003e\u003e"},{"line_number":22,"context_line":"    Options Indexes FollowSymLinks MultiViews"}],"source_content_type":"application/x-erb","patch_set":1,"id":"7faddb67_c373704d","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":10},"updated":"2019-07-31 21:04:54.000000000","message":"Should this end tag go after line 15 above? Then the rewrite stuff can pop out of the elsif block and we can redirect everything to https:// instead of http:// currently at line 18.","commit_id":"6e85e2f8cbfa0218af18576a1ebe6af56a884de5"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2e56aa99788c4cd2f2dbd36242d9b02446e2a8cf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    AllowOverrideList Redirect RedirectMatch"},{"line_number":25,"context_line":"    Satisfy Any"},{"line_number":26,"context_line":"    Require all granted"},{"line_number":27,"context_line":"  \u003c/Directory\u003e"},{"line_number":28,"context_line":"  LogLevel warn"},{"line_number":29,"context_line":"  ErrorLog /var/log/apache2/\u003c%\u003d @vhost_name %\u003e_error.log"},{"line_number":30,"context_line":"  CustomLog /var/log/apache2/\u003c%\u003d @vhost_name %\u003e_access.log combined"}],"source_content_type":"application/x-erb","patch_set":1,"id":"7faddb67_a3943438","line":27,"updated":"2019-07-31 21:03:53.000000000","message":"Does this vhost not need all the WSGI/FileMatch/et cetera that the https vhost below includes?","commit_id":"6e85e2f8cbfa0218af18576a1ebe6af56a884de5"}]}
