)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ddf47b1ab1b4d687eda75e02a115fba7d252bf3d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"new gitea-lb role."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"statsd reporting is made optional with an argument.  This"},{"line_number":17,"context_line":"enables/disables the service in the docker compose."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Role documenation is updated."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"cf52ebb7_7becfaee","line":17,"updated":"2021-11-30 19:20:28.000000000","message":"When would we ever disable it?","commit_id":"3ca9f5a8c97eabecd9d63eba130b812d98cbabab"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"af874b7f3a48741bb800f5d23f95cf3a53e3a488","unresolved":true,"context_lines":[{"line_number":14,"context_line":"new gitea-lb role."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"statsd reporting is made optional with an argument.  This"},{"line_number":17,"context_line":"enables/disables the service in the docker compose."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Role documenation is updated."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"d8332f27_15cbb2d0","line":17,"in_reply_to":"cf52ebb7_7becfaee","updated":"2021-11-30 19:24:13.000000000","message":"I can\u0027t remember my thinking at the time, but I feel like it was related to gate testing it","commit_id":"3ca9f5a8c97eabecd9d63eba130b812d98cbabab"}],"playbooks/roles/haproxy/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"83fd20a19c4820cd6c58528ce51acf0952235d9c","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Write haproxy config file"},{"line_number":22,"context_line":"  template:"},{"line_number":23,"context_line":"    src: \u0027{{ haproxy_config_template }}\u0027"},{"line_number":24,"context_line":"    dest: /var/haproxy/etc/haproxy.cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Ensure docker compose configuration directory"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ffe7c742_fa8dc23a","line":23,"updated":"2021-11-30 21:26:22.000000000","message":"I\u0027m somewhat impressed that ansible is able to find this file relative to the gitea-lb role using relative paths from within the haproxy role. This is something that puppet has struggled with in the past.\n\nThat said I wonder if we shouldn\u0027t try to qualify the haproxy.cfg.j2 path a bit more in gitea-lb.","commit_id":"d66389035f599bf17ab8c574c8be9ce99e00fbc6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"415679af2dbde4885ec755f39edfcb7663c21b33","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Write haproxy config file"},{"line_number":22,"context_line":"  template:"},{"line_number":23,"context_line":"    src: \u0027{{ haproxy_config_template }}\u0027"},{"line_number":24,"context_line":"    dest: /var/haproxy/etc/haproxy.cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Ensure docker compose configuration directory"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"59c64aa5_4ba81e06","line":23,"in_reply_to":"ffe7c742_fa8dc23a","updated":"2021-11-30 22:50:24.000000000","message":"I think this is intentional that it looks at the path of the parent role (https://docs.ansible.com/ansible/latest/user_guide/playbook_pathing.html#the-magic-of-local-paths).\n\nHowever, I agree it is quite magic.  I think the best thing would be to more explicitly name the template (prefix with gitea-) so that we don\u0027t ever have two generically named haproxy.cfg.j2 files we need to decide between","commit_id":"d66389035f599bf17ab8c574c8be9ce99e00fbc6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"83fd20a19c4820cd6c58528ce51acf0952235d9c","unresolved":true,"context_lines":[{"line_number":21,"context_line":"- name: Write haproxy config file"},{"line_number":22,"context_line":"  template:"},{"line_number":23,"context_line":"    src: \u0027{{ haproxy_config_template }}\u0027"},{"line_number":24,"context_line":"    dest: /var/haproxy/etc/haproxy.cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Ensure docker compose configuration directory"},{"line_number":27,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"31178c5b_4685e40e","line":24,"updated":"2021-11-30 21:26:22.000000000","message":"We weren\u0027t doing it before but maybe we should set ownership and mode on this file? I think it is owner: 1000 group: 1000 and mode: 0644?","commit_id":"d66389035f599bf17ab8c574c8be9ce99e00fbc6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a0e18b14438bd062c649150c3329195f2df36f0b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"- name: Write haproxy config file"},{"line_number":22,"context_line":"  template:"},{"line_number":23,"context_line":"    src: \u0027{{ haproxy_config_template }}\u0027"},{"line_number":24,"context_line":"    dest: /var/haproxy/etc/haproxy.cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Ensure docker compose configuration directory"},{"line_number":27,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d0b168af_8c7b034b","line":24,"in_reply_to":"31178c5b_4685e40e","updated":"2021-11-30 22:36:13.000000000","message":"Done","commit_id":"d66389035f599bf17ab8c574c8be9ce99e00fbc6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bf60ede094b61383116f8410732d0ec48c88a5f6","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    state: directory"},{"line_number":30,"context_line":"    owner: root"},{"line_number":31,"context_line":"    group: root"},{"line_number":32,"context_line":"    mode: 0644"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Install docker-compose configuration"},{"line_number":35,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"eb6dea74_f9d3cbb8","line":32,"updated":"2021-11-30 21:27:10.000000000","message":"Since this is a directory it should be 0755","commit_id":"d66389035f599bf17ab8c574c8be9ce99e00fbc6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a0e18b14438bd062c649150c3329195f2df36f0b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    state: directory"},{"line_number":30,"context_line":"    owner: root"},{"line_number":31,"context_line":"    group: root"},{"line_number":32,"context_line":"    mode: 0644"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Install docker-compose configuration"},{"line_number":35,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d3481b2b_d8784a5a","line":32,"in_reply_to":"eb6dea74_f9d3cbb8","updated":"2021-11-30 22:36:13.000000000","message":"Done","commit_id":"d66389035f599bf17ab8c574c8be9ce99e00fbc6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"83fd20a19c4820cd6c58528ce51acf0952235d9c","unresolved":true,"context_lines":[{"line_number":34,"context_line":"- name: Install docker-compose configuration"},{"line_number":35,"context_line":"  template:"},{"line_number":36,"context_line":"    src: docker-compose.yaml.j2"},{"line_number":37,"context_line":"    dest: /etc/haproxy-docker/docker-compose.yaml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  notify: Reload haproxy"},{"line_number":40,"context_line":"- name: Run docker-compose pull"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"69a5833f_2dd86c4a","line":37,"updated":"2021-11-30 21:26:22.000000000","message":"Same question about setting mode and owner for this file. The previous synchronize would\u0027ve ensured it matched the local mode and owner I think.","commit_id":"d66389035f599bf17ab8c574c8be9ce99e00fbc6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a0e18b14438bd062c649150c3329195f2df36f0b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- name: Install docker-compose configuration"},{"line_number":35,"context_line":"  template:"},{"line_number":36,"context_line":"    src: docker-compose.yaml.j2"},{"line_number":37,"context_line":"    dest: /etc/haproxy-docker/docker-compose.yaml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  notify: Reload haproxy"},{"line_number":40,"context_line":"- name: Run docker-compose pull"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a3dafb60_537c8f43","line":37,"in_reply_to":"69a5833f_2dd86c4a","updated":"2021-11-30 22:36:13.000000000","message":"done as root","commit_id":"d66389035f599bf17ab8c574c8be9ce99e00fbc6"}]}