)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ea5e65b480c3cd5556fb48777945e02e7c41f5ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5dd13cf1_34d27991","updated":"2022-08-04 06:25:17.000000000","message":"approving this and the follow-on that clarifies the inline behaviour","commit_id":"ed3de9bac93f907f3f7e5cf3a351c6ba8ec53028"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a8161ac6e8c7da6105c49d84f657639463451038","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0085458a_6c0ede3f","updated":"2022-08-05 05:14:51.000000000","message":"recheck","commit_id":"864f39bfff904f8f000de97743c9cfdaa1fe34d4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"85563fae1f008e66b23d9883f50518dd18d6dd7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"158a3a9c_406fa0a9","updated":"2022-08-11 00:47:24.000000000","message":"recheck","commit_id":"864f39bfff904f8f000de97743c9cfdaa1fe34d4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1ec842dd74152b2fa274f4052a27c7536d192ba4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"35bcc981_14ed705f","updated":"2022-08-08 04:52:04.000000000","message":"recheck","commit_id":"864f39bfff904f8f000de97743c9cfdaa1fe34d4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"141cbef06203a8434abb3bfc8634941a8fe88cab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6dc336aa_c9a6f7b3","updated":"2022-08-08 23:58:56.000000000","message":"recheck","commit_id":"864f39bfff904f8f000de97743c9cfdaa1fe34d4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ea3226b37f26c6a7329fd95c7c95cf2f6e903bdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eda8a691_e364dcdc","updated":"2022-08-08 02:16:21.000000000","message":"recheck","commit_id":"864f39bfff904f8f000de97743c9cfdaa1fe34d4"}],"playbooks/roles/letsencrypt-acme-sh-install/files/driver.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ae01f35efdd46e4da585c42c02593f29a373fba1","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        _exit_code\u003d${PIPESTATUS[0]}"},{"line_number":58,"context_line":"        if [[ ${_exit_code} \u003d\u003d 2 ]]; then"},{"line_number":59,"context_line":"            echo \"Valid and current certificate found\" \u003e\u003e ${LOG_FILE}"},{"line_number":60,"context_line":"            exit 0"},{"line_number":61,"context_line":"        elif [[ ${_exit_code} \u003d\u003d 3 ]]; then"},{"line_number":62,"context_line":"            echo \"Certificate request issued\" \u003e\u003e ${LOG_FILE}"},{"line_number":63,"context_line":"        else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"a5ed40c2_354a5b7e","line":60,"updated":"2022-07-19 22:14:38.000000000","message":"Nit maybe don\u0027t exit 0 here and let it fall through like the \u003d\u003d 3 case? Just a bit more consistent that way and shows that falling through is a safe 0 exit code.","commit_id":"ed3de9bac93f907f3f7e5cf3a351c6ba8ec53028"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ac6364073baf6b885cc09efb6761e0d626ded718","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        _exit_code\u003d${PIPESTATUS[0]}"},{"line_number":58,"context_line":"        if [[ ${_exit_code} \u003d\u003d 2 ]]; then"},{"line_number":59,"context_line":"            echo \"Valid and current certificate found\" \u003e\u003e ${LOG_FILE}"},{"line_number":60,"context_line":"            exit 0"},{"line_number":61,"context_line":"        elif [[ ${_exit_code} \u003d\u003d 3 ]]; then"},{"line_number":62,"context_line":"            echo \"Certificate request issued\" \u003e\u003e ${LOG_FILE}"},{"line_number":63,"context_line":"        else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"c8a4933e_f0942de4","line":60,"in_reply_to":"a5ed40c2_354a5b7e","updated":"2022-07-20 00:15:31.000000000","message":"actaully I think this is more like a bug.  This section is supposed to be \"terminal\" in that no further processing happens.  The fact that this falls out an returns zero is more happy accident than thought out by me 😊\n\nI think it will be clearer to explicitly exit with 0 here, to make it clear that we\u0027re handling this error code","commit_id":"ed3de9bac93f907f3f7e5cf3a351c6ba8ec53028"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ea5e65b480c3cd5556fb48777945e02e7c41f5ee","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        _exit_code\u003d${PIPESTATUS[0]}"},{"line_number":58,"context_line":"        if [[ ${_exit_code} \u003d\u003d 2 ]]; then"},{"line_number":59,"context_line":"            echo \"Valid and current certificate found\" \u003e\u003e ${LOG_FILE}"},{"line_number":60,"context_line":"            exit 0"},{"line_number":61,"context_line":"        elif [[ ${_exit_code} \u003d\u003d 3 ]]; then"},{"line_number":62,"context_line":"            echo \"Certificate request issued\" \u003e\u003e ${LOG_FILE}"},{"line_number":63,"context_line":"        else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dbae3c3e_ec9ba68a","line":60,"in_reply_to":"c8a4933e_f0942de4","updated":"2022-08-04 06:25:17.000000000","message":"this is clarified with https://review.opendev.org/c/opendev/system-config/+/850435/1","commit_id":"ed3de9bac93f907f3f7e5cf3a351c6ba8ec53028"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ae01f35efdd46e4da585c42c02593f29a373fba1","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        _exit_code\u003d${PIPESTATUS[0]}"},{"line_number":110,"context_line":"        if [[ ${_exit_code} \u003d\u003d 2 ]]; then"},{"line_number":111,"context_line":"            echo \"Valid and current certificate found\" \u003e\u003e ${LOG_FILE}"},{"line_number":112,"context_line":"            exit 0"},{"line_number":113,"context_line":"        elif [[ ${_exit_code} \u003d\u003d 0 ]]; then"},{"line_number":114,"context_line":"            echo \"Certificate renewed\" \u003e\u003e ${LOG_FILE}"},{"line_number":115,"context_line":"        else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"a8460cd1_883756a5","line":112,"updated":"2022-07-19 22:14:38.000000000","message":"See above.","commit_id":"ed3de9bac93f907f3f7e5cf3a351c6ba8ec53028"}]}