)]}'
{"docker/python-builder/scripts/assemble":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"63ec906b862b0b2cab174361416fdc2194efefe6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"done"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# pbr needs git installed, else nothing will work. Do this in between"},{"line_number":87,"context_line":"# bindep and wheel so that we don\u0027t miss git in target images."},{"line_number":88,"context_line":"apt-get install -y git"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Use a clean virtualenv for install steps to prevent things from the"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_f00a3477","line":87,"range":{"start_line":87,"start_character":19,"end_line":87,"end_character":61},"updated":"2019-12-03 17:21:36.000000000","message":"Don\u0027t we need to install runtime deps in the target image? This build image simply builds the python package which we copy out and install into the target image which won\u0027t include git?","commit_id":"5e12438e0dbed995e2ae1c74e89d068ea03164f9"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"79aea45a88a58409cc574c261d60aa9df2619f19","unresolved":false,"context_lines":[{"line_number":84,"context_line":"done"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# pbr needs git installed, else nothing will work. Do this in between"},{"line_number":87,"context_line":"# bindep and wheel so that we don\u0027t miss git in target images."},{"line_number":88,"context_line":"apt-get install -y git"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Use a clean virtualenv for install steps to prevent things from the"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_5062283f","line":87,"range":{"start_line":87,"start_character":19,"end_line":87,"end_character":61},"in_reply_to":"3fa7e38b_f00a3477","updated":"2019-12-03 17:24:30.000000000","message":"We do need to install runtime deps in the target image - but we produce that list in the builder image and write it to /output/bindep/run.txt - so that the target image doesn\u0027t have to have bindep installed.\n\nSo if we install git before producing the list in /output/bindep/run.txt - run.txt will erroneously not list git in the packages to be installed in runtime image.","commit_id":"5e12438e0dbed995e2ae1c74e89d068ea03164f9"}]}