)]}'
{"playbooks/roles/letsencrypt-create-certs/handlers/main.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6e16ef44d58b2a123b41262de1e025fffe619644","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Static"},{"line_number":24,"context_line":"- name: letsencrypt updated static01-governance-openstack-org"},{"line_number":25,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: letsencrypt updated static01-security-openstack-org"},{"line_number":28,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_6c6a13ed","line":25,"updated":"2020-01-15 22:29:39.000000000","message":"Should I have renamed the file for this role in Iac3fad3d0d8216914d94a42f7705e07cef741847 and not just changed its name and state?","commit_id":"46898f3415105b658c7615bbba59500503446da2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"52925606b0d8cf4785dfec6d965f6fa91c04cb5e","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Static"},{"line_number":24,"context_line":"- name: letsencrypt updated static01-governance-openstack-org"},{"line_number":25,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: letsencrypt updated static01-security-openstack-org"},{"line_number":28,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_5593164f","line":25,"in_reply_to":"3fa7e38b_6c6a13ed","updated":"2020-01-16 03:05:34.000000000","message":"i think it\u0027s ok, we get the idea :)","commit_id":"46898f3415105b658c7615bbba59500503446da2"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bc891053e6ccb460a84f0c8be26a268d05cf1efc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: letsencrypt updated static01-security-openstack-org"},{"line_number":28,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Mirrors"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_23346bf9","line":28,"updated":"2020-01-11 00:07:35.000000000","message":"These are likely to happen together right? I wonder if there is some way we can collapse the apache restarts into a single restart per host.\n\nOr will the time skewing end up renewing these randomly over time making it not worthwhile?","commit_id":"46898f3415105b658c7615bbba59500503446da2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e4cae6c9deee6b504f67f36267165c716bcc2aaa","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: letsencrypt updated static01-security-openstack-org"},{"line_number":28,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Mirrors"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_7e996a69","line":28,"in_reply_to":"3fa7e38b_23346bf9","updated":"2020-01-15 00:09:13.000000000","message":"this is definitely the hackiest bit of all this\n\nperhaps having this as a no-op that then does a notify?","commit_id":"46898f3415105b658c7615bbba59500503446da2"}],"playbooks/roles/static/files/50-governance.openstack.org.conf":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1777b918d9be67166ce3287dd15060e1bd6e914d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  SSLHonorCipherOrder on"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  # Alias other folders"},{"line_number":27,"context_line":"  Alias \"/election/\" \"/afs/openstack.org/governance.openstack.org/election/\""},{"line_number":28,"context_line":"  Alias \"/sigs/\" \"/afs/openstack.org/governance.openstack.org/sigs/\""},{"line_number":29,"context_line":"  Alias \"/tc/\" \"/afs/openstack.org/governance.openstack.org/tc/\""},{"line_number":30,"context_line":"  Alias \"/uc/\" \"/afs/openstack.org/governance.openstack.org/uc/\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  # Set up redirects"},{"line_number":33,"context_line":"  Redirect \"/badges/\" \"/tc/badges/\""}],"source_content_type":"text/plain","patch_set":2,"id":"3fa7e38b_5fdaf01c","line":30,"range":{"start_line":27,"start_character":1,"end_line":30,"end_character":64},"updated":"2019-12-09 04:38:30.000000000","message":"AJaeger; can I confirm with you that \n\n* elections\n* sigs\n* tc\n* uc\n\nare all set to publish to /afs/openstack.org/governance.openstack.org?\n\nThat is, https://review.opendev.org/681583 covers all of these?","commit_id":"419f8c0fad7fc4fcb4393c10860356d78de17c6e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8fba6d8fa3ad1ce01921aea93d2e95512ee685c8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  # Alias other folders"},{"line_number":27,"context_line":"  Alias \"/election/\" \"/afs/openstack.org/governance.openstack.org/election/\""},{"line_number":28,"context_line":"  Alias \"/sigs/\" \"/afs/openstack.org/governance.openstack.org/sigs/\""},{"line_number":29,"context_line":"  Alias \"/tc/\" \"/afs/openstack.org/governance.openstack.org/tc/\""},{"line_number":30,"context_line":"  Alias \"/uc/\" \"/afs/openstack.org/governance.openstack.org/uc/\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  # Set up redirects"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_4258d7f7","line":29,"range":{"start_line":29,"start_character":60,"end_line":29,"end_character":64},"updated":"2019-12-09 07:21:56.000000000","message":"http://files.openstack.org/project/governance.openstack.org/tc is the URL, should there be a \"/project\" in these?","commit_id":"ab025e8dc419905de71e104bbf8ac6af43d242ee"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8fba6d8fa3ad1ce01921aea93d2e95512ee685c8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    Satisfy Any"},{"line_number":49,"context_line":"    Require all granted"},{"line_number":50,"context_line":"  \u003c/Directory\u003e"},{"line_number":51,"context_line":"  "},{"line_number":52,"context_line":"  \u003c/Directory\u003e"},{"line_number":53,"context_line":"    \u003cDirectory /afs/openstack.org/governance.openstack.org/sigs\u003e"},{"line_number":54,"context_line":"    Options Indexes FollowSymLinks MultiViews"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_e270e375","line":51,"updated":"2019-12-09 07:21:56.000000000","message":"extra whitespace here and in lines 59, 67, 75","commit_id":"ab025e8dc419905de71e104bbf8ac6af43d242ee"}],"playbooks/roles/static/handlers/main.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6e16ef44d58b2a123b41262de1e025fffe619644","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: restart apache2"},{"line_number":2,"context_line":"  service:"},{"line_number":3,"context_line":"    name: apache2"},{"line_number":4,"context_line":"    state: restarted"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_2c6c1b04","line":4,"updated":"2020-01-15 22:29:39.000000000","message":"This can be updated to \"reloaded\" similar to what I did in Iac3fad3d0d8216914d94a42f7705e07cef741847 right? Or is it changing something which actually needs a non-graceful restart? (I can\u0027t think of what that would be).","commit_id":"46898f3415105b658c7615bbba59500503446da2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"52925606b0d8cf4785dfec6d965f6fa91c04cb5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: restart apache2"},{"line_number":2,"context_line":"  service:"},{"line_number":3,"context_line":"    name: apache2"},{"line_number":4,"context_line":"    state: restarted"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_75af327c","line":4,"in_reply_to":"3fa7e38b_2c6c1b04","updated":"2020-01-16 03:05:34.000000000","message":"will do; as long as that passes CI in that the service has started, otherwise there was no specific reason for restart v reloaded","commit_id":"46898f3415105b658c7615bbba59500503446da2"}],"playbooks/roles/static/tasks/main.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8fba6d8fa3ad1ce01921aea93d2e95512ee685c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check AFS mounted"},{"line_number":2,"context_line":"  stat:"},{"line_number":3,"context_line":"    path: \"/afs/openstack.org/projects\""},{"line_number":4,"context_line":"  register: afs_mirror"},{"line_number":5,"context_line":"- name: Sanity check AFS"},{"line_number":6,"context_line":"  assert:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_026e5f95","line":3,"range":{"start_line":3,"start_character":31,"end_line":3,"end_character":38},"updated":"2019-12-09 07:21:56.000000000","message":"here you have /projects/","commit_id":"ab025e8dc419905de71e104bbf8ac6af43d242ee"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bc891053e6ccb460a84f0c8be26a268d05cf1efc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check AFS mounted"},{"line_number":2,"context_line":"  stat:"},{"line_number":3,"context_line":"    path: \"/afs/openstack.org/project\""},{"line_number":4,"context_line":"  register: afs_mirror"},{"line_number":5,"context_line":"- name: Sanity check AFS"},{"line_number":6,"context_line":"  assert:"},{"line_number":7,"context_line":"    that:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_031daf75","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":22},"updated":"2020-01-11 00:07:35.000000000","message":"Nit this isn\u0027t the mirror content on afs.","commit_id":"46898f3415105b658c7615bbba59500503446da2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8000856f05456ac89f02a976ce7794be66de2535","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check AFS mounted"},{"line_number":2,"context_line":"  stat:"},{"line_number":3,"context_line":"    path: \"/afs/openstack.org/project\""},{"line_number":4,"context_line":"  register: afs_mirror"},{"line_number":5,"context_line":"- name: Sanity check AFS"},{"line_number":6,"context_line":"  assert:"},{"line_number":7,"context_line":"    that:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_d5d4e6ec","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":22},"in_reply_to":"3fa7e38b_031daf75","updated":"2020-01-16 03:09:57.000000000","message":"Done","commit_id":"46898f3415105b658c7615bbba59500503446da2"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bc891053e6ccb460a84f0c8be26a268d05cf1efc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Sanity check AFS"},{"line_number":6,"context_line":"  assert:"},{"line_number":7,"context_line":"    that:"},{"line_number":8,"context_line":"      - afs_mirror.stat.exists"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Install apache2"},{"line_number":11,"context_line":"  apt:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_a327fbc7","line":8,"updated":"2020-01-11 00:07:35.000000000","message":"See above.","commit_id":"46898f3415105b658c7615bbba59500503446da2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8000856f05456ac89f02a976ce7794be66de2535","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Sanity check AFS"},{"line_number":6,"context_line":"  assert:"},{"line_number":7,"context_line":"    that:"},{"line_number":8,"context_line":"      - afs_mirror.stat.exists"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Install apache2"},{"line_number":11,"context_line":"  apt:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_f5cfa251","line":8,"in_reply_to":"3fa7e38b_a327fbc7","updated":"2020-01-16 03:09:57.000000000","message":"Done","commit_id":"46898f3415105b658c7615bbba59500503446da2"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6e16ef44d58b2a123b41262de1e025fffe619644","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  args:"},{"line_number":69,"context_line":"    creates: /etc/apache2/sites-enabled/50-governance.openstack.org"},{"line_number":70,"context_line":"  notify:"},{"line_number":71,"context_line":"    - restart apache2"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# security.openstack.org"},{"line_number":74,"context_line":"- name: Install security.openstack.org"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_0c711fe0","line":71,"updated":"2020-01-15 22:29:39.000000000","message":"Per comment in the handler, adding/altering a vhost config works fine with \"reload\" (which underneath is simply calling a graceful restart anyway, as opposed to a hard restart which disconnects all active clients).","commit_id":"46898f3415105b658c7615bbba59500503446da2"}],"testinfra/test_static.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bc891053e6ccb460a84f0c8be26a268d05cf1efc","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def test_governance_openstack_org(host):"},{"line_number":24,"context_line":"    cmd \u003d host.run(\u0027curl --insecure \u0027"},{"line_number":25,"context_line":"                   \u0027--resolve governance.openstack.org:443:127.0.0.1 \u0027"},{"line_number":26,"context_line":"                   \u0027https://governance.openstack.org/\u0027)"},{"line_number":27,"context_line":"    assert \u0027OpenStack Governance\u0027 in cmd.stdout"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_c32237b7","line":25,"range":{"start_line":25,"start_character":20,"end_line":25,"end_character":29},"updated":"2020-01-11 00:07:35.000000000","message":"I never knew about this. This is an awesome flag.","commit_id":"46898f3415105b658c7615bbba59500503446da2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8000856f05456ac89f02a976ce7794be66de2535","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def test_governance_openstack_org(host):"},{"line_number":24,"context_line":"    cmd \u003d host.run(\u0027curl --insecure \u0027"},{"line_number":25,"context_line":"                   \u0027--resolve governance.openstack.org:443:127.0.0.1 \u0027"},{"line_number":26,"context_line":"                   \u0027https://governance.openstack.org/\u0027)"},{"line_number":27,"context_line":"    assert \u0027OpenStack Governance\u0027 in cmd.stdout"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_75fdf26b","line":25,"range":{"start_line":25,"start_character":20,"end_line":25,"end_character":29},"in_reply_to":"3fa7e38b_c32237b7","updated":"2020-01-16 03:09:57.000000000","message":"yeah, you can get trapped with this working for a single host if it\u0027s the default apache host, but for TLS to work properly it has to have the name resolution","commit_id":"46898f3415105b658c7615bbba59500503446da2"}]}