)]}'
{"playbooks/roles/install-kubectl/files/99-pin-google-kubectl":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6e512909bdfcd017a1e3247bc66c952bf49d7135","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Never prefer packages from the my-custom-repo repository"},{"line_number":2,"context_line":"Package: *"},{"line_number":3,"context_line":"Pin: origin o\u003dapt.kubernetes.io"},{"line_number":4,"context_line":"Pin-Priority: 1"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"df33271e_d5578ac9","line":1,"updated":"2020-03-31 19:26:25.000000000","message":"These comments could maybe use un-generifying, but the meaning is clear anyway.","commit_id":"1d664c92a533cbe56ddc2dd111b68230de02cb9d"}],"playbooks/roles/install-kubectl/tasks/main.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a32f47611c33b72db84758f138d7ebbb4c37a48a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  with_items:"},{"line_number":19,"context_line":"    - apt-transport-https"},{"line_number":20,"context_line":"    - ca-certificates"},{"line_number":21,"context_line":"    - software-properties-common"},{"line_number":22,"context_line":"  become: yes"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add kubectl GPG key"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_d7bb87c1","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":32},"updated":"2020-02-27 14:15:16.000000000","message":"I\u0027m actually not convinced we need this package ...","commit_id":"72e88649363831cfa6c72068e64be9743a3bfd8f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"33a94b2d974aee8506a86c6d7f0aaaee58a64344","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  with_items:"},{"line_number":19,"context_line":"    - apt-transport-https"},{"line_number":20,"context_line":"    - ca-certificates"},{"line_number":21,"context_line":"    - software-properties-common"},{"line_number":22,"context_line":"  become: yes"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add kubectl GPG key"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_f7f3239d","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":32},"in_reply_to":"1fa4df85_d7bb87c1","updated":"2020-02-27 14:29:13.000000000","message":"Yeah, you would need it if you\u0027d run add-apt-repository in order to add the repo, but you\u0027re creating it directly from a template below, so o.k. to drop this IMO.","commit_id":"72e88649363831cfa6c72068e64be9743a3bfd8f"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"346c1cb1df69597eee8647eae622d25cb44d00ad","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- name: Add kubectl GPG key"},{"line_number":25,"context_line":"  become: yes"},{"line_number":26,"context_line":"  apt_key:"},{"line_number":27,"context_line":"    data: \"{{ kubectl_ubuntu_gpg_key }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Add kubectl apt repo"},{"line_number":30,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_b714cba1","line":27,"updated":"2020-02-27 14:21:57.000000000","message":"We should be aware that doing this allows Google\u0027s key to sign package lists in any repository we\u0027re using and apt will still consider it valid.","commit_id":"72e88649363831cfa6c72068e64be9743a3bfd8f"}],"playbooks/roles/install-kubectl/templates/sources.list.j2":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"346c1cb1df69597eee8647eae622d25cb44d00ad","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# but the kubernetes folks provide this url in their docs."},{"line_number":4,"context_line":"# Presumably they could choose to change the redirect target, so"},{"line_number":5,"context_line":"# we use the alias."},{"line_number":6,"context_line":"deb https://apt.kubernetes.io/ kubernetes-xenial main"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1fa4df85_1744bfb6","line":6,"updated":"2020-02-27 14:21:57.000000000","message":"We should be aware that any packages in this repository will be used if they satisfy an install or upgrade request to apt.","commit_id":"72e88649363831cfa6c72068e64be9743a3bfd8f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"33a94b2d974aee8506a86c6d7f0aaaee58a64344","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# but the kubernetes folks provide this url in their docs."},{"line_number":4,"context_line":"# Presumably they could choose to change the redirect target, so"},{"line_number":5,"context_line":"# we use the alias."},{"line_number":6,"context_line":"deb https://apt.kubernetes.io/ kubernetes-xenial main"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1fa4df85_57d6b7c5","line":6,"in_reply_to":"1fa4df85_1744bfb6","updated":"2020-02-27 14:29:13.000000000","message":"Would we need to cache/mirror this for stability?\n\nAlso, if the pkgs really only contains a single static binary, maybe we\u0027d prefer to download or otherwise install that directly as mentioned in the first section of https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl-on-linux","commit_id":"72e88649363831cfa6c72068e64be9743a3bfd8f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"de5e48354914ee6b97cb0aa633932d01ff899dce","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# but the kubernetes folks provide this url in their docs."},{"line_number":4,"context_line":"# Presumably they could choose to change the redirect target, so"},{"line_number":5,"context_line":"# we use the alias."},{"line_number":6,"context_line":"deb https://apt.kubernetes.io/ kubernetes-xenial main"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1fa4df85_57ad572f","line":6,"in_reply_to":"1fa4df85_57d6b7c5","updated":"2020-02-27 14:35:42.000000000","message":"I think with that though it\u0027s tough for us to update. Since this is used on bridge, I think it\u0027s better for us to track a repo?\n\nAlso - this is a prod role and not a CI role - I don\u0027t think it\u0027s necessary (even though we do do this in CI - we don\u0027t do it THAT much)","commit_id":"72e88649363831cfa6c72068e64be9743a3bfd8f"}]}