)]}'
{"playbooks/roles/nodepool-base/defaults/main.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1a929656657049f3cd3ea0aed767c9c4743b5c03","unresolved":false,"context_lines":[{"line_number":1,"context_line":"nodepool_base_install_zookeeper: False"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Keep these in sync with the container uid\u0027s so containers can write"},{"line_number":4,"context_line":"# to local bits and pieces."},{"line_number":5,"context_line":"nodepool_base_nodepool_uid: 10001"},{"line_number":6,"context_line":"nodepool_base_nodepool_gid: 10001"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1fa4df85_9a67c64d","line":4,"updated":"2020-03-10 19:39:29.000000000","message":"I didn\u0027t expect this.  Specifically what \"local bits and pieces\" are we fixing here?","commit_id":"ab6bf07900b86dc8944283a51e4fdf60d3909ad3"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"a34023bb4f73963b0a752af0db21f6f4a46772f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"nodepool_base_install_zookeeper: False"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Keep these in sync with the container uid\u0027s so containers can write"},{"line_number":4,"context_line":"# to local bits and pieces."},{"line_number":5,"context_line":"nodepool_base_nodepool_uid: 10001"},{"line_number":6,"context_line":"nodepool_base_nodepool_gid: 10001"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1fa4df85_5d5dc876","line":4,"updated":"2020-03-10 20:44:26.000000000","message":"I like having the build logs and images mounted on the host.  It will make debugging more convenient.  And it\u0027s true, we probably don\u0027t need a nodepool user, but we would at least need to set the uid of those to 10001.  My main concern isn\u0027t actually with the idea of having a nodepool user, it\u0027s that we need to know the uid.  But that seems unavoidable, so as long as it isn\u0027t conflicting with something else, I\u0027m okay with keeping it this way.","commit_id":"ab6bf07900b86dc8944283a51e4fdf60d3909ad3"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ec83088d4e0698bf90f892d199e3f9007c45c9b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"nodepool_base_install_zookeeper: False"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Keep these in sync with the container uid\u0027s so containers can write"},{"line_number":4,"context_line":"# to local bits and pieces."},{"line_number":5,"context_line":"nodepool_base_nodepool_uid: 10001"},{"line_number":6,"context_line":"nodepool_base_nodepool_gid: 10001"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1fa4df85_dde9b8e2","line":4,"updated":"2020-03-10 20:24:49.000000000","message":"The configs don\u0027t need to be writable, so we could make them root owned and world readable, but inside of a non-world-readable directory on the host.\n\nI kind of like the idea of dib_tmp being a volume.\n\nI agree that having the build logs and images accessible on the host will be convenient.  So maybe that use case alone drives this.  And as long as we\u0027re doing that, we could use it for the configs too.\n\nBut maybe dib_tmp should still be a volume?","commit_id":"ab6bf07900b86dc8944283a51e4fdf60d3909ad3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7b80b29326da86dfc44942a7b45c096349d1ba04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"nodepool_base_install_zookeeper: False"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Keep these in sync with the container uid\u0027s so containers can write"},{"line_number":4,"context_line":"# to local bits and pieces."},{"line_number":5,"context_line":"nodepool_base_nodepool_uid: 10001"},{"line_number":6,"context_line":"nodepool_base_nodepool_gid: 10001"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1fa4df85_7dd44448","line":4,"in_reply_to":"1fa4df85_9a67c64d","updated":"2020-03-10 20:14:27.000000000","message":"the container has quite a few things mapped into it from the local system that are owned by the local \"nodepool\" user\n\nconfigs (cloud and nodepool)\nthe build logs in /var/log/nodepool/builds\nthe output images in /opt/nodepool_dib\nkeeps tmp files in /opt/dib_tmp\n\nso keeping the id\u0027s the same means we can set them up in ansible with \"nodepool\" as the owner and it works from the container.","commit_id":"ab6bf07900b86dc8944283a51e4fdf60d3909ad3"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"66177b8e1e9f96272642b3f525fe2d709f3304e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"nodepool_base_install_zookeeper: False"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Keep these in sync with the container uid\u0027s so containers can write"},{"line_number":4,"context_line":"# to local bits and pieces."},{"line_number":5,"context_line":"nodepool_base_nodepool_uid: 10001"},{"line_number":6,"context_line":"nodepool_base_nodepool_gid: 10001"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1fa4df85_1dc99057","line":4,"in_reply_to":"1fa4df85_dde9b8e2","updated":"2020-03-10 20:34:13.000000000","message":"\u003e The configs don\u0027t need to be writable, so we could make them root\n \u003e owned and world readable, but inside of a non-world-readable\n \u003e directory on the host.\n\nAgree, configs don\u0027t need to be owned 10001\n \n \u003e I kind of like the idea of dib_tmp being a volume.\n \nYeah.\n\n \u003e I agree that having the build logs and images accessible on the\n \u003e host will be convenient.  So maybe that use case alone drives this.\n \u003e  And as long as we\u0027re doing that, we could use it for the configs\n \u003e too.\n \nWhy not put the build logs and images in a volume too? And do we really care about uid of the logs and images? Like - do we even need a host-level nodepool user at all?\n\n \u003e But maybe dib_tmp should still be a volume?","commit_id":"ab6bf07900b86dc8944283a51e4fdf60d3909ad3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"05b1551564eadb6748d3fd509450277594f8be8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"nodepool_base_install_zookeeper: False"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Keep these in sync with the container uid\u0027s so containers can write"},{"line_number":4,"context_line":"# to local bits and pieces."},{"line_number":5,"context_line":"nodepool_base_nodepool_uid: 10001"},{"line_number":6,"context_line":"nodepool_base_nodepool_gid: 10001"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1fa4df85_5db388e9","line":4,"in_reply_to":"1fa4df85_dde9b8e2","updated":"2020-03-10 20:34:07.000000000","message":"i agree that dib_tmp should be a volume, but it needs to be backed by very large storage on /opt; it also has mounts put on it, etc.  for version 0 I\u0027d prefer to keep it very simple and just map in the directory.\n\nhowever, i think we should have a story to track what we want to end up with","commit_id":"ab6bf07900b86dc8944283a51e4fdf60d3909ad3"}],"playbooks/roles/nodepool-builder/templates/docker-compose.yaml.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2e3364e7d5f36b3df7c7e732229dad64e9075a61","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      # nodepool config"},{"line_number":20,"context_line":"      - /etc/nodepool:/etc/nodepool:ro"},{"line_number":21,"context_line":"      # project-config"},{"line_number":22,"context_line":"      - /opt/project-config:/opt/project-config:ro"},{"line_number":23,"context_line":"      # dib temporary storage; see config in project-config"},{"line_number":24,"context_line":"      - /opt/dib_tmp:/opt/dib_tmp:rw"},{"line_number":25,"context_line":"      # dib image output; see config in project-config"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1fa4df85_288bfec2","line":22,"updated":"2020-03-09 23:18:06.000000000","message":"In a previous change I mentioned we might consider a copy of the nodepool.yaml file rather than a link. If we copied we could remove this mount.","commit_id":"3aeaf5be016ce751e77cafd295d284ec33ccaa82"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"66177b8e1e9f96272642b3f525fe2d709f3304e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"version: \u00273.0\u0027"},{"line_number":2,"context_line":"services:"},{"line_number":3,"context_line":"  nodepool-builder:"},{"line_number":4,"context_line":"    image: docker.io/zuul/nodepool-builder{{ nodepool_builder_container_tag|default(\u0027\u0027) }}"},{"line_number":5,"context_line":"    user: nodepool"},{"line_number":6,"context_line":"    network_mode: host"},{"line_number":7,"context_line":"    restart: always"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1fa4df85_1d7bd027","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":90},"updated":"2020-03-10 20:34:13.000000000","message":"This is missing an : for the tag case.\n\nPerhaps:\n\n  image docker.io/zuul/nodepool-builder:{{ nodepool_builder_container_tag|default(\u0027latest\u0027) }}\n\n?","commit_id":"ab6bf07900b86dc8944283a51e4fdf60d3909ad3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"05c920eec842f1ca37cee74cd5459f5a2ab75e78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"version: \u00273.0\u0027"},{"line_number":2,"context_line":"services:"},{"line_number":3,"context_line":"  nodepool-builder:"},{"line_number":4,"context_line":"    image: docker.io/zuul/nodepool-builder{{ nodepool_builder_container_tag|default(\u0027\u0027) }}"},{"line_number":5,"context_line":"    user: nodepool"},{"line_number":6,"context_line":"    network_mode: host"},{"line_number":7,"context_line":"    restart: always"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1fa4df85_33559dfa","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":90},"in_reply_to":"1fa4df85_1d7bd027","updated":"2020-03-10 22:16:10.000000000","message":"Done","commit_id":"ab6bf07900b86dc8944283a51e4fdf60d3909ad3"}]}