)]}'
{"inventory/service/group_vars/zookeeper.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"f03085859206f0d02e231ebbff4dc2aaeb433e9c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"zookeeper_uid: 10001"},{"line_number":4,"context_line":"zookeeper_gid: 10001"},{"line_number":5,"context_line":"iptables_extra_allowed_groups:"},{"line_number":6,"context_line":"  # Insecure (TODO: remove)"},{"line_number":7,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027group\u0027: \u0027nodepool\u0027}"},{"line_number":8,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027group\u0027: \u0027zuul\u0027}"},{"line_number":9,"context_line":"  # Secure"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_d18731d7","line":6,"updated":"2020-06-15 21:43:58.000000000","message":"Do we have the cleanup change for this proposed yet?","commit_id":"29825ac18b58145f007f64b2998357445b8fdd91"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0333ff0c1ca644df294087148d97257cba2ed7d9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"zookeeper_uid: 10001"},{"line_number":4,"context_line":"zookeeper_gid: 10001"},{"line_number":5,"context_line":"iptables_extra_allowed_groups:"},{"line_number":6,"context_line":"  # Insecure (TODO: remove)"},{"line_number":7,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027group\u0027: \u0027nodepool\u0027}"},{"line_number":8,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027group\u0027: \u0027zuul\u0027}"},{"line_number":9,"context_line":"  # Secure"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_11524968","line":6,"updated":"2020-06-15 21:44:50.000000000","message":"Nope.","commit_id":"29825ac18b58145f007f64b2998357445b8fdd91"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"1f1f046a677ec2af8e9c8940aef876f811199c74","unresolved":false,"context_lines":[{"line_number":3,"context_line":"zookeeper_uid: 10001"},{"line_number":4,"context_line":"zookeeper_gid: 10001"},{"line_number":5,"context_line":"iptables_extra_allowed_groups:"},{"line_number":6,"context_line":"  # Insecure (TODO: remove)"},{"line_number":7,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027group\u0027: \u0027nodepool\u0027}"},{"line_number":8,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027group\u0027: \u0027zuul\u0027}"},{"line_number":9,"context_line":"  # Secure"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_115c094a","line":6,"updated":"2020-06-15 21:59:46.000000000","message":"Now proposed: I688b06a85dc994803cc0ff9b0d550c87893987d2","commit_id":"29825ac18b58145f007f64b2998357445b8fdd91"}],"playbooks/group_vars/zookeeper.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"71e65eb7031d63c25a1ec66598d7981ada330fa7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"iptables_extra_allowed_hosts:"},{"line_number":2,"context_line":"  # Insecure (TODO: remove)"},{"line_number":3,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027hostname\u0027: \u0027nb01.openstack.org\u0027}"},{"line_number":4,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027hostname\u0027: \u0027nb02.openstack.org\u0027}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_8b6c2b09","line":1,"updated":"2020-05-06 23:09:23.000000000","message":"As an improvement - it kinda feels like the value of this should be able to be generated from inventory groups. Or even a single inventory group called \"zookeeper-clients\" or something like that. No need for that for now - but you know?","commit_id":"681dfcc4ab2d587a4c0a39c6fddfd436abaf080e"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f8681e341e12b760d43a1cdae82a6227811453de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"iptables_extra_allowed_hosts:"},{"line_number":2,"context_line":"  # Insecure (TODO: remove)"},{"line_number":3,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027hostname\u0027: \u0027nb01.openstack.org\u0027}"},{"line_number":4,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00272181\u0027, \u0027hostname\u0027: \u0027nb02.openstack.org\u0027}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_63eebe22","line":1,"updated":"2020-06-02 21:04:56.000000000","message":"Done! :)","commit_id":"681dfcc4ab2d587a4c0a39c6fddfd436abaf080e"}],"playbooks/roles/zk-ca/defaults/main.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"916e499a13a37414e8a88c0798cc3f11af75a08f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"zk_ca_root: /var/zk-ca"},{"line_number":2,"context_line":"zk_ca_server: \"{{ inventory_hostname }}\""},{"line_number":3,"context_line":"zk_ca_cert_dir: /etc/zuul"},{"line_number":4,"context_line":"zk_ca_cert_dir_owner: 10001"},{"line_number":5,"context_line":"zk_ca_cert_dir_group: 10001"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_4b2d0345","line":4,"updated":"2020-05-06 22:33:01.000000000","message":"Could; or actually in PS3 I\u0027m passing in the values from those vars at the place of use.","commit_id":"075f6d90d56e68523a350db054d63463a1a1b65d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"03794df4d81bc6230215d36fd0ebf2cc7a630e88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"zk_ca_root: /var/zk-ca"},{"line_number":2,"context_line":"zk_ca_server: \"{{ inventory_hostname }}\""},{"line_number":3,"context_line":"zk_ca_cert_dir: /etc/zuul"},{"line_number":4,"context_line":"zk_ca_cert_dir_owner: 10001"},{"line_number":5,"context_line":"zk_ca_cert_dir_group: 10001"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_2f136a5e","line":4,"updated":"2020-04-15 22:17:00.000000000","message":"FWIW, we set zuul_user_id in group_vars/zuul.yaml - maybe we should set this to that? and maybe move that var to a new group like \"zuul_and_nodepool_and_zk\"","commit_id":"075f6d90d56e68523a350db054d63463a1a1b65d"}],"playbooks/roles/zk-ca/zk-ca.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5002806822677fde0e5026d0863235922f62d2e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONFIG\u003d\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"make_ca() {"},{"line_number":28,"context_line":"    mkdir $CAROOT/demoCA"},{"line_number":29,"context_line":"    mkdir $CAROOT/demoCA/reqs"},{"line_number":30,"context_line":"    mkdir $CAROOT/demoCA/newcerts"},{"line_number":31,"context_line":"    mkdir $CAROOT/demoCA/crl"}],"source_content_type":"text/x-sh","patch_set":17,"id":"bf51134e_113b6938","line":28,"range":{"start_line":28,"start_character":18,"end_line":28,"end_character":24},"updated":"2020-06-15 21:42:19.000000000","message":"Should we give this a more descriptive name? Perhaps zkCA or similar?","commit_id":"29825ac18b58145f007f64b2998357445b8fdd91"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"a508ba31000136e2000cc2d6b1f5b44d20afa484","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONFIG\u003d\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"make_ca() {"},{"line_number":28,"context_line":"    mkdir $CAROOT/demoCA"},{"line_number":29,"context_line":"    mkdir $CAROOT/demoCA/reqs"},{"line_number":30,"context_line":"    mkdir $CAROOT/demoCA/newcerts"},{"line_number":31,"context_line":"    mkdir $CAROOT/demoCA/crl"}],"source_content_type":"text/x-sh","patch_set":17,"id":"bf51134e_51732116","line":28,"updated":"2020-06-15 21:44:25.000000000","message":"Then we\u0027ll need an openssl.conf to change that.  This is the default value.","commit_id":"29825ac18b58145f007f64b2998357445b8fdd91"}],"playbooks/roles/zookeeper/templates/zoo.cfg.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5002806822677fde0e5026d0863235922f62d2e3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"standaloneEnabled\u003dtrue"},{"line_number":24,"context_line":"admin.enableServer\u003dtrue"},{"line_number":25,"context_line":"secureClientPort\u003d2281"},{"line_number":26,"context_line":"ssl.keyStore.location\u003d/tls/keys/keystore.pem"},{"line_number":27,"context_line":"ssl.trustStore.location\u003d/tls/certs/cacert.pem"},{"line_number":28,"context_line":"{% for host in groups[\u0027zookeeper\u0027] %}"},{"line_number":29,"context_line":"server.{{ loop.index }}\u003d{{ (hostvars[host].public_v4) }}:2888:3888"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_71f3c59f","line":26,"range":{"start_line":26,"start_character":22,"end_line":26,"end_character":23},"updated":"2020-06-15 21:42:19.000000000","message":"Should this be prefixed with /var/zookeeper?","commit_id":"29825ac18b58145f007f64b2998357445b8fdd91"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"a508ba31000136e2000cc2d6b1f5b44d20afa484","unresolved":false,"context_lines":[{"line_number":23,"context_line":"standaloneEnabled\u003dtrue"},{"line_number":24,"context_line":"admin.enableServer\u003dtrue"},{"line_number":25,"context_line":"secureClientPort\u003d2281"},{"line_number":26,"context_line":"ssl.keyStore.location\u003d/tls/keys/keystore.pem"},{"line_number":27,"context_line":"ssl.trustStore.location\u003d/tls/certs/cacert.pem"},{"line_number":28,"context_line":"{% for host in groups[\u0027zookeeper\u0027] %}"},{"line_number":29,"context_line":"server.{{ loop.index }}\u003d{{ (hostvars[host].public_v4) }}:2888:3888"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_b161dd3c","line":26,"updated":"2020-06-15 21:44:25.000000000","message":"This is inside the container; we bind mount /var/zookeeper/tls to /tls","commit_id":"29825ac18b58145f007f64b2998357445b8fdd91"}]}