)]}'
{".zuul.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7d46da09693c40fb3ac7df731764f841d9c910e4","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"      eavesdrop01.openstack.org:"},{"line_number":1032,"context_line":"        host_copy_output:"},{"line_number":1033,"context_line":"          \u0027/etc/docker/daemon.json\u0027: logs"},{"line_number":1034,"context_line":"          \u0027/etc/hosts\u0027: logs"},{"line_number":1035,"context_line":"    files:"},{"line_number":1036,"context_line":"      - playbooks/service-eavesdrop.yaml"},{"line_number":1037,"context_line":"      - playbooks/run-accessbot.yaml"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_926da19a","line":1034,"updated":"2020-04-22 13:48:46.000000000","message":"Do we want to remove these now that we\u0027re done with debugging (which wasn\u0027t related to eavesdrop per se)?","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9a1dcab84407bafbf6fddb11197ac667ac4de064","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"      eavesdrop01.openstack.org:"},{"line_number":1032,"context_line":"        host_copy_output:"},{"line_number":1033,"context_line":"          \u0027/etc/docker/daemon.json\u0027: logs"},{"line_number":1034,"context_line":"          \u0027/etc/hosts\u0027: logs"},{"line_number":1035,"context_line":"    files:"},{"line_number":1036,"context_line":"      - playbooks/service-eavesdrop.yaml"},{"line_number":1037,"context_line":"      - playbooks/run-accessbot.yaml"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_4ebcf1db","line":1034,"in_reply_to":"1f493fa4_926da19a","updated":"2020-04-23 19:24:01.000000000","message":"Done","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59e9f9cd10e69a7c0c10321ca30d30ea0b749e8f","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"      eavesdrop01.openstack.org:"},{"line_number":1032,"context_line":"        host_copy_output:"},{"line_number":1033,"context_line":"          \u0027/etc/docker/daemon.json\u0027: logs"},{"line_number":1034,"context_line":"          \u0027/etc/hosts\u0027: logs"},{"line_number":1035,"context_line":"    files:"},{"line_number":1036,"context_line":"      - playbooks/service-eavesdrop.yaml"},{"line_number":1037,"context_line":"      - playbooks/run-accessbot.yaml"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_ce976190","line":1034,"in_reply_to":"1f493fa4_926da19a","updated":"2020-04-23 19:31:00.000000000","message":"If we think we want to keep them maybe we should move this into the base job and do it for all system-config-run jobs?","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6a8e5573e514fec4730cfe4b6c1d2f008e03c714","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"      eavesdrop01.openstack.org:"},{"line_number":1032,"context_line":"        host_copy_output:"},{"line_number":1033,"context_line":"          \u0027/etc/docker/daemon.json\u0027: logs"},{"line_number":1034,"context_line":"          \u0027/etc/hosts\u0027: logs"},{"line_number":1035,"context_line":"    files:"},{"line_number":1036,"context_line":"      - playbooks/service-eavesdrop.yaml"},{"line_number":1037,"context_line":"      - playbooks/run-accessbot.yaml"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_aecbf547","line":1034,"in_reply_to":"1f493fa4_ce976190","updated":"2020-04-23 19:34:20.000000000","message":"Can we do host-vars: all?","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"}],"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d8d0fdb3bdbf607f84a256573ac2b99292c47b37","unresolved":false,"context_lines":[{"line_number":10,"context_line":"puppet manifest. While doing that, stop using jenkinsuser"},{"line_number":11,"context_line":"on eavesdrop in favor of zuul-user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add the ability to override the keys for the zuul user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Remove openstack_project::server, it doesn\u0027t do anything."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1f493fa4_0c698c24","line":13,"updated":"2020-04-21 17:34:41.000000000","message":"Ah, the old jenkins user had an ssh key that project-config used.","commit_id":"d37868dc60582e166dc0eb53059035097ea93126"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d760e4f6d608d1970abff0ce82976de1adb11fc8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"puppet manifest. While doing that, stop using jenkinsuser"},{"line_number":11,"context_line":"on eavesdrop in favor of zuul-user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add the ability to override the keys for the zuul user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Remove openstack_project::server, it doesn\u0027t do anything."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1f493fa4_f9d060cc","line":13,"updated":"2020-04-21 16:55:02.000000000","message":"Ah; where\u0027s the yaml2ical job?","commit_id":"d37868dc60582e166dc0eb53059035097ea93126"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0273d151c5456371293fc6d761f79160ea0cb12c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"puppet manifest. While doing that, stop using jenkinsuser"},{"line_number":11,"context_line":"on eavesdrop in favor of zuul-user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add the ability to override the keys for the zuul user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Remove openstack_project::server, it doesn\u0027t do anything."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1f493fa4_6ce65047","line":13,"updated":"2020-04-21 17:16:52.000000000","message":"Oh, that\u0027s the same job, and it still runs through bridge.\n\nThen if this is for yaml2ical, which is an existing job, then why does it look like we\u0027re making a change here to add an ssh key?","commit_id":"d37868dc60582e166dc0eb53059035097ea93126"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5d91a2ea7fc6360728a6f15dd3233dcff8ff66f9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"puppet manifest. While doing that, stop using jenkinsuser"},{"line_number":11,"context_line":"on eavesdrop in favor of zuul-user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add the ability to override the keys for the zuul user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Remove openstack_project::server, it doesn\u0027t do anything."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1f493fa4_591eb4ba","line":13,"updated":"2020-04-21 16:50:57.000000000","message":"The reasoning here appears to be so that we can run the accessbot job in prod on changes to project-config.  We add keys for both repos to eavesdrop.openstack.org.  So we\u0027re trusting project-config reviewers with full acccess to the eavesdrop host.  I think that\u0027s fine.","commit_id":"d37868dc60582e166dc0eb53059035097ea93126"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e625fe6badf7181128ac82455b5fb16f0716bc65","unresolved":false,"context_lines":[{"line_number":10,"context_line":"puppet manifest. While doing that, stop using jenkinsuser"},{"line_number":11,"context_line":"on eavesdrop in favor of zuul-user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add the ability to override the keys for the zuul user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Remove openstack_project::server, it doesn\u0027t do anything."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1f493fa4_2c972893","line":13,"updated":"2020-04-21 17:15:15.000000000","message":"Then what\u0027s this?  https://review.opendev.org/721627","commit_id":"d37868dc60582e166dc0eb53059035097ea93126"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b21a5aa1aac2ed973429da172c85e37752e631d3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"puppet manifest. While doing that, stop using jenkinsuser"},{"line_number":11,"context_line":"on eavesdrop in favor of zuul-user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add the ability to override the keys for the zuul user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Remove openstack_project::server, it doesn\u0027t do anything."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1f493fa4_d9600436","line":13,"in_reply_to":"1f493fa4_591eb4ba","updated":"2020-04-21 16:53:47.000000000","message":"Actually - this is not for the accessbot job - that runs on bridge. This is for yaml2ical job - corresponding change here: https://review.opendev.org/#/c/721099/. But the second part is correct.","commit_id":"d37868dc60582e166dc0eb53059035097ea93126"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"54efb91d3339159e90306212a0e76032e367cf1c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"puppet manifest. While doing that, stop using jenkinsuser"},{"line_number":11,"context_line":"on eavesdrop in favor of zuul-user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add the ability to override the keys for the zuul user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Remove openstack_project::server, it doesn\u0027t do anything."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1f493fa4_397648da","line":13,"in_reply_to":"1f493fa4_f9d060cc","updated":"2020-04-21 17:03:18.000000000","message":"In project-config. It publishes the output of yaml2ical on to eavesdrop. So it\u0027s still the same safety domain.\n\nAs we continue to clean things up - one could imagine changing yaml2ical publication to be AFS based.","commit_id":"d37868dc60582e166dc0eb53059035097ea93126"}],"manifests/eavesdrop.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59e9f9cd10e69a7c0c10321ca30d30ea0b749e8f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    meetbot_channels        \u003d\u003e hiera(\u0027meetbot_channels\u0027, [\u0027openstack-infra\u0027]),"},{"line_number":27,"context_line":"    ptgbot_nick             \u003d\u003e hiera(\u0027ptgbot_nick\u0027, \u0027username\u0027),"},{"line_number":28,"context_line":"    ptgbot_password         \u003d\u003e hiera(\u0027ptgbot_password\u0027),"},{"line_number":29,"context_line":"    install_only            \u003d\u003e hiera(\u0027access_bot_install_only\u0027, false),"},{"line_number":30,"context_line":"  }"},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f493fa4_cecbe150","line":29,"updated":"2020-04-23 19:31:00.000000000","message":"See comment in openstack_project/manifests/eavesdrop.pp.","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6a8e5573e514fec4730cfe4b6c1d2f008e03c714","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    meetbot_channels        \u003d\u003e hiera(\u0027meetbot_channels\u0027, [\u0027openstack-infra\u0027]),"},{"line_number":27,"context_line":"    ptgbot_nick             \u003d\u003e hiera(\u0027ptgbot_nick\u0027, \u0027username\u0027),"},{"line_number":28,"context_line":"    ptgbot_password         \u003d\u003e hiera(\u0027ptgbot_password\u0027),"},{"line_number":29,"context_line":"    install_only            \u003d\u003e hiera(\u0027access_bot_install_only\u0027, false),"},{"line_number":30,"context_line":"  }"},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f493fa4_cef92181","line":29,"in_reply_to":"1f493fa4_cecbe150","updated":"2020-04-23 19:34:20.000000000","message":"Done","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"}],"modules/openstack_project/manifests/eavesdrop.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59e9f9cd10e69a7c0c10321ca30d30ea0b749e8f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  $meetbot_channels \u003d [],"},{"line_number":25,"context_line":"  $ptgbot_nick \u003d \u0027\u0027,"},{"line_number":26,"context_line":"  $ptgbot_password \u003d \u0027\u0027,"},{"line_number":27,"context_line":"  $install_only \u003d false,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":"  include ::httpd"},{"line_number":30,"context_line":"  include meetbot"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f493fa4_2e8d2531","line":27,"updated":"2020-04-23 19:31:00.000000000","message":"I don\u0027t see this being used.","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6a8e5573e514fec4730cfe4b6c1d2f008e03c714","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  $meetbot_channels \u003d [],"},{"line_number":25,"context_line":"  $ptgbot_nick \u003d \u0027\u0027,"},{"line_number":26,"context_line":"  $ptgbot_password \u003d \u0027\u0027,"},{"line_number":27,"context_line":"  $install_only \u003d false,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":"  include ::httpd"},{"line_number":30,"context_line":"  include meetbot"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f493fa4_eed5fde6","line":27,"in_reply_to":"1f493fa4_2e8d2531","updated":"2020-04-23 19:34:20.000000000","message":"Done","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"}],"playbooks/service-eavesdrop.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59e9f9cd10e69a7c0c10321ca30d30ea0b749e8f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - puppet-install"},{"line_number":10,"context_line":"    - disable-puppet-agent"},{"line_number":11,"context_line":"    - name: puppet"},{"line_number":12,"context_line":"      manifest: /opt/system-config/production/manifests/eavesdrop.pp"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_4ea191a9","line":12,"updated":"2020-04-23 19:31:00.000000000","message":"Why are we splitting the puppet out like this? Because we match on the node name identifier it isn\u0027t actually necessary.","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6a8e5573e514fec4730cfe4b6c1d2f008e03c714","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - puppet-install"},{"line_number":10,"context_line":"    - disable-puppet-agent"},{"line_number":11,"context_line":"    - name: puppet"},{"line_number":12,"context_line":"      manifest: /opt/system-config/production/manifests/eavesdrop.pp"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_eeee9db2","line":12,"in_reply_to":"1f493fa4_4ea191a9","updated":"2020-04-23 19:34:20.000000000","message":"So that we can control zuul job triggering. Otherwise we have to have EVERYTHING trigger on changes to site.pp.","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"}],"playbooks/zuul/run-base-pre.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7d46da09693c40fb3ac7df731764f841d9c910e4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- hosts: all"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  roles:"},{"line_number":11,"context_line":"    - set-hostname"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- hosts: all"},{"line_number":14,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_726a9580","line":11,"updated":"2020-04-22 13:48:46.000000000","message":"Likewise, wouldn\u0027t it be better to put become:true on the task in the role?","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9a1dcab84407bafbf6fddb11197ac667ac4de064","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- hosts: all"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  roles:"},{"line_number":11,"context_line":"    - set-hostname"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- hosts: all"},{"line_number":14,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_6eae0d99","line":11,"in_reply_to":"1f493fa4_726a9580","updated":"2020-04-23 19:24:01.000000000","message":"Done","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7d46da09693c40fb3ac7df731764f841d9c910e4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    - set-hostname"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- hosts: all"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  tasks:"},{"line_number":16,"context_line":"    - include_role:"},{"line_number":17,"context_line":"        name: use-buildset-registry"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_d20449c9","line":14,"updated":"2020-04-22 13:48:46.000000000","message":"This shouldn\u0027t need become: true.","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9a1dcab84407bafbf6fddb11197ac667ac4de064","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    - set-hostname"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- hosts: all"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  tasks:"},{"line_number":16,"context_line":"    - include_role:"},{"line_number":17,"context_line":"        name: use-buildset-registry"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1f493fa4_8eab9987","line":14,"in_reply_to":"1f493fa4_d20449c9","updated":"2020-04-23 19:24:01.000000000","message":"Done","commit_id":"8c62072a949fafb6c32d474acc335654884daf44"}]}