)]}'
{"docker/python-builder/scripts/assemble":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"6ef61c6483027ffee51d3e4ad329efec3a88dda4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"/tmp/venv/bin/pip install -U pip wheel"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# If we didn\u0027t get a list of packages, Install the main package"},{"line_number":94,"context_line":"if [ -z $PACKAGES ] ; then"},{"line_number":95,"context_line":"    # pbr needs git installed, else nothing will work. Do this in between"},{"line_number":96,"context_line":"    # bindep and wheel so that we don\u0027t miss git in target images."},{"line_number":97,"context_line":"    apt-get install -y git"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1f493fa4_f0e173d2","line":94,"range":{"start_line":94,"start_character":7,"end_line":94,"end_character":17},"updated":"2020-04-22 21:45:40.000000000","message":"but bash is unhappy about this","commit_id":"42555eed9c656b856fc809278442bf991550e150"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"6ef61c6483027ffee51d3e4ad329efec3a88dda4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    install_wheels"},{"line_number":100,"context_line":"else"},{"line_number":101,"context_line":"    /tmp/venv/bin/pip install --cache-dir\u003d/output/wheels \"$PACKAGES\""},{"line_number":102,"context_line":"    for package in \"$PACKAGES\" ; do"},{"line_number":103,"context_line":"      echo \"$package\" \u003e\u003e /output/packages.txt"},{"line_number":104,"context_line":"    done"},{"line_number":105,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1f493fa4_10ddff13","line":102,"range":{"start_line":102,"start_character":19,"end_line":102,"end_character":30},"updated":"2020-04-22 21:45:40.000000000","message":"this is fine","commit_id":"42555eed9c656b856fc809278442bf991550e150"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"95b42f805cf58207c7305c9eb6e322db3a1a14e4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    done"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"PACKAGES\u003d$*"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# bindep the main package"},{"line_number":79,"context_line":"install_bindep"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1f493fa4_46317fec","line":76,"updated":"2020-04-23 15:41:56.000000000","message":"One thing not completely called out about this package list is that we seem to not want local source paths in the list. That should be fine as it adds new functionality and the preexisting behavior can be used for source paths.\n\nCalling this out because we might be able to combine the two sets of logic below into one standard thing? Basically put everything in a packages.txt after building wheels for it?","commit_id":"f3304c38d57d8db56e9dc1ec18c94cbeb8cf8e2b"}],"docker/python-builder/scripts/install-from-bindep":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"0effc84f78f5981817b67d659d1a47aab9cd2062","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    EXTRAS\u003d\"${EXTRAS} -f /output/$extra/requirements.txt\""},{"line_number":33,"context_line":"done"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"if [ -f /output/package.txt ] ; then"},{"line_number":36,"context_line":"  # If a package list was passed to assemble, install that in the final"},{"line_number":37,"context_line":"  # image."},{"line_number":38,"context_line":"  pip install --cache-dir\u003d/output/wheels -f /output/package.txt $EXTRAS"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_3383e555","line":35,"range":{"start_line":35,"start_character":16,"end_line":35,"end_character":27},"updated":"2020-04-22 22:13:30.000000000","message":"typo: should be packages.txt","commit_id":"e8d8c94fd6bf8926cb6e754b16759c9979eb8ffe"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"0effc84f78f5981817b67d659d1a47aab9cd2062","unresolved":false,"context_lines":[{"line_number":35,"context_line":"if [ -f /output/package.txt ] ; then"},{"line_number":36,"context_line":"  # If a package list was passed to assemble, install that in the final"},{"line_number":37,"context_line":"  # image."},{"line_number":38,"context_line":"  pip install --cache-dir\u003d/output/wheels -f /output/package.txt $EXTRAS"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  # Install the wheels.  Use --force here because sibling wheels might"},{"line_number":41,"context_line":"  # be built with the same version number as the latest release, but we"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_93975991","line":38,"range":{"start_line":38,"start_character":52,"end_line":38,"end_character":63},"updated":"2020-04-22 22:13:30.000000000","message":"packages.txt","commit_id":"e8d8c94fd6bf8926cb6e754b16759c9979eb8ffe"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"d38c78550f7e003704c65e0e90bc9e38483602ae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"if [ -f /output/packages.txt ] ; then"},{"line_number":36,"context_line":"  # If a package list was passed to assemble, install that in the final"},{"line_number":37,"context_line":"  # image."},{"line_number":38,"context_line":"  pip install --cache-dir\u003d/output/wheels -f /output/packages.txt $EXTRAS"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  # Install the wheels.  Use --force here because sibling wheels might"},{"line_number":41,"context_line":"  # be built with the same version number as the latest release, but we"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1f493fa4_6ecc6489","line":38,"range":{"start_line":38,"start_character":41,"end_line":38,"end_character":43},"updated":"2020-04-23 00:00:26.000000000","message":"turns out -f is just find links","commit_id":"08c7656b271056aaaf4cf1d1703966b4a23952a5"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"1ec2cc3ffef00663a12fb3a8884451faa443f048","unresolved":false,"context_lines":[{"line_number":35,"context_line":"if [ -f /output/packages.txt ] ; then"},{"line_number":36,"context_line":"  # If a package list was passed to assemble, install that in the final"},{"line_number":37,"context_line":"  # image."},{"line_number":38,"context_line":"  pip install --cache-dir\u003d/output/wheels -f /output/packages.txt $EXTRAS"},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"  # Install the wheels.  Use --force here because sibling wheels might"},{"line_number":41,"context_line":"  # be built with the same version number as the latest release, but we"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1f493fa4_0ea160aa","line":38,"range":{"start_line":38,"start_character":41,"end_line":38,"end_character":43},"in_reply_to":"1f493fa4_6ecc6489","updated":"2020-04-23 00:00:54.000000000","message":"maybe we just wanna use -r ?","commit_id":"08c7656b271056aaaf4cf1d1703966b4a23952a5"}]}
