)]}'
{"inventory/service/host_vars/gitea01.opendev.org.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"69c764f206858921506fc35281e0f43afc2b9a93","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  # db is backed up in dumps, don\u0027t capture live files"},{"line_number":9,"context_line":"  - /var/gitea/db"},{"line_number":10,"context_line":"  # backed up by streaming backup"},{"line_number":11,"context_line":"  /var/backups/gitea-mariadb"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a27cc7e8_0fae6e64","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":28},"updated":"2021-02-03 00:42:16.000000000","message":"You need a - prefix here as it is a list entry.","commit_id":"c8fc2e3fb92a8f79eaa39b3993add517164c964f"}],"playbooks/roles/borg-backup/templates/borg-backup.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"85d57841c2bd6170f908ba3e8d70b9a65dad903a","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"backup_exit\u003d$?"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"for f in $(shopt -s nullglob; echo /etc/borg-streams/*)"},{"line_number":40,"context_line":"do"},{"line_number":41,"context_line":"    stream_name\u003d$(basename $f)"},{"line_number":42,"context_line":"    info \"Backing up stream archive $stream_name\""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"b936f8d9_ff6dde9e","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":28},"updated":"2021-02-03 00:27:16.000000000","message":"Do we need to unset this to prevent an unexpected behavior later in the script? perhaps even behavior that would leak into the child bash script? I don\u0027t know if those get exposed as exported env vars.","commit_id":"b49e0124bdfe04353718ca3466df0f7f6ff970fe"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7e5ec52b46eb517e692d5d8c92d34ed31d188ab6","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"backup_exit\u003d$?"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"for f in $(shopt -s nullglob; echo /etc/borg-streams/*)"},{"line_number":40,"context_line":"do"},{"line_number":41,"context_line":"    stream_name\u003d$(basename $f)"},{"line_number":42,"context_line":"    info \"Backing up stream archive $stream_name\""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"8f4d8974_653b6b06","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":28},"in_reply_to":"b936f8d9_ff6dde9e","updated":"2021-02-03 00:30:48.000000000","message":"that will only apply in the $() subshell, so won\u0027t go outside","commit_id":"b49e0124bdfe04353718ca3466df0f7f6ff970fe"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"85d57841c2bd6170f908ba3e8d70b9a65dad903a","unresolved":true,"context_lines":[{"line_number":40,"context_line":"do"},{"line_number":41,"context_line":"    stream_name\u003d$(basename $f)"},{"line_number":42,"context_line":"    info \"Backing up stream archive $stream_name\""},{"line_number":43,"context_line":"    bash $f | ${BORG_CREATE} --stdin-name ${stream_name} \\"},{"line_number":44,"context_line":"                      ::\"{hostname}-${stream_name}-{now}\" -"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    stream_exit\u003d$?"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"c039208f_5bb2bc09","line":43,"range":{"start_line":43,"start_character":29,"end_line":43,"end_character":56},"updated":"2021-02-03 00:27:16.000000000","message":"This names the file in the archive.","commit_id":"b49e0124bdfe04353718ca3466df0f7f6ff970fe"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"85d57841c2bd6170f908ba3e8d70b9a65dad903a","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    stream_name\u003d$(basename $f)"},{"line_number":42,"context_line":"    info \"Backing up stream archive $stream_name\""},{"line_number":43,"context_line":"    bash $f | ${BORG_CREATE} --stdin-name ${stream_name} \\"},{"line_number":44,"context_line":"                      ::\"{hostname}-${stream_name}-{now}\" -"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    stream_exit\u003d$?"},{"line_number":47,"context_line":"    (( backup_exit \u003d backup_exit || stream_exit ))"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"96cde47e_eb9b6ccd","line":44,"range":{"start_line":44,"start_character":22,"end_line":44,"end_character":57},"updated":"2021-02-03 00:27:16.000000000","message":"This names the archive. Thought I would leave these two comments to help disambiguate what is going on with the multiple of things using stream_name as I had to look it up.","commit_id":"b49e0124bdfe04353718ca3466df0f7f6ff970fe"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"85d57841c2bd6170f908ba3e8d70b9a65dad903a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    bash $f | ${BORG_CREATE} --stdin-name ${stream_name} \\"},{"line_number":44,"context_line":"                      ::\"{hostname}-${stream_name}-{now}\" -"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    stream_exit\u003d$?"},{"line_number":47,"context_line":"    (( backup_exit \u003d backup_exit || stream_exit ))"},{"line_number":48,"context_line":"done"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"0d6d3a0d_23f8d06d","line":46,"updated":"2021-02-03 00:27:16.000000000","message":"To make this more resilient should we set pipefail? that way the stream script or borg can error and we\u0027d record it.","commit_id":"b49e0124bdfe04353718ca3466df0f7f6ff970fe"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7e5ec52b46eb517e692d5d8c92d34ed31d188ab6","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    bash $f | ${BORG_CREATE} --stdin-name ${stream_name} \\"},{"line_number":44,"context_line":"                      ::\"{hostname}-${stream_name}-{now}\" -"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    stream_exit\u003d$?"},{"line_number":47,"context_line":"    (( backup_exit \u003d backup_exit || stream_exit ))"},{"line_number":48,"context_line":"done"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"4173971c_572eb45f","line":46,"in_reply_to":"0d6d3a0d_23f8d06d","updated":"2021-02-03 00:30:48.000000000","message":"it was probably a bit more obvious when this had the pruning in here; where it would explicitly check for a good exit before pruning, but we wanted to loop through everything and not stop if one part failed.\n\nbut overall, this should exit with failure if any part of this fails","commit_id":"b49e0124bdfe04353718ca3466df0f7f6ff970fe"}],"playbooks/roles/etherpad/tasks/main.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"aee36df15def690943e02b8718ee78cf71f2a580","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      copy:"},{"line_number":155,"context_line":"        content: \u003e-"},{"line_number":156,"context_line":"          /usr/local/bin/docker-compose -f /etc/etherpad-docker/docker-compose.yaml exec -T mariadb"},{"line_number":157,"context_line":"          bash -c \u0027/usr/bin/mysqldump --opt --databases etherpad-lite --single-transaction -uroot -p\"$MYSQL_ROOT_PASSWORD\"\u0027"},{"line_number":158,"context_line":"        dest: /etc/borg-streams/mysql"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6786bba0_f9905c0b","line":157,"range":{"start_line":157,"start_character":55,"end_line":157,"end_character":56},"updated":"2021-01-21 21:35:01.000000000","message":"I\u0027d add --skip-extended-insert so that the inserts don\u0027t all wind up concatenated into a single line. I don\u0027t lknow if borg is smarter than diff - but I\u0027d imaging having each insert on its own line, although larger for the initial case in terms of lines in file, would be smaller for incrementals.","commit_id":"964057b29046f713b7597b334ceda3fbcc6c3925"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"aee36df15def690943e02b8718ee78cf71f2a580","unresolved":true,"context_lines":[{"line_number":154,"context_line":"      copy:"},{"line_number":155,"context_line":"        content: \u003e-"},{"line_number":156,"context_line":"          /usr/local/bin/docker-compose -f /etc/etherpad-docker/docker-compose.yaml exec -T mariadb"},{"line_number":157,"context_line":"          bash -c \u0027/usr/bin/mysqldump --opt --databases etherpad-lite --single-transaction -uroot -p\"$MYSQL_ROOT_PASSWORD\"\u0027"},{"line_number":158,"context_line":"        dest: /etc/borg-streams/mysql"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"03dbb00c_36cb4e73","line":157,"range":{"start_line":157,"start_character":38,"end_line":157,"end_character":44},"updated":"2021-01-21 21:35:01.000000000","message":"not needed - defaults to on now","commit_id":"964057b29046f713b7597b334ceda3fbcc6c3925"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"bd47bed02b22c57f388380bd0ce4faa759dbf8d2","unresolved":false,"context_lines":[{"line_number":154,"context_line":"      copy:"},{"line_number":155,"context_line":"        content: \u003e-"},{"line_number":156,"context_line":"          /usr/local/bin/docker-compose -f /etc/etherpad-docker/docker-compose.yaml exec -T mariadb"},{"line_number":157,"context_line":"          bash -c \u0027/usr/bin/mysqldump --opt --databases etherpad-lite --single-transaction -uroot -p\"$MYSQL_ROOT_PASSWORD\"\u0027"},{"line_number":158,"context_line":"        dest: /etc/borg-streams/mysql"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"88c5c825_899bca76","line":157,"range":{"start_line":157,"start_character":38,"end_line":157,"end_character":44},"in_reply_to":"03dbb00c_36cb4e73","updated":"2021-02-02 00:38:56.000000000","message":"Done","commit_id":"964057b29046f713b7597b334ceda3fbcc6c3925"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"bd47bed02b22c57f388380bd0ce4faa759dbf8d2","unresolved":false,"context_lines":[{"line_number":154,"context_line":"      copy:"},{"line_number":155,"context_line":"        content: \u003e-"},{"line_number":156,"context_line":"          /usr/local/bin/docker-compose -f /etc/etherpad-docker/docker-compose.yaml exec -T mariadb"},{"line_number":157,"context_line":"          bash -c \u0027/usr/bin/mysqldump --opt --databases etherpad-lite --single-transaction -uroot -p\"$MYSQL_ROOT_PASSWORD\"\u0027"},{"line_number":158,"context_line":"        dest: /etc/borg-streams/mysql"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f6cd704e_c9444673","line":157,"range":{"start_line":157,"start_character":55,"end_line":157,"end_character":56},"in_reply_to":"6786bba0_f9905c0b","updated":"2021-02-02 00:38:56.000000000","message":"Done","commit_id":"964057b29046f713b7597b334ceda3fbcc6c3925"}]}