)]}'
{"docker/gerrit/base/Dockerfile":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":61,"context_line":"# Download mysql-connector so that gerrit doens\u0027t download it during init."},{"line_number":62,"context_line":"RUN mkdir /var/gerrit/lib \u0026\u0026 \\"},{"line_number":63,"context_line":"  wget https://repo1.maven.org/maven2/mysql/mysql-connector-java/5.1.43/mysql-connector-java-5.1.43.jar -O /var/gerrit/lib/mysql-connector-java.jar \u0026\u0026 \\"},{"line_number":64,"context_line":"  wget https://repo1.maven.org/maven2/org/mariadb/jdbc/mariadb-java-client/2.7.2/mariadb-java-client-2.7.2.jar -O /var/gerrit/lib/mariadb-java-client.jar"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Allow incoming traffic"},{"line_number":67,"context_line":"# OpenDev Gerrit listens on 8081 not default of 8080"}],"source_content_type":"text/x-dockerfile","patch_set":18,"id":"2df73d52_6abd1d84","line":64,"updated":"2021-04-01 22:39:13.000000000","message":"I guess gerrit knows which one to load and use based on the connection url?","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":61,"context_line":"# Download mysql-connector so that gerrit doens\u0027t download it during init."},{"line_number":62,"context_line":"RUN mkdir /var/gerrit/lib \u0026\u0026 \\"},{"line_number":63,"context_line":"  wget https://repo1.maven.org/maven2/mysql/mysql-connector-java/5.1.43/mysql-connector-java-5.1.43.jar -O /var/gerrit/lib/mysql-connector-java.jar \u0026\u0026 \\"},{"line_number":64,"context_line":"  wget https://repo1.maven.org/maven2/org/mariadb/jdbc/mariadb-java-client/2.7.2/mariadb-java-client-2.7.2.jar -O /var/gerrit/lib/mariadb-java-client.jar"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Allow incoming traffic"},{"line_number":67,"context_line":"# OpenDev Gerrit listens on 8081 not default of 8080"}],"source_content_type":"text/x-dockerfile","patch_set":18,"id":"cbe80135_25baadaf","line":64,"in_reply_to":"2df73d52_6abd1d84","updated":"2021-06-07 04:31:39.000000000","message":"Yes, I don\u0027t believe that having both causes any problems","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"}],"inventory/service/host_vars/review01.openstack.org.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fef47978fc208e50fc224a95cc0e382cb30e4ce5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"7a836095_0b11c37a","line":83,"updated":"2021-06-07 19:59:24.000000000","message":"Do we also need to set gerrit_review_database_type to be mysql here? Otherwise production will try to use h2?\n\nDoesn\u0027t look like we need to update host/group vars for the username, password, and host because those vars don\u0027t get new names when talking to mysql.","commit_id":"8e75d9f813b6b51bdff537206c738e1be892b1b8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7b09fdb62ab62dbe2c2eb90523ce596f09b6978e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c2b7bd31_b907d338","line":83,"in_reply_to":"7a836095_0b11c37a","updated":"2021-06-14 23:04:37.000000000","message":"yes, we should","commit_id":"8e75d9f813b6b51bdff537206c738e1be892b1b8"}],"inventory/service/host_vars/review02.opendev.org.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fef47978fc208e50fc224a95cc0e382cb30e4ce5","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  - /home/gerrit2/review_site/tmp/*"},{"line_number":22,"context_line":"  - /home/gerrit2/review_site/index/*"},{"line_number":23,"context_line":"  # dump directly via stream"},{"line_number":24,"context_line":"  - /home/gerrit2/mysql_backups/*"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"af8b5d93_544ad5c9","line":24,"updated":"2021-06-07 19:59:24.000000000","message":"Should we include the new mariadb dir exclude here for backups on the new host?","commit_id":"8e75d9f813b6b51bdff537206c738e1be892b1b8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7b09fdb62ab62dbe2c2eb90523ce596f09b6978e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  - /home/gerrit2/review_site/tmp/*"},{"line_number":22,"context_line":"  - /home/gerrit2/review_site/index/*"},{"line_number":23,"context_line":"  # dump directly via stream"},{"line_number":24,"context_line":"  - /home/gerrit2/mysql_backups/*"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"f7669212_2e2cdff9","line":24,"in_reply_to":"af8b5d93_544ad5c9","updated":"2021-06-14 23:04:37.000000000","message":"Yes, done","commit_id":"8e75d9f813b6b51bdff537206c738e1be892b1b8"}],"playbooks/roles/gerrit/README.rst":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":3,"context_line":"**Role Variables**"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":".. zuul:rolevar:: gerrit_database_type"},{"line_number":6,"context_line":"   :default: h2"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   One of"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"4b8bd944_85329719","line":6,"updated":"2021-04-01 22:39:13.000000000","message":"playbooks/roles/gerrit/defaults/main.yaml seems to show a default of MYSQL.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":3,"context_line":"**Role Variables**"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":".. zuul:rolevar:: gerrit_database_type"},{"line_number":6,"context_line":"   :default: h2"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   One of"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"b4165fed_d4707ffd","line":6,"in_reply_to":"4b8bd944_85329719","updated":"2021-06-07 04:31:39.000000000","message":"Done","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":8,"context_line":"   One of"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    * h2 : use local h2 database, not for production"},{"line_number":11,"context_line":"    * mysql : connect to existing mysql instance"},{"line_number":12,"context_line":"    * mariadb_container : run a sibling mariadb container"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. zuul:rolevar:: gerrit_mariadb_dbname"}],"source_content_type":"text/x-rst","patch_set":18,"id":"2dd5bd79_2207d7b3","line":11,"updated":"2021-04-01 22:39:13.000000000","message":"This seems to sometimes be MYSQL.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   One of"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    * h2 : use local h2 database, not for production"},{"line_number":11,"context_line":"    * mysql : connect to existing mysql instance"},{"line_number":12,"context_line":"    * mariadb_container : run a sibling mariadb container"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. zuul:rolevar:: gerrit_mariadb_dbname"}],"source_content_type":"text/x-rst","patch_set":18,"id":"33ca8472_4ff12e86","line":11,"in_reply_to":"2dd5bd79_2207d7b3","updated":"2021-06-07 04:31:39.000000000","message":"Agree, fixed all to be lower case","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    * mariadb_container : run a sibling mariadb container"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. zuul:rolevar:: gerrit_mariadb_dbname"},{"line_number":15,"context_line":"   :default: gerrit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"   When ``gerrit_database_type`` is ``mariadb_container``; the default"},{"line_number":18,"context_line":"   database to make and connect to."}],"source_content_type":"text/x-rst","patch_set":18,"id":"b1f08637_55537662","line":15,"updated":"2021-04-01 22:39:13.000000000","message":"I think the db we actually need is accountPatchReviewDb? I think we should be specific like that if we can. (Gerrit has a history of using multiple DBs so avoiding a super generic name like gerrit is likely a good idea).\n\nAlso I don\u0027t see an update to the role defaults file to add these new defaults.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    * mariadb_container : run a sibling mariadb container"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. zuul:rolevar:: gerrit_mariadb_dbname"},{"line_number":15,"context_line":"   :default: gerrit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"   When ``gerrit_database_type`` is ``mariadb_container``; the default"},{"line_number":18,"context_line":"   database to make and connect to."}],"source_content_type":"text/x-rst","patch_set":18,"id":"d3049195_b723d120","line":15,"in_reply_to":"b1f08637_55537662","updated":"2021-06-07 04:31:39.000000000","message":"To account for multiple databases, I\u0027ve renamed this \u0027gerrit_reviewdb_mariadb_*\u0027.  \n\nUpdated the defaults too.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":24,"context_line":"   user to make and connect with."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. zuul:rolevar:: gerrit_mariadb_password"},{"line_number":27,"context_line":"   :default: gerrit"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   When ``gerrit_database_type`` is ``mariadb_container``; the default"},{"line_number":30,"context_line":"   password to set for ``gerrit_mariadb_username``"}],"source_content_type":"text/x-rst","patch_set":18,"id":"87867968_e19298f7","line":27,"updated":"2021-04-01 22:39:13.000000000","message":"Lets not set a passwd default.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":24,"context_line":"   user to make and connect with."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. zuul:rolevar:: gerrit_mariadb_password"},{"line_number":27,"context_line":"   :default: gerrit"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   When ``gerrit_database_type`` is ``mariadb_container``; the default"},{"line_number":30,"context_line":"   password to set for ``gerrit_mariadb_username``"}],"source_content_type":"text/x-rst","patch_set":18,"id":"a2ee45c1_aca77c78","line":27,"in_reply_to":"87867968_e19298f7","updated":"2021-06-07 04:31:39.000000000","message":"Done","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"}],"playbooks/roles/gerrit/tasks/backup.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    state: directory"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Setup remote mysql backup jobs"},{"line_number":7,"context_line":"  when: gerrit_database_type \u003d\u003d \u0027mysql\u0027"},{"line_number":8,"context_line":"  block:"},{"line_number":9,"context_line":"    # NOTE(ianw) 2021-02-19 We are explicitly backing up just"},{"line_number":10,"context_line":"    # accountPatchReviewDb because \"--all-databases\" doesn\u0027t work with"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ef5df691_fe90026e","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":38},"updated":"2021-04-01 22:39:13.000000000","message":"We seem to use MYSQL in other locations.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    state: directory"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Setup remote mysql backup jobs"},{"line_number":7,"context_line":"  when: gerrit_database_type \u003d\u003d \u0027mysql\u0027"},{"line_number":8,"context_line":"  block:"},{"line_number":9,"context_line":"    # NOTE(ianw) 2021-02-19 We are explicitly backing up just"},{"line_number":10,"context_line":"    # accountPatchReviewDb because \"--all-databases\" doesn\u0027t work with"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"f3188c04_1201dbf2","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":38},"in_reply_to":"ef5df691_fe90026e","updated":"2021-06-07 04:31:39.000000000","message":"Done","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fef47978fc208e50fc224a95cc0e382cb30e4ce5","unresolved":true,"context_lines":[{"line_number":28,"context_line":"  when: gerrit_reviewdb_database_type \u003d\u003d \u0027mariadb_container\u0027"},{"line_number":29,"context_line":"  block:"},{"line_number":30,"context_line":"    # NOTE(ianw) 2021-02-19 : note we only dump to remote; we already"},{"line_number":31,"context_line":"    # have the raw db on disk."},{"line_number":32,"context_line":"    - name: Create mariadb streaming file"},{"line_number":33,"context_line":"      copy:"},{"line_number":34,"context_line":"        content: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"4eb10842_a0f1db67","line":31,"updated":"2021-06-07 19:59:24.000000000","message":"We seem to be inconsistent on whether or not we want to backup the raw dir. But also the raw db isn\u0027t really a backup? thats the live running db. Maybe we should keep dumps for simplicity too?","commit_id":"8e75d9f813b6b51bdff537206c738e1be892b1b8"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9370e89d554c6ed95886545eef3a0bf77bcef3eb","unresolved":true,"context_lines":[{"line_number":16,"context_line":"            /usr/bin/mysqldump --defaults-file\u003d/root/.gerrit_db.cnf --skip-extended-insert --ignore-table mysql.event --single-transaction --databases accountPatchReviewDb"},{"line_number":17,"context_line":"        dest: /etc/borg-streams/mysql-accountPatchReviewDb"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Set up cron job to back up gerrit db to disk"},{"line_number":20,"context_line":"      cron:"},{"line_number":21,"context_line":"        name: gerrit-backup"},{"line_number":22,"context_line":"        user: root"},{"line_number":23,"context_line":"        hour: 0"},{"line_number":24,"context_line":"        minute: 0"},{"line_number":25,"context_line":"        job: \u0027/usr/bin/mysqldump --defaults-file\u003d/root/.gerrit_db.cnf --opt --ignore-table mysql.event --single-transaction --databases accountPatchReviewDb | gzip -9 \u003e /home/gerrit2/mysql_backups/gerrit.sql.gz\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Setup container mariadb backup jobs"},{"line_number":28,"context_line":"  when: gerrit_reviewdb_database_type \u003d\u003d \u0027mariadb_container\u0027"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"d431a593_f93b0a5b","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":211},"updated":"2021-06-08 15:22:31.000000000","message":"I think the comment below talking about the raw db on disk is trying to explain why this backup isn\u0027t running in the mariadb case. I think this backup is still useful in the mariadb case so that we have local backups that are easily accessible. Not a substitute for remote backups, but if you just need a local dump having this is nice?","commit_id":"f5df831f299b97a2b5cbb7ce0c61b024bb748732"}],"playbooks/roles/gerrit/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":297,"context_line":"  include_tasks: start.yaml"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"- name: Set up root mysql conf file"},{"line_number":300,"context_line":"  when: gerrit_database_type \u003d\u003d \u0027MYSQL\u0027"},{"line_number":301,"context_line":"  template:"},{"line_number":302,"context_line":"    src: root.my.cnf.mysql.j2"},{"line_number":303,"context_line":"    dest: /root/.gerrit_db.cnf"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"cf3e9ae0_af00a5fb","line":300,"updated":"2021-04-01 22:39:13.000000000","message":"This seems to sometimes be mysql.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":297,"context_line":"  include_tasks: start.yaml"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"- name: Set up root mysql conf file"},{"line_number":300,"context_line":"  when: gerrit_database_type \u003d\u003d \u0027MYSQL\u0027"},{"line_number":301,"context_line":"  template:"},{"line_number":302,"context_line":"    src: root.my.cnf.mysql.j2"},{"line_number":303,"context_line":"    dest: /root/.gerrit_db.cnf"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9db53dd2_4342f1aa","line":300,"in_reply_to":"cf3e9ae0_af00a5fb","updated":"2021-06-07 04:31:39.000000000","message":"Done","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"}],"playbooks/roles/gerrit/templates/docker-compose.yaml.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":12,"context_line":"      MYSQL_USER: \"{{ gerrit_mariadb_username }}\""},{"line_number":13,"context_line":"      MYSQL_PASSWORD: \"{{ gerrit_mariadb_password }}\""},{"line_number":14,"context_line":"    volumes:"},{"line_number":15,"context_line":"      - /home/gerrit2/review_site/mariadb:/var/lib/mysql"},{"line_number":16,"context_line":"    logging:"},{"line_number":17,"context_line":"      driver: syslog"},{"line_number":18,"context_line":"      options:"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"ca83cff8_87eb5c8e","line":15,"updated":"2021-04-01 22:39:13.000000000","message":"Typically we mount /var/container_name/stuff into the container. I believe we are not doing that here because we want to take advantage of the nice volume we are consuming. Would that be worth a comment here you think?","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      MYSQL_USER: \"{{ gerrit_mariadb_username }}\""},{"line_number":13,"context_line":"      MYSQL_PASSWORD: \"{{ gerrit_mariadb_password }}\""},{"line_number":14,"context_line":"    volumes:"},{"line_number":15,"context_line":"      - /home/gerrit2/review_site/mariadb:/var/lib/mysql"},{"line_number":16,"context_line":"    logging:"},{"line_number":17,"context_line":"      driver: syslog"},{"line_number":18,"context_line":"      options:"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"19b0fe6c_c51e6e81","line":15,"in_reply_to":"ca83cff8_87eb5c8e","updated":"2021-06-07 04:31:39.000000000","message":"The idea is to keep everything under /home/gerrit2/review_site for consistency.  Comment added.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ed2d2472bb9e05b3f403ea2c0efc7664cd88f496","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      # NOTE(ianw) : mounted under /home/gerrit2 (rather than more"},{"line_number":16,"context_line":"      # usual /var/ in our configs) to keep everything together on the"},{"line_number":17,"context_line":"      # storage attached at /home/gerrit2 on the server."},{"line_number":18,"context_line":"      - /home/gerrit2/review_site/mariadb:/var/lib/mysql"},{"line_number":19,"context_line":"    logging:"},{"line_number":20,"context_line":"      driver: syslog"},{"line_number":21,"context_line":"      options:"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"c2c51fe1_8593382f","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":41},"updated":"2021-06-10 18:36:12.000000000","message":"Does something need to create this dir? I\u0027m not seeing it in the ansible but I may have overlooked it as testing seems to work?","commit_id":"b312542f60207e531ac9b1319d477508d8c3cfe0"}],"playbooks/roles/gerrit/templates/secure.config.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% if gerrit_database_type \u003d\u003d \u0027MYSQL\u0027 %}"},{"line_number":2,"context_line":"[accountPatchReviewDb]"},{"line_number":3,"context_line":"\turl \u003d jdbc:mysql://{{ gerrit_mysql_host }}:3306/accountPatchReviewDb?characterSetResults\u003dutf8\u0026characterEncoding\u003dutf8\u0026connectionCollation\u003dutf8_bin\u0026useUnicode\u003dyes\u0026user\u003dgerrit2\u0026password\u003d{{ gerrit_mysql_password }}"},{"line_number":4,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"07a2300e_e71983c7","line":1,"range":{"start_line":1,"start_character":31,"end_line":1,"end_character":35},"updated":"2021-04-01 22:39:13.000000000","message":"Sometimes this is mysql.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if gerrit_database_type \u003d\u003d \u0027MYSQL\u0027 %}"},{"line_number":2,"context_line":"[accountPatchReviewDb]"},{"line_number":3,"context_line":"\turl \u003d jdbc:mysql://{{ gerrit_mysql_host }}:3306/accountPatchReviewDb?characterSetResults\u003dutf8\u0026characterEncoding\u003dutf8\u0026connectionCollation\u003dutf8_bin\u0026useUnicode\u003dyes\u0026user\u003dgerrit2\u0026password\u003d{{ gerrit_mysql_password }}"},{"line_number":4,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"6881ac63_3f831e0c","line":1,"range":{"start_line":1,"start_character":31,"end_line":1,"end_character":35},"in_reply_to":"07a2300e_e71983c7","updated":"2021-06-07 04:31:39.000000000","message":"Done","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":2,"context_line":"[accountPatchReviewDb]"},{"line_number":3,"context_line":"\turl \u003d jdbc:mysql://{{ gerrit_mysql_host }}:3306/accountPatchReviewDb?characterSetResults\u003dutf8\u0026characterEncoding\u003dutf8\u0026connectionCollation\u003dutf8_bin\u0026useUnicode\u003dyes\u0026user\u003dgerrit2\u0026password\u003d{{ gerrit_mysql_password }}"},{"line_number":4,"context_line":"{% endif %}"},{"line_number":5,"context_line":"[accountPatchReviewDb]"},{"line_number":6,"context_line":"{% if gerrit_database_type \u003d\u003d \u0027mariadb_container\u0027 %}"},{"line_number":7,"context_line":"\turl \u003d jdbc:mariadb://127.0.0.1:3306/{{ gerrit_mariadb_dbname }}?sessionVariables\u003dcharacter_set_client\u003dutf8,character_set_results\u003dutf8,character_set_connection\u003dutf8,collation_connection\u003dutf8_unicode_ci,collation_database\u003dutf8_unicode_ci,collation_server\u003dutf8_unicode_ci\u0026user\u003d{{ gerrit_mariadb_username }}\u0026password\u003d{{ gerrit_mariadb_password }}"},{"line_number":8,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"99d271d3_37be9f6f","line":5,"updated":"2021-04-01 22:39:13.000000000","message":"This line should be within the if block below. Since we only want to set this up if using one or the other dbs (you don\u0027t want it at all if doing h2 iirc).","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":2,"context_line":"[accountPatchReviewDb]"},{"line_number":3,"context_line":"\turl \u003d jdbc:mysql://{{ gerrit_mysql_host }}:3306/accountPatchReviewDb?characterSetResults\u003dutf8\u0026characterEncoding\u003dutf8\u0026connectionCollation\u003dutf8_bin\u0026useUnicode\u003dyes\u0026user\u003dgerrit2\u0026password\u003d{{ gerrit_mysql_password }}"},{"line_number":4,"context_line":"{% endif %}"},{"line_number":5,"context_line":"[accountPatchReviewDb]"},{"line_number":6,"context_line":"{% if gerrit_database_type \u003d\u003d \u0027mariadb_container\u0027 %}"},{"line_number":7,"context_line":"\turl \u003d jdbc:mariadb://127.0.0.1:3306/{{ gerrit_mariadb_dbname }}?sessionVariables\u003dcharacter_set_client\u003dutf8,character_set_results\u003dutf8,character_set_connection\u003dutf8,collation_connection\u003dutf8_unicode_ci,collation_database\u003dutf8_unicode_ci,collation_server\u003dutf8_unicode_ci\u0026user\u003d{{ gerrit_mariadb_username }}\u0026password\u003d{{ gerrit_mariadb_password }}"},{"line_number":8,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"b7e3a546_a3e452c4","line":5,"in_reply_to":"99d271d3_37be9f6f","updated":"2021-06-07 04:31:39.000000000","message":"Done","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"}],"playbooks/zuul/gerrit/base.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - name: Copy helpers into jeepyb build context"},{"line_number":4,"context_line":"      copy:"},{"line_number":5,"context_line":"        src: \u0027{{ item }}\u0027"},{"line_number":6,"context_line":"        dest: \u0027/home/zuul/src/opendev.org/opendev/jeepyb\u0027"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3abe78c6_60e158bc","line":3,"updated":"2021-04-01 22:39:13.000000000","message":"Might be worthwhile to have a comment in here explaining why the scripts are copied into the jeepyb repo (looks like we run the image build job against that dir context).","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - name: Copy helpers into jeepyb build context"},{"line_number":4,"context_line":"      copy:"},{"line_number":5,"context_line":"        src: \u0027{{ item }}\u0027"},{"line_number":6,"context_line":"        dest: \u0027/home/zuul/src/opendev.org/opendev/jeepyb\u0027"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"6c963a40_693c98a5","line":3,"in_reply_to":"3abe78c6_60e158bc","updated":"2021-06-07 04:31:39.000000000","message":"Done","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"}],"playbooks/zuul/gerrit/files/wait-for-it.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# The MIT License (MIT)"},{"line_number":4,"context_line":"# Copyright (c) 2016 Giles Hall"}],"source_content_type":"text/x-sh","patch_set":18,"id":"5b089683_a51a89a0","line":1,"updated":"2021-04-01 22:39:13.000000000","message":"I feel like this script needs Hamilton ascii art.\n\nDo you know where it comes from? might be worth a note in here?","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# The MIT License (MIT)"},{"line_number":4,"context_line":"# Copyright (c) 2016 Giles Hall"}],"source_content_type":"text/x-sh","patch_set":18,"id":"9953f300_2424f2ba","line":1,"in_reply_to":"5b089683_a51a89a0","updated":"2021-06-07 04:31:39.000000000","message":"This does run in the container where it happens, the container where it happens, the container where it happens.\n\nAdded links to the github \u0026 deb package page.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Use this script to test if a given TCP host/port are available"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"WAITFORIT_cmdname\u003d${0##*/}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"echoerr() { if [[ $WAITFORIT_QUIET -ne 1 ]]; then echo \"$@\" 1\u003e\u00262; fi }"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"31b54207_d85d5191","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":25},"updated":"2021-04-01 22:39:13.000000000","message":"This is apparently the unreadable bash version of `basename`. I guess they don\u0027t want to assume that basename is present when running in stripped down container envs.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":92,"context_line":"while [[ $# -gt 0 ]]; do"},{"line_number":93,"context_line":"    case \"$1\" in"},{"line_number":94,"context_line":"        *:* )"},{"line_number":95,"context_line":"        WAITFORIT_hostport\u003d(${1//:/ })"},{"line_number":96,"context_line":"        WAITFORIT_HOST\u003d${WAITFORIT_hostport[0]}"},{"line_number":97,"context_line":"        WAITFORIT_PORT\u003d${WAITFORIT_hostport[1]}"},{"line_number":98,"context_line":"        shift 1"}],"source_content_type":"text/x-sh","patch_set":18,"id":"a6a9e691_598c009a","line":95,"updated":"2021-04-01 22:39:13.000000000","message":"This means replace all occurences of \u0027:\u0027 in $1 with \u0027 \u0027.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        shift 2"},{"line_number":118,"context_line":"        ;;"},{"line_number":119,"context_line":"        --host\u003d*)"},{"line_number":120,"context_line":"        WAITFORIT_HOST\u003d\"${1#*\u003d}\""},{"line_number":121,"context_line":"        shift 1"},{"line_number":122,"context_line":"        ;;"},{"line_number":123,"context_line":"        -p)"}],"source_content_type":"text/x-sh","patch_set":18,"id":"65b51af2_4243355e","line":120,"range":{"start_line":120,"start_character":27,"end_line":120,"end_character":30},"updated":"2021-04-01 22:39:13.000000000","message":"This strips off the --host\u003d prefix.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"}],"playbooks/zuul/templates/group_vars/review.yaml.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d2f18b793e664069339ca35f44c6e87997d73eb1","unresolved":true,"context_lines":[{"line_number":85,"context_line":"  -----END OPENSSH PRIVATE KEY-----"},{"line_number":86,"context_line":"gerrit_replication_ssh_rsa_pubkey_contents: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDQhZQ0z+RVPmOzY2f56N9/PrqDeHftvnagPJyOOXnCd/9N0j+stFWNmavvb8y4dRZ+y6lOJpzPYEahwUUXZHAanz5l5as+VihWq7ldcMxSPnmkC9zr65Z8eNDcM2Bzk8gx5e4DE6OgpWkc6ke9MpwI5dmfW7o53gQZkdSc94TuLr+ZCYUKo7fScsVeE+F9dT0PLyW0zU7c23PzYnkKcrB9ihpQfSfbJj9EAtsA3aA8ZdHt78i5r7+0u0JZxaWoKjkCfYqC8ofbTU61YuUO8TTgNgMC6ZzBmTRdRRRKdGun+m1fqtgIqPSi+iZpKnERgg/hPwY+gqcKh+svW6pgCDhJ gerrit-code-review-replication"},{"line_number":87,"context_line":"gerrit_database_type: mariadb_container"},{"line_number":88,"context_line":"gerrit_mariadb_dbname: gerrit"},{"line_number":89,"context_line":"gerrit_mariadb_username: gerrit"},{"line_number":90,"context_line":"gerrit_mariadb_password: password"},{"line_number":91,"context_line":"gerrit_run_compose_up: true"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"07343576_a8e17e31","line":88,"updated":"2021-04-01 22:39:13.000000000","message":"See note about the default dbname in the role README.","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8edd491d4a11eb1effc35117766be2b1de319474","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  -----END OPENSSH PRIVATE KEY-----"},{"line_number":86,"context_line":"gerrit_replication_ssh_rsa_pubkey_contents: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDQhZQ0z+RVPmOzY2f56N9/PrqDeHftvnagPJyOOXnCd/9N0j+stFWNmavvb8y4dRZ+y6lOJpzPYEahwUUXZHAanz5l5as+VihWq7ldcMxSPnmkC9zr65Z8eNDcM2Bzk8gx5e4DE6OgpWkc6ke9MpwI5dmfW7o53gQZkdSc94TuLr+ZCYUKo7fScsVeE+F9dT0PLyW0zU7c23PzYnkKcrB9ihpQfSfbJj9EAtsA3aA8ZdHt78i5r7+0u0JZxaWoKjkCfYqC8ofbTU61YuUO8TTgNgMC6ZzBmTRdRRRKdGun+m1fqtgIqPSi+iZpKnERgg/hPwY+gqcKh+svW6pgCDhJ gerrit-code-review-replication"},{"line_number":87,"context_line":"gerrit_database_type: mariadb_container"},{"line_number":88,"context_line":"gerrit_mariadb_dbname: gerrit"},{"line_number":89,"context_line":"gerrit_mariadb_username: gerrit"},{"line_number":90,"context_line":"gerrit_mariadb_password: password"},{"line_number":91,"context_line":"gerrit_run_compose_up: true"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"8fa5c595_22b026b7","line":88,"in_reply_to":"07343576_a8e17e31","updated":"2021-06-07 04:31:39.000000000","message":"all changed to have reviewdb in the var name","commit_id":"e6a690076a0c1b7a2564862c5e1a9a8388c9d97f"}]}