)]}'
{"playbooks/roles/mailman-list/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8c5c3f419aab9225faa197443ecb6738a10d3db9","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        - ( listlists.stdout_lines | intersect([ mm_list_name ]) | length | int ) \u003d\u003d 0"},{"line_number":33,"context_line":"  when: mm_site_name \u003d\u003d \"_default\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# TODO we accept a description parameter but don\u0027t do anything with it"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"838e5e71_63be7e9a","line":35,"updated":"2021-05-05 22:58:00.000000000","message":"Looking at prod it seems that the puppetry may have never done anything with the descriptions either? A lot of lists don\u0027t have descriptions. I think we can accept that this is a TODO for now.","commit_id":"e27c4f645147defbd3a53869f5c572059a647d21"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1df6618e50a07a3da8f93a93cd80548a9850d6c8","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        MAILMAN_SITE_DIR: \"{{ mm_site_root }}\""},{"line_number":15,"context_line":"      register: listlists"},{"line_number":16,"context_line":"    - name: Create the site list if it doesn\u0027t exist"},{"line_number":17,"context_line":"      # TODO Is there a better way to do this? I only want the -q when we"},{"line_number":18,"context_line":"      # are testing and would rather not think about it otherwise."},{"line_number":19,"context_line":"      command: \"newlist {{ mailman_test_mode | default(False) | ternary(\u0027-q\u0027, \u0027\u0027, \u0027\u0027) }} {{ mm_list_name }} {{ mm_list_admin }} {{ mm_list_password }}\""},{"line_number":20,"context_line":"      environment:"},{"line_number":21,"context_line":"        MAILMAN_SITE_DIR: \"{{ mm_site_root }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3107fd71_ab9209fd","line":18,"range":{"start_line":17,"start_character":5,"end_line":18,"end_character":66},"updated":"2021-05-11 06:29:29.000000000","message":"{% if mailman_test_mode %} -q {% endif %} maybe seems clearer","commit_id":"2b663a31c13f8834d3e4eb5f8eb37e7fc3d2c677"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d1092f13a2a9edc4010fdf1c751d9cd635050b67","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        MAILMAN_SITE_DIR: \"{{ mm_site_root }}\""},{"line_number":15,"context_line":"      register: listlists"},{"line_number":16,"context_line":"    - name: Create the site list if it doesn\u0027t exist"},{"line_number":17,"context_line":"      # TODO Is there a better way to do this? I only want the -q when we"},{"line_number":18,"context_line":"      # are testing and would rather not think about it otherwise."},{"line_number":19,"context_line":"      command: \"newlist {{ mailman_test_mode | default(False) | ternary(\u0027-q\u0027, \u0027\u0027, \u0027\u0027) }} {{ mm_list_name }} {{ mm_list_admin }} {{ mm_list_password }}\""},{"line_number":20,"context_line":"      environment:"},{"line_number":21,"context_line":"        MAILMAN_SITE_DIR: \"{{ mm_site_root }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"43575a3d_46f4be21","line":18,"range":{"start_line":17,"start_character":5,"end_line":18,"end_character":66},"in_reply_to":"3107fd71_ab9209fd","updated":"2021-05-11 15:36:07.000000000","message":"I knew there had to be a better way. I think that update is worthwhile.","commit_id":"2b663a31c13f8834d3e4eb5f8eb37e7fc3d2c677"}],"playbooks/roles/mailman-site/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"292946cdb2ea599bea0cda7978ccfbeddd32bb80","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    group: root"},{"line_number":73,"context_line":"    mode: \u00270444\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: Create normal mailman vhost config"},{"line_number":76,"context_line":"  template:"},{"line_number":77,"context_line":"    src: mailman_multihost.vhost.j2"},{"line_number":78,"context_line":"    dest: \"/etc/apache2/sites-enabled/50-{{ mailman_site.listdomain }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ad979c74_99f3b61d","line":75,"updated":"2021-05-05 23:09:44.000000000","message":"Nit: This should be \u0027Create site specific mailman vhost config\u0027.","commit_id":"e27c4f645147defbd3a53869f5c572059a647d21"}],"playbooks/roles/mailman-site/templates/mailman_multihost.vhost.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"292946cdb2ea599bea0cda7978ccfbeddd32bb80","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003cVirtualHost *:80\u003e"},{"line_number":2,"context_line":"\tServerName {{ mailman_site.listdomain }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"\tErrorLog ${APACHE_LOG_DIR}/{{ mailman_site.listdomain }}-error.log"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"00acae4d_14ac131e","line":2,"updated":"2021-05-05 23:09:44.000000000","message":"Note this was taken as is from the puppetry. Tabs and all. Only changes were to the template var interpolation.","commit_id":"e27c4f645147defbd3a53869f5c572059a647d21"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1df6618e50a07a3da8f93a93cd80548a9850d6c8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003cVirtualHost *:80\u003e"},{"line_number":2,"context_line":"\tServerName {{ mailman_site.listdomain }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"\tErrorLog ${APACHE_LOG_DIR}/{{ mailman_site.listdomain }}-error.log"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"338de09e_2ceee0bb","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":18},"updated":"2021-05-11 06:29:29.000000000","message":"I guess we can letsecnrypt this in a follow-on...","commit_id":"2b663a31c13f8834d3e4eb5f8eb37e7fc3d2c677"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1df6618e50a07a3da8f93a93cd80548a9850d6c8","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    AllowOverride None"},{"line_number":55,"context_line":"    Order allow,deny"},{"line_number":56,"context_line":"    Allow from all"},{"line_number":57,"context_line":"    \u003cIfVersion \u003e\u003d 2.4\u003e"},{"line_number":58,"context_line":"        Require all granted"},{"line_number":59,"context_line":"    \u003c/IfVersion\u003e"},{"line_number":60,"context_line":"\u003c/Directory\u003e"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9791e302_ced845a4","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":16},"updated":"2021-05-11 06:29:29.000000000","message":"can probably modernise this, although I get you\u0027re trying to just replicate puppet ATM","commit_id":"2b663a31c13f8834d3e4eb5f8eb37e7fc3d2c677"}],"playbooks/roles/mailman/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"912937faf70a90c208994e343ad11df185d2bd53","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        name: \"mailman\""},{"line_number":115,"context_line":"        enabled: yes"},{"line_number":116,"context_line":"    # TODO does this need to do anything special to mimic the noaliasmailman"},{"line_number":117,"context_line":"    # puppet provider?"},{"line_number":118,"context_line":"    - name: Create mailman site lists"},{"line_number":119,"context_line":"      include_role:"},{"line_number":120,"context_line":"        name: mailman-list"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3faaa04d_802d5177","line":117,"updated":"2021-05-07 15:31:40.000000000","message":"Specifically wondering if I need to do anything to accommodate what was done here: https://opendev.org/opendev/puppet-mailman/src/branch/master/lib/puppet/provider/mailman_list/mailman.rb#L17-L19","commit_id":"e27c4f645147defbd3a53869f5c572059a647d21"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"11b4e08dba5a0d02221fe500e2dd1856e01aa7a4","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        name: \"mailman\""},{"line_number":115,"context_line":"        enabled: yes"},{"line_number":116,"context_line":"    # TODO does this need to do anything special to mimic the noaliasmailman"},{"line_number":117,"context_line":"    # puppet provider?"},{"line_number":118,"context_line":"    - name: Create mailman site lists"},{"line_number":119,"context_line":"      include_role:"},{"line_number":120,"context_line":"        name: mailman-list"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bc7b434c_0bec8d04","line":117,"in_reply_to":"3faaa04d_802d5177","updated":"2021-05-07 16:04:51.000000000","message":"Corvus says the original puppetry assumed it had to edit /etc/aliases but we have exim doing the name mapping for us and none of that is necessary. My implementation here is simple/naive and doesn\u0027t include anything like that so we are good.","commit_id":"e27c4f645147defbd3a53869f5c572059a647d21"}],"zuul.d/system-config-run.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"292946cdb2ea599bea0cda7978ccfbeddd32bb80","unresolved":true,"context_lines":[{"line_number":222,"context_line":"      run_playbooks:"},{"line_number":223,"context_line":"        - playbooks/service-lists.yaml"},{"line_number":224,"context_line":"        # Run this twice to check idempotency"},{"line_number":225,"context_line":"        - playbooks/service-lists.yaml"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"- job:"},{"line_number":228,"context_line":"    name: system-config-run-nodepool"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"fe53c9e3_76f321ff","line":225,"updated":"2021-05-05 23:09:44.000000000","message":"Looking at the second pass of service-lists.yaml in the ara report for this job I see a bunch of skipped \"Create this list if it doesn\u0027t exist\" so that is looking good.","commit_id":"e27c4f645147defbd3a53869f5c572059a647d21"}]}