)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fb78ab1b85e7a7c19b76e4d5803860c9597edbd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8b047d78_64375c35","updated":"2021-10-13 05:23:43.000000000","message":"This actually has a syntax error that isn\u0027t reporting due to https://review.opendev.org/c/zuul/zuul/+/813733/1","commit_id":"77ae45f01d70c3a3db9706372cdee74d3e2a65b8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0d97a109bde2a660856a6489c686a5418f3ab198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8d7a2cd9_8f1bf8f9","updated":"2021-10-21 03:39:44.000000000","message":"recheck","commit_id":"77ae45f01d70c3a3db9706372cdee74d3e2a65b8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8687115e468b34070ab3f043251a24a774a1858b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7824335f_5148ddf2","updated":"2021-11-17 00:39:10.000000000","message":"recheck","commit_id":"4244a49cec80720d389bc83df7f2fb34eeeda110"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"50d32b7bfb044791c84c0f22e74ec50a389b4a26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0527a99c_6d2148f7","updated":"2021-11-17 22:15:11.000000000","message":"recheck","commit_id":"254303ad9db3723f13264f0141135a396de695e7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ec4f3c0b1256810a88d7bc9631e1292c619596fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1e67e4bd_7f406f2d","updated":"2021-11-29 19:48:20.000000000","message":"will monitor","commit_id":"d0467bfc98bf433cef50c21ffd2b9d1eb43a2462"}],"zuul.d/infra-prod.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"eee60aa6443e4e3221e41cb03446a5dc9afbfb52","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    required-projects:"},{"line_number":93,"context_line":"      - opendev/system-config"},{"line_number":94,"context_line":"      - openstack/project-config"},{"line_number":95,"context_line":"    files:"},{"line_number":96,"context_line":"      - inventory/.*"},{"line_number":97,"context_line":"      - playbooks/manage-projects.yaml"},{"line_number":98,"context_line":"      - inventory/service/group_vars/gerrit.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c0448eff_8c9709ac","line":95,"updated":"2021-09-07 19:56:22.000000000","message":"I believe these were set on the pipeline variants rather than at the job definition level because project-config also runs this job and has a different set of file matchers. I\u0027m not sure how zuul will handle the variant in project-config updating this list.","commit_id":"a735d4b866cfd059ace527e2ae3bb5c9fda37e90"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"be54b5a6afbdea7c61bec486819625b0dc34d8ff","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    required-projects:"},{"line_number":93,"context_line":"      - opendev/system-config"},{"line_number":94,"context_line":"      - openstack/project-config"},{"line_number":95,"context_line":"    files:"},{"line_number":96,"context_line":"      - inventory/.*"},{"line_number":97,"context_line":"      - playbooks/manage-projects.yaml"},{"line_number":98,"context_line":"      - inventory/service/group_vars/gerrit.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da986110_2f99c550","line":95,"in_reply_to":"c0448eff_8c9709ac","updated":"2021-09-07 20:29:23.000000000","message":"ok, will move back with a comment","commit_id":"a735d4b866cfd059ace527e2ae3bb5c9fda37e90"}],"zuul.d/project.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"eee60aa6443e4e3221e41cb03446a5dc9afbfb52","unresolved":true,"context_lines":[{"line_number":339,"context_line":"        - infra-prod-install-ansible"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # XXX NOT SURE WHERE TO PUT THESE"},{"line_number":342,"context_line":"        - infra-prod-service-bridge"},{"line_number":343,"context_line":"        - infra-prod-run-cloud-launcher"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # From now on, all jobs should depend on base"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"72857336_fc878a4b","line":342,"updated":"2021-09-07 19:56:22.000000000","message":"Lets run bridge early in the dependency graph because it updates ansible and ansible configs on bridge. Then we get consistent ansible behavior out of the subsequent jobs. The system-config checkout this job does is not necessary (though maybe a good idea to keep as an escape hatch?).","commit_id":"a735d4b866cfd059ace527e2ae3bb5c9fda37e90"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"be54b5a6afbdea7c61bec486819625b0dc34d8ff","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        - infra-prod-install-ansible"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # XXX NOT SURE WHERE TO PUT THESE"},{"line_number":342,"context_line":"        - infra-prod-service-bridge"},{"line_number":343,"context_line":"        - infra-prod-run-cloud-launcher"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # From now on, all jobs should depend on base"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"11067ff3_cb98ffa2","line":342,"in_reply_to":"72857336_fc878a4b","updated":"2021-09-07 20:29:23.000000000","message":"will move","commit_id":"a735d4b866cfd059ace527e2ae3bb5c9fda37e90"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"eee60aa6443e4e3221e41cb03446a5dc9afbfb52","unresolved":true,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # XXX NOT SURE WHERE TO PUT THESE"},{"line_number":342,"context_line":"        - infra-prod-service-bridge"},{"line_number":343,"context_line":"        - infra-prod-run-cloud-launcher"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # From now on, all jobs should depend on base"},{"line_number":346,"context_line":"        - infra-prod-base:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"327be72a_c6b8a016","line":343,"updated":"2021-09-07 19:56:22.000000000","message":"This should be able to run independently 99% of the time. The only time it wants to run before anything else is when we add a new cloud to nodepool and need it to set up ssh keys and the like. But nodepool should \"gracefully\" fail in those cases until this job completes running its updates to ssh keys and security groups and networks.","commit_id":"a735d4b866cfd059ace527e2ae3bb5c9fda37e90"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"be54b5a6afbdea7c61bec486819625b0dc34d8ff","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # XXX NOT SURE WHERE TO PUT THESE"},{"line_number":342,"context_line":"        - infra-prod-service-bridge"},{"line_number":343,"context_line":"        - infra-prod-run-cloud-launcher"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # From now on, all jobs should depend on base"},{"line_number":346,"context_line":"        - infra-prod-base:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"87b428ae_bdd1c68f","line":343,"in_reply_to":"327be72a_c6b8a016","updated":"2021-09-07 20:29:23.000000000","message":"will add a note saying as such","commit_id":"a735d4b866cfd059ace527e2ae3bb5c9fda37e90"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"565c775c9e49548836d47335b1c090d09cf051cc","unresolved":true,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # This installs the ansible on bridge that all the infra-prod"},{"line_number":352,"context_line":"        # jobs will run with.  Note the jobs use this ansible to then"},{"line_number":353,"context_line":"        # run against zuul\u0027s checkout of system-config."},{"line_number":354,"context_line":"        - infra-prod-install-ansible"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        # From now on, all jobs should depend on base"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"73340915_120a6003","line":353,"updated":"2021-10-05 23:00:13.000000000","message":"I think we should add a note here that explains why dependencies are managed in the pipelines and not in the job definitions. IIRC it has something to do with some jobs running in other contexts like project-config merging code. Looks like in the other file you also note it is easier to keep track of an overview from this context. Let\u0027s note that stuff here as well.","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6100b5833fab060eb12fe20fd86dae28d63fa381","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # This installs the ansible on bridge that all the infra-prod"},{"line_number":352,"context_line":"        # jobs will run with.  Note the jobs use this ansible to then"},{"line_number":353,"context_line":"        # run against zuul\u0027s checkout of system-config."},{"line_number":354,"context_line":"        - infra-prod-install-ansible"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        # From now on, all jobs should depend on base"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a5188d0d_3227e6f0","line":353,"in_reply_to":"73340915_120a6003","updated":"2021-10-12 04:33:25.000000000","message":"done, added a note above the jobs","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"565c775c9e49548836d47335b1c090d09cf051cc","unresolved":true,"context_lines":[{"line_number":405,"context_line":"              - name: infra-prod-base"},{"line_number":406,"context_line":"                soft: true"},{"line_number":407,"context_line":"              # NOTE(ianw) should depend on afs?  not sure practically"},{"line_number":408,"context_line":"              # anything would require this"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        #"},{"line_number":411,"context_line":"        # Hosts using certificates and backups"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"728935f7_729bf8e5","line":408,"updated":"2021-10-05 23:00:13.000000000","message":"The way afs works this is sort of a soft dependency anyway. The files just won\u0027t be there until afs happens.","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6100b5833fab060eb12fe20fd86dae28d63fa381","unresolved":false,"context_lines":[{"line_number":405,"context_line":"              - name: infra-prod-base"},{"line_number":406,"context_line":"                soft: true"},{"line_number":407,"context_line":"              # NOTE(ianw) should depend on afs?  not sure practically"},{"line_number":408,"context_line":"              # anything would require this"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        #"},{"line_number":411,"context_line":"        # Hosts using certificates and backups"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7fab8c0d_ced67738","line":408,"in_reply_to":"728935f7_729bf8e5","updated":"2021-10-12 04:33:25.000000000","message":"removed this note.  no need to cause confusion when it\u0027s already confusing enough","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"565c775c9e49548836d47335b1c090d09cf051cc","unresolved":true,"context_lines":[{"line_number":487,"context_line":"              - name: infra-prod-service-borg-backup"},{"line_number":488,"context_line":"                soft: true"},{"line_number":489,"context_line":"              - name: infra-prod-letsencrypt"},{"line_number":490,"context_line":"                soft: true"},{"line_number":491,"context_line":"              - name: system-config-promote-image-grafana"},{"line_number":492,"context_line":"                soft: true"},{"line_number":493,"context_line":"        - infra-prod-service-mirror: \u0026infra-prod-service-mirror"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"35527acc_50f785b5","line":490,"updated":"2021-10-05 23:00:13.000000000","message":"Lists doesn\u0027t currently use letsencrypt certs (or any certs). This will change with mailman 3. Not sure if it is better to leave this as is or update it when LE happens.","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6100b5833fab060eb12fe20fd86dae28d63fa381","unresolved":false,"context_lines":[{"line_number":487,"context_line":"              - name: infra-prod-service-borg-backup"},{"line_number":488,"context_line":"                soft: true"},{"line_number":489,"context_line":"              - name: infra-prod-letsencrypt"},{"line_number":490,"context_line":"                soft: true"},{"line_number":491,"context_line":"              - name: system-config-promote-image-grafana"},{"line_number":492,"context_line":"                soft: true"},{"line_number":493,"context_line":"        - infra-prod-service-mirror: \u0026infra-prod-service-mirror"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"01ae6ab8_3bfca6a6","line":490,"in_reply_to":"35527acc_50f785b5","updated":"2021-10-12 04:33:25.000000000","message":"good point.  i\u0027ll make the call to just leave it as is; this will surely acquire certificates soon enough","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"565c775c9e49548836d47335b1c090d09cf051cc","unresolved":true,"context_lines":[{"line_number":527,"context_line":"              - name: infra-prod-letsencrypt"},{"line_number":528,"context_line":"                soft: true"},{"line_number":529,"context_line":"              - name: system-config-promote-image-gerrit-3.2"},{"line_number":530,"context_line":"                soft: true"},{"line_number":531,"context_line":"        - infra-prod-service-zookeeper: \u0026infra-prod-service-zookeeper"},{"line_number":532,"context_line":"            dependencies:"},{"line_number":533,"context_line":"              - name: infra-prod-letsencrypt"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f6522ea9_075e5224","line":530,"updated":"2021-10-05 23:00:13.000000000","message":"Maybe add the 3.3 promotion here too since it is a soft dependency and will assist with the planned upgrade?","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6100b5833fab060eb12fe20fd86dae28d63fa381","unresolved":false,"context_lines":[{"line_number":527,"context_line":"              - name: infra-prod-letsencrypt"},{"line_number":528,"context_line":"                soft: true"},{"line_number":529,"context_line":"              - name: system-config-promote-image-gerrit-3.2"},{"line_number":530,"context_line":"                soft: true"},{"line_number":531,"context_line":"        - infra-prod-service-zookeeper: \u0026infra-prod-service-zookeeper"},{"line_number":532,"context_line":"            dependencies:"},{"line_number":533,"context_line":"              - name: infra-prod-letsencrypt"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dce6f839_24ccdddd","line":530,"in_reply_to":"f6522ea9_075e5224","updated":"2021-10-12 04:33:25.000000000","message":"this has been merged and 3.3. is active, so it\u0027s updated to 3.3 now","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"565c775c9e49548836d47335b1c090d09cf051cc","unresolved":true,"context_lines":[{"line_number":570,"context_line":"              - name: infra-prod-service-review"},{"line_number":571,"context_line":"                soft: true"},{"line_number":572,"context_line":"              - name: system-config-promote-image-gerrit-3.2"},{"line_number":573,"context_line":"                soft: true"},{"line_number":574,"context_line":"            # Note that this job also runs from project-config, so we"},{"line_number":575,"context_line":"            # match system-config specific files here rather than the"},{"line_number":576,"context_line":"            # job definition."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"edba3c08_918d77a9","line":573,"updated":"2021-10-05 23:00:13.000000000","message":"This also runs on set up gitea services. I think we should depend on infra-prod-service-gitea.","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6100b5833fab060eb12fe20fd86dae28d63fa381","unresolved":false,"context_lines":[{"line_number":570,"context_line":"              - name: infra-prod-service-review"},{"line_number":571,"context_line":"                soft: true"},{"line_number":572,"context_line":"              - name: system-config-promote-image-gerrit-3.2"},{"line_number":573,"context_line":"                soft: true"},{"line_number":574,"context_line":"            # Note that this job also runs from project-config, so we"},{"line_number":575,"context_line":"            # match system-config specific files here rather than the"},{"line_number":576,"context_line":"            # job definition."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3dfe7581_c45865b8","line":573,"in_reply_to":"edba3c08_918d77a9","updated":"2021-10-12 04:33:25.000000000","message":"Done","commit_id":"1c917f2c5b4dd78ca7b1d8192414d4b0bad65dfb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"95405a7917025a26210c771cf9ea5d654de897e8","unresolved":true,"context_lines":[{"line_number":170,"context_line":"      jobs:"},{"line_number":171,"context_line":"        # NOTE(ianw) 2021-10-13 : temporarily added"},{"line_number":172,"context_line":"        # for https://review.opendev.org/c/opendev/system-config/+/807672"},{"line_number":173,"context_line":"        - noop"},{"line_number":174,"context_line":"        - opendev-tox-docs"},{"line_number":175,"context_line":"        - opendev-buildset-registry"},{"line_number":176,"context_line":"        - tox-linters:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4a3ddaa0_addd2304","line":173,"updated":"2021-11-17 21:14:27.000000000","message":"Will the three check jobs not run in the gate when we approve this change? If they will run maybe we should just remove this to avoid unnecessary confusion.","commit_id":"4279de4aa37804d5399b1ed657799e619ecfec27"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cf12c564aae3ebb89a051d6321038f381fbe2771","unresolved":false,"context_lines":[{"line_number":170,"context_line":"      jobs:"},{"line_number":171,"context_line":"        # NOTE(ianw) 2021-10-13 : temporarily added"},{"line_number":172,"context_line":"        # for https://review.opendev.org/c/opendev/system-config/+/807672"},{"line_number":173,"context_line":"        - noop"},{"line_number":174,"context_line":"        - opendev-tox-docs"},{"line_number":175,"context_line":"        - opendev-buildset-registry"},{"line_number":176,"context_line":"        - tox-linters:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cfa0e520_27003bce","line":173,"in_reply_to":"4a3ddaa0_addd2304","updated":"2021-11-17 23:29:49.000000000","message":"Oh, this was from when I didn\u0027t understand what was going on with the config errors; which turned out to be the comment was too long to post to gerrit so zuul wasn\u0027t reporting.  this bit can go.","commit_id":"4279de4aa37804d5399b1ed657799e619ecfec27"}]}