)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1ddb1b55f97d5aef87517ac09a6d0ebf6e42f453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5bc3475a_50c29c23","updated":"2021-12-02 19:41:44.000000000","message":"Sorry for all the separate comments. I keep thinking of stuff to call out.","commit_id":"1987f86a9ab9f5f4579b27bb89569131de400e15"}],"zuul.d/infra-prod.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6414652a92ad0ca98d5d2f07371688f19db6b989","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    # because it\u0027s a trusted playbook.  But this might be a handy"},{"line_number":24,"context_line":"    # place to hook in things such as writing out secrets from Zuul in"},{"line_number":25,"context_line":"    # the future?"},{"line_number":26,"context_line":"    run: playbooks/zuul/setup-production-workspace.yaml"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- job:"},{"line_number":29,"context_line":"    name: infra-prod-playbook"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dbce7859_09b5c692","side":"PARENT","line":26,"updated":"2021-12-02 19:40:39.000000000","message":"This job needs to set nodes: [] otherwise it gets a single instance of a default node which runs normal workspace preparation which confusingly made it look like this job was working. It was working but against the wrong host :)","commit_id":"fc257bdcaabb48706a9723a289195d75393044bd"}],"zuul.d/project.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9feaf03df1c638ad661d06321ed5baf09e3a0241","unresolved":true,"context_lines":[{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        # This job replicates the system-config from this buildset"},{"line_number":357,"context_line":"        # onto bridge"},{"line_number":358,"context_line":"        - infra-prod-setup-src"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # This installs the ansible on bridge that all the infra-prod"},{"line_number":361,"context_line":"        # jobs will run with.  Note the jobs use this ansible to then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bd828eb0_4c1a28e9","side":"PARENT","line":358,"updated":"2021-12-02 19:29:08.000000000","message":"Note for when we work on unreverting this. We need this setup-src job to run in every pipeline otherwise we could merge a change and deploy that update then the hourly or daily periodic jobs can come by and undo our updates because they will reset to old code? Its possible they will just leave it as is, but I think for consistency we want a setup-src job in every pipeline and a non soft dependency on that for every job.","commit_id":"fc257bdcaabb48706a9723a289195d75393044bd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1ddb1b55f97d5aef87517ac09a6d0ebf6e42f453","unresolved":true,"context_lines":[{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        # This job replicates the system-config from this buildset"},{"line_number":357,"context_line":"        # onto bridge"},{"line_number":358,"context_line":"        - infra-prod-setup-src"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # This installs the ansible on bridge that all the infra-prod"},{"line_number":361,"context_line":"        # jobs will run with.  Note the jobs use this ansible to then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"71c3931c_80cc5a89","side":"PARENT","line":358,"in_reply_to":"bd828eb0_4c1a28e9","updated":"2021-12-02 19:41:44.000000000","message":"Another note. The way the playbooks in opendev/base-jobs are arranged only this job ends up checking the DISABLE-ANSIBLE file on bridge. I think we want every job to check that.","commit_id":"fc257bdcaabb48706a9723a289195d75393044bd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9feaf03df1c638ad661d06321ed5baf09e3a0241","unresolved":true,"context_lines":[{"line_number":367,"context_line":"        - infra-prod-base: \u0026infra-prod-base"},{"line_number":368,"context_line":"            dependencies:"},{"line_number":369,"context_line":"              - name: infra-prod-install-ansible"},{"line_number":370,"context_line":"                soft: true"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        # Legacy puppet hosts"},{"line_number":373,"context_line":"        - infra-prod-remote-puppet-else: \u0026infra-prod-remote-puppet-else"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"928fa0a8_da1eb0e5","side":"PARENT","line":370,"updated":"2021-12-02 19:29:08.000000000","message":"This would become a hard dependency to ensure that the source is updated.","commit_id":"fc257bdcaabb48706a9723a289195d75393044bd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9feaf03df1c638ad661d06321ed5baf09e3a0241","unresolved":true,"context_lines":[{"line_number":373,"context_line":"        - infra-prod-remote-puppet-else: \u0026infra-prod-remote-puppet-else"},{"line_number":374,"context_line":"            dependencies:"},{"line_number":375,"context_line":"              - name: infra-prod-base"},{"line_number":376,"context_line":"                soft: true"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        #"},{"line_number":379,"context_line":"        # Only depends on base, or amongst themselves."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa064d2f_d2f0eace","side":"PARENT","line":376,"updated":"2021-12-02 19:29:08.000000000","message":"We need to add a hard dependency to infra-prod-install-ansible to this job and every job below in the unrevert.\n\nMy concern is that if infra-prod-base doesn\u0027t need to run then we won\u0027t depend on infra-prod-install-ansible which depends on infra-prod-setup-src. I may be wrong about this. But I think starting conservatively is important then we can keep refining.","commit_id":"fc257bdcaabb48706a9723a289195d75393044bd"}]}