)]}'
{"playbooks/test-lists.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6737a853f76bb845a9725adc20bfd4bae8fd973f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # we can capture that activity in the Exim logs."},{"line_number":7,"context_line":"    - name: Restart Mailman services"},{"line_number":8,"context_line":"      command:"},{"line_number":9,"context_line":"        cmd: \"systemctl restart mailman-{{ zuul_mailman_site.name }}\""},{"line_number":10,"context_line":"      become: yes"},{"line_number":11,"context_line":"      loop: \"{{ mailman_sites }}\""},{"line_number":12,"context_line":"      loop_control:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"66070a5b_57d3c1d2","line":9,"updated":"2021-12-15 17:21:28.000000000","message":"I\u0027ll give it a shot. I know (from local testing) that a manual restart will work both when the service is not running but also when it\u0027s failed to start previously due to errors.","commit_id":"bf1ffeab32142dba5ac0b68620230ac6b95c177e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7e0a9f7baa298ffbcb8541b821f7d7265ec78e4f","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    # we can capture that activity in the Exim logs."},{"line_number":7,"context_line":"    - name: Restart Mailman services"},{"line_number":8,"context_line":"      command:"},{"line_number":9,"context_line":"        cmd: \"systemctl restart mailman-{{ zuul_mailman_site.name }}\""},{"line_number":10,"context_line":"      become: yes"},{"line_number":11,"context_line":"      loop: \"{{ mailman_sites }}\""},{"line_number":12,"context_line":"      loop_control:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bbcc281d_12a1370f","line":9,"updated":"2021-12-15 03:24:22.000000000","message":"Prety sure you can just do\n\nservice:\n\n name: mailman-{{ zuul... }}\n state: restarted\n\nhere?","commit_id":"bf1ffeab32142dba5ac0b68620230ac6b95c177e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e5b595ea5a6f1aa690908a0551c89aee742dca12","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    - name: Restart Mailman services"},{"line_number":8,"context_line":"      service:"},{"line_number":9,"context_line":"        name: \"mailman-{{ zuul_mailman_site.name }}\""},{"line_number":10,"context_line":"      state: restarted"},{"line_number":11,"context_line":"      loop: \"{{ mailman_sites }}\""},{"line_number":12,"context_line":"      loop_control:"},{"line_number":13,"context_line":"        loop_var: zuul_mailman_site"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"efd3ee22_3ff47c61","line":10,"updated":"2021-12-15 17:42:50.000000000","message":"Oh, and this should be indented one more level.","commit_id":"bea646a8d2344526db97ab522a3efdeb7252c5c0"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bf3a696c15dec630d3fb4a565b551fed9499a02d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # activity in the Exim logs."},{"line_number":21,"context_line":"    - name: Restart Mailman services"},{"line_number":22,"context_line":"      service:"},{"line_number":23,"context_line":"        name: \"mailman\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- hosts: \"localhost\""},{"line_number":26,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"733575f4_16a9b23b","line":23,"updated":"2021-12-15 17:41:27.000000000","message":"Oops, I forgot the state:restarted here.","commit_id":"bea646a8d2344526db97ab522a3efdeb7252c5c0"}],"testinfra/test_lists_o_o.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9894e67b2bb94649ba718868cf7411bc3475c397","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    host.run(\u0027systemctl restart mailman-openstack\u0027)"},{"line_number":21,"context_line":"    host.run(\u0027systemctl restart mailman-starlingx\u0027)"},{"line_number":22,"context_line":"    host.run(\u0027systemctl restart mailman-zuul\u0027)"},{"line_number":23,"context_line":"    host.run(\u0027sleep 10\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    cmd \u003d host.run(\u0027HOST\u003dlists.airshipit.org list_lists --bare\u0027)"},{"line_number":26,"context_line":"    assert \u0027airship-discuss\u0027 in cmd.stdout"}],"source_content_type":"text/x-python","patch_set":2,"id":"3e65b4d8_93bd5883","line":23,"updated":"2021-12-09 17:32:24.000000000","message":"Instead of sleeping and hoping we could check if each of the services is running with https://testinfra.readthedocs.io/en/latest/modules.html#testinfra.modules.service.Service.is_running and then have a timeout.","commit_id":"97604ee994507e1d834ebbd6832074871489172b"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0a52f1143b6051b65551a7a1fcd6efb7f178409c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    host.run(\u0027systemctl restart mailman-openstack\u0027)"},{"line_number":21,"context_line":"    host.run(\u0027systemctl restart mailman-starlingx\u0027)"},{"line_number":22,"context_line":"    host.run(\u0027systemctl restart mailman-zuul\u0027)"},{"line_number":23,"context_line":"    host.run(\u0027sleep 10\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    cmd \u003d host.run(\u0027HOST\u003dlists.airshipit.org list_lists --bare\u0027)"},{"line_number":26,"context_line":"    assert \u0027airship-discuss\u0027 in cmd.stdout"}],"source_content_type":"text/x-python","patch_set":2,"id":"83333dd6_94fb251d","line":23,"updated":"2021-12-09 18:30:33.000000000","message":"There\u0027s almost certainly a better solution than the sleep here (which is definitely an ugly hack). The idea was not just to make sure the services had started, but that they had time to try to deliver notifications before we collect the MM and Exim logs. I\u0027m open to suggestions, but just checking that the services have started is probably insufficient in this case.","commit_id":"97604ee994507e1d834ebbd6832074871489172b"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2b81cf78ec9f9ad4e2cfca5cf37d7afe537c990b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    host.run(\u0027systemctl restart mailman-openstack\u0027)"},{"line_number":21,"context_line":"    host.run(\u0027systemctl restart mailman-starlingx\u0027)"},{"line_number":22,"context_line":"    host.run(\u0027systemctl restart mailman-zuul\u0027)"},{"line_number":23,"context_line":"    host.run(\u0027sleep 10\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    cmd \u003d host.run(\u0027HOST\u003dlists.airshipit.org list_lists --bare\u0027)"},{"line_number":26,"context_line":"    assert \u0027airship-discuss\u0027 in cmd.stdout"}],"source_content_type":"text/x-python","patch_set":2,"id":"a8dfea0f_b82c3ab6","line":23,"updated":"2021-12-09 19:22:56.000000000","message":"Well, more to the point, the restarts and sleep aren\u0027t strictly necessary for the test itself, just helpful in producing entries in the relevant service logs so we can observe things like admin notification attempts (and rejections) from the earlier newlist invocations. I couldn\u0027t come up with a better place to do this as part of the testing phase in order to avoid applying in production. I guess the proper way would be to do it in a separate test playbook between deployment and testinfra? This was merely a cheap way to be able to double-check that the notifications enabled in the next change weren\u0027t actually going out over the Internet and annoying/confusing the admins of our existing lists.","commit_id":"97604ee994507e1d834ebbd6832074871489172b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"19b5c328b76e29c1bcd04eddff91f06e864ab61a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    host.run(\u0027systemctl restart mailman-openstack\u0027)"},{"line_number":21,"context_line":"    host.run(\u0027systemctl restart mailman-starlingx\u0027)"},{"line_number":22,"context_line":"    host.run(\u0027systemctl restart mailman-zuul\u0027)"},{"line_number":23,"context_line":"    host.run(\u0027sleep 10\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    cmd \u003d host.run(\u0027HOST\u003dlists.airshipit.org list_lists --bare\u0027)"},{"line_number":26,"context_line":"    assert \u0027airship-discuss\u0027 in cmd.stdout"}],"source_content_type":"text/x-python","patch_set":2,"id":"8eb6b925_7ab03021","line":23,"in_reply_to":"83333dd6_94fb251d","updated":"2021-12-09 19:13:20.000000000","message":"Ya I guess most services out there in the wild aren\u0027t actually ready for work once started. In this case the sleep is probably fine and we can reevaluate if the test becomes flaky.","commit_id":"97604ee994507e1d834ebbd6832074871489172b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"476cee1a31a0b630ca3dea4f7263a6a88dc0aecf","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    host.run(\u0027systemctl restart mailman-starlingx\u0027)"},{"line_number":22,"context_line":"    host.run(\u0027systemctl restart mailman-zuul\u0027)"},{"line_number":23,"context_line":"    host.run(\u0027sleep 10\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    cmd \u003d host.run(\u0027HOST\u003dlists.airshipit.org list_lists --bare\u0027)"},{"line_number":26,"context_line":"    assert \u0027airship-discuss\u0027 in cmd.stdout"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2ad13cc6_abc8a3b4","line":24,"updated":"2021-12-13 22:12:01.000000000","message":"i don\u0027t have a strong preference but we\u0027ve usually done stuff like this in a test playbook, rather than testinfra?","commit_id":"083af61c77764c84e6672df8b06884c0ede821a6"}],"zuul.d/system-config-run.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"f2b40bc1f525a09c5f808547303c267b3626db41","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        - playbooks/service-lists.yaml"},{"line_number":263,"context_line":"        # Run this twice to check idempotency"},{"line_number":264,"context_line":"        - playbooks/service-lists.yaml"},{"line_number":265,"context_line":"      run_test_playbook: playbooks/test-lists.yaml"},{"line_number":266,"context_line":"    host-vars:"},{"line_number":267,"context_line":"      lists.katacontainers.io:"},{"line_number":268,"context_line":"        host_copy_output:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fc2be813_9e813b60","line":265,"updated":"2021-12-14 21:29:17.000000000","message":"Oh, I should also add this to the files list above!","commit_id":"aa5641b9824f14620becb02d4c0ea7bad8686beb"}]}