)]}'
{"testinfra/test_bridge.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e51a2f57c7fe4304f6ead8053766a0e7386529df","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        assert not zk.port(2181).is_reachable()"},{"line_number":124,"context_line":"        assert not zk.port(2281).is_reachable()"},{"line_number":125,"context_line":"    # Force a failure to validate addresses above."},{"line_number":126,"context_line":"    assert False"}],"source_content_type":"text/x-python","patch_set":1,"id":"61c6e305_7d517765","line":126,"updated":"2021-12-14 23:54:55.000000000","message":"This will always be reached, right? So the test will always fail?","commit_id":"35cb63f847ccc41139d3af82d402a4a30b4634f1"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7de806774e912e14ef0f8cf4f8afb88662e42d3d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        assert not zk.port(2181).is_reachable()"},{"line_number":124,"context_line":"        assert not zk.port(2281).is_reachable()"},{"line_number":125,"context_line":"    # Force a failure to validate addresses above."},{"line_number":126,"context_line":"    assert False"}],"source_content_type":"text/x-python","patch_set":1,"id":"6eb609ea_7ee45fb2","line":126,"in_reply_to":"61c6e305_7d517765","updated":"2021-12-14 23:58:40.000000000","message":"Yes I want to validate we aren\u0027t talking to the prod IP addresses and the prints only seem to show up if pytest gets a failure. The Next patchset does a bit more validation of this too.","commit_id":"35cb63f847ccc41139d3af82d402a4a30b4634f1"}],"testinfra/test_firewall.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"11a1f88a391be57cc6c927368794eb06fee00ccd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    inv_path \u003d \"/home/zuul/src/opendev.org/opendev/system-config\" \\"},{"line_number":27,"context_line":"               \"/inventory/base/gate-hosts.yaml\""},{"line_number":28,"context_line":"    inv_str \u003d host.file(inv_path).content_string"},{"line_number":29,"context_line":"    if \u0027zk04.opendev.org\u0027 in inv_str:"},{"line_number":30,"context_line":"        # Only run this test if zk04 is in our inventory"},{"line_number":31,"context_line":"        zk \u003d host.addr(\"zk04.opendev.org\")"},{"line_number":32,"context_line":"        # Verify it is using our local /etc/hosts values"}],"source_content_type":"text/x-python","patch_set":4,"id":"7bddca42_73370227","line":29,"updated":"2021-12-15 18:14:19.000000000","message":"If we change the zk server name in the test inventory in the future, we\u0027ll start silently skipping this test, right? Is there a way to guard against it? I guess the problem is that we want to skip if we\u0027re testing some scenario which doesn\u0027t need zk.","commit_id":"9e93180a9adf3ae446ace6e91696587f25bd5f1c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bc0cd751f5a4425866700c97096a2f229789e7ba","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    inv_path \u003d \"/home/zuul/src/opendev.org/opendev/system-config\" \\"},{"line_number":27,"context_line":"               \"/inventory/base/gate-hosts.yaml\""},{"line_number":28,"context_line":"    inv_str \u003d host.file(inv_path).content_string"},{"line_number":29,"context_line":"    if \u0027zk04.opendev.org\u0027 in inv_str:"},{"line_number":30,"context_line":"        # Only run this test if zk04 is in our inventory"},{"line_number":31,"context_line":"        zk \u003d host.addr(\"zk04.opendev.org\")"},{"line_number":32,"context_line":"        # Verify it is using our local /etc/hosts values"}],"source_content_type":"text/x-python","patch_set":4,"id":"67404ab2_d7af80e0","line":29,"updated":"2021-12-15 18:16:27.000000000","message":"Maybe you could look for any zk server in the inventory, so that if the job includes zk servers but there\u0027s no zk04 then this test will fail. Is that sensible?","commit_id":"9e93180a9adf3ae446ace6e91696587f25bd5f1c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4d310f5dbcb5a7f782a7f125d8e654ab63efa398","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    inv_path \u003d \"/home/zuul/src/opendev.org/opendev/system-config\" \\"},{"line_number":27,"context_line":"               \"/inventory/base/gate-hosts.yaml\""},{"line_number":28,"context_line":"    inv_str \u003d host.file(inv_path).content_string"},{"line_number":29,"context_line":"    if \u0027zk04.opendev.org\u0027 in inv_str:"},{"line_number":30,"context_line":"        # Only run this test if zk04 is in our inventory"},{"line_number":31,"context_line":"        zk \u003d host.addr(\"zk04.opendev.org\")"},{"line_number":32,"context_line":"        # Verify it is using our local /etc/hosts values"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f5cb1a9_598afea2","line":29,"in_reply_to":"67404ab2_d7af80e0","updated":"2021-12-15 18:18:26.000000000","message":"That is a good idea. I guess match zk\\.*.opendev.org instead.","commit_id":"9e93180a9adf3ae446ace6e91696587f25bd5f1c"}],"testinfra/test_nodepool.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e51a2f57c7fe4304f6ead8053766a0e7386529df","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import pytest"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"testinfra_hosts \u003d [\u0027nl01.opendev.org\u0027, \u0027nb01.opendev.org\u0027,]"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def test_clouds_yaml(host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"77bc065a_38cc14ab","line":17,"updated":"2021-12-14 23:54:55.000000000","message":"Extra comma for any particular reason?","commit_id":"35cb63f847ccc41139d3af82d402a4a30b4634f1"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7de806774e912e14ef0f8cf4f8afb88662e42d3d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import pytest"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"testinfra_hosts \u003d [\u0027nl01.opendev.org\u0027, \u0027nb01.opendev.org\u0027,]"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def test_clouds_yaml(host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"abb361e4_628165ce","line":17,"in_reply_to":"77bc065a_38cc14ab","updated":"2021-12-14 23:58:40.000000000","message":"I wanted to trigger jobs that include zk04.opendev.org in the inventory and modifying these testinfra files causes that to happen.","commit_id":"35cb63f847ccc41139d3af82d402a4a30b4634f1"}]}