)]}'
{"inventory/service/group_vars/zuul-lb.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ce72e77c3b4ec2404bf73553e2e0d6706d475f76","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      - \u0027:::80\u0027"},{"line_number":5,"context_line":"    servers:"},{"line_number":6,"context_line":"      - name: \u0027zuul02.opendev.org\u0027"},{"line_number":7,"context_line":"        address: \u0027104.130.246.31:80\u0027"},{"line_number":8,"context_line":"  - name: balance_zuul_https"},{"line_number":9,"context_line":"    bind:"},{"line_number":10,"context_line":"      - \u0027:::443\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7d44ca0b_7d5d04c9","line":7,"updated":"2022-02-10 21:19:31.000000000","message":"This is how we do gitea.  I\u0027m assuming the reason is so we can choose to enable/disable servers at will.  This system probably predated inventory being a file (ie, maybe we set this up when we used openstack inventory).  We could make that switch with a hostvar in inventory, now that it\u0027s a file.","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b8d9cecf036c460f8c97221b6719e99f905b4167","unresolved":true,"context_lines":[{"line_number":4,"context_line":"      - \u0027:::80\u0027"},{"line_number":5,"context_line":"    servers:"},{"line_number":6,"context_line":"      - name: \u0027zuul02.opendev.org\u0027"},{"line_number":7,"context_line":"        address: \u0027104.130.246.31:80\u0027"},{"line_number":8,"context_line":"  - name: balance_zuul_https"},{"line_number":9,"context_line":"    bind:"},{"line_number":10,"context_line":"      - \u0027:::443\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f41d0be7_04498b7f","line":7,"updated":"2022-02-10 21:07:04.000000000","message":"would probably work to take this from inventory, so we don\u0027t have to update it?","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"05b96e8b0f94457c58dfee488d3dc70f08876269","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \u0027:::79\u0027"},{"line_number":17,"context_line":"    servers:"},{"line_number":18,"context_line":"      - name: \u0027zuul02.opendev.org\u0027"},{"line_number":19,"context_line":"        address: \u0027104.130.246.31:79\u0027"},{"line_number":20,"context_line":"iptables_extra_public_tcp_ports:"},{"line_number":21,"context_line":"  - 443"},{"line_number":22,"context_line":"  - 80"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"664f0ee4_c158e265","line":19,"updated":"2022-02-10 21:14:28.000000000","message":"At the moment there is no zuul-web running on zuul01, but Apache is listening, making it unsafe to add to balance_zuul_https without a more complex health check. It could be added to balance_zuul_finger now since that port is refusing connections, but may as well add it to both of them at the same time.","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ce72e77c3b4ec2404bf73553e2e0d6706d475f76","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \u0027:::79\u0027"},{"line_number":17,"context_line":"    servers:"},{"line_number":18,"context_line":"      - name: \u0027zuul02.opendev.org\u0027"},{"line_number":19,"context_line":"        address: \u0027104.130.246.31:79\u0027"},{"line_number":20,"context_line":"iptables_extra_public_tcp_ports:"},{"line_number":21,"context_line":"  - 443"},{"line_number":22,"context_line":"  - 80"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d5c5d0c0_63426a82","line":19,"updated":"2022-02-10 21:19:31.000000000","message":"Yes; after it\u0027s running zuul-web.  :)","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b8d9cecf036c460f8c97221b6719e99f905b4167","unresolved":true,"context_lines":[{"line_number":16,"context_line":"      - \u0027:::79\u0027"},{"line_number":17,"context_line":"    servers:"},{"line_number":18,"context_line":"      - name: \u0027zuul02.opendev.org\u0027"},{"line_number":19,"context_line":"        address: \u0027104.130.246.31:79\u0027"},{"line_number":20,"context_line":"iptables_extra_public_tcp_ports:"},{"line_number":21,"context_line":"  - 443"},{"line_number":22,"context_line":"  - 80"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ebdc28de_425af56f","line":19,"updated":"2022-02-10 21:07:04.000000000","message":"presumably adding zuul01 is future work","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"}],"testinfra/test_zuul_lb.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e90e449022634e9348f8a5a7f96af04fa3b9e14f","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    zuul_https \u003d host.socket(\"tcp://0.0.0.0:443\")"},{"line_number":24,"context_line":"    assert zuul_https.is_listening"},{"line_number":25,"context_line":"    zuul_http \u003d host.socket(\"tcp://0.0.0.0:80\")"},{"line_number":26,"context_line":"    assert zuul_http.is_listening"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def test_haproxy_statsd_running(host):"},{"line_number":29,"context_line":"    cmd \u003d host.run(\"docker inspect haproxy-docker_haproxy-statsd_1\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"49e0f6be_fae31ec4","line":26,"updated":"2022-02-10 21:07:27.000000000","message":"Should this check port 79 is listening too? If you really want to check things I think you can do an http request too and see what data you get back since this should be talking to the test zuul02 host.","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ce72e77c3b4ec2404bf73553e2e0d6706d475f76","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    zuul_https \u003d host.socket(\"tcp://0.0.0.0:443\")"},{"line_number":24,"context_line":"    assert zuul_https.is_listening"},{"line_number":25,"context_line":"    zuul_http \u003d host.socket(\"tcp://0.0.0.0:80\")"},{"line_number":26,"context_line":"    assert zuul_http.is_listening"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def test_haproxy_statsd_running(host):"},{"line_number":29,"context_line":"    cmd \u003d host.run(\"docker inspect haproxy-docker_haproxy-statsd_1\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bad07c2_e03a7407","line":26,"updated":"2022-02-10 21:19:31.000000000","message":"Wouldn\u0027t hurt.  If we did an actual http request, we\u0027d probably get an error from the proxy because Zuul won\u0027t be able to fully start.","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"}],"zuul.d/project.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ce72e77c3b4ec2404bf73553e2e0d6706d475f76","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        - infra-prod-service-zuul-lb: \u0026infra-prod-service-zuul-lb"},{"line_number":546,"context_line":"            dependencies:"},{"line_number":547,"context_line":"              - name: infra-prod-letsencrypt"},{"line_number":548,"context_line":"                soft: true"},{"line_number":549,"context_line":"              - name: system-config-promote-image-haproxy-statsd"},{"line_number":550,"context_line":"                soft: true"},{"line_number":551,"context_line":"        - infra-prod-service-zuul-preview: \u0026infra-prod-service-zuul-preview"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"64efae55_a1b8ce0c","line":548,"updated":"2022-02-10 21:19:31.000000000","message":"Copypasta fram gitea-lb -- should we remove it there?","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e90e449022634e9348f8a5a7f96af04fa3b9e14f","unresolved":true,"context_lines":[{"line_number":545,"context_line":"        - infra-prod-service-zuul-lb: \u0026infra-prod-service-zuul-lb"},{"line_number":546,"context_line":"            dependencies:"},{"line_number":547,"context_line":"              - name: infra-prod-letsencrypt"},{"line_number":548,"context_line":"                soft: true"},{"line_number":549,"context_line":"              - name: system-config-promote-image-haproxy-statsd"},{"line_number":550,"context_line":"                soft: true"},{"line_number":551,"context_line":"        - infra-prod-service-zuul-preview: \u0026infra-prod-service-zuul-preview"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f7b605f_3c3f61b2","line":548,"updated":"2022-02-10 21:07:27.000000000","message":"Since this proxy is doing tcp forwarding I don\u0027t think we need to depend on letsencrypt here.","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"}],"zuul.d/system-config-run.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ce72e77c3b4ec2404bf73553e2e0d6706d475f76","unresolved":false,"context_lines":[{"line_number":859,"context_line":"        - name: zuul02.opendev.org"},{"line_number":860,"context_line":"          label: ubuntu-focal"},{"line_number":861,"context_line":"        - name: zuul-lb01.opendev.org"},{"line_number":862,"context_line":"          label: ubuntu-bionic"},{"line_number":863,"context_line":"    required-projects:"},{"line_number":864,"context_line":"      - openstack/project-config"},{"line_number":865,"context_line":"      - opendev/system-config"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"03b192cc_3df8b6db","line":862,"updated":"2022-02-10 21:19:31.000000000","message":"Derp.","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b8d9cecf036c460f8c97221b6719e99f905b4167","unresolved":true,"context_lines":[{"line_number":859,"context_line":"        - name: zuul02.opendev.org"},{"line_number":860,"context_line":"          label: ubuntu-focal"},{"line_number":861,"context_line":"        - name: zuul-lb01.opendev.org"},{"line_number":862,"context_line":"          label: ubuntu-bionic"},{"line_number":863,"context_line":"    required-projects:"},{"line_number":864,"context_line":"      - openstack/project-config"},{"line_number":865,"context_line":"      - opendev/system-config"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ca6c0b34_2e251803","line":862,"range":{"start_line":862,"start_character":17,"end_line":862,"end_character":30},"updated":"2022-02-10 21:07:04.000000000","message":"we should probably start this on focal","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e384d15901ca4bf41f583732304a1dd2d3662fb9","unresolved":false,"context_lines":[{"line_number":905,"context_line":"      - inventory/service/host_vars/zuul02.opendev.org"},{"line_number":906,"context_line":"      - playbooks/roles/zookeeper/"},{"line_number":907,"context_line":"      - playbooks/roles/install-apt-repo"},{"line_number":908,"context_line":"      - playbooks/roles/zuul"},{"line_number":909,"context_line":"      - playbooks/zuul/templates/group_vars/zuul"},{"line_number":910,"context_line":"      - playbooks/zuul/templates/group_vars/zookeeper.yaml"},{"line_number":911,"context_line":"      - playbooks/zuul/templates/group_vars/zuul-lb.yaml.j2"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"50436773_1bc1c0f5","line":908,"updated":"2022-02-10 21:24:19.000000000","message":"Er, technically we don\u0027t need to because of the lack of trailing/ but I\u0027ll make that more clear.","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ce72e77c3b4ec2404bf73553e2e0d6706d475f76","unresolved":false,"context_lines":[{"line_number":905,"context_line":"      - inventory/service/host_vars/zuul02.opendev.org"},{"line_number":906,"context_line":"      - playbooks/roles/zookeeper/"},{"line_number":907,"context_line":"      - playbooks/roles/install-apt-repo"},{"line_number":908,"context_line":"      - playbooks/roles/zuul"},{"line_number":909,"context_line":"      - playbooks/zuul/templates/group_vars/zuul"},{"line_number":910,"context_line":"      - playbooks/zuul/templates/group_vars/zookeeper.yaml"},{"line_number":911,"context_line":"      - playbooks/zuul/templates/group_vars/zuul-lb.yaml.j2"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"748bc04a_cb504dbd","line":908,"updated":"2022-02-10 21:19:31.000000000","message":"Yep.","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b8d9cecf036c460f8c97221b6719e99f905b4167","unresolved":true,"context_lines":[{"line_number":905,"context_line":"      - inventory/service/host_vars/zuul02.opendev.org"},{"line_number":906,"context_line":"      - playbooks/roles/zookeeper/"},{"line_number":907,"context_line":"      - playbooks/roles/install-apt-repo"},{"line_number":908,"context_line":"      - playbooks/roles/zuul"},{"line_number":909,"context_line":"      - playbooks/zuul/templates/group_vars/zuul"},{"line_number":910,"context_line":"      - playbooks/zuul/templates/group_vars/zookeeper.yaml"},{"line_number":911,"context_line":"      - playbooks/zuul/templates/group_vars/zuul-lb.yaml.j2"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6b3fbb5f_8f27ad79","line":908,"updated":"2022-02-10 21:07:04.000000000","message":"add playbooks/roles/zuul-lb here too","commit_id":"c4769fa662652ea2196ee5b71c8c1879d78eb23c"}]}
