)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f33b554_b10b4409","updated":"2022-03-04 01:18:01.000000000","message":"Thanks for the review! ","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"43ac553daadec026446cfa43aa8148692884b248","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"29a8d729_f3497750","updated":"2022-03-10 05:31:16.000000000","message":"i\u0027ll take fungi\u0027s extensive review and clarkb\u0027s prior +2 on this to get it out of the queue","commit_id":"4c86706e5ea47074a4dd166c7eefc6b77699fbbf"}],"doc/source/open-infrastructure.rst":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":6,"context_line":"######################################"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The OpenDev team strives to run the infrastructure behind the OpenDev"},{"line_number":9,"context_line":"project as an open source project; we term this *open infrastructure*."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Our infrastructure is code and contributions to it are handled just"},{"line_number":12,"context_line":"like the rest of OpenDev.  This means that anyone can contribute to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"90eb29cf_ed0e56ca","line":9,"updated":"2022-03-03 22:01:49.000000000","message":"Repetition of overloaded terms \"infrastructure\" and \"project\" make this a little confusing, might be clearer to say \"The OpenDev sysadmins strive to run the services behind the OpenDev Collaboratory as...\"","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"######################################"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The OpenDev team strives to run the infrastructure behind the OpenDev"},{"line_number":9,"context_line":"project as an open source project; we term this *open infrastructure*."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Our infrastructure is code and contributions to it are handled just"},{"line_number":12,"context_line":"like the rest of OpenDev.  This means that anyone can contribute to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a1a3e245_5d0ffa9d","line":9,"in_reply_to":"90eb29cf_ed0e56ca","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":14,"context_line":"access, and anyone who is interested can provide feedback and"},{"line_number":15,"context_line":"collaborate on code reviews.  There are no permissions or special"},{"line_number":16,"context_line":"privileges required to contribute to the OpenDev infrastructure"},{"line_number":17,"context_line":"project."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Below is a short guide to the major pieces of the project.  Some"},{"line_number":20,"context_line":"knowledge of Zuul job configuration, Ansible, interaction with the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"93aedca1_5bc7ed10","line":17,"updated":"2022-03-03 22:01:49.000000000","message":"Or maybe just \"...to contribute to OpenDev.\"","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"access, and anyone who is interested can provide feedback and"},{"line_number":15,"context_line":"collaborate on code reviews.  There are no permissions or special"},{"line_number":16,"context_line":"privileges required to contribute to the OpenDev infrastructure"},{"line_number":17,"context_line":"project."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Below is a short guide to the major pieces of the project.  Some"},{"line_number":20,"context_line":"knowledge of Zuul job configuration, Ansible, interaction with the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bcdb5169_67b9d770","line":17,"in_reply_to":"93aedca1_5bc7ed10","updated":"2022-03-04 01:18:01.000000000","message":"I get that it is a general point that you don\u0027t need permissions to contribute to any of OpenDev, but I think I like this as is because it\u0027s specifically calling out that you can contribute to the services back-end, which I think is very unique.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Getting started - CI"},{"line_number":51,"context_line":"--------------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"The configuration of every system operated by the infrastructure team"},{"line_number":54,"context_line":"is managed by Ansible and driven by continuous integration and"},{"line_number":55,"context_line":"deployment by Zuul.  This is almost exclusively driven by code kept in"},{"line_number":56,"context_line":"the `system-config` repository, which can be browsed at:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"77c717b1_3b9b724f","line":53,"updated":"2022-03-03 22:01:49.000000000","message":"We\u0027ve been terming the infrastructure team \"OpenDev sysadmins\" since the dissolution of the OpenStack Infrastructure project.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Getting started - CI"},{"line_number":51,"context_line":"--------------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"The configuration of every system operated by the infrastructure team"},{"line_number":54,"context_line":"is managed by Ansible and driven by continuous integration and"},{"line_number":55,"context_line":"deployment by Zuul.  This is almost exclusively driven by code kept in"},{"line_number":56,"context_line":"the `system-config` repository, which can be browsed at:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"012ea502_816208a8","line":53,"in_reply_to":"77c717b1_3b9b724f","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":53,"context_line":"The configuration of every system operated by the infrastructure team"},{"line_number":54,"context_line":"is managed by Ansible and driven by continuous integration and"},{"line_number":55,"context_line":"deployment by Zuul.  This is almost exclusively driven by code kept in"},{"line_number":56,"context_line":"the `system-config` repository, which can be browsed at:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  https://opendev.org/opendev/system-config"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b056c937_9bb6bea2","line":56,"updated":"2022-03-03 22:01:49.000000000","message":"There are lots of occurrences of terms surrounded by single backticks, which Sphinx seems to be converting to italics similar to terms surrounded by asterisks, but the former isn\u0027t called out in the Sphinx or reST docs as standard markup.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"The configuration of every system operated by the infrastructure team"},{"line_number":54,"context_line":"is managed by Ansible and driven by continuous integration and"},{"line_number":55,"context_line":"deployment by Zuul.  This is almost exclusively driven by code kept in"},{"line_number":56,"context_line":"the `system-config` repository, which can be browsed at:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  https://opendev.org/opendev/system-config"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a9d2ab09_97512a34","line":56,"in_reply_to":"b056c937_9bb6bea2","updated":"2022-03-04 01:18:01.000000000","message":"hrm, i mean \u003ctt\u003e; i\u0027ll correct this to ``.  I think it\u0027s markdown that renders `code`","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":64,"context_line":"review to this repository at ``review.opendev.org``.  The current open"},{"line_number":65,"context_line":"reviews can be seen at"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  https://review.opendev.org/q/project:opendev%252Fsystem-config"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Zuul will first run CI on all incoming changes.  Each service"},{"line_number":70,"context_line":"generally has its own CI job that runs when relevant files"}],"source_content_type":"text/x-rst","patch_set":1,"id":"904368c6_bffe6154","line":67,"updated":"2022-03-03 22:01:49.000000000","message":"Gerrit will also accept https://review.opendev.org/q/project:opendev/system-config which might be a bit more user-friendly since we\u0027re displaying a raw URL here.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"review to this repository at ``review.opendev.org``.  The current open"},{"line_number":65,"context_line":"reviews can be seen at"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  https://review.opendev.org/q/project:opendev%252Fsystem-config"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Zuul will first run CI on all incoming changes.  Each service"},{"line_number":70,"context_line":"generally has its own CI job that runs when relevant files"}],"source_content_type":"text/x-rst","patch_set":1,"id":"05bb3797_571fac5c","line":67,"in_reply_to":"904368c6_bffe6154","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":78,"context_line":"These jobs are crafted in a way that they replicate production as much"},{"line_number":79,"context_line":"as possible.  Reading the job definitions in in"},{"line_number":80,"context_line":":git_file:`zuul.d/system-config-run.yaml` will give you a feel for the"},{"line_number":81,"context_line":"hosts that are set up with each job.  .When you view the job results"},{"line_number":82,"context_line":"in the Zuul UI, you will see many logs collected from a number of"},{"line_number":83,"context_line":"hosts that simulate the production environment.  This has all the"},{"line_number":84,"context_line":"information you generally need to debug problems, but the best place"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e6593403_6b26ed70","line":81,"updated":"2022-03-03 22:01:49.000000000","message":"Stray \".\" here.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"These jobs are crafted in a way that they replicate production as much"},{"line_number":79,"context_line":"as possible.  Reading the job definitions in in"},{"line_number":80,"context_line":":git_file:`zuul.d/system-config-run.yaml` will give you a feel for the"},{"line_number":81,"context_line":"hosts that are set up with each job.  .When you view the job results"},{"line_number":82,"context_line":"in the Zuul UI, you will see many logs collected from a number of"},{"line_number":83,"context_line":"hosts that simulate the production environment.  This has all the"},{"line_number":84,"context_line":"information you generally need to debug problems, but the best place"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3bbf1df4_9a0db7a7","line":81,"in_reply_to":"e6593403_6b26ed70","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"One of the job artifacts is the `ARA report"},{"line_number":89,"context_line":"\u003chttps://ara.readthedocs.io/en/latest/\u003e`__.  This is a graphical view"},{"line_number":90,"context_line":"of the Ansible run on the (ephemeral) bastion host against the"},{"line_number":91,"context_line":"(ephemeral) production-test nodes.  This is generally the first stop"},{"line_number":92,"context_line":"for finding deployment issues."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ec2d1476_18533507","line":90,"updated":"2022-03-03 22:01:49.000000000","message":"Might be more precise to say \"nested Ansible\" since the Ansible executed by Zuul is not represented there.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"One of the job artifacts is the `ARA report"},{"line_number":89,"context_line":"\u003chttps://ara.readthedocs.io/en/latest/\u003e`__.  This is a graphical view"},{"line_number":90,"context_line":"of the Ansible run on the (ephemeral) bastion host against the"},{"line_number":91,"context_line":"(ephemeral) production-test nodes.  This is generally the first stop"},{"line_number":92,"context_line":"for finding deployment issues."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fd56c882_458be252","line":90,"in_reply_to":"ec2d1476_18533507","updated":"2022-03-04 01:18:01.000000000","message":"done, I made it *nested* Ansible to emphasise it\u0027s difference.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":92,"context_line":"for finding deployment issues."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Another artifact is the `testinfra results`.  `Testinfra"},{"line_number":95,"context_line":"\u003chttps://testfinra.readthedoocs.io\u003e`__ allows us to define unit-test"},{"line_number":96,"context_line":"like behaviour to test functionality such as service and API status,"},{"line_number":97,"context_line":"correct deployment of users and files and other interesting details."},{"line_number":98,"context_line":"Failures here would indicate the the deployment steps worked, but some"}],"source_content_type":"text/x-rst","patch_set":1,"id":"920255a7_8c94bebd","line":95,"updated":"2022-03-03 22:01:49.000000000","message":"unit-test-like","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"for finding deployment issues."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Another artifact is the `testinfra results`.  `Testinfra"},{"line_number":95,"context_line":"\u003chttps://testfinra.readthedoocs.io\u003e`__ allows us to define unit-test"},{"line_number":96,"context_line":"like behaviour to test functionality such as service and API status,"},{"line_number":97,"context_line":"correct deployment of users and files and other interesting details."},{"line_number":98,"context_line":"Failures here would indicate the the deployment steps worked, but some"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fe03e00c_9375ad95","line":95,"in_reply_to":"920255a7_8c94bebd","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":114,"context_line":"-------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The starting point for all services is generally the playbooks and"},{"line_number":117,"context_line":"roles kept in :git_file:`playbooks`.  Most playbooks are named"},{"line_number":118,"context_line":"``service-\u003cname\u003e.yaml`` and will indicate from their naming which"},{"line_number":119,"context_line":"production areas they drive."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"c9bf2d07_b0da84a2","line":117,"updated":"2022-03-03 22:01:49.000000000","message":"Elsewhere you\u0027re including a trailing \"/\" on git_file references to directories. I think I prefer that as it makes it clear we\u0027re referring to a directory rather than a single file.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"-------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The starting point for all services is generally the playbooks and"},{"line_number":117,"context_line":"roles kept in :git_file:`playbooks`.  Most playbooks are named"},{"line_number":118,"context_line":"``service-\u003cname\u003e.yaml`` and will indicate from their naming which"},{"line_number":119,"context_line":"production areas they drive."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5753136d_cfe280f2","line":117,"in_reply_to":"c9bf2d07_b0da84a2","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Public production and testing variables are kept under"},{"line_number":146,"context_line":":git_file:`inventory/`.  The one difference between CI and production"},{"line_number":147,"context_line":"is *secrets*; in production these are provided via the bastion host."},{"line_number":148,"context_line":"In CI, dummy values should be populated into the templates under"},{"line_number":149,"context_line":":git_file:`playbooks/zuul/templates/`."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9c5127de_cf13fd7d","line":147,"updated":"2022-03-03 22:01:49.000000000","message":"Should we choose a different term than \"secrets\" in order to avoid confusion with configured Zuul secrets (which these aren\u0027t)? Maybe \"private data,\" \"sensitive values,\" or something along those lines?","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Public production and testing variables are kept under"},{"line_number":146,"context_line":":git_file:`inventory/`.  The one difference between CI and production"},{"line_number":147,"context_line":"is *secrets*; in production these are provided via the bastion host."},{"line_number":148,"context_line":"In CI, dummy values should be populated into the templates under"},{"line_number":149,"context_line":":git_file:`playbooks/zuul/templates/`."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"87e2daab_8063ae4a","line":147,"in_reply_to":"9c5127de_cf13fd7d","updated":"2022-03-04 01:18:01.000000000","message":"I couldn\u0027t find another term that seemed more logical than *secrets*.  But I reworded the whole thing to make it clearer it\u0027s coming from values stored on the bastion host","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":158,"context_line":"testing and merge the change on your behalf."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Just as uploading a new change triggers Zuul to run CI tests in the"},{"line_number":161,"context_line":"*check* queue, and approving a change triggers Zuul to run gate tests"},{"line_number":162,"context_line":"and merge in the *gate* queue, the merge of a change triggers Zuul to"},{"line_number":163,"context_line":"run the deployment jobs in the *deployment* queue."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"af99e049_31e6c1e0","line":161,"updated":"2022-03-03 22:01:49.000000000","message":"We might want to refer to these as \"pipelines\" rather than \"queues\" for alignment with Zuul\u0027s terminology (which has queues within the pipelines, but the names you\u0027re providing are the pipeline names not the queue names).","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":158,"context_line":"testing and merge the change on your behalf."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Just as uploading a new change triggers Zuul to run CI tests in the"},{"line_number":161,"context_line":"*check* queue, and approving a change triggers Zuul to run gate tests"},{"line_number":162,"context_line":"and merge in the *gate* queue, the merge of a change triggers Zuul to"},{"line_number":163,"context_line":"run the deployment jobs in the *deployment* queue."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ef5e6a55_d8c390ff","line":161,"in_reply_to":"af99e049_31e6c1e0","updated":"2022-03-04 01:18:01.000000000","message":"Good idea, changed.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d8b129209782abd98d94c847208baae9178e9606","unresolved":true,"context_lines":[{"line_number":160,"context_line":"Just as uploading a new change triggers Zuul to run CI tests in the"},{"line_number":161,"context_line":"*check* queue, and approving a change triggers Zuul to run gate tests"},{"line_number":162,"context_line":"and merge in the *gate* queue, the merge of a change triggers Zuul to"},{"line_number":163,"context_line":"run the deployment jobs in the *deployment* queue."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"These jobs are named `infra-prod-\u003cservice\u003e` and run the same playbooks"},{"line_number":166,"context_line":"and roles as in the CI system, except against the production services."}],"source_content_type":"text/x-rst","patch_set":1,"id":"cae510c5_9712b14e","line":163,"range":{"start_line":163,"start_character":32,"end_line":163,"end_character":42},"updated":"2022-02-25 21:55:56.000000000","message":"Nit we call it \"deploy\" in zuul.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"55731ce732b735a4be8f1fda4098ec9d1688fc34","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Just as uploading a new change triggers Zuul to run CI tests in the"},{"line_number":161,"context_line":"*check* queue, and approving a change triggers Zuul to run gate tests"},{"line_number":162,"context_line":"and merge in the *gate* queue, the merge of a change triggers Zuul to"},{"line_number":163,"context_line":"run the deployment jobs in the *deployment* queue."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"These jobs are named `infra-prod-\u003cservice\u003e` and run the same playbooks"},{"line_number":166,"context_line":"and roles as in the CI system, except against the production services."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7552bf1d_21c2f2e8","line":163,"range":{"start_line":163,"start_character":32,"end_line":163,"end_character":42},"in_reply_to":"cae510c5_9712b14e","updated":"2022-03-04 01:18:58.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":165,"context_line":"These jobs are named `infra-prod-\u003cservice\u003e` and run the same playbooks"},{"line_number":166,"context_line":"and roles as in the CI system, except against the production services."},{"line_number":167,"context_line":"Zuul will deploy the merged changes to the bastion host, and then"},{"line_number":168,"context_line":"trigger it to run Ansible."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Since the production run logs may leak secrets, they are not published"},{"line_number":171,"context_line":"openly.  You can add a GPG public key to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a0ba227c_2681152a","line":168,"updated":"2022-03-03 22:01:49.000000000","message":"Wound it make sense to say that it\u0027s triggered \"to run a nested Ansible\" for clarity?","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"These jobs are named `infra-prod-\u003cservice\u003e` and run the same playbooks"},{"line_number":166,"context_line":"and roles as in the CI system, except against the production services."},{"line_number":167,"context_line":"Zuul will deploy the merged changes to the bastion host, and then"},{"line_number":168,"context_line":"trigger it to run Ansible."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Since the production run logs may leak secrets, they are not published"},{"line_number":171,"context_line":"openly.  You can add a GPG public key to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa682212_ea2f8305","line":168,"in_reply_to":"a0ba227c_2681152a","updated":"2022-03-04 01:18:01.000000000","message":"Yes, reworded this.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Zuul will deploy the merged changes to the bastion host, and then"},{"line_number":168,"context_line":"trigger it to run Ansible."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Since the production run logs may leak secrets, they are not published"},{"line_number":171,"context_line":"openly.  You can add a GPG public key to"},{"line_number":172,"context_line":":git_file:`playbooks/zuul/roles/encrypt-logs/defaults/main.yaml` and"},{"line_number":173,"context_line":"then ensure the `infra-prod-\u003cservice\u003e` production has your name in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c49a25c2_009eba45","line":170,"updated":"2022-03-03 22:01:49.000000000","message":"\"leak sensitive information\" (aside from possible confusion with Zuul secrets, they could leak other sensitive information beyond what you referred to as \"secrets\" earlier)","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Zuul will deploy the merged changes to the bastion host, and then"},{"line_number":168,"context_line":"trigger it to run Ansible."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Since the production run logs may leak secrets, they are not published"},{"line_number":171,"context_line":"openly.  You can add a GPG public key to"},{"line_number":172,"context_line":":git_file:`playbooks/zuul/roles/encrypt-logs/defaults/main.yaml` and"},{"line_number":173,"context_line":"then ensure the `infra-prod-\u003cservice\u003e` production has your name in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bbe14590_7a012339","line":170,"in_reply_to":"c49a25c2_009eba45","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":184,"context_line":"that build a bespoke container for this environment."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"The base `Dockerfile` for these containers is found under"},{"line_number":187,"context_line":":git_file:`docker`.  Most are straight forward, but some of the more"},{"line_number":188,"context_line":"complicated services have multiple steps and layers.  Any changes to"},{"line_number":189,"context_line":"the `Dockerfile` will be tested as usual, and when approved the"},{"line_number":190,"context_line":"containers will be rebuilt, published and pulled onto the production"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b7090da9_7c5a9f1c","line":187,"updated":"2022-03-03 22:01:49.000000000","message":"should add a trailing \"/\"","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":184,"context_line":"that build a bespoke container for this environment."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"The base `Dockerfile` for these containers is found under"},{"line_number":187,"context_line":":git_file:`docker`.  Most are straight forward, but some of the more"},{"line_number":188,"context_line":"complicated services have multiple steps and layers.  Any changes to"},{"line_number":189,"context_line":"the `Dockerfile` will be tested as usual, and when approved the"},{"line_number":190,"context_line":"containers will be rebuilt, published and pulled onto the production"}],"source_content_type":"text/x-rst","patch_set":1,"id":"689b18ba_d7443a4d","line":187,"in_reply_to":"b7090da9_7c5a9f1c","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":207,"context_line":"-------"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Any host in the `backup` group will have backups to two redundant"},{"line_number":210,"context_line":"physical locations setup by the deployment infrastructure.  See the"},{"line_number":211,"context_line":"`borg-backup` role for details on including or excluding various data."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"97808d34_2f92c07d","line":210,"updated":"2022-03-03 22:01:49.000000000","message":"Could say \"two geographically distinct locations\" even, which is the most important aspect.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":207,"context_line":"-------"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Any host in the `backup` group will have backups to two redundant"},{"line_number":210,"context_line":"physical locations setup by the deployment infrastructure.  See the"},{"line_number":211,"context_line":"`borg-backup` role for details on including or excluding various data."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bbd558ca_a54cef9b","line":210,"in_reply_to":"97808d34_2f92c07d","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":226,"context_line":"See :ref:`ssh-access` for details on keys."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"Documentation"},{"line_number":231,"context_line":"-------------"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e13a61f8_95a9d5f5","line":229,"updated":"2022-03-03 22:01:49.000000000","message":"It seems like the number of blank lines between sections is entirely random. Sometimes one, sometimes two, in this case we have three?","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":226,"context_line":"See :ref:`ssh-access` for details on keys."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"Documentation"},{"line_number":231,"context_line":"-------------"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dd34a4ff_1bfe6585","line":229,"in_reply_to":"e13a61f8_95a9d5f5","updated":"2022-03-04 01:18:01.000000000","message":"All are now one 😊","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":231,"context_line":"-------------"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Each service should have an RST file with documentation about the"},{"line_number":234,"context_line":"server and services in :git_file:`doc/source`."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"The change description is very important and the major source of"},{"line_number":237,"context_line":"historical information.  It is expected a developer can read the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0a8fd1cc_2ed76c4b","line":234,"updated":"2022-03-03 22:01:49.000000000","message":"Missing a trailing \"/\" here.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"-------------"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Each service should have an RST file with documentation about the"},{"line_number":234,"context_line":"server and services in :git_file:`doc/source`."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"The change description is very important and the major source of"},{"line_number":237,"context_line":"historical information.  It is expected a developer can read the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"39821ace_c94f4dc3","line":234,"in_reply_to":"0a8fd1cc_2ed76c4b","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":240,"context_line":"to understand the deeper history of each change, but each change"},{"line_number":241,"context_line":"should stand-alone once committed.  Only the most trivial of changes"},{"line_number":242,"context_line":"that are completely self-evident (e.g. typo fixes) would be expected"},{"line_number":243,"context_line":"to have less than a few sentences of context in their change log."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Lifecycle"}],"source_content_type":"text/x-rst","patch_set":1,"id":"786d0e6f_7acbfacd","line":243,"updated":"2022-03-03 22:01:49.000000000","message":"While I completely agree with this paragraph, it seems somewhat out of place in the Documentation section. Should we have a separate section about our expectations for commit messages?","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":240,"context_line":"to understand the deeper history of each change, but each change"},{"line_number":241,"context_line":"should stand-alone once committed.  Only the most trivial of changes"},{"line_number":242,"context_line":"that are completely self-evident (e.g. typo fixes) would be expected"},{"line_number":243,"context_line":"to have less than a few sentences of context in their change log."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Lifecycle"}],"source_content_type":"text/x-rst","patch_set":1,"id":"263dd1df_9e023fb1","line":243,"in_reply_to":"786d0e6f_7acbfacd","updated":"2022-03-04 01:18:01.000000000","message":"Added a section, and linked to some of the developer guides for getting setup before this paragraph.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":251,"context_line":"Before starting work to deploy a new service that will require"},{"line_number":252,"context_line":"resources, you should do some preparation work.  Putting an item on"},{"line_number":253,"context_line":"the `weekly team meeting"},{"line_number":254,"context_line":"\u003chttps://wiki.openstack.org/wiki/Meetings/InfraTeamMeeting\u003e`__ agenda"},{"line_number":255,"context_line":"is always welcome.  More complicated changes may justify going through"},{"line_number":256,"context_line":"the spec process; see `\u003chttps://opendev.org/opendev/infra-specs\u003e`__."},{"line_number":257,"context_line":"If the existing admins are aware of the details before reviews start"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8599b029_590cea45","line":254,"updated":"2022-03-03 22:01:49.000000000","message":"Since you named the link \"weekly team meeting\" it may make more sense to link to https://meetings.opendev.org/#OpenDev_Meeting rather than the agenda in the wiki. Otherwise include Agenda in the link name instead. Also you don\u0027t need a double-underscore for this sort of link, a single trailing underscore is typical.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":251,"context_line":"Before starting work to deploy a new service that will require"},{"line_number":252,"context_line":"resources, you should do some preparation work.  Putting an item on"},{"line_number":253,"context_line":"the `weekly team meeting"},{"line_number":254,"context_line":"\u003chttps://wiki.openstack.org/wiki/Meetings/InfraTeamMeeting\u003e`__ agenda"},{"line_number":255,"context_line":"is always welcome.  More complicated changes may justify going through"},{"line_number":256,"context_line":"the spec process; see `\u003chttps://opendev.org/opendev/infra-specs\u003e`__."},{"line_number":257,"context_line":"If the existing admins are aware of the details before reviews start"}],"source_content_type":"text/x-rst","patch_set":1,"id":"93784b51_f71a4376","line":254,"in_reply_to":"8599b029_590cea45","updated":"2022-03-04 01:18:01.000000000","message":"Added links to the meetings.opendev.org section as well, can clarified that\u0027s the agenda.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":258,"context_line":"appearing it makes the process much smoother."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"All preliminary work can be done in an iterative fashion using the CI"},{"line_number":261,"context_line":"jobs at your own pace.  The IRC channels are a good place to find help"},{"line_number":262,"context_line":"during this process.  This change (or changes) will be reviewed and"},{"line_number":263,"context_line":"may take a few rounds before final approval (in gerrit terms, a `+2`"},{"line_number":264,"context_line":"vote).  Most changes will receive a few `-1` votes from reviewers"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3e3c79dd_dd962798","line":261,"updated":"2022-03-03 22:01:49.000000000","message":"Which IRC channels? Might make more sense to specify one, especially since this is the first and only mention of IRC on this page.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"appearing it makes the process much smoother."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"All preliminary work can be done in an iterative fashion using the CI"},{"line_number":261,"context_line":"jobs at your own pace.  The IRC channels are a good place to find help"},{"line_number":262,"context_line":"during this process.  This change (or changes) will be reviewed and"},{"line_number":263,"context_line":"may take a few rounds before final approval (in gerrit terms, a `+2`"},{"line_number":264,"context_line":"vote).  Most changes will receive a few `-1` votes from reviewers"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2f2a5345_9446c7f0","line":261,"in_reply_to":"3e3c79dd_dd962798","updated":"2022-03-04 01:18:01.000000000","message":"Added that.  I also added a sentence with a link to service-discuss as another channel for help","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":260,"context_line":"All preliminary work can be done in an iterative fashion using the CI"},{"line_number":261,"context_line":"jobs at your own pace.  The IRC channels are a good place to find help"},{"line_number":262,"context_line":"during this process.  This change (or changes) will be reviewed and"},{"line_number":263,"context_line":"may take a few rounds before final approval (in gerrit terms, a `+2`"},{"line_number":264,"context_line":"vote).  Most changes will receive a few `-1` votes from reviewers"},{"line_number":265,"context_line":"during development.  This is really just a flag to note that some"},{"line_number":266,"context_line":"further discussion is required; it is not a rejection."}],"source_content_type":"text/x-rst","patch_set":1,"id":"4217cded_3606df12","line":263,"updated":"2022-03-03 22:01:49.000000000","message":"Gerrit is a proper noun, so should be capitalized as you\u0027ve done elsewhere in the document.","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":260,"context_line":"All preliminary work can be done in an iterative fashion using the CI"},{"line_number":261,"context_line":"jobs at your own pace.  The IRC channels are a good place to find help"},{"line_number":262,"context_line":"during this process.  This change (or changes) will be reviewed and"},{"line_number":263,"context_line":"may take a few rounds before final approval (in gerrit terms, a `+2`"},{"line_number":264,"context_line":"vote).  Most changes will receive a few `-1` votes from reviewers"},{"line_number":265,"context_line":"during development.  This is really just a flag to note that some"},{"line_number":266,"context_line":"further discussion is required; it is not a rejection."}],"source_content_type":"text/x-rst","patch_set":1,"id":"503a2b83_12a9191c","line":263,"in_reply_to":"4217cded_3606df12","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"72493708de4ae4cc0860fde38694452aac064458","unresolved":false,"context_lines":[{"line_number":268,"context_line":"You can use the WIP flag provided by Gerrit on changes you are working"},{"line_number":269,"context_line":"on, or some developers like to put `[WIP]` at the front of their"},{"line_number":270,"context_line":"change to indicate to reviewers they probably shouldn\u0027t spend much"},{"line_number":271,"context_line":"time on this yet, as you are still working on it.  Small, stand-alone"},{"line_number":272,"context_line":"sequential changes are encouraged, and Zuul makes testing such"},{"line_number":273,"context_line":"\"stacks\" of changes trivial."},{"line_number":274,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"18b6c691_9a6a9d7f","line":271,"updated":"2022-03-03 22:01:49.000000000","message":"Should we also mention Workflow -1 here?","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"483eab44742ffdedac5fb199e5fd29033d97a93d","unresolved":false,"context_lines":[{"line_number":268,"context_line":"You can use the WIP flag provided by Gerrit on changes you are working"},{"line_number":269,"context_line":"on, or some developers like to put `[WIP]` at the front of their"},{"line_number":270,"context_line":"change to indicate to reviewers they probably shouldn\u0027t spend much"},{"line_number":271,"context_line":"time on this yet, as you are still working on it.  Small, stand-alone"},{"line_number":272,"context_line":"sequential changes are encouraged, and Zuul makes testing such"},{"line_number":273,"context_line":"\"stacks\" of changes trivial."},{"line_number":274,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e98f0cd0_0f19135c","line":271,"in_reply_to":"18b6c691_9a6a9d7f","updated":"2022-03-04 01:18:01.000000000","message":"Done","commit_id":"d7e3f074be632f7c505aa61928a4fba8caf5cc10"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3e00b1ed0b451e344ade9da084e890fac159565f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"useful overviews."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"One of the job artifacts is the `ARA report"},{"line_number":89,"context_line":"\u003chttps://ara.readthedocs.io/en/latest/\u003e`__.  This is a graphical view"},{"line_number":90,"context_line":"of the *nested* Ansible run on the (ephemeral) bastion host against"},{"line_number":91,"context_line":"the (ephemeral) production-test nodes.  This is generally the first"},{"line_number":92,"context_line":"stop for finding deployment issues."}],"source_content_type":"text/x-rst","patch_set":3,"id":"cb808d02_fad16872","line":89,"updated":"2022-03-04 13:13:31.000000000","message":"Nit: Trailing underscores for named links like this one don\u0027t need to be doubled, a single underscore there is sufficient and more typical (but it still renders fine either way).","commit_id":"4c86706e5ea47074a4dd166c7eefc6b77699fbbf"}]}