)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99611e2a_883d2760","updated":"2022-03-02 16:53:06.000000000","message":"I\u0027ve left inline","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1d70275747994863ba245b4377fe9561821c9018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b646bcd2_1787aca8","updated":"2022-03-02 22:59:28.000000000","message":"In addition to the inline comment I\u0027ve just noticed that the way we do ssl certs for this service needs a small update too. https://opendev.org/opendev/system-config/src/branch/master/playbooks/roles/letsencrypt-create-certs/handlers/restart_zuul_registry.yaml this file should be updated to use the new uid:gid instead of root:root for the file ownership. I think it will work as is since we set them to 0644 which is readable by the new user, but updating ownership seems more complete.","commit_id":"228cd23bda46728231ced1f7c5d7ed531ce66820"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a4b7c4477da180e5d67398b5c4dc16142b74136e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a9f13c43_821892b1","updated":"2022-03-03 20:50:26.000000000","message":"Not approving as I\u0027ve ended up getting distracted by a numebr of other items today. Hope to be able to +A tomorrow morning. Or someone else can +A it if they are able to watch it.","commit_id":"ded27cbb5da19a929e1fb60a7e8061158aec449d"}],"inventory/service/group_vars/registry.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"registry_user: zuul"},{"line_number":2,"context_line":"iptables_extra_public_tcp_ports:"},{"line_number":3,"context_line":"  - 5000"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e7d2d6db_bd75dc2c","side":"PARENT","line":1,"updated":"2022-03-02 16:53:06.000000000","message":"We need to keep this value as it is used by the docker registry configuration.","commit_id":"bb93b17c05fd414348f78237f6ba042efb79425d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"registry_user: zuul"},{"line_number":2,"context_line":"iptables_extra_public_tcp_ports:"},{"line_number":3,"context_line":"  - 5000"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"725b52c3_84a0f44f","side":"PARENT","line":1,"in_reply_to":"e7d2d6db_bd75dc2c","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"bb93b17c05fd414348f78237f6ba042efb79425d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Note: creating separate user/userid, group/groupid from the zuul service user"},{"line_number":2,"context_line":"registry_service_user: registry"},{"line_number":3,"context_line":"registry_service_group: registry  "},{"line_number":4,"context_line":"registry_service_user_id: 10001"},{"line_number":5,"context_line":"registry_service_group_id: 10001"},{"line_number":6,"context_line":"iptables_extra_public_tcp_ports:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"258de8f5_65cb1a0e","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":34},"updated":"2022-03-02 16:53:06.000000000","message":"We don\u0027t really use these variables in tasks/main.yaml and instead hardcode the values. As noted in tasks/main.yaml we should use these variables if we define them here.\n\nAn alternative would be to drop these two variables entirely and simply hardcode the values in tasks/main.yaml as you\u0027ve already done.","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Note: creating separate user/userid, group/groupid from the zuul service user"},{"line_number":2,"context_line":"registry_service_user: registry"},{"line_number":3,"context_line":"registry_service_group: registry  "},{"line_number":4,"context_line":"registry_service_user_id: 10001"},{"line_number":5,"context_line":"registry_service_group_id: 10001"},{"line_number":6,"context_line":"iptables_extra_public_tcp_ports:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e4d0f3ba_467ac0ad","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":34},"in_reply_to":"258de8f5_65cb1a0e","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"}],"playbooks/roles/letsencrypt-create-certs/handlers/restart_zuul_registry.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"98bc09ae22221e16349b0142c7e12feb7b014c7c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    state: directory"},{"line_number":4,"context_line":"    path: \"/var/registry/certs\""},{"line_number":5,"context_line":"    owner: registry"},{"line_number":6,"context_line":"    group: registry"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Put key in place"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e16bee0b_2277faf6","line":5,"updated":"2022-03-03 02:20:33.000000000","message":"Looks like it\u0027s having trouble finding this user: https://zuul.opendev.org/t/openstack/build/a1330fefe536431881bae58705376e3e/log/insecure-ci-registry01.opendev.org/docker/registry-docker_registry_1.txt#4-35","commit_id":"e9c6062c6c06b6a897fbc67104dcb186d82295c7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8d0198317013744a5e4cf6ec03c050fc02a7f3b8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    state: directory"},{"line_number":4,"context_line":"    path: \"/var/registry/certs\""},{"line_number":5,"context_line":"    owner: registry"},{"line_number":6,"context_line":"    group: registry"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Put key in place"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"51fbfd6d_e4479726","line":5,"in_reply_to":"e16bee0b_2277faf6","updated":"2022-03-03 16:18:29.000000000","message":"Ya I think testing has caught that my previous suggestion to chown these from root:root is flawed because we issue certs before we set up the service and its user. In that case I think the old code with perms set permissively as they were is sufficient. Sorry about that bad advice there. I think we can just switch this file back to the way it was.","commit_id":"e9c6062c6c06b6a897fbc67104dcb186d82295c7"}],"playbooks/roles/registry/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Create registry_service group"},{"line_number":2,"context_line":"  group:"},{"line_number":3,"context_line":"    name: \"registry\""},{"line_number":4,"context_line":"    gid: \"{{ rregistry_service_group_id }}\""},{"line_number":5,"context_line":"    system: yes"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"616f8273_0ced33ec","line":3,"range":{"start_line":3,"start_character":11,"end_line":3,"end_character":19},"updated":"2022-03-02 16:53:06.000000000","message":"This should be {{ registry_service_group }} to use the var that is defined.","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Create registry_service group"},{"line_number":2,"context_line":"  group:"},{"line_number":3,"context_line":"    name: \"registry\""},{"line_number":4,"context_line":"    gid: \"{{ rregistry_service_group_id }}\""},{"line_number":5,"context_line":"    system: yes"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d5648fb0_d0aa4d75","line":3,"range":{"start_line":3,"start_character":11,"end_line":3,"end_character":19},"in_reply_to":"616f8273_0ced33ec","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"192e709744ce30d3676c47e1db82111a4d7b34b0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Create registry_service group"},{"line_number":2,"context_line":"  group:"},{"line_number":3,"context_line":"    name: \"registry\""},{"line_number":4,"context_line":"    gid: \"{{ rregistry_service_group_id }}\""},{"line_number":5,"context_line":"    system: yes"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create registry_service user"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e57d12d3_31296bc3","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":43},"updated":"2022-03-02 02:19:47.000000000","message":"This looks like a typo -- but perhaps the more important question is why didn\u0027t this fail CI?  Am I missing something?","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Create registry_service group"},{"line_number":2,"context_line":"  group:"},{"line_number":3,"context_line":"    name: \"registry\""},{"line_number":4,"context_line":"    gid: \"{{ rregistry_service_group_id }}\""},{"line_number":5,"context_line":"    system: yes"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create registry_service user"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"25ae82db_e585139a","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":43},"in_reply_to":"8716802b_b330a0aa","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6c156ec3a944e61d0b549a5acd100b9c3fe4a124","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Create registry_service group"},{"line_number":2,"context_line":"  group:"},{"line_number":3,"context_line":"    name: \"registry\""},{"line_number":4,"context_line":"    gid: \"{{ rregistry_service_group_id }}\""},{"line_number":5,"context_line":"    system: yes"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create registry_service user"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8716802b_b330a0aa","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":43},"in_reply_to":"e57d12d3_31296bc3","updated":"2022-03-02 02:50:25.000000000","message":"This is detected, but I broke the error reporting recently 😐\n\nhttps://review.opendev.org/c/opendev/system-config/+/831465","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create registry_service user"},{"line_number":8,"context_line":"  user:"},{"line_number":9,"context_line":"    name: \"registry\""},{"line_number":10,"context_line":"    group: \"registry\""},{"line_number":11,"context_line":"    uid: \"{{ registry_service_user_id }}\""},{"line_number":12,"context_line":"    home: \"/var/registry\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2f564bef_f3c77087","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":19},"updated":"2022-03-02 16:53:06.000000000","message":"This should be {{ registry_service_user }} to use the var that is defined.","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create registry_service user"},{"line_number":8,"context_line":"  user:"},{"line_number":9,"context_line":"    name: \"registry\""},{"line_number":10,"context_line":"    group: \"registry\""},{"line_number":11,"context_line":"    uid: \"{{ registry_service_user_id }}\""},{"line_number":12,"context_line":"    home: \"/var/registry\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d4aa0cfb_df270d63","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":19},"in_reply_to":"2f564bef_f3c77087","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"- name: Create registry_service user"},{"line_number":8,"context_line":"  user:"},{"line_number":9,"context_line":"    name: \"registry\""},{"line_number":10,"context_line":"    group: \"registry\""},{"line_number":11,"context_line":"    uid: \"{{ registry_service_user_id }}\""},{"line_number":12,"context_line":"    home: \"/var/registry\""},{"line_number":13,"context_line":"    system: yes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a900d1f4_0696c56d","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":20},"updated":"2022-03-02 16:53:06.000000000","message":"This should be {{ registry_service_group }} to use the var that is defined.","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"- name: Create registry_service user"},{"line_number":8,"context_line":"  user:"},{"line_number":9,"context_line":"    name: \"registry\""},{"line_number":10,"context_line":"    group: \"registry\""},{"line_number":11,"context_line":"    uid: \"{{ registry_service_user_id }}\""},{"line_number":12,"context_line":"    home: \"/var/registry\""},{"line_number":13,"context_line":"    system: yes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5eb91764_1295af8a","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":20},"in_reply_to":"a900d1f4_0696c56d","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    src: registry-docker/"},{"line_number":18,"context_line":"    dest: /etc/registry-docker/"},{"line_number":19,"context_line":"    owner: registry"},{"line_number":20,"context_line":"    group: registry"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Ensure registry volume directories exists"},{"line_number":23,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2da2a798_b820a9e4","line":20,"updated":"2022-03-02 16:53:06.000000000","message":"See above comments about using the variables instead of hard coded names.","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    src: registry-docker/"},{"line_number":18,"context_line":"    dest: /etc/registry-docker/"},{"line_number":19,"context_line":"    owner: registry"},{"line_number":20,"context_line":"    group: registry"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Ensure registry volume directories exists"},{"line_number":23,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"61208e48_b62e1611","line":20,"in_reply_to":"2da2a798_b820a9e4","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    state: directory"},{"line_number":25,"context_line":"    path: \"/var/registry/{{ item }}\""},{"line_number":26,"context_line":"    owner: registry"},{"line_number":27,"context_line":"    group: registry"},{"line_number":28,"context_line":"  loop:"},{"line_number":29,"context_line":"    - certs"},{"line_number":30,"context_line":"    - conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"771c7caa_d7612ebc","line":27,"updated":"2022-03-02 16:53:06.000000000","message":"See above comments about using the variables instead of hard coded names.","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    state: directory"},{"line_number":25,"context_line":"    path: \"/var/registry/{{ item }}\""},{"line_number":26,"context_line":"    owner: registry"},{"line_number":27,"context_line":"    group: registry"},{"line_number":28,"context_line":"  loop:"},{"line_number":29,"context_line":"    - certs"},{"line_number":30,"context_line":"    - conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"276759e8_903d3f3e","line":27,"in_reply_to":"771c7caa_d7612ebc","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    state: directory"},{"line_number":36,"context_line":"    path: /var/registry/"},{"line_number":37,"context_line":"    owner: registry"},{"line_number":38,"context_line":"    group: registry"},{"line_number":39,"context_line":"    mode: 0755"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Write clouds.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"edb39e0f_0aab95c6","line":38,"updated":"2022-03-02 16:53:06.000000000","message":"See above comments about using the variables instead of hard coded names.","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    state: directory"},{"line_number":36,"context_line":"    path: /var/registry/"},{"line_number":37,"context_line":"    owner: registry"},{"line_number":38,"context_line":"    group: registry"},{"line_number":39,"context_line":"    mode: 0755"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Write clouds.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fcbae865_62588fd5","line":38,"in_reply_to":"edb39e0f_0aab95c6","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    src: clouds.yaml.j2"},{"line_number":44,"context_line":"    dest: /var/registry/etc/clouds.yaml"},{"line_number":45,"context_line":"    owner: registry"},{"line_number":46,"context_line":"    group: registry"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Write registry config"},{"line_number":49,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"234e690b_e62b94d0","line":46,"updated":"2022-03-02 16:53:06.000000000","message":"See above comments about using the variables instead of hard coded names.","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    src: clouds.yaml.j2"},{"line_number":44,"context_line":"    dest: /var/registry/etc/clouds.yaml"},{"line_number":45,"context_line":"    owner: registry"},{"line_number":46,"context_line":"    group: registry"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Write registry config"},{"line_number":49,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"79ed3b5a_90a7a646","line":46,"in_reply_to":"234e690b_e62b94d0","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"124068dd1effc1094fe901468f6d35d20d5c681c","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    src: registry.yaml.j2"},{"line_number":51,"context_line":"    dest: /var/registry/conf/registry.yaml"},{"line_number":52,"context_line":"    owner: registry"},{"line_number":53,"context_line":"    group: registry"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Run docker-compose pull"},{"line_number":56,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f9b7acc9_292f5816","line":53,"updated":"2022-03-02 16:53:06.000000000","message":"See above comments about using the variables instead of hard coded names.","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    src: registry.yaml.j2"},{"line_number":51,"context_line":"    dest: /var/registry/conf/registry.yaml"},{"line_number":52,"context_line":"    owner: registry"},{"line_number":53,"context_line":"    group: registry"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Run docker-compose pull"},{"line_number":56,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cea62809_3142db50","line":53,"in_reply_to":"f9b7acc9_292f5816","updated":"2022-03-02 20:14:57.000000000","message":"Done","commit_id":"6dae3ca615dd164c67b9d2d6b7d8bbf6be4be104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"373ec3a32e5e2511f9d36fcf3777f5e5ec9f5abe","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  synchronize:"},{"line_number":17,"context_line":"    src: registry-docker/"},{"line_number":18,"context_line":"    dest: /etc/registry-docker/"},{"line_number":19,"context_line":"    owner: registry"},{"line_number":20,"context_line":"    group: registry"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Ensure registry volume directories exists"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"425fdc5f_70c11a4a","line":19,"updated":"2022-03-02 20:14:57.000000000","message":"I think the current failure is due to trying to use owner on the synchronize module. It works for file and template but not synchronize in the same way. With synchronize it is meant to be a boolean that determines if we should preserve the owner from the host side. In this case I think we should just drop owner and group and keep the old behavior. The docker-compose file will end up owned by root which is ok since it is system configuration.","commit_id":"b42409c53de881233ade6ccc9bd661b767a0e6ab"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"91cd02870cc580745f3308960704251f7921c9b4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  synchronize:"},{"line_number":17,"context_line":"    src: registry-docker/"},{"line_number":18,"context_line":"    dest: /etc/registry-docker/"},{"line_number":19,"context_line":"    owner: registry"},{"line_number":20,"context_line":"    group: registry"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Ensure registry volume directories exists"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f79d83c8_578eb1db","line":19,"in_reply_to":"425fdc5f_70c11a4a","updated":"2022-03-02 22:11:57.000000000","message":"Done","commit_id":"b42409c53de881233ade6ccc9bd661b767a0e6ab"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"91cd02870cc580745f3308960704251f7921c9b4","unresolved":true,"context_lines":[{"line_number":15,"context_line":"- name: Synchronize docker-compose directory"},{"line_number":16,"context_line":"  synchronize:"},{"line_number":17,"context_line":"    src: registry-docker/"},{"line_number":18,"context_line":"    dest: /etc/registry-docker/"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Ensure registry volume directories exists"},{"line_number":21,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d67ef8c5_10f572ae","line":18,"updated":"2022-03-02 22:11:57.000000000","message":"The previous failure should\u0027ve been a hint that I would catch. This is failing now because we\u0027re writing out the docker-compose.yaml file as if it were a template with variables to substitute but the synchronize module doesn\u0027t expand templates.\n\nInstead we should replace this block with a template block. Something like:\n\n  - name: Make docker-compose dir\n    file:\n      state: directory\n      path: /etc/registry-docker\n      owner: root\n      group: root\n      mode: 0755     \n  - name: Write docker-compose.yaml\n    template:\n      src: docker-compose.yaml.j2\n      dest: /etc/registry-docker/docker-compose.yaml\n      owner: root\n      group: root\n      mode: 644\n\nThen also move the docker-compose file from roles/registry/files/registry-docker/docker-compose.yaml to roles/registry/templates/docker-compose.yaml.j2.","commit_id":"1220a010c968ca418c1e3c5e978c7cb040bd1e5e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1d70275747994863ba245b4377fe9561821c9018","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    path: /var/registry/"},{"line_number":46,"context_line":"    owner: registry"},{"line_number":47,"context_line":"    group: registry"},{"line_number":48,"context_line":"    mode: 0755"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Write clouds.yaml"},{"line_number":51,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7cb87d8b_862b2c30","line":48,"updated":"2022-03-02 22:59:28.000000000","message":"This task should go above the previous task since the previous task creates subdirs of this directory. Sorry for not noticing earlier.","commit_id":"228cd23bda46728231ced1f7c5d7ed531ce66820"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"b66f9171ddb1eeeeb868aa1550a7a2d815587b8e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    gid: \"{{ registry_service_group_id }}\""},{"line_number":5,"context_line":"    system: yes"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create registry_service user"},{"line_number":8,"context_line":"  user:"},{"line_number":9,"context_line":"    name: \"registry\""},{"line_number":10,"context_line":"    group: \"registry\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"aafa4638_de0c2898","line":7,"updated":"2022-03-03 02:23:11.000000000","message":"I think these tasks are running too late to create the user and group before the Let\u0027s Encrypt tasks want them to exist.","commit_id":"e9c6062c6c06b6a897fbc67104dcb186d82295c7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"b66f9171ddb1eeeeb868aa1550a7a2d815587b8e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    path: /etc/registry-docker"},{"line_number":19,"context_line":"    owner: root"},{"line_number":20,"context_line":"    group: root"},{"line_number":21,"context_line":"    mode: 0755     "},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Write docker-compose.yaml"},{"line_number":24,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7256e190_a1257a65","line":21,"updated":"2022-03-03 02:23:11.000000000","message":"Tip: If you configure your editor to highlight trailing whitespace, you can clean it up as you go.","commit_id":"e9c6062c6c06b6a897fbc67104dcb186d82295c7"}]}