)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"febe15cd4c1609c25d246807aafd7d16b601df2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6825a0ff_f25ca864","updated":"2022-03-17 20:46:43.000000000","message":"recheck","commit_id":"8de5634e8ae2d498ae98a0b1917466935674452d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a6aa7aa39d8b2c5b6a36cc29b919400206ab98eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"280906c1_9caba209","updated":"2022-03-18 00:08:27.000000000","message":"+2 but this is probably a good one to ensure others are comfortable with it since we\u0027re doing a bit of a hack due to the lack of an api for this.","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c70a8b75f816e501cc1f47022460d14ba0cefe04","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"10601396_fdab176c","updated":"2022-03-18 03:46:58.000000000","message":"\u003e One thing we may want to be careful of is implying that the license for this Git repo also applies to the images added here. Especially as we start letting other organizations supply logos too.\n\nWhat would you propose we do?\n\nWe already have things like [1] committed and I don\u0027t think that file being in an open-source licensed project means anything at all ... if you did anything with it the trademark owner didn\u0027t like, the fact you claim the bytes of the logo were given to you from an open source project would have no relevance to you infringing trademarks?\n\n[1] https://opendev.org/openinfra/openstackweb/src/branch/master/themes/openstack/images/customer-disney.png","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"72a8e5f9e12be96564e9328cfcaeef33bbe146b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"87c65329_c33240a1","updated":"2022-03-18 15:40:17.000000000","message":"\u003e Patch Set 14:\n\u003e \n\u003e I\u0027m actually not all that concerned about trademarks in this case ...\n\nI think it\u0027s a bit of a shame to hold this up over what I see as clear fair-use (putting your logo as an identifier for your code).  I personally would appreciate it if you would contact the appropriate legal people to satisfy the concerns.\n\nIf you\u0027re otherwise happy with the mechanism of the change, in the mean time, I think it might be good if you could upload a version of this with only a blank or copyright free place-holder default.png (I\u0027m not in a position to do so for a bit).  This will at least remove the broken images we currently serve.\n","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f46a8a8bcec7b9277388d9e7fefe6a373830fac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"cbcebd16_db7451d8","in_reply_to":"10601396_fdab176c","updated":"2022-03-18 12:32:24.000000000","message":"Asking the involved orgs for explicit consent might be good, like you already did with mnaser. For future changes I\u0027d expect the logo owner to submit them and thus implicitly authorize the logo use.","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"}],"playbooks/roles/gitea-set-org-logos/README.rst":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"88b976eb959fd172c9f722b2eb03797ca45de748","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Set custom logos for organisations in gitea"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Note that logos should be a PNG file.  We\u0027ve standardised on a 400x400"},{"line_number":4,"context_line":"to keep it simple."}],"source_content_type":"text/x-rst","patch_set":13,"id":"fca1ff5f_2c77ab67","line":4,"updated":"2022-03-17 23:49:44.000000000","message":"Should we link to the gitea limitations here? In particular a file size limit of 1MB appears to be in place: https://docs.gitea.io/en-us/config-cheat-sheet/#picture-picture","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e9b341a7a034828567cddd59e275fd4fc153910a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Set custom logos for organisations in gitea"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Note that logos should be a PNG file.  We\u0027ve standardised on a 400x400"},{"line_number":4,"context_line":"to keep it simple."}],"source_content_type":"text/x-rst","patch_set":13,"id":"ee413e1c_8de3fb46","line":4,"in_reply_to":"fca1ff5f_2c77ab67","updated":"2022-03-18 00:03:20.000000000","message":"I guess we should probably reject anything over about 50k in review 😊.  added link","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f46a8a8bcec7b9277388d9e7fefe6a373830fac","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Set custom logos for organisations in gitea"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Note that logos should be a PNG file.  We\u0027ve standardised on a 400x400"},{"line_number":4,"context_line":"to keep it simple."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Images should respect the limits set by gitea; see"}],"source_content_type":"text/x-rst","patch_set":14,"id":"604a76f4_2b2cc661","line":3,"updated":"2022-03-18 12:32:24.000000000","message":"Where does the 400 come from? Is the logo shown anywhere in anything near that size? I would suggest something smaller to avoid overhead and having to scale down too much, maybe 100x100 at most?","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"72a8e5f9e12be96564e9328cfcaeef33bbe146b8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Set custom logos for organisations in gitea"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Note that logos should be a PNG file.  We\u0027ve standardised on a 400x400"},{"line_number":4,"context_line":"to keep it simple."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Images should respect the limits set by gitea; see"}],"source_content_type":"text/x-rst","patch_set":14,"id":"c9e36b22_2dc4734b","line":3,"in_reply_to":"604a76f4_2b2cc661","updated":"2022-03-18 15:40:17.000000000","message":"there was some method to the madness, I read somewhere about the generated icons not scaling well on very high dpi screens.  400 seemed big enough but not too big.  SVG would be better of course, but issues with that are noted.","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"}],"playbooks/roles/gitea-set-org-logos/files/default.png":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"88b976eb959fd172c9f722b2eb03797ca45de748","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bb62ce57_8b62d3ec","updated":"2022-03-17 23:49:44.000000000","message":"Maybe the default should be something other than opendev\u0027s logo?","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f46a8a8bcec7b9277388d9e7fefe6a373830fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"208ce1c9_31351d23","in_reply_to":"5f96e6e4_dad7e6cc","updated":"2022-03-18 12:32:24.000000000","message":"Ack","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a6aa7aa39d8b2c5b6a36cc29b919400206ab98eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5f96e6e4_dad7e6cc","in_reply_to":"9712acdc_6e59830e","updated":"2022-03-18 00:08:27.000000000","message":"Thats a good point. The opendev branding is there either way so probably not a big deal.","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e9b341a7a034828567cddd59e275fd4fc153910a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9712acdc_6e59830e","in_reply_to":"bb62ce57_8b62d3ec","updated":"2022-03-18 00:03:20.000000000","message":"I\u0027m not hugely fussed; I figured it matches the favicon just as a placeholder?","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"}],"playbooks/roles/gitea-set-org-logos/files/openstack.png":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f46a8a8bcec7b9277388d9e7fefe6a373830fac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7d2c0d2d_41ecee6d","updated":"2022-03-18 12:32:24.000000000","message":"Is that (r) really needed? Scaled to typical avatar logo size it just looks like dirt.","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"72a8e5f9e12be96564e9328cfcaeef33bbe146b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"64e2bf9f_94982b09","in_reply_to":"7d2c0d2d_41ecee6d","updated":"2022-03-18 15:40:17.000000000","message":"probably not, I just grabbed it from the official logo page though","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"}],"playbooks/roles/gitea-set-org-logos/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"88b976eb959fd172c9f722b2eb03797ca45de748","unresolved":true,"context_lines":[{"line_number":45,"context_line":"      \"USE gitea; UPDATE user SET avatar \u003d \u0027\\\u0027\u0027{{ item }}\u0027\\\u0027\u0027, use_custom_avatar \u003d 1 WHERE name \u003d \u0027\\\u0027\u0027{{ item }}\u0027\\\u0027\u0027\"\u0027"},{"line_number":46,"context_line":"  args:"},{"line_number":47,"context_line":"    executable: \u0027/bin/bash\u0027"},{"line_number":48,"context_line":"  loop: \u0027{{ _changed_logos }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"b958c503_ed0355c7","line":48,"updated":"2022-03-17 23:49:44.000000000","message":"Does this need a no_log: True to avoid disclosing the db password in logs?\n\nAlso any idea how this will fail if there isn\u0027t already an entry for the org? I guess it will just fail to update and maybe not update orgs after the failed one? That is probably fine and it shouldn\u0027t be an issue since we create orgs first.","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e9b341a7a034828567cddd59e275fd4fc153910a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      \"USE gitea; UPDATE user SET avatar \u003d \u0027\\\u0027\u0027{{ item }}\u0027\\\u0027\u0027, use_custom_avatar \u003d 1 WHERE name \u003d \u0027\\\u0027\u0027{{ item }}\u0027\\\u0027\u0027\"\u0027"},{"line_number":46,"context_line":"  args:"},{"line_number":47,"context_line":"    executable: \u0027/bin/bash\u0027"},{"line_number":48,"context_line":"  loop: \u0027{{ _changed_logos }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"d5cd2d04_daa7fe47","line":48,"in_reply_to":"b958c503_ed0355c7","updated":"2022-03-18 00:03:20.000000000","message":"The password won\u0027t come out in logs, it\u0027s just referenced from the docker env var\n\nSince we\u0027ve just queried the api for the list of orgs, I don\u0027t think this can fail as it must be there to return in that list.","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"}],"testinfra/test_gitea.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"88b976eb959fd172c9f722b2eb03797ca45de748","unresolved":true,"context_lines":[{"line_number":97,"context_line":"            (\u0027https://localhost:3081/opendev/\u0027, None,"},{"line_number":98,"context_line":"             \u0027gitea-org-opendev.png\u0027),"},{"line_number":99,"context_line":"            (\u0027https://localhost:3081/zuul/\u0027, None,"},{"line_number":100,"context_line":"             \u0027gitea-org-zuul.png\u0027),"},{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        take_screenshots(host, shots)"}],"source_content_type":"text/x-python","patch_set":13,"id":"00a5ac77_a2aeb392","line":100,"updated":"2022-03-17 23:49:44.000000000","message":"A screenshot of /explore/organizations would give us good coverage of this too.","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e9b341a7a034828567cddd59e275fd4fc153910a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            (\u0027https://localhost:3081/opendev/\u0027, None,"},{"line_number":98,"context_line":"             \u0027gitea-org-opendev.png\u0027),"},{"line_number":99,"context_line":"            (\u0027https://localhost:3081/zuul/\u0027, None,"},{"line_number":100,"context_line":"             \u0027gitea-org-zuul.png\u0027),"},{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        take_screenshots(host, shots)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5329846a_ae75face","line":100,"in_reply_to":"00a5ac77_a2aeb392","updated":"2022-03-18 00:03:20.000000000","message":"Done","commit_id":"7f9124490ac81d07b432ad30ee37def95853df68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f46a8a8bcec7b9277388d9e7fefe6a373830fac","unresolved":true,"context_lines":[{"line_number":97,"context_line":"            (\u0027https://localhost:3081/opendev/\u0027, None,"},{"line_number":98,"context_line":"             \u0027gitea-org-opendev.png\u0027),"},{"line_number":99,"context_line":"            (\u0027https://localhost:3081/explore/organizations\u0027, None,"},{"line_number":100,"context_line":"             \u0027gitea-org-expore.png\u0027),"},{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        take_screenshots(host, shots)"}],"source_content_type":"text/x-python","patch_set":14,"id":"df0d637d_5ae529f2","line":100,"range":{"start_line":100,"start_character":24,"end_line":100,"end_character":30},"updated":"2022-03-18 12:32:24.000000000","message":"nit: \"explore\"","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f46a8a8bcec7b9277388d9e7fefe6a373830fac","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        take_screenshots(host, shots)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"68642868_ccc77d15","line":104,"updated":"2022-03-18 12:32:24.000000000","message":"nit: unrelated+unneeded?","commit_id":"2d9c8b620f6d778cf13aaad1a5b05957bcbb077a"}]}