)]}'
{"playbooks/roles/letsencrypt-acme-sh-install/files/driver.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"53ad345e929816d66eb19a8728617cf5f9e7759a","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    shift;"},{"line_number":98,"context_line":"    for arg in \"$@\"; do"},{"line_number":99,"context_line":"        {"},{"line_number":100,"context_line":"            read -r -a domain_array \u003c\u003c\u003c \"$arg\""},{"line_number":101,"context_line":"            domain\u003d${domain_array[1]}"},{"line_number":102,"context_line":"            mkdir -p ${CERT_HOME}/${domain}"},{"line_number":103,"context_line":"            cd ${CERT_HOME}/${domain}"}],"source_content_type":"text/x-sh","patch_set":18,"id":"2dc3ac26_6c25c2fb","line":100,"updated":"2022-07-19 21:39:12.000000000","message":"We are in a loop processing each arg separately, but then at this point we seem to expect all of $@ to be read in as an array? Should we drop the loop and replace $arg here with $@?\n\nI\u0027m probably missing some bash behavior that ensures this works as intended, but my read on it is that we\u0027ll loop multiple times doing multiple cert generations.","commit_id":"0d83dd3ea0778b511fed9625df7ffb226bcfc002"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"57b55152411b5fd339a4bbc4bd700d448a1ee840","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    shift;"},{"line_number":98,"context_line":"    for arg in \"$@\"; do"},{"line_number":99,"context_line":"        {"},{"line_number":100,"context_line":"            read -r -a domain_array \u003c\u003c\u003c \"$arg\""},{"line_number":101,"context_line":"            domain\u003d${domain_array[1]}"},{"line_number":102,"context_line":"            mkdir -p ${CERT_HOME}/${domain}"},{"line_number":103,"context_line":"            cd ${CERT_HOME}/${domain}"}],"source_content_type":"text/x-sh","patch_set":18,"id":"59e0bb61_e7e9d182","line":100,"in_reply_to":"2dc3ac26_6c25c2fb","updated":"2022-07-19 21:43:33.000000000","message":"The arguments here are batched up and weird, it\u0027s like:\n\n \"-d moo.domain.com -d moo1.domain.com\" \"-d foo.domain.com -d foo1.domain.com\"\n \nso basically each arg of \"$@\" is actually a space-deliminated string, that we then split into \"domain_array\"","commit_id":"0d83dd3ea0778b511fed9625df7ffb226bcfc002"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e61ae1809420e16cf5157406da8f689f999989d8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    shift;"},{"line_number":98,"context_line":"    for arg in \"$@\"; do"},{"line_number":99,"context_line":"        {"},{"line_number":100,"context_line":"            read -r -a domain_array \u003c\u003c\u003c \"$arg\""},{"line_number":101,"context_line":"            domain\u003d${domain_array[1]}"},{"line_number":102,"context_line":"            mkdir -p ${CERT_HOME}/${domain}"},{"line_number":103,"context_line":"            cd ${CERT_HOME}/${domain}"}],"source_content_type":"text/x-sh","patch_set":18,"id":"0452f52b_ee2f45a3","line":100,"in_reply_to":"59e0bb61_e7e9d182","updated":"2022-07-25 00:40:22.000000000","message":"this was addressed in https://review.opendev.org/c/opendev/system-config/+/850435","commit_id":"0d83dd3ea0778b511fed9625df7ffb226bcfc002"}]}