)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"30789f25b397ce9eef6cfb0718d5ddaac1fc33af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aab3b99c_f901cdb5","updated":"2022-10-20 17:26:09.000000000","message":"https://review.opendev.org/c/zuul/nodepool/+/861797 is testing this with nodepool. Nodepool is a good option because it has arm64 and amd64 builds as well as siblings jobs. I\u0027m not sure if the siblings jobs will trigger on that change though we may need to also push glean and dib jobs to trigger those.","commit_id":"47a58e83d442e4fbb04a4e4b9fa9697c00ea2951"}],"docker/python-builder/scripts/assemble":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b8b5429181be0ba2250ea40e28bcc11716c13b09","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        /tmp/venv/bin/pip wheel $CONSTRAINTS --wheel-dir\u003d/output/wheels -r /tmp/src/requirements.txt"},{"line_number":66,"context_line":"        cp /tmp/src/requirements.txt /output/requirements.txt"},{"line_number":67,"context_line":"    fi"},{"line_number":68,"context_line":"    /tmp/venv/bin/pip wheel $CONSTRAINTS --wheel-dir\u003d/output/wheels /output/toplevel_wheels/*whl"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # Pip wheel each of the extras so that we collect all possibly"},{"line_number":71,"context_line":"    # needed wheels in the wheel output dir. get-extras-packages also"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"04f92a3d_01d8169c","line":68,"range":{"start_line":68,"start_character":3,"end_line":68,"end_character":96},"updated":"2022-11-09 04:08:48.000000000","message":"I\u0027m a bit confused about this line.  Previously we\u0027d build the wheel above (\"python3 -m build\") and then install this wheel here with --cache-dir to populate /output/wheels with everything from installing the package?\n\nBut this is calling \"pip wheel\" on the wheel we\u0027ve built of the package?  What does calling a wheel on a wheel do, if that makes sense?  Presumably populates /output/wheels ... but is that a defined operation, or something that happens to work?","commit_id":"c2b8916c17d4cb3c309ec01742862771f7ccfb61"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d20f51bbebda96c78d5ba243a7c5d32c16941dae","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        /tmp/venv/bin/pip wheel $CONSTRAINTS --wheel-dir\u003d/output/wheels -r /tmp/src/requirements.txt"},{"line_number":66,"context_line":"        cp /tmp/src/requirements.txt /output/requirements.txt"},{"line_number":67,"context_line":"    fi"},{"line_number":68,"context_line":"    /tmp/venv/bin/pip wheel $CONSTRAINTS --wheel-dir\u003d/output/wheels /output/toplevel_wheels/*whl"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # Pip wheel each of the extras so that we collect all possibly"},{"line_number":71,"context_line":"    # needed wheels in the wheel output dir. get-extras-packages also"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"c17c75a4_c8b0b8fa","line":68,"range":{"start_line":68,"start_character":3,"end_line":68,"end_character":96},"in_reply_to":"04f92a3d_01d8169c","updated":"2022-11-09 05:36:29.000000000","message":"ok, clarkb has clarified for me that \"pip wheel\" should take pretty much anything as an input -- requirements file, another wheel, source dir, etc. and sort out the wheels required into \"--wheel-dir\" ... this is defined behaviour and what upstream reccommend.","commit_id":"c2b8916c17d4cb3c309ec01742862771f7ccfb61"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e82363ecb78cc76d2baf1920c0b6b5587b02193e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        /tmp/venv/bin/pip wheel $CONSTRAINTS --wheel-dir\u003d/output/wheels -r /tmp/src/requirements.txt"},{"line_number":66,"context_line":"        cp /tmp/src/requirements.txt /output/requirements.txt"},{"line_number":67,"context_line":"    fi"},{"line_number":68,"context_line":"    /tmp/venv/bin/pip wheel $CONSTRAINTS --wheel-dir\u003d/output/wheels /output/toplevel_wheels/*whl"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # Pip wheel each of the extras so that we collect all possibly"},{"line_number":71,"context_line":"    # needed wheels in the wheel output dir. get-extras-packages also"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"843c1ccf_e0bff8c6","line":68,"range":{"start_line":68,"start_character":3,"end_line":68,"end_character":96},"in_reply_to":"c17c75a4_c8b0b8fa","updated":"2022-11-09 15:48:12.000000000","message":"Yup, in particular it seems that \"making all the wheels you need for an install target\" is the functionality of `pip wheel`. Relying on the cache as we did worked until it didn\u0027t beacuse they expect people to use `pip wheel` instead.","commit_id":"c2b8916c17d4cb3c309ec01742862771f7ccfb61"}],"docker/python-builder/scripts/install-from-bindep":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"1d9d716ffa11643f9506ee8ef08a1e880177e9be","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# to do things like pick up patched but unreleased versions"},{"line_number":30,"context_line":"# of dependencies."},{"line_number":31,"context_line":"if [ -f /output/requirements.txt ] ; then"},{"line_number":32,"context_line":"    pip install $CONSTRAINTS --find-links\u003d/output/wheels -r /output/requirements.txt"},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Add any requested extras to the list of things to install"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1afb4068_f6c86830","line":32,"updated":"2022-10-21 00:24:04.000000000","message":"Seems like adding --no-index would be more efficient and stable than making additional network connections.","commit_id":"765597aa2cc60465bccd26918884af2a4df95ddc"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c7834b26024746444f8b2e19d2c07f0180b72178","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# to do things like pick up patched but unreleased versions"},{"line_number":30,"context_line":"# of dependencies."},{"line_number":31,"context_line":"if [ -f /output/requirements.txt ] ; then"},{"line_number":32,"context_line":"    pip install $CONSTRAINTS --find-links\u003d/output/wheels -r /output/requirements.txt"},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Add any requested extras to the list of things to install"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"b505ffa5_394d68af","line":32,"updated":"2022-10-20 23:31:22.000000000","message":"We need to add --no-index to the pip install commands if we don\u0027t want pip consulting pypi for packages. The behavior on this version has it only installing wheels which don\u0027t exist on pypi that we\u0027ve locally built from the /output/wheels dir. Everything else is installed from pypi.\n\nEither way the key thing which is that we don\u0027t run any builds on the python-base based images seems to still be the case. This means we need to decide if we want --no-index or if we\u0027d prefer to stick with the new behavior.","commit_id":"765597aa2cc60465bccd26918884af2a4df95ddc"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c7834b26024746444f8b2e19d2c07f0180b72178","unresolved":true,"context_lines":[{"line_number":41,"context_line":"if [ -f /output/packages.txt ] ; then"},{"line_number":42,"context_line":"  # If a package list was passed to assemble, install that in the final"},{"line_number":43,"context_line":"  # image."},{"line_number":44,"context_line":"  pip install $CONSTRAINTS --find-links\u003d/output/wheels -r /output/packages.txt $EXTRAS"},{"line_number":45,"context_line":"else"},{"line_number":46,"context_line":"  # Install the top level wheels."},{"line_number":47,"context_line":"  pip install $CONSTRAINTS --find-links\u003d/output/wheels /output/toplevel_wheels/*.whl $EXTRAS"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"11fcc6d2_37154de5","line":44,"updated":"2022-10-20 23:31:22.000000000","message":"See above.","commit_id":"765597aa2cc60465bccd26918884af2a4df95ddc"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c7834b26024746444f8b2e19d2c07f0180b72178","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  pip install $CONSTRAINTS --find-links\u003d/output/wheels -r /output/packages.txt $EXTRAS"},{"line_number":45,"context_line":"else"},{"line_number":46,"context_line":"  # Install the top level wheels."},{"line_number":47,"context_line":"  pip install $CONSTRAINTS --find-links\u003d/output/wheels /output/toplevel_wheels/*.whl $EXTRAS"},{"line_number":48,"context_line":"fi"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# clean up after ourselves"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"cf3a1900_0e9b988c","line":47,"updated":"2022-10-20 23:31:22.000000000","message":"See above.","commit_id":"765597aa2cc60465bccd26918884af2a4df95ddc"}]}