)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6e2d1a6ebafbb06e83577d8e2d1ed92b29cb05f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ed4c61c3_7ff251c0","updated":"2022-11-02 12:19:23.000000000","message":"I really don\u0027t know how to properly review this patch. either we add a job (or maybe there is one already?) that deploys all the keys somewhere and verifies that it can then connect everywhere, or we can simple merge and do live testing","commit_id":"e8eac073401d26f5151fbb0654f907a3d6c56511"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5dcf06f14fac52f274182d7312f210594c307ab2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b65ba446_09900344","updated":"2022-11-02 12:22:03.000000000","message":"Thinking about it a bit more, there\u0027s also the question how to keep this data up to date and avoid it regressing. Maybe adding a script (which you likely used to generate this anyway) could be added and be run either as periodic job or in checks?","commit_id":"e8eac073401d26f5151fbb0654f907a3d6c56511"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bfce58d235fad0e27627be61dc30cbb6448de139","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d298218a_31102874","updated":"2022-11-07 20:06:07.000000000","message":"guess I\u0027m fine with that, thx","commit_id":"e8eac073401d26f5151fbb0654f907a3d6c56511"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1e1b3617179b3a7c4e0b2db8e60470290a47f6d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5ac059d6_c503de6a","in_reply_to":"b65ba446_09900344","updated":"2022-11-02 23:50:08.000000000","message":"So this data should never change for an active host (unless we are rotating the keys for some reason, at which point we would want to codify it a changelog in git here anyway).  \n\nGoing forward, managing it should be a matter of just adding they keys statically when we start a new host.","commit_id":"e8eac073401d26f5151fbb0654f907a3d6c56511"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1e1b3617179b3a7c4e0b2db8e60470290a47f6d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da3b7014_7f353202","in_reply_to":"ed4c61c3_7ff251c0","updated":"2022-11-02 23:50:08.000000000","message":"If you\u0027d like to verify it, I started from \n\n for h in $(cat hosts.yaml  | grep \u0027^    [^ ]\u0027 | sed \u0027s/://\u0027); do ssh-keyscan $h \u003e\u003e /tmp/scan.txt; done\n\nand then wrote an emacs macro to just cut-copy the lines between scan.txt and inventory.yaml 😊  basically to double check the keys are in the right place -- but also I would like to clear out the /root known hosts and rely on this -- so basically bridge wouldn\u0027t connect to the hosts if their keys don\u0027t match up.","commit_id":"e8eac073401d26f5151fbb0654f907a3d6c56511"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8bd45ba46036e0b3b07bbe338356deaf125e10da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"29370954_0c06e878","updated":"2022-11-10 04:10:26.000000000","message":"going to rework this to generate the hostnames","commit_id":"cc7c3cd6ec06d5f54c09860e7ea1ddb18c5dc216"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2d21add97f280077a12f87f744795ece65e82d03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ee48f8a4_7778d21a","updated":"2022-11-20 22:28:13.000000000","message":"as fungi is fine with the follow-on, and frickler was OK with the general idea of this here I\u0027ll take that as enough general consensus this is at least pointing in the right direction.\n\nOne thing to finalise is making the inventory output of the launch-node script put these here in this format, there is some work re-arranging that into a venv that we can put that ontop of later.  I\u0027m keen to try this out and make sure bridge can still talk to everything, and will be watching closely","commit_id":"618708b42ad6363655f0803261c4a841ba0bc21e"}]}
