)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fbf411a3ca3a1b506b9021cc1d945176c38fc9ca","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Only the *nested* Ansible running on the bastion host reads"},{"line_number":28,"context_line":"s-c:inventory/service/groups.yaml.  None of the nested-ansible"},{"line_number":29,"context_line":"playbooks need to target only the currently active bastion host.  For"},{"line_number":30,"context_line":"example, we can define as many bridge nodes as we like in the"},{"line_number":31,"context_line":"inventory and run service-bridge.yaml against them.  It won\u0027t matter"},{"line_number":32,"context_line":"because the production jobs know the host that is the currently active"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e1ca64d8_77a785f2","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":64},"updated":"2022-11-03 21:41:44.000000000","message":"There is one exception to this which is the zuul_reboot.yaml playbook which is run by cron on the active bastion. The reason for this is we cannot restart zuul via a zuul job as the executor running the job will never stop. I don\u0027t think we need to solve this problem for this change to merge, but we should be aware that we do have one area where two bridges is a problem.","commit_id":"26af4c9cc7df8ca63a22c7998cdfb444da9bf818"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7ac0bcf6b19919b932785c0db1958351c55bc1a3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Only the *nested* Ansible running on the bastion host reads"},{"line_number":28,"context_line":"s-c:inventory/service/groups.yaml.  None of the nested-ansible"},{"line_number":29,"context_line":"playbooks need to target only the currently active bastion host.  For"},{"line_number":30,"context_line":"example, we can define as many bridge nodes as we like in the"},{"line_number":31,"context_line":"inventory and run service-bridge.yaml against them.  It won\u0027t matter"},{"line_number":32,"context_line":"because the production jobs know the host that is the currently active"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e461bbe4_6759476d","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":64},"in_reply_to":"e1ca64d8_77a785f2","updated":"2022-11-03 22:37:06.000000000","message":"agreed; that is special and i think we can just pin it with a host match.  Proposed in https://review.opendev.org/c/opendev/system-config/+/863568","commit_id":"26af4c9cc7df8ca63a22c7998cdfb444da9bf818"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fbf411a3ca3a1b506b9021cc1d945176c38fc9ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"706ef418_b49cc78d","updated":"2022-11-03 21:41:44.000000000","message":"Few things inline. Also, I wonder if we should try to use the filesystem to organize playbooks that run from a zuul context separately from those that run from a bridge context.\n\nMaybe we should try and do something like playbooks/zuul/bridge/ and leave playbooks/ for things that run via bridge ansible? I think you did some of that already but for example playbooks/boostrap-bridge.yaml runs from the zuul not bridge context.","commit_id":"26af4c9cc7df8ca63a22c7998cdfb444da9bf818"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7ac0bcf6b19919b932785c0db1958351c55bc1a3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f41a27f8_f95ddca8","in_reply_to":"706ef418_b49cc78d","updated":"2022-11-03 22:37:06.000000000","message":"Good idea, i\u0027ll take a look","commit_id":"26af4c9cc7df8ca63a22c7998cdfb444da9bf818"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c32e75c995d0fb7a5938d59f71a4e5dfce715419","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ae30f323_4ce725fe","updated":"2022-11-03 23:19:27.000000000","message":"The issue I -1\u0027d for was addressed in the parent change.","commit_id":"0c90c128d733d0754dfe35d1098f7bcbdec5d435"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7a6868a8f3644f9e55f98f0dcaac8e06f7def216","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"50dd0954_e41d02ad","updated":"2022-11-07 19:54:57.000000000","message":"recheck","commit_id":"0c90c128d733d0754dfe35d1098f7bcbdec5d435"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d841f41e1c7c6436d010dc913fdeaf26dcb0d38e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e699903d_13b67a28","updated":"2022-11-07 00:09:14.000000000","message":"the base job is now adding prod_bastion and using \"prod_bastion[0]\" -- see\n\nhttps://zuul.opendev.org/t/openstack/build/016fc24e8b2c49dfabd65f8597d4420c/console\n\ni will watch this closely","commit_id":"0c90c128d733d0754dfe35d1098f7bcbdec5d435"}],"playbooks/bootstrap-bridge.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fbf411a3ca3a1b506b9021cc1d945176c38fc9ca","unresolved":true,"context_lines":[{"line_number":12,"context_line":"# In both cases, the \"bastion\" group has one entry, which is the"},{"line_number":13,"context_line":"# bastion host to run against."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- hosts: prod_bastion[0]:!disabled"},{"line_number":16,"context_line":"  name: \"Bridge: bootstrap the bastion host\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a8cef50_e39cd676","line":15,"updated":"2022-11-03 21:41:44.000000000","message":"This is run by playbooks/zuul/run-production-bootstrap-bridge.yaml but that playbook doesn\u0027t seem to be updated to use prod_bastion in its add_host. I think that updating this file without that file will break things.","commit_id":"26af4c9cc7df8ca63a22c7998cdfb444da9bf818"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7ac0bcf6b19919b932785c0db1958351c55bc1a3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# In both cases, the \"bastion\" group has one entry, which is the"},{"line_number":13,"context_line":"# bastion host to run against."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- hosts: prod_bastion[0]:!disabled"},{"line_number":16,"context_line":"  name: \"Bridge: bootstrap the bastion host\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"89e057c8_4e567411","line":15,"in_reply_to":"3a8cef50_e39cd676","updated":"2022-11-03 22:37:06.000000000","message":"Excellent catch!  I believe that can also use the add-bastion-host role ... I\u0027m not sure why it doesn\u0027t ... possibly just i got things out of order.  that is proposed with I5ad7f6f1ac9bdf9af59b835d8fd466c3ca276639","commit_id":"26af4c9cc7df8ca63a22c7998cdfb444da9bf818"}],"playbooks/zuul/roles/add-bastion-host/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fbf411a3ca3a1b506b9021cc1d945176c38fc9ca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Add bastion host to inventory for production playbook"},{"line_number":2,"context_line":"  add_host:"},{"line_number":3,"context_line":"    name: \u0027bridge01.opendev.org\u0027"},{"line_number":4,"context_line":"    groups: \u0027prod_bastion\u0027"},{"line_number":5,"context_line":"    ansible_python_interpreter: python3"},{"line_number":6,"context_line":"    ansible_user: zuul"},{"line_number":7,"context_line":"    # Without setting ansible_host directly, mirror-workspace-git-repos"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3718e262_68e63d41","line":4,"updated":"2022-11-03 21:41:44.000000000","message":"We should do similar to the base-jobs add_host or maybe even drop the group entry there entirely as we don\u0027t seem to use it. That should minimize confusion.","commit_id":"26af4c9cc7df8ca63a22c7998cdfb444da9bf818"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7ac0bcf6b19919b932785c0db1958351c55bc1a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Add bastion host to inventory for production playbook"},{"line_number":2,"context_line":"  add_host:"},{"line_number":3,"context_line":"    name: \u0027bridge01.opendev.org\u0027"},{"line_number":4,"context_line":"    groups: \u0027prod_bastion\u0027"},{"line_number":5,"context_line":"    ansible_python_interpreter: python3"},{"line_number":6,"context_line":"    ansible_user: zuul"},{"line_number":7,"context_line":"    # Without setting ansible_host directly, mirror-workspace-git-repos"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ebd35482_b04b18ef","line":4,"in_reply_to":"3718e262_68e63d41","updated":"2022-11-03 22:37:06.000000000","message":"I have proposed that with https://review.opendev.org/c/opendev/base-jobs/+/863566","commit_id":"26af4c9cc7df8ca63a22c7998cdfb444da9bf818"}]}