)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59b4bd95f212045d9f1109274e6d70f1436fe96b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"This is added and hacked in, along with a config file for the"},{"line_number":22,"context_line":"appropriate account (I have added these details on bridge)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"I\u0027ve left the update of openstack.org DNS entries as a manual"},{"line_number":25,"context_line":"procedure.  Although they could be set automatically with small"},{"line_number":26,"context_line":"updates to the tool (just a different POST) -- details like CNAMES,"},{"line_number":27,"context_line":"etc. and the relatively few servers we start in the RAX mangaed DNS"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"170e19d7_90c819de","line":24,"updated":"2022-11-29 23:23:58.000000000","message":"I think this is the right choice. We often cycle a few server boots when sorting out new platforms or when we run into problems. Not adding forward records until we know we are ready is a good thing.","commit_id":"3ba1c1f6dec8ac43bbb665a8fb26dc4d51810c6d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2bbc00717fb4c7572225b90c9b93df90f6a34638","unresolved":false,"context_lines":[{"line_number":21,"context_line":"This is added and hacked in, along with a config file for the"},{"line_number":22,"context_line":"appropriate account (I have added these details on bridge)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"I\u0027ve left the update of openstack.org DNS entries as a manual"},{"line_number":25,"context_line":"procedure.  Although they could be set automatically with small"},{"line_number":26,"context_line":"updates to the tool (just a different POST) -- details like CNAMES,"},{"line_number":27,"context_line":"etc. and the relatively few servers we start in the RAX mangaed DNS"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b928a15c_714fd3ad","line":24,"in_reply_to":"170e19d7_90c819de","updated":"2022-12-01 00:26:59.000000000","message":"Ack","commit_id":"3ba1c1f6dec8ac43bbb665a8fb26dc4d51810c6d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59b4bd95f212045d9f1109274e6d70f1436fe96b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c2ac586_9e7bd9a2","updated":"2022-11-29 23:23:58.000000000","message":"-1 for the name var issue inline.","commit_id":"3ba1c1f6dec8ac43bbb665a8fb26dc4d51810c6d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f252795cf2bf35fb86ed67814796963b7ccb082b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f5500ecd_e564740f","updated":"2022-12-21 22:10:04.000000000","message":"recheck","commit_id":"20d2643f745217670b56a85cb436aea2caf49973"}],"launch/src/opendev_launch/dns.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59b4bd95f212045d9f1109274e6d70f1436fe96b","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    # Reads default config file /etc/rax-rdns-auth.conf and calls to"},{"line_number":67,"context_line":"    # API to set reverse dns for RAX servers."},{"line_number":68,"context_line":"    auth \u003d rax_rdns.get_auth()"},{"line_number":69,"context_line":"    rax_rdns.rax_rdns(name, href, ip4, ip6, 3600, auth)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def print_inventory_yaml(server, ip4, ip6):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a195cab3_ee077cec","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":26},"updated":"2022-11-29 23:23:58.000000000","message":"This appears to be server.name not name.","commit_id":"3ba1c1f6dec8ac43bbb665a8fb26dc4d51810c6d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2bbc00717fb4c7572225b90c9b93df90f6a34638","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    # Reads default config file /etc/rax-rdns-auth.conf and calls to"},{"line_number":67,"context_line":"    # API to set reverse dns for RAX servers."},{"line_number":68,"context_line":"    auth \u003d rax_rdns.get_auth()"},{"line_number":69,"context_line":"    rax_rdns.rax_rdns(name, href, ip4, ip6, 3600, auth)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def print_inventory_yaml(server, ip4, ip6):"}],"source_content_type":"text/x-python","patch_set":4,"id":"4ae096d4_0724c165","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":26},"in_reply_to":"a195cab3_ee077cec","updated":"2022-12-01 00:26:59.000000000","message":"Done","commit_id":"3ba1c1f6dec8ac43bbb665a8fb26dc4d51810c6d"}],"launch/src/opendev_launch/rax_rdns.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59b4bd95f212045d9f1109274e6d70f1436fe96b","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    r \u003d session.post(url\u003drdns_url, headers\u003dheaders, json\u003drdns_json)"},{"line_number":113,"context_line":"    logging.info(\"Done: %s %s\" % (r.status_code, r.reason))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":4,"id":"535f15f1_c21abc18","line":113,"range":{"start_line":113,"start_character":18,"end_line":113,"end_character":22},"updated":"2022-11-29 23:23:58.000000000","message":"Nit, might want to indicate what is done? Or does r.reason give us enough context?","commit_id":"3ba1c1f6dec8ac43bbb665a8fb26dc4d51810c6d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2bbc00717fb4c7572225b90c9b93df90f6a34638","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    r \u003d session.post(url\u003drdns_url, headers\u003dheaders, json\u003drdns_json)"},{"line_number":113,"context_line":"    logging.info(\"Done: %s %s\" % (r.status_code, r.reason))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":4,"id":"e476bc04_5aac0fe2","line":113,"range":{"start_line":113,"start_character":18,"end_line":113,"end_character":22},"in_reply_to":"535f15f1_c21abc18","updated":"2022-12-01 00:26:59.000000000","message":"If it were general purpose it really should handle all the errors, etc.  I think for our purposes here, just the status/log will be enough -- if it does fail the server doesn\u0027t give you back anything useful anyway (other than it was a bad request).","commit_id":"3ba1c1f6dec8ac43bbb665a8fb26dc4d51810c6d"}],"playbooks/roles/install-launch-node/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59b4bd95f212045d9f1109274e6d70f1436fe96b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    dest: /etc/rax-rdns-auth.conf"},{"line_number":11,"context_line":"    owner: root"},{"line_number":12,"context_line":"    group: root"},{"line_number":13,"context_line":"    mode: \u00270644\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Install node launcher"},{"line_number":16,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"61b2ed2f_690a05ee","line":13,"updated":"2022-11-29 23:23:58.000000000","message":"Not, should this be more restrictive permissions?","commit_id":"3ba1c1f6dec8ac43bbb665a8fb26dc4d51810c6d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2bbc00717fb4c7572225b90c9b93df90f6a34638","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    dest: /etc/rax-rdns-auth.conf"},{"line_number":11,"context_line":"    owner: root"},{"line_number":12,"context_line":"    group: root"},{"line_number":13,"context_line":"    mode: \u00270644\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Install node launcher"},{"line_number":16,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"afcb6d11_07d65f64","line":13,"in_reply_to":"61b2ed2f_690a05ee","updated":"2022-12-01 00:26:59.000000000","message":"++ sensible to make it the same as /etc/rax-dns-auth.conf which is used to dump the domains.  that\u0027s 0600 which I\u0027ll update this to","commit_id":"3ba1c1f6dec8ac43bbb665a8fb26dc4d51810c6d"}]}