)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d29323f39423e2840dd58e1a654597ad0e3c284d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5664653d_08226b9f","updated":"2022-11-30 15:28:56.000000000","message":"Working on some better testing for that usecase.","commit_id":"7a9f3874e3308f231f79a7ac3ca1d34c2d92c502"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a503db3abb976b7ec11d6a48fb4b23f883937551","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ab461080_2fb96bd8","updated":"2022-12-01 17:26:25.000000000","message":"Port mapping issues noted inline. I\u0027m a bit surprised this worked properly in testing. Maybe because the alias isn\u0027t being checked for sni ?","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"18d3b036cb3da76cd22a3470808747d73085bc98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a72687c6_efefa2ac","updated":"2022-12-01 09:57:21.000000000","message":"recheck\n\nerror wasn\u0027t related to the patch this time I think.","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b1f3cd67cfb4ec9b401193fc29ec53ab8e54fca8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"33d50756_1610b606","updated":"2022-12-02 11:39:41.000000000","message":"Thank you fungi for the quick correction!\n\nWondering if those directives couldn\u0027t be in the Macro, in order to avoid this kind of things?","commit_id":"d6a5c34eb04b34607a6ddb949de523e4048fe4aa"}],"playbooks/roles/mirror/templates/mirror.vhost.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cb02352f4f10b0a24870008fff025ae2dc9d3611","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Ansible Galaxy"},{"line_number":128,"context_line":"    # Catch wild redirect"},{"line_number":129,"context_line":"    RewriteRule \"^/galaxy/api$\" \"/galaxy/api/\" [R]"},{"line_number":130,"context_line":"    \u003cLocation \"/galaxy\"\u003e"},{"line_number":131,"context_line":"      ProxyPass \"https://galaxy.ansible.com/\" ttl\u003d120 keepalive\u003dOn retry\u003d0"},{"line_number":132,"context_line":"      ProxyPassReverse \"https://galaxy.ansible.com/\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"035a065a_6ae97014","line":129,"updated":"2022-11-30 16:30:59.000000000","message":"I would not do this redirect here. We should proxy the request for /galaxy/api to https://galaxy.ansible.com/api and let that redirect to https://galaxy.ansible.com/api/. The ProxyPassReverse directive will update the headers in the redirect response.\n\nThe reason for not performing the redirect ourselves is that if the galaxy api behavior changes we can potentially diverge in a problematic way.","commit_id":"9c2b68425dace43b7511f034a7acf17ba30359f3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"fdb1a86f3979699d27edee25826acede58011f3b","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Ansible Galaxy"},{"line_number":128,"context_line":"    # Catch wild redirect"},{"line_number":129,"context_line":"    RewriteRule \"^/galaxy/api$\" \"/galaxy/api/\" [R]"},{"line_number":130,"context_line":"    \u003cLocation \"/galaxy\"\u003e"},{"line_number":131,"context_line":"      ProxyPass \"https://galaxy.ansible.com/\" ttl\u003d120 keepalive\u003dOn retry\u003d0"},{"line_number":132,"context_line":"      ProxyPassReverse \"https://galaxy.ansible.com/\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0ee1b2fe_b5421630","line":129,"in_reply_to":"035a065a_6ae97014","updated":"2022-12-01 09:56:58.000000000","message":"The redirection sent by the remote server breaks the proxypassreverse.\n\nI doubt that redirect would ever change, but OK - new port, so that we can use the root of the vhost, like it\u0027s done for docker and some others.","commit_id":"9c2b68425dace43b7511f034a7acf17ba30359f3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cb02352f4f10b0a24870008fff025ae2dc9d3611","unresolved":true,"context_lines":[{"line_number":135,"context_line":"      # ansible-galaxy CLI needs a fully qualified URI. So we must take care"},{"line_number":136,"context_line":"      # of the REQUEST_SCHEME. Note that mod_substitute can\u0027t use parameters..."},{"line_number":137,"context_line":"      \u003cIf \"-T %{HTTPS}\"\u003e"},{"line_number":138,"context_line":"        Substitute \"s|https://galaxy.ansible.com/|https://{{ apache_server_name }}:$port/galaxy/|ni\""},{"line_number":139,"context_line":"        Substitute \"s|https://ansible-galaxy.s3.amazonaws.com/|https://{{ apache_server_name }}:$port/galaxy-s3/|ni\""},{"line_number":140,"context_line":"      \u003c/If\u003e"},{"line_number":141,"context_line":"      \u003cIf \"! -T %{HTTPS}\"\u003e"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"b50d7860_1b542e76","line":138,"range":{"start_line":138,"start_character":50,"end_line":138,"end_character":88},"updated":"2022-11-30 16:30:59.000000000","message":"The pypi substitutions use relative paths then you don\u0027t need all of this server info. Could simplify a bit I guess.","commit_id":"9c2b68425dace43b7511f034a7acf17ba30359f3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"fdb1a86f3979699d27edee25826acede58011f3b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"      # ansible-galaxy CLI needs a fully qualified URI. So we must take care"},{"line_number":136,"context_line":"      # of the REQUEST_SCHEME. Note that mod_substitute can\u0027t use parameters..."},{"line_number":137,"context_line":"      \u003cIf \"-T %{HTTPS}\"\u003e"},{"line_number":138,"context_line":"        Substitute \"s|https://galaxy.ansible.com/|https://{{ apache_server_name }}:$port/galaxy/|ni\""},{"line_number":139,"context_line":"        Substitute \"s|https://ansible-galaxy.s3.amazonaws.com/|https://{{ apache_server_name }}:$port/galaxy-s3/|ni\""},{"line_number":140,"context_line":"      \u003c/If\u003e"},{"line_number":141,"context_line":"      \u003cIf \"! -T %{HTTPS}\"\u003e"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"75994ba3_868dea78","line":138,"range":{"start_line":138,"start_character":50,"end_line":138,"end_character":88},"in_reply_to":"b50d7860_1b542e76","updated":"2022-12-01 09:56:58.000000000","message":"ansible-galaxy wants the full name - with proto, server, port and all. As written in the comment actually.","commit_id":"9c2b68425dace43b7511f034a7acf17ba30359f3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a503db3abb976b7ec11d6a48fb4b23f883937551","unresolved":true,"context_lines":[{"line_number":596,"context_line":"\u003c/Macro\u003e"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"\u003cVirtualHost *:8085\u003e"},{"line_number":599,"context_line":"    ServerName {{ apache_server_name }}:8084"},{"line_number":600,"context_line":"    ServerAlias {{ apache_server_alias }}:8084"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    Use AnsibleGalaxy 8085"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"12dd07f7_624539cb","line":599,"range":{"start_line":599,"start_character":40,"end_line":599,"end_character":44},"updated":"2022-12-01 17:26:25.000000000","message":"This port needs to be 8085.","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b1f3cd67cfb4ec9b401193fc29ec53ab8e54fca8","unresolved":false,"context_lines":[{"line_number":596,"context_line":"\u003c/Macro\u003e"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"\u003cVirtualHost *:8085\u003e"},{"line_number":599,"context_line":"    ServerName {{ apache_server_name }}:8084"},{"line_number":600,"context_line":"    ServerAlias {{ apache_server_alias }}:8084"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    Use AnsibleGalaxy 8085"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7f7eef3a_9875bb0d","line":599,"range":{"start_line":599,"start_character":40,"end_line":599,"end_character":44},"in_reply_to":"12dd07f7_624539cb","updated":"2022-12-02 11:39:41.000000000","message":"Done","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a503db3abb976b7ec11d6a48fb4b23f883937551","unresolved":true,"context_lines":[{"line_number":597,"context_line":""},{"line_number":598,"context_line":"\u003cVirtualHost *:8085\u003e"},{"line_number":599,"context_line":"    ServerName {{ apache_server_name }}:8084"},{"line_number":600,"context_line":"    ServerAlias {{ apache_server_alias }}:8084"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    Use AnsibleGalaxy 8085"},{"line_number":603,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fde3bad_37d9bed0","line":600,"range":{"start_line":600,"start_character":42,"end_line":600,"end_character":46},"updated":"2022-12-01 17:26:25.000000000","message":"See above.","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b1f3cd67cfb4ec9b401193fc29ec53ab8e54fca8","unresolved":false,"context_lines":[{"line_number":597,"context_line":""},{"line_number":598,"context_line":"\u003cVirtualHost *:8085\u003e"},{"line_number":599,"context_line":"    ServerName {{ apache_server_name }}:8084"},{"line_number":600,"context_line":"    ServerAlias {{ apache_server_alias }}:8084"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    Use AnsibleGalaxy 8085"},{"line_number":603,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"e9ee8801_acd0a600","line":600,"range":{"start_line":600,"start_character":42,"end_line":600,"end_character":46},"in_reply_to":"5fde3bad_37d9bed0","updated":"2022-12-02 11:39:41.000000000","message":"Done","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a503db3abb976b7ec11d6a48fb4b23f883937551","unresolved":true,"context_lines":[{"line_number":603,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"\u003cVirtualHost *:4448\u003e"},{"line_number":606,"context_line":"    ServerName {{ apache_server_name }}:8084"},{"line_number":607,"context_line":"    ServerAlias {{ apache_server_alias }}:8084"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    Use SSLConfig"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"647fa8c7_18dca6f4","line":606,"range":{"start_line":606,"start_character":40,"end_line":606,"end_character":44},"updated":"2022-12-01 17:26:25.000000000","message":"This port needs to be 4448.","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b1f3cd67cfb4ec9b401193fc29ec53ab8e54fca8","unresolved":false,"context_lines":[{"line_number":603,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"\u003cVirtualHost *:4448\u003e"},{"line_number":606,"context_line":"    ServerName {{ apache_server_name }}:8084"},{"line_number":607,"context_line":"    ServerAlias {{ apache_server_alias }}:8084"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    Use SSLConfig"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"587b0edc_9885629b","line":606,"range":{"start_line":606,"start_character":40,"end_line":606,"end_character":44},"in_reply_to":"647fa8c7_18dca6f4","updated":"2022-12-02 11:39:41.000000000","message":"Done","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a503db3abb976b7ec11d6a48fb4b23f883937551","unresolved":true,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"\u003cVirtualHost *:4448\u003e"},{"line_number":606,"context_line":"    ServerName {{ apache_server_name }}:8084"},{"line_number":607,"context_line":"    ServerAlias {{ apache_server_alias }}:8084"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    Use SSLConfig"},{"line_number":610,"context_line":"    Use AnsibleGalaxy 4448"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5eaa6a02_9d11374c","line":607,"range":{"start_line":607,"start_character":42,"end_line":607,"end_character":46},"updated":"2022-12-01 17:26:25.000000000","message":"See above.","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b1f3cd67cfb4ec9b401193fc29ec53ab8e54fca8","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"\u003cVirtualHost *:4448\u003e"},{"line_number":606,"context_line":"    ServerName {{ apache_server_name }}:8084"},{"line_number":607,"context_line":"    ServerAlias {{ apache_server_alias }}:8084"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    Use SSLConfig"},{"line_number":610,"context_line":"    Use AnsibleGalaxy 4448"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"a543993d_4bbff951","line":607,"range":{"start_line":607,"start_character":42,"end_line":607,"end_character":46},"in_reply_to":"5eaa6a02_9d11374c","updated":"2022-12-02 11:39:41.000000000","message":"Done","commit_id":"b84e843ac29bc0c99bba26e865876e8483b5e36b"}]}