)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3fa5907d79f3d5f2870911fb24874fbcd0d758b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1acc38ac_248480e6","updated":"2023-01-31 20:48:58.000000000","message":"This LGTM.  General \"does this work\" concerns are covered by testing, where it does work :)  We will want to watch for subtle runtime things due to the different openjdk build, but this is presumably unlikely to to be an issue.\n\nObviously we would like to work with upstream (Debian) in any way we can.  However, it seems we have a pretty decent escape-hatch to other officially built/maintained images like eclipse-temurin where we are on a recent-enough base container that we can just pull in their builds of openjdk, should we need to.","commit_id":"49c506ce1f1e17477d07db3f8f6922124cba0411"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c0ee14d5ee3458113bee8c5799ffb3a0da9a4037","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"397389b0_8e85d727","updated":"2023-02-01 19:34:32.000000000","message":"\u003e Patch Set 3: Code-Review+2\n\u003e \n\u003e Looks like that last revision was just a rebase? Or did other things change in it? Hard to tell, Gerrit at least didn\u0027t consider the rebase trivial.\n\nIt was a rebase to deal with the merge conflict between this change and https://review.opendev.org/c/opendev/system-config/+/872212 landing. C git treats this as trivial because the content matches but not jgit I guess.","commit_id":"c95726ed1e0e0d1321e4c8b60f05f12646270b18"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"adc022f2dfeda95e13172853d6d54cc1e33bf3b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"002d405c_0bebabd0","updated":"2023-02-01 20:38:21.000000000","message":"i think we wanted to run one more testing run with  870114 merged","commit_id":"c95726ed1e0e0d1321e4c8b60f05f12646270b18"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c1244ffed9d3d5b9d680cdfde07e6e7f884e97c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52625d0a_9af94fc0","updated":"2023-02-01 22:15:58.000000000","message":"recheck\n\nthis will now run with the upgrade test, and if it passes, i think we\u0027re good for images","commit_id":"c95726ed1e0e0d1321e4c8b60f05f12646270b18"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"261ce1571b20547de4f6d3c78bac864a6c20b8ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"32404f79_6b4fee2a","updated":"2023-02-01 20:37:41.000000000","message":"sorry yes +2 on this.  approving so the images are built; we will pull them in manually","commit_id":"c95726ed1e0e0d1321e4c8b60f05f12646270b18"}],"docker/gerrit/base/Dockerfile":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6cbd3f714344cb654bc2edde627b77fae695b434","unresolved":true,"context_lines":[{"line_number":25,"context_line":"RUN echo \u0027APT::Install-Recommends \"0\";\u0027 \u003e /etc/apt/apt.conf.d/95disable-recommends"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"RUN apt-get update \\"},{"line_number":28,"context_line":"  \u0026\u0026 apt-get install -y dumb-init git openjdk-11-jre-headless unzip \\"},{"line_number":29,"context_line":"  # This next set of installs helps align us with the old openjdk image \\"},{"line_number":30,"context_line":"  # but they may not all be necessary \\"},{"line_number":31,"context_line":"  \u0026\u0026 apt-get install -y xz-utils bzip2 wget curl gnupg \\"}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"3d36d0de_314e7a16","line":28,"range":{"start_line":28,"start_character":34,"end_line":28,"end_character":37},"updated":"2023-01-31 19:53:09.000000000","message":"Note this is important to ensure we\u0027re installing the latest patched version of git from debian. Our base images include git but it is somewhat stale.","commit_id":"49c506ce1f1e17477d07db3f8f6922124cba0411"}]}