)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7cfbfb69f40dd0bae78488985602a417f96cdb6e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"we want ot change the repliction config file."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note we did have this setting set at one time and it was removed in"},{"line_number":16,"context_line":"e7c6b7602609d14bc49eaca958bcdef788e861cf. This was due to replication"},{"line_number":17,"context_line":"events being dropped and gitea\u0027s not being kept in sync when the plugin"},{"line_number":18,"context_line":"updated its config. I think we can toggle this setting to true while we"},{"line_number":19,"context_line":"add do gitea server work and plan for the occasional manual full sync to"},{"line_number":20,"context_line":"ensure nothing gets missed. Then go back to having this set to false"},{"line_number":21,"context_line":"long term when we are done."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6a6d905b_0d3592b3","line":18,"range":{"start_line":16,"start_character":42,"end_line":18,"end_character":20},"updated":"2023-02-27 23:04:24.000000000","message":"Should we perhaps put a handler for the replication.conf.j2 file changing that triggers a full resync?  That would seem to avoid the problem?","commit_id":"982763cc1eb2c4942ac04b83496db22f6d54454f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0851859ac1648ff7956c4f5751e2142ae68c7943","unresolved":false,"context_lines":[{"line_number":13,"context_line":"we want ot change the repliction config file."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note we did have this setting set at one time and it was removed in"},{"line_number":16,"context_line":"e7c6b7602609d14bc49eaca958bcdef788e861cf. This was due to replication"},{"line_number":17,"context_line":"events being dropped and gitea\u0027s not being kept in sync when the plugin"},{"line_number":18,"context_line":"updated its config. I think we can toggle this setting to true while we"},{"line_number":19,"context_line":"add do gitea server work and plan for the occasional manual full sync to"},{"line_number":20,"context_line":"ensure nothing gets missed. Then go back to having this set to false"},{"line_number":21,"context_line":"long term when we are done."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"15fa2021_b32f6433","line":18,"range":{"start_line":16,"start_character":42,"end_line":18,"end_character":20},"in_reply_to":"2110632f_5773070f","updated":"2023-02-27 23:15:57.000000000","message":"SGTM; if we notice replication issues, we\u0027ve got a thread to pull on with this anyway","commit_id":"982763cc1eb2c4942ac04b83496db22f6d54454f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bc15ce2e7382d775a937802e4624244cb17136a4","unresolved":true,"context_lines":[{"line_number":13,"context_line":"we want ot change the repliction config file."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note we did have this setting set at one time and it was removed in"},{"line_number":16,"context_line":"e7c6b7602609d14bc49eaca958bcdef788e861cf. This was due to replication"},{"line_number":17,"context_line":"events being dropped and gitea\u0027s not being kept in sync when the plugin"},{"line_number":18,"context_line":"updated its config. I think we can toggle this setting to true while we"},{"line_number":19,"context_line":"add do gitea server work and plan for the occasional manual full sync to"},{"line_number":20,"context_line":"ensure nothing gets missed. Then go back to having this set to false"},{"line_number":21,"context_line":"long term when we are done."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2110632f_5773070f","line":18,"range":{"start_line":16,"start_character":42,"end_line":18,"end_character":20},"in_reply_to":"6a6d905b_0d3592b3","updated":"2023-02-27 23:13:45.000000000","message":"That would be one way to deal with it. I think that the followup change largely negates this concern though. I didn\u0027t squash them together because I think the mounting of volumes is worthy of review independent of config updates. But ya I think this may be a non concern with modern versions of the plugin as long as we persist the data directory.","commit_id":"982763cc1eb2c4942ac04b83496db22f6d54454f"}]}