)]}'
{"doc/source/gerrit.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d630079fdd7709979c6793289a414d4b0d594d4e","unresolved":true,"context_lines":[{"line_number":305,"context_line":"  [submit-requirement \"Code-Review\"]"},{"line_number":306,"context_line":"  description \u003d Code reviewed"},{"line_number":307,"context_line":"  submittableIf \u003d label:Code-Review\u003dMAX and -label:Code-Review\u003dMIN"},{"line_number":308,"context_line":"  canOverrideInChildProjects \u003d true"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  [label \"Verified\"]"},{"line_number":311,"context_line":"  function \u003d NoOp"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa2fa09e_c621d083","line":308,"range":{"start_line":308,"start_character":2,"end_line":308,"end_character":35},"updated":"2023-03-03 05:24:35.000000000","message":"Note it does seem that some projects want to override this; e.g.\n\nhttps://review.opendev.org/c/openstack/project-config/+/875804/4/gerrit/acls/opendev/infra-specs.config\n\nsets this to \"NoOp\".  Is that really it\u0027s intention?  I\u0027m not sure ... but we need it for backwards compat","commit_id":"60def8132a40f4bcdb5b22c9e49739a4fb799537"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8081ce7a6ef6a88273e575430554f92bd0cfe92d","unresolved":false,"context_lines":[{"line_number":305,"context_line":"  [submit-requirement \"Code-Review\"]"},{"line_number":306,"context_line":"  description \u003d Code reviewed"},{"line_number":307,"context_line":"  submittableIf \u003d label:Code-Review\u003dMAX and -label:Code-Review\u003dMIN"},{"line_number":308,"context_line":"  canOverrideInChildProjects \u003d true"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  [label \"Verified\"]"},{"line_number":311,"context_line":"  function \u003d NoOp"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9b1a5742_0e625128","line":308,"range":{"start_line":308,"start_character":2,"end_line":308,"end_character":35},"in_reply_to":"b9ba6710_f9a28cc2","updated":"2023-03-07 23:23:02.000000000","message":"Considering the number of projects allowing overrides should be fine.","commit_id":"60def8132a40f4bcdb5b22c9e49739a4fb799537"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"99b2948739cea09b370e8509314aee7b5245f6dd","unresolved":true,"context_lines":[{"line_number":305,"context_line":"  [submit-requirement \"Code-Review\"]"},{"line_number":306,"context_line":"  description \u003d Code reviewed"},{"line_number":307,"context_line":"  submittableIf \u003d label:Code-Review\u003dMAX and -label:Code-Review\u003dMIN"},{"line_number":308,"context_line":"  canOverrideInChildProjects \u003d true"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  [label \"Verified\"]"},{"line_number":311,"context_line":"  function \u003d NoOp"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b9ba6710_f9a28cc2","line":308,"range":{"start_line":308,"start_character":2,"end_line":308,"end_character":35},"in_reply_to":"f4c760d1_60dde581","updated":"2023-03-07 00:08:10.000000000","message":"There are actually 4 cases of this\n\n opendev/infra-specs.config\n openinfra/transparency-policy.config\n openstack/governance.config\n starlingx/governance.config\n \nLooking into the history of it a bit gets you back to https://review.opendev.org/c/openstack/project-config/+/185785\n\nThis was basically done so that openstack/governance.config could allow anyone to leave a +1/-1 code-review vote on a change with their thoughts, but then only the TC could add their separate TC votes to make the final tally on if it goes ahead or not.  It was up to the PTL to look at the TC tally votes and make the final decision.\n\nIf we removed the ability to override this, then the code-review would go back to MaxWithBlock semantics where TC members could leave a +2 or -2 code-review.  I think this would confuse the matter and be counter to what the original change was trying to do; which is make everyone\u0027s comment votes the same \"level\" and then keep the TC votes as a separate thing.\n\nWe could make the argument it is easier for us to manage gerrit without this type of override, so could you please just make do.  But since this has been working like this for a long time, I think that\u0027s probably going to be a tough argument.  On balance, I think we probably want to keep this?","commit_id":"60def8132a40f4bcdb5b22c9e49739a4fb799537"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2335d3e09bb6f2282bedcd83b7138831a185573a","unresolved":true,"context_lines":[{"line_number":305,"context_line":"  [submit-requirement \"Code-Review\"]"},{"line_number":306,"context_line":"  description \u003d Code reviewed"},{"line_number":307,"context_line":"  submittableIf \u003d label:Code-Review\u003dMAX and -label:Code-Review\u003dMIN"},{"line_number":308,"context_line":"  canOverrideInChildProjects \u003d true"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  [label \"Verified\"]"},{"line_number":311,"context_line":"  function \u003d NoOp"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f4c760d1_60dde581","line":308,"range":{"start_line":308,"start_character":2,"end_line":308,"end_character":35},"in_reply_to":"fa2fa09e_c621d083","updated":"2023-03-06 23:24:08.000000000","message":"FWIW if we really want to I think we can go ahead and break this in infra-specs. Basically force us to provide a code review and a rollcall vote together rather than just the roll call. That might be worth considering if infra-specs is the only case that needs this override set.","commit_id":"60def8132a40f4bcdb5b22c9e49739a4fb799537"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8081ce7a6ef6a88273e575430554f92bd0cfe92d","unresolved":true,"context_lines":[{"line_number":295,"context_line":"  [label \"Code-Review\"]"},{"line_number":296,"context_line":"  abbreviation \u003d R"},{"line_number":297,"context_line":"  copyCondition \u003d changekind:TRIVIAL_REBASE OR is:MIN"},{"line_number":298,"context_line":"  function \u003d NoOp"},{"line_number":299,"context_line":"  value \u003d -2 Do not merge"},{"line_number":300,"context_line":"  value \u003d -1 This patch needs further work before it can be merged"},{"line_number":301,"context_line":"  value \u003d 0 No score"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c50b4a46_9bb07cb6","line":298,"range":{"start_line":298,"start_character":13,"end_line":298,"end_character":17},"updated":"2023-03-07 23:23:02.000000000","message":"We are standardizing NoBlock so this should be updated.","commit_id":"ae2f4daef652478f51e54ae7b3ea334d27ae04fd"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c17bfb20a6a67a579c4abf881df30706b3ded443","unresolved":false,"context_lines":[{"line_number":295,"context_line":"  [label \"Code-Review\"]"},{"line_number":296,"context_line":"  abbreviation \u003d R"},{"line_number":297,"context_line":"  copyCondition \u003d changekind:TRIVIAL_REBASE OR is:MIN"},{"line_number":298,"context_line":"  function \u003d NoOp"},{"line_number":299,"context_line":"  value \u003d -2 Do not merge"},{"line_number":300,"context_line":"  value \u003d -1 This patch needs further work before it can be merged"},{"line_number":301,"context_line":"  value \u003d 0 No score"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3717b104_ba557bb4","line":298,"range":{"start_line":298,"start_character":13,"end_line":298,"end_character":17},"in_reply_to":"c50b4a46_9bb07cb6","updated":"2023-03-07 23:25:56.000000000","message":"Done","commit_id":"ae2f4daef652478f51e54ae7b3ea334d27ae04fd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"645b0a2758fc92ffe78becfab4f61fef2b20a5ca","unresolved":false,"context_lines":[{"line_number":295,"context_line":"  [label \"Code-Review\"]"},{"line_number":296,"context_line":"  abbreviation \u003d R"},{"line_number":297,"context_line":"  copyCondition \u003d changekind:TRIVIAL_REBASE OR is:MIN"},{"line_number":298,"context_line":"  function \u003d NoOp"},{"line_number":299,"context_line":"  value \u003d -2 Do not merge"},{"line_number":300,"context_line":"  value \u003d -1 This patch needs further work before it can be merged"},{"line_number":301,"context_line":"  value \u003d 0 No score"}],"source_content_type":"text/x-rst","patch_set":3,"id":"70621e8c_14389e55","line":298,"range":{"start_line":298,"start_character":13,"end_line":298,"end_character":17},"in_reply_to":"c50b4a46_9bb07cb6","updated":"2023-03-07 23:25:38.000000000","message":"Done","commit_id":"ae2f4daef652478f51e54ae7b3ea334d27ae04fd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8081ce7a6ef6a88273e575430554f92bd0cfe92d","unresolved":true,"context_lines":[{"line_number":308,"context_line":"  canOverrideInChildProjects \u003d true"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  [label \"Verified\"]"},{"line_number":311,"context_line":"  function \u003d NoOp"},{"line_number":312,"context_line":"  value \u003d -2 Fails"},{"line_number":313,"context_line":"  value \u003d -1 Doesn\u0027t seem to work"},{"line_number":314,"context_line":"  value \u003d 0 No score"}],"source_content_type":"text/x-rst","patch_set":3,"id":"712c4db3_c040da23","line":311,"updated":"2023-03-07 23:23:02.000000000","message":"See above.","commit_id":"ae2f4daef652478f51e54ae7b3ea334d27ae04fd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"645b0a2758fc92ffe78becfab4f61fef2b20a5ca","unresolved":false,"context_lines":[{"line_number":308,"context_line":"  canOverrideInChildProjects \u003d true"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  [label \"Verified\"]"},{"line_number":311,"context_line":"  function \u003d NoOp"},{"line_number":312,"context_line":"  value \u003d -2 Fails"},{"line_number":313,"context_line":"  value \u003d -1 Doesn\u0027t seem to work"},{"line_number":314,"context_line":"  value \u003d 0 No score"}],"source_content_type":"text/x-rst","patch_set":3,"id":"29c6f592_74f96969","line":311,"in_reply_to":"712c4db3_c040da23","updated":"2023-03-07 23:25:38.000000000","message":"Done","commit_id":"ae2f4daef652478f51e54ae7b3ea334d27ae04fd"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c17bfb20a6a67a579c4abf881df30706b3ded443","unresolved":false,"context_lines":[{"line_number":308,"context_line":"  canOverrideInChildProjects \u003d true"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  [label \"Verified\"]"},{"line_number":311,"context_line":"  function \u003d NoOp"},{"line_number":312,"context_line":"  value \u003d -2 Fails"},{"line_number":313,"context_line":"  value \u003d -1 Doesn\u0027t seem to work"},{"line_number":314,"context_line":"  value \u003d 0 No score"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5643094d_5515c37c","line":311,"in_reply_to":"712c4db3_c040da23","updated":"2023-03-07 23:25:56.000000000","message":"Done","commit_id":"ae2f4daef652478f51e54ae7b3ea334d27ae04fd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8081ce7a6ef6a88273e575430554f92bd0cfe92d","unresolved":true,"context_lines":[{"line_number":320,"context_line":"  submittableIf \u003d label:Verified\u003dMAX and -label:Verified\u003dMIN"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  [label \"Workflow\"]"},{"line_number":323,"context_line":"  function \u003d NoOp"},{"line_number":324,"context_line":"  value \u003d -1 Work in progress"},{"line_number":325,"context_line":"  value \u003d 0 Ready for reviews"},{"line_number":326,"context_line":"  value \u003d +1 Approved"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ae5c987d_e690675d","line":323,"updated":"2023-03-07 23:23:02.000000000","message":"See above.","commit_id":"ae2f4daef652478f51e54ae7b3ea334d27ae04fd"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c17bfb20a6a67a579c4abf881df30706b3ded443","unresolved":false,"context_lines":[{"line_number":320,"context_line":"  submittableIf \u003d label:Verified\u003dMAX and -label:Verified\u003dMIN"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  [label \"Workflow\"]"},{"line_number":323,"context_line":"  function \u003d NoOp"},{"line_number":324,"context_line":"  value \u003d -1 Work in progress"},{"line_number":325,"context_line":"  value \u003d 0 Ready for reviews"},{"line_number":326,"context_line":"  value \u003d +1 Approved"}],"source_content_type":"text/x-rst","patch_set":3,"id":"77904d60_0584d822","line":323,"in_reply_to":"ae5c987d_e690675d","updated":"2023-03-07 23:25:56.000000000","message":"Done","commit_id":"ae2f4daef652478f51e54ae7b3ea334d27ae04fd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"645b0a2758fc92ffe78becfab4f61fef2b20a5ca","unresolved":false,"context_lines":[{"line_number":320,"context_line":"  submittableIf \u003d label:Verified\u003dMAX and -label:Verified\u003dMIN"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  [label \"Workflow\"]"},{"line_number":323,"context_line":"  function \u003d NoOp"},{"line_number":324,"context_line":"  value \u003d -1 Work in progress"},{"line_number":325,"context_line":"  value \u003d 0 Ready for reviews"},{"line_number":326,"context_line":"  value \u003d +1 Approved"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dcab0b7f_2b7bbe0c","line":323,"in_reply_to":"ae5c987d_e690675d","updated":"2023-03-07 23:25:38.000000000","message":"Done","commit_id":"ae2f4daef652478f51e54ae7b3ea334d27ae04fd"}]}