)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e7fdd2cb0c5270b1443db86cc2981d68cf0e9326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"68c4652c_3ed4e52a","updated":"2023-04-21 02:04:46.000000000","message":"recheck","commit_id":"0a0ca77f3b092ac7995267219acd72b59009e3c9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"269c73bd2164b3a4b170093af806359415e63b28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7cd51ca5_c1957b95","updated":"2023-04-21 05:02:34.000000000","message":"recheck","commit_id":"0a0ca77f3b092ac7995267219acd72b59009e3c9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6847033d05ab5b2ee9f11be0d13570075956fc67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"50585f2b_69db7a36","updated":"2023-04-21 00:03:59.000000000","message":"will montior as this deploys, but it should be a no-op","commit_id":"0a0ca77f3b092ac7995267219acd72b59009e3c9"}],"playbooks/roles/letsencrypt-install-txt-record/templates/zone.db.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b5fb4b936a3c092eb1c49da4de5e512a278fbfeb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"; -*- mode: zone -*-"},{"line_number":2,"context_line":"$ORIGIN acme.opendev.org."},{"line_number":3,"context_line":"$TTL 1m"},{"line_number":4,"context_line":"@               IN      SOA     {{ inventory_hostname }} hostmaster.opendev.org. ("},{"line_number":5,"context_line":"                        {{ lookup(\u0027pipe\u0027, \u0027date +%s\u0027) }}  ; serial number unixtime"},{"line_number":6,"context_line":"                        1h          ; refresh (secondary checks for updates)"},{"line_number":7,"context_line":"                        10m         ; retry   (secondary retries failed axfr)"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"673eff66_c5924908","line":4,"updated":"2023-04-18 16:31:30.000000000","message":"`{{ inventory_hostname }}` needs to be followed by a `.`\n\nSeparately, does this have implications when we update this in production to switch to adns2? In particular we will end up with two different SOA records one on adns1 claiming it is the authority and one on adns2 claiming it is the authority. When we switch to having adns2 sync to nsXY the record will update publicly. Do we need to do this in conjunction with the registrar as well?","commit_id":"05bccac73407b92fc323ca585c773d8fc1d77e42"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4853e7d04172ea15a20c6df355687d07318ad082","unresolved":false,"context_lines":[{"line_number":1,"context_line":"; -*- mode: zone -*-"},{"line_number":2,"context_line":"$ORIGIN acme.opendev.org."},{"line_number":3,"context_line":"$TTL 1m"},{"line_number":4,"context_line":"@               IN      SOA     {{ inventory_hostname }} hostmaster.opendev.org. ("},{"line_number":5,"context_line":"                        {{ lookup(\u0027pipe\u0027, \u0027date +%s\u0027) }}  ; serial number unixtime"},{"line_number":6,"context_line":"                        1h          ; refresh (secondary checks for updates)"},{"line_number":7,"context_line":"                        10m         ; retry   (secondary retries failed axfr)"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"caad48a8_be86161f","line":4,"in_reply_to":"673eff66_c5924908","updated":"2023-04-18 23:18:59.000000000","message":"As discussed in #opendev, this field in the SOA record isn\u0027t really used with our model of primary notifying secondary servers.  So I think the most correct thing to do is stamp in the host that this record was generated on, which this will do.\n\nTo confirm, nothing related with this needs to be switched in the registrar","commit_id":"05bccac73407b92fc323ca585c773d8fc1d77e42"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b5fb4b936a3c092eb1c49da4de5e512a278fbfeb","unresolved":true,"context_lines":[{"line_number":8,"context_line":"                        10d         ; expire  (secondary ends serving old data)"},{"line_number":9,"context_line":"                        5m  )       ; min ttl (cache time for failed lookups)"},{"line_number":10,"context_line":"{% for ns in groups[\u0027adns-secondary\u0027] %}"},{"line_number":11,"context_line":"@               IN      NS      {{ ns }}"},{"line_number":12,"context_line":"{% endfor %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"; NOTE: DO NOT HAND EDIT.  THESE KEYS ARE MANAGED BY ANSIBLE"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bec42d03_730f187e","line":11,"updated":"2023-04-18 16:31:30.000000000","message":"`{{ ns }}` needs to be followed by a `.`","commit_id":"05bccac73407b92fc323ca585c773d8fc1d77e42"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b4a360813d524e640ad1506162d18a682144d0d7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"                        10d         ; expire  (secondary ends serving old data)"},{"line_number":9,"context_line":"                        5m  )       ; min ttl (cache time for failed lookups)"},{"line_number":10,"context_line":"{% for ns in groups[\u0027adns-secondary\u0027] %}"},{"line_number":11,"context_line":"@               IN      NS      {{ ns }}"},{"line_number":12,"context_line":"{% endfor %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"; NOTE: DO NOT HAND EDIT.  THESE KEYS ARE MANAGED BY ANSIBLE"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3b48c0d8_43aaa555","line":11,"in_reply_to":"bec42d03_730f187e","updated":"2023-04-18 23:27:40.000000000","message":"Done","commit_id":"05bccac73407b92fc323ca585c773d8fc1d77e42"}],"zuul.d/system-config-run.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"44bbfe25cb5a54413e13376a570192255f077dc6","unresolved":true,"context_lines":[{"line_number":225,"context_line":"    name: system-config-run-letsencrypt"},{"line_number":226,"context_line":"    parent: system-config-run"},{"line_number":227,"context_line":"    description: |"},{"line_number":228,"context_line":"      Run the playbook for letsencrypt key acquisition"},{"line_number":229,"context_line":"    nodeset:"},{"line_number":230,"context_line":"      nodes:"},{"line_number":231,"context_line":"        - \u003c\u003c: *bridge_node_x86"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6c20b7ee_cdbdccae","line":228,"updated":"2023-04-18 07:26:56.000000000","message":"nit: you added the trailing . in the parent review, might want to keep it here","commit_id":"05bccac73407b92fc323ca585c773d8fc1d77e42"}]}