)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f9963a9afd6acf574b39f0e6cabd54df6d733f75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4d295115_23bb0f5c","updated":"2023-04-18 23:02:29.000000000","message":"lgtm once we append to the logfile","commit_id":"b8b906b123dc917100047b02b70ff943c8b97027"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0a8ee0166153cad9b5f54a6cb474e3c07e18ccf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0515c4c2_8922cc90","updated":"2023-05-09 19:47:27.000000000","message":"Makes sense to me.\n\nThanks.","commit_id":"6756f651b5462bed6a6d1084822b40ff9c281f9f"}],"playbooks/roles/gerrit/tasks/main.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"93c2fab1361be4c43db773de968dd10ceccc81c6","unresolved":true,"context_lines":[{"line_number":339,"context_line":"    user: root"},{"line_number":340,"context_line":"    job: \u003e"},{"line_number":341,"context_line":"      /usr/local/bin/docker-compose -f /etc/gerrit-compose/docker-compose.yaml"},{"line_number":342,"context_line":"      run -T shell"},{"line_number":343,"context_line":"      python3 /cleanup-replication-tasks.py"},{"line_number":344,"context_line":"      \u003e /var/log/cleanup-replication-tasks.log 2\u003e\u00261"},{"line_number":345,"context_line":"    minute: 43"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e9f3b005_7705a85f","line":342,"updated":"2023-04-17 23:01:47.000000000","message":"In other places we\u0027ve used \"exec\" to do this from the running container; which probably works here.  But if we do want to run, I think we want to make sure to use --rm to get rid of the container?","commit_id":"dac54aac474dba38e76c86b42ba43e093ef4ab66"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d3b26c60fe07ad5e3d0543dd5308505859d48e0c","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    user: root"},{"line_number":340,"context_line":"    job: \u003e"},{"line_number":341,"context_line":"      /usr/local/bin/docker-compose -f /etc/gerrit-compose/docker-compose.yaml"},{"line_number":342,"context_line":"      run -T shell"},{"line_number":343,"context_line":"      python3 /cleanup-replication-tasks.py"},{"line_number":344,"context_line":"      \u003e /var/log/cleanup-replication-tasks.log 2\u003e\u00261"},{"line_number":345,"context_line":"    minute: 43"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"70f1d67a_bca506e9","line":342,"in_reply_to":"336ee9a1_63305e3d","updated":"2023-04-18 00:29:39.000000000","message":"As discussed in IRC we think that \"rm\" does leave the container around, but probably \"docker-compose down\" clears out old containers for us, hiding that when we do upgrades, etc.  But with a daily cron job, the explicit --rm seems appropriate.","commit_id":"dac54aac474dba38e76c86b42ba43e093ef4ab66"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fe63d71803527dab4b9780b7d54c3339f6b0fcd2","unresolved":true,"context_lines":[{"line_number":339,"context_line":"    user: root"},{"line_number":340,"context_line":"    job: \u003e"},{"line_number":341,"context_line":"      /usr/local/bin/docker-compose -f /etc/gerrit-compose/docker-compose.yaml"},{"line_number":342,"context_line":"      run -T shell"},{"line_number":343,"context_line":"      python3 /cleanup-replication-tasks.py"},{"line_number":344,"context_line":"      \u003e /var/log/cleanup-replication-tasks.log 2\u003e\u00261"},{"line_number":345,"context_line":"    minute: 43"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"336ee9a1_63305e3d","line":342,"in_reply_to":"e9f3b005_7705a85f","updated":"2023-04-17 23:09:22.000000000","message":"This is a special case because our docker compose file defines the shell container as a container that mimics the gerrit container without actually running gerrit. We don\u0027t currently rm it today and it is defined on the host. I think if we want to clean that up we should do that in a followup?","commit_id":"dac54aac474dba38e76c86b42ba43e093ef4ab66"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f9963a9afd6acf574b39f0e6cabd54df6d733f75","unresolved":true,"context_lines":[{"line_number":341,"context_line":"      /usr/local/bin/docker-compose -f /etc/gerrit-compose/docker-compose.yaml"},{"line_number":342,"context_line":"      run --rm -T shell"},{"line_number":343,"context_line":"      python3 /cleanup-replication-tasks.py"},{"line_number":344,"context_line":"      \u003e /var/log/cleanup-replication-tasks.log 2\u003e\u00261"},{"line_number":345,"context_line":"    minute: 43"},{"line_number":346,"context_line":"    hour: 22"},{"line_number":347,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"20dc8e0d_523ea4a7","line":344,"updated":"2023-04-18 23:02:29.000000000","message":"We probably want this to be \u003e\u003e","commit_id":"b8b906b123dc917100047b02b70ff943c8b97027"}]}