)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"400fd57151b6b4911384e5a1fe3c0c3718ddedc6","unresolved":true,"context_lines":[{"line_number":67,"context_line":" * Rewrite logger system (#24726)"},{"line_number":68,"context_line":"   * They made changes to the loggers and encourage people to check"},{"line_number":69,"context_line":"     their logs work as expected when upgrading."},{"line_number":70,"context_line":"     TODO check logs."},{"line_number":71,"context_line":" * Increase default LFS auth timeout from 20m to 24h (#24628)"},{"line_number":72,"context_line":"   * We don\u0027t LFS but can change the timeout if necssary."},{"line_number":73,"context_line":" * Rewrite queue (#24505)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"60916ebc_37df5ed1","line":70,"updated":"2023-07-20 22:59:01.000000000","message":"The logs look fine to me? I don\u0027t think we need to compare against 1.19 as long as we are happy with what they currently produce.","commit_id":"d23b585fdec6698c21d6904885f9be962e460b6b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"400fd57151b6b4911384e5a1fe3c0c3718ddedc6","unresolved":true,"context_lines":[{"line_number":72,"context_line":"   * We don\u0027t LFS but can change the timeout if necssary."},{"line_number":73,"context_line":" * Rewrite queue (#24505)"},{"line_number":74,"context_line":"   * TODO check for \u0027Removed queue option:\u0027 log entries and clean up"},{"line_number":75,"context_line":"     corresponding entries in app.ini."},{"line_number":76,"context_line":" * Remove unused setting time.FORMAT (#24430)"},{"line_number":77,"context_line":"   * We didn\u0027t have this entry in app.ini."},{"line_number":78,"context_line":" * Refactor setting.Other and remove unused SHOW_FOOTER_BRANDING (#24270)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9dfff544_a3f0ceb2","line":75,"updated":"2023-07-20 22:59:01.000000000","message":"This `Removed queue option:` string does not show up in the logs created by our test instance. I think this one is fine.","commit_id":"d23b585fdec6698c21d6904885f9be962e460b6b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"400fd57151b6b4911384e5a1fe3c0c3718ddedc6","unresolved":true,"context_lines":[{"line_number":78,"context_line":" * Refactor setting.Other and remove unused SHOW_FOOTER_BRANDING (#24270)"},{"line_number":79,"context_line":"   * This setting can be removed from app.ini, but we don\u0027t set it."},{"line_number":80,"context_line":" * Correct the access log format (#24085)"},{"line_number":81,"context_line":"   * TODO check the access log format for approprate escaping."},{"line_number":82,"context_line":" * Reserve \".png\" suffix for user/org names (#23992)"},{"line_number":83,"context_line":"   * .png is no longer a valid user/org name (it didn\u0027t work before"},{"line_number":84,"context_line":"     anyway)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"646a6227_cdc46024","line":81,"updated":"2023-07-20 22:59:01.000000000","message":"I think we need to update our jobs to collect logs from /var/gitea/gitea/logs or whatever the path is. The access logs go there and not into the docker container log collection system.","commit_id":"d23b585fdec6698c21d6904885f9be962e460b6b"}],"docker/gitea/custom/templates/custom/header.tmpl":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"65add8178af91a586cc133446c706507f589a8aa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003cmeta name\u003d\"theme-color\" content\u003d\"#ee265e\"/\u003e"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"b4fadcfa_947f69c0","line":1,"updated":"2023-08-16 20:31:24.000000000","message":"This doesn\u0027t seem to be working with my phone on the heald test node for patchset 15. I did double check it works with production and it does.\n\nThat said it defaults to the dark theme on my phone in both testing and prod and neither respect the theme-color in that situation. It is only used when using a light theme overall.","commit_id":"2976008d8be9eb3ede368db1fb9d0b07af99afa8"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4060ad3f5742ff21cfa445d247fc50d27084a192","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003cmeta name\u003d\"theme-color\" content\u003d\"#ee265e\"/\u003e"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"3ad90634_c1270884","line":1,"in_reply_to":"b4fadcfa_947f69c0","updated":"2023-08-16 20:56:30.000000000","message":"Apparently, this is expected because chrome only honors theme-color when valid ssl is used. Our test nodes don\u0027t have valid certs which would make it not work. I have manually checked the resulting html and cross checked against production and I think this is correct and will work when we go to production.","commit_id":"2976008d8be9eb3ede368db1fb9d0b07af99afa8"}],"playbooks/test-gitea.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8e5ce5ea8b1ae7db24583933755424960e2f6862","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  tasks:"},{"line_number":68,"context_line":"    - name: Make gitea access logs readable by zuul for log collection"},{"line_number":69,"context_line":"      file:"},{"line_number":70,"context_line":"        path: /var/gitea/logs/access.log"},{"line_number":71,"context_line":"        mode: o+r"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# This is conveniently left here so that it can be uncommented in order to"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f505987d_2a96de61","line":70,"updated":"2023-07-25 02:32:32.000000000","message":"This file exists on gitea09 but not the test instance according to the failed job log. May need to hold a node.","commit_id":"dedebc3ed411022dde532595c7cf5259c4837690"}]}