)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"250c41cebf483e121d48cb7e1653fb0bf35d4e44","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://github.com/ether/etherpad-lite/blob/v1.9.3/CHANGELOG.md#193"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There doesn\u0027t appear to be anything relebant to our deployment in"},{"line_number":14,"context_line":"this update, but upgrading now will reduce future deltas."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic1629bf8cb140c33a641e1c613d43e8a9d4d0f1e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d780ae6e_3929b83a","line":13,"range":{"start_line":13,"start_character":36,"end_line":13,"end_character":44},"updated":"2023-09-25 18:16:52.000000000","message":"nit: relevant","commit_id":"04e2433fab14a74b52adba5b5cd33b376df5ae7b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0b777b74c846a6e4e7baf27da9eb6f339404b218","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://github.com/ether/etherpad-lite/blob/v1.9.3/CHANGELOG.md#193"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There doesn\u0027t appear to be anything relebant to our deployment in"},{"line_number":14,"context_line":"this update, but upgrading now will reduce future deltas."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic1629bf8cb140c33a641e1c613d43e8a9d4d0f1e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c90424bd_a9322c6c","line":13,"range":{"start_line":13,"start_character":36,"end_line":13,"end_character":44},"in_reply_to":"d780ae6e_3929b83a","updated":"2023-11-01 18:37:39.000000000","message":"Done","commit_id":"04e2433fab14a74b52adba5b5cd33b376df5ae7b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5065244bb21bb82ecd730418e943a69e51137157","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca72b373_c46bf54e","updated":"2023-11-01 17:40:31.000000000","message":"Most of my concerns are inline. -1 for the database settings item in particular.\n\nI think we should consider making this update on the existing etherpad version decoupling it from the upgrade. Basically update configs. Deploy, ensure all is well, then upgrade. Not sure this is possible but I think that will reduce a lot of the potential for confusing breakage due to the moving parts here.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"}],"playbooks/roles/etherpad/templates/settings.json.j2":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"9b9ce0958653b1ec1d773fe69d71f7206914586b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"   * \"full-width-editor\" variant (by default editor is rendered as a page, with"},{"line_number":141,"context_line":"   * a max-width of 900px)."},{"line_number":142,"context_line":"   */"},{"line_number":143,"context_line":"  \"skinVariants\": \"super-light-toolbar super-light-editor light-background\","},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  /*"},{"line_number":146,"context_line":"   * IP and port which Etherpad should bind at."}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"f87f1396_33c05562","line":143,"updated":"2023-11-01 17:52:51.000000000","message":"Does it even get used though? I\u0027d prefer not to comment out upstream lines in cases where they\u0027re a no-op for us, since that\u0027s just more divergence we need to track.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5065244bb21bb82ecd730418e943a69e51137157","unresolved":true,"context_lines":[{"line_number":140,"context_line":"   * \"full-width-editor\" variant (by default editor is rendered as a page, with"},{"line_number":141,"context_line":"   * a max-width of 900px)."},{"line_number":142,"context_line":"   */"},{"line_number":143,"context_line":"  \"skinVariants\": \"super-light-toolbar super-light-editor light-background\","},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  /*"},{"line_number":146,"context_line":"   * IP and port which Etherpad should bind at."}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"821188d2_8c970032","line":143,"updated":"2023-11-01 17:40:31.000000000","message":"I think this value should be commented out because we use no-skin instead of colibris.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0b777b74c846a6e4e7baf27da9eb6f339404b218","unresolved":true,"context_lines":[{"line_number":140,"context_line":"   * \"full-width-editor\" variant (by default editor is rendered as a page, with"},{"line_number":141,"context_line":"   * a max-width of 900px)."},{"line_number":142,"context_line":"   */"},{"line_number":143,"context_line":"  \"skinVariants\": \"super-light-toolbar super-light-editor light-background\","},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  /*"},{"line_number":146,"context_line":"   * IP and port which Etherpad should bind at."}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"128ac9cf_3650e880","line":143,"in_reply_to":"821188d2_8c970032","updated":"2023-11-01 18:37:39.000000000","message":"We\u0027ll test and see if this has any impact on no-skin usage. If not we can leave it to reduce the size of our diff to upstream configs.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"9b9ce0958653b1ec1d773fe69d71f7206914586b","unresolved":false,"context_lines":[{"line_number":199,"context_line":"  \"dbType\": \"dirty\","},{"line_number":200,"context_line":"  \"dbSettings\": {"},{"line_number":201,"context_line":"    \"filename\": \"var/dirty.db\""},{"line_number":202,"context_line":"  },"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"  /*"},{"line_number":205,"context_line":"   * An Example of MySQL Configuration (commented out)."}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"d3bba55d_aa418e0f","line":202,"updated":"2023-11-01 17:52:51.000000000","message":"Aha! I missed that the mysql version below is inside a comment block. That\u0027s what I get for relying on line-by-line diffing. *sigh*","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5065244bb21bb82ecd730418e943a69e51137157","unresolved":true,"context_lines":[{"line_number":199,"context_line":"  \"dbType\": \"dirty\","},{"line_number":200,"context_line":"  \"dbSettings\": {"},{"line_number":201,"context_line":"    \"filename\": \"var/dirty.db\""},{"line_number":202,"context_line":"  },"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"  /*"},{"line_number":205,"context_line":"   * An Example of MySQL Configuration (commented out)."}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"587d707d_83076d90","line":202,"updated":"2023-11-01 17:40:31.000000000","message":"This local db needs to be commented out.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0b777b74c846a6e4e7baf27da9eb6f339404b218","unresolved":false,"context_lines":[{"line_number":199,"context_line":"  \"dbType\": \"dirty\","},{"line_number":200,"context_line":"  \"dbSettings\": {"},{"line_number":201,"context_line":"    \"filename\": \"var/dirty.db\""},{"line_number":202,"context_line":"  },"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"  /*"},{"line_number":205,"context_line":"   * An Example of MySQL Configuration (commented out)."}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"664eb832_3982d9b6","line":202,"in_reply_to":"587d707d_83076d90","updated":"2023-11-01 18:37:39.000000000","message":"Done","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5065244bb21bb82ecd730418e943a69e51137157","unresolved":true,"context_lines":[{"line_number":217,"context_line":"    \"database\": \"etherpad-lite\","},{"line_number":218,"context_line":"    \"charset\":  \"utf8mb4\""},{"line_number":219,"context_line":"  },"},{"line_number":220,"context_line":"  */"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  /*"},{"line_number":223,"context_line":"   * The default text of a pad"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ca45dd97_6ed4610e","line":220,"updated":"2023-11-01 17:40:31.000000000","message":"The mysql db needs to be uncommented so that we use mysql.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0b777b74c846a6e4e7baf27da9eb6f339404b218","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    \"database\": \"etherpad-lite\","},{"line_number":218,"context_line":"    \"charset\":  \"utf8mb4\""},{"line_number":219,"context_line":"  },"},{"line_number":220,"context_line":"  */"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  /*"},{"line_number":223,"context_line":"   * The default text of a pad"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"66ad5679_36d44f75","line":220,"in_reply_to":"ca45dd97_6ed4610e","updated":"2023-11-01 18:37:39.000000000","message":"Done","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"9b9ce0958653b1ec1d773fe69d71f7206914586b","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  \"defaultPadText\" : \"Welcome to OpenDev Etherpad!\\n\\nThis pad text is synchronized as you type, so that everyone viewing this page sees the same text. This allows you to collaborate seamlessly on documents!\\n\\nOpenDev: https://opendev.org\\nEtherpad on Github: https://github.com/ether/etherpad-lite\\n\","},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"  /*"},{"line_number":228,"context_line":"   * Default Pad behavior."},{"line_number":229,"context_line":"   *"},{"line_number":230,"context_line":"   * Change them if you want to override."},{"line_number":231,"context_line":"   */"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"8f42a79d_bd37f78f","line":228,"updated":"2023-11-01 17:52:51.000000000","message":"Probably we should explicitly document each change we make. I\u0027m mainly wanting to future-proof this so that it\u0027s easier to compare the upstream version to ours for subsequent versions.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5065244bb21bb82ecd730418e943a69e51137157","unresolved":true,"context_lines":[{"line_number":225,"context_line":"  \"defaultPadText\" : \"Welcome to OpenDev Etherpad!\\n\\nThis pad text is synchronized as you type, so that everyone viewing this page sees the same text. This allows you to collaborate seamlessly on documents!\\n\\nOpenDev: https://opendev.org\\nEtherpad on Github: https://github.com/ether/etherpad-lite\\n\","},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"  /*"},{"line_number":228,"context_line":"   * Default Pad behavior."},{"line_number":229,"context_line":"   *"},{"line_number":230,"context_line":"   * Change them if you want to override."},{"line_number":231,"context_line":"   */"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a83be5b5_adaddd4c","line":228,"updated":"2023-11-01 17:40:31.000000000","message":"We do change these so we aren\u0027t using defaults. maybe comment out the defaults then set out values below.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0b777b74c846a6e4e7baf27da9eb6f339404b218","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  \"defaultPadText\" : \"Welcome to OpenDev Etherpad!\\n\\nThis pad text is synchronized as you type, so that everyone viewing this page sees the same text. This allows you to collaborate seamlessly on documents!\\n\\nOpenDev: https://opendev.org\\nEtherpad on Github: https://github.com/ether/etherpad-lite\\n\","},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"  /*"},{"line_number":228,"context_line":"   * Default Pad behavior."},{"line_number":229,"context_line":"   *"},{"line_number":230,"context_line":"   * Change them if you want to override."},{"line_number":231,"context_line":"   */"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0b4483c4_7b0a60a7","line":228,"in_reply_to":"a83be5b5_adaddd4c","updated":"2023-11-01 18:37:39.000000000","message":"Done","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5065244bb21bb82ecd730418e943a69e51137157","unresolved":true,"context_lines":[{"line_number":335,"context_line":"   * Allow import of file types other than the supported ones:"},{"line_number":336,"context_line":"   * txt, doc, docx, rtf, odt, html \u0026 htm"},{"line_number":337,"context_line":"   */"},{"line_number":338,"context_line":"  \"allowUnknownFileEnds\": true,"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"  /*"},{"line_number":341,"context_line":"   * This setting is used if you require authentication of all users."}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7c1c1c0a_a4207eb7","line":338,"updated":"2023-11-01 17:40:31.000000000","message":"I\u0027m tempted to set this one to false now that I see it again. But I think that would be a divergence so maybe best as a followup.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"9b9ce0958653b1ec1d773fe69d71f7206914586b","unresolved":false,"context_lines":[{"line_number":513,"context_line":"   * WARNING: passwords should not be stored in plaintext in this file."},{"line_number":514,"context_line":"   *          If you want to mitigate this, please install ep_hash_auth and"},{"line_number":515,"context_line":"   *          follow the section \"secure your installation\" in README.md"},{"line_number":516,"context_line":"   */"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"  /*"},{"line_number":519,"context_line":"  \"users\": {"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7827a79f_c9c6e795","line":516,"updated":"2023-11-01 17:52:51.000000000","message":"Except we already had it commented out, right?","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5065244bb21bb82ecd730418e943a69e51137157","unresolved":true,"context_lines":[{"line_number":513,"context_line":"   * WARNING: passwords should not be stored in plaintext in this file."},{"line_number":514,"context_line":"   *          If you want to mitigate this, please install ep_hash_auth and"},{"line_number":515,"context_line":"   *          follow the section \"secure your installation\" in README.md"},{"line_number":516,"context_line":"   */"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"  /*"},{"line_number":519,"context_line":"  \"users\": {"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9bf28516_6d998d86","line":516,"updated":"2023-11-01 17:40:31.000000000","message":"The old comment said that if you don\u0027t uncomment this /admin is not available. That is the behavior we want. I wonder if it is still the case.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5065244bb21bb82ecd730418e943a69e51137157","unresolved":true,"context_lines":[{"line_number":535,"context_line":"  /*"},{"line_number":536,"context_line":"   * Restrict socket.io transport methods"},{"line_number":537,"context_line":"   */"},{"line_number":538,"context_line":"  \"socketTransportProtocols\" : [\"websocket\", \"xhr-polling\", \"jsonp-polling\", \"htmlfile\"],"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"  \"socketIo\": {"},{"line_number":541,"context_line":"    /*"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"c8f81d9e_984c0c3e","line":538,"updated":"2023-11-01 17:40:31.000000000","message":"As another followup we should consider dropping \"websocket\" and see if that works to be better aligned with upstream.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0b777b74c846a6e4e7baf27da9eb6f339404b218","unresolved":false,"context_lines":[{"line_number":535,"context_line":"  /*"},{"line_number":536,"context_line":"   * Restrict socket.io transport methods"},{"line_number":537,"context_line":"   */"},{"line_number":538,"context_line":"  \"socketTransportProtocols\" : [\"websocket\", \"xhr-polling\", \"jsonp-polling\", \"htmlfile\"],"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"  \"socketIo\": {"},{"line_number":541,"context_line":"    /*"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3ae29a76_2b7644dc","line":538,"in_reply_to":"c8f81d9e_984c0c3e","updated":"2023-11-01 18:37:39.000000000","message":"According to the comment here this was added for jitsi meet integration.","commit_id":"655edec7ded18738b6b25db2f8e9c9da3f78cbc7"}]}