)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04be4f184326c5a73d10666995dcf7c8782555ee","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a helper script for doing the LVM setup on mirror nodes."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Mirror nodes have an atypical LVN setup.  In that the volume, once"},{"line_number":10,"context_line":"visible to the guest, is split between 2 equal volumes for proxy and"},{"line_number":11,"context_line":"afs caches."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"8e1594ba_486e8f32","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":33},"updated":"2023-11-30 21:17:44.000000000","message":"nit: LVM","commit_id":"54665c4660bf2a3b57b06eb474def949c4314e49"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"aef7807c60e1ee6e24351e51df3f1f1eb983787c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"27d96ff5_294b5872","updated":"2023-11-21 18:29:43.000000000","message":"Opps mixing up chnages","commit_id":"2a0a205981b83bd15fe0d27b4f3de64fce9ccd1e"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5bda0b9f_683307cf","updated":"2023-11-27 18:20:02.000000000","message":"new patchset incoming","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"119e4b47_8a8cbb27","updated":"2023-11-22 05:50:58.000000000","message":"nice script, just some small bits for discussion","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04be4f184326c5a73d10666995dcf7c8782555ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"22d02988_ae2d5e47","updated":"2023-11-30 21:17:44.000000000","message":"some comments, but also fine to merge as-is if you prefer","commit_id":"54665c4660bf2a3b57b06eb474def949c4314e49"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"bff50940c08a17d5f958555e352ed5ce8b8072b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7916b8df_f697ea0b","updated":"2024-05-02 23:22:54.000000000","message":"I held off approving this until I\u0027d addressed the review feedback.","commit_id":"5684a75119418b52c52158515be0544266730c92"}],"launch/src/opendev_launch/mirror_volumes.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4a42806510b58a9bbd58be651449aea04bb62b3c","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    echo \"NOTE: This script doesn\u0027t need to know the full size of the volume\""},{"line_number":28,"context_line":"    echo \"\""},{"line_number":29,"context_line":"    echo \"Example invokation:\""},{"line_number":30,"context_line":"    echo \"# $(basename $0) -d /dev/sdb -g main -v afscache:50%VG:/var/cache/openafs -v proxycache:50%VG:/var/cache/apache2\""},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"d629d5ef_06ec94a6","line":30,"updated":"2023-11-20 22:00:28.000000000","message":"Will this example create the first volume at 50% of total space then the second at 25% because it will do 50% of the remaining space?","commit_id":"23c10375151cd36ea44c706e5e5055665b129315"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"28daa66aa2311d02b3faf9a9aca43c9baa1452d9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    echo \"NOTE: This script doesn\u0027t need to know the full size of the volume\""},{"line_number":28,"context_line":"    echo \"\""},{"line_number":29,"context_line":"    echo \"Example invokation:\""},{"line_number":30,"context_line":"    echo \"# $(basename $0) -d /dev/sdb -g main -v afscache:50%VG:/var/cache/openafs -v proxycache:50%VG:/var/cache/apache2\""},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"09fb555a_f203f348","line":30,"in_reply_to":"0dcc6dfb_9afb3f47","updated":"2023-11-20 22:10:37.000000000","message":"Acknowledged","commit_id":"23c10375151cd36ea44c706e5e5055665b129315"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"b5db18f9ca28ce66735170552c9144ee3c021c78","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    echo \"NOTE: This script doesn\u0027t need to know the full size of the volume\""},{"line_number":28,"context_line":"    echo \"\""},{"line_number":29,"context_line":"    echo \"Example invokation:\""},{"line_number":30,"context_line":"    echo \"# $(basename $0) -d /dev/sdb -g main -v afscache:50%VG:/var/cache/openafs -v proxycache:50%VG:/var/cache/apache2\""},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"0dcc6dfb_9afb3f47","line":30,"in_reply_to":"d629d5ef_06ec94a6","updated":"2023-11-20 22:08:12.000000000","message":"It\u0027s using 50%VG which should make 2 LVs each 50% of the *total* space in the volume.  We used 50% which is 50%FREE and would create the situation you ask about.\n\n\nBeacuse I can\u0027t find a good site that will let me link directly to the spot.\nFrom: https://man7.org/linux/man-pages/man8/lvcreate.8.html\n\n       -l|--extents Number[PERCENT]\n              Specifies the size of the new LV in logical extents.  The\n              --size and --extents options are alternate methods of\n              specifying size.  The total number of physical extents\n              used will be greater when redundant data is needed for\n              RAID levels.  An alternate syntax allows the size to be\n              determined indirectly as a percentage of the size of a\n              related VG, LV, or set of PVs. The suffix %VG denotes the\n              total size of the VG, the suffix %FREE the remaining free\n              space in the VG, and the suffix %PVS the free space in the\n              specified PVs.  For a snapshot, the size can be expressed\n              as a percentage of the total size of the origin LV with\n              the suffix %ORIGIN (100%ORIGIN provides space for the\n              whole origin).  When expressed as a percentage, the size\n              defines an upper limit for the number of logical extents\n              in the new LV. The precise number of logical extents in\n              the new LV is not determined until the command has\n              completed.","commit_id":"23c10375151cd36ea44c706e5e5055665b129315"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4a42806510b58a9bbd58be651449aea04bb62b3c","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"set -xeu"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"parted --script $PV_DEVICE mklabel msdos mkpart primary 0% 100% set 1 lvm on"},{"line_number":75,"context_line":"partprobe -s $PV_DEVICE"},{"line_number":76,"context_line":"pvcreate ${PV_DEVICE}1"},{"line_number":77,"context_line":"vgcreate ${VOLUME_GROUP} ${PV_DEVICE}1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"02d4cffb_dff307bc","line":74,"updated":"2023-11-20 22:00:28.000000000","message":"Before running this should we check if there is already a partition and maybe bail out without a force flag if so?","commit_id":"23c10375151cd36ea44c706e5e5055665b129315"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"b5db18f9ca28ce66735170552c9144ee3c021c78","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"set -xeu"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"parted --script $PV_DEVICE mklabel msdos mkpart primary 0% 100% set 1 lvm on"},{"line_number":75,"context_line":"partprobe -s $PV_DEVICE"},{"line_number":76,"context_line":"pvcreate ${PV_DEVICE}1"},{"line_number":77,"context_line":"vgcreate ${VOLUME_GROUP} ${PV_DEVICE}1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"c5b07125_b8e05c37","line":74,"in_reply_to":"02d4cffb_dff307bc","updated":"2023-11-20 22:08:12.000000000","message":"I think I do that near line 40?  Happy to place it more inline as it\u0027s pretty hidden as it is.","commit_id":"23c10375151cd36ea44c706e5e5055665b129315"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"set -xeu"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"parted --script $PV_DEVICE mklabel msdos mkpart primary 0% 100% set 1 lvm on"},{"line_number":75,"context_line":"partprobe -s $PV_DEVICE"},{"line_number":76,"context_line":"pvcreate ${PV_DEVICE}1"},{"line_number":77,"context_line":"vgcreate ${VOLUME_GROUP} ${PV_DEVICE}1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4029baae_db4b15bd","line":74,"in_reply_to":"5b1986e2_d2874b9a","updated":"2023-11-22 05:50:58.000000000","message":"Done","commit_id":"23c10375151cd36ea44c706e5e5055665b129315"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"28daa66aa2311d02b3faf9a9aca43c9baa1452d9","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"set -xeu"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"parted --script $PV_DEVICE mklabel msdos mkpart primary 0% 100% set 1 lvm on"},{"line_number":75,"context_line":"partprobe -s $PV_DEVICE"},{"line_number":76,"context_line":"pvcreate ${PV_DEVICE}1"},{"line_number":77,"context_line":"vgcreate ${VOLUME_GROUP} ${PV_DEVICE}1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5b1986e2_d2874b9a","line":74,"in_reply_to":"c5b07125_b8e05c37","updated":"2023-11-20 22:10:37.000000000","message":"oh yup. I would move it outside of opt parsing. It is a bit hidden there.","commit_id":"23c10375151cd36ea44c706e5e5055665b129315"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"function usage {"},{"line_number":18,"context_line":"    echo \"$(basename $0): -d [device] -g [vg name] -v [volume spec]\""},{"line_number":19,"context_line":"    echo \"      [device]: The device path to use as the Physical Volume: eg /dev/sdb\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"98bc18af_be7781be","line":16,"updated":"2023-11-22 05:50:58.000000000","message":"Do we want to set errexit and pipefail?","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"function usage {"},{"line_number":18,"context_line":"    echo \"$(basename $0): -d [device] -g [vg name] -v [volume spec]\""},{"line_number":19,"context_line":"    echo \"      [device]: The device path to use as the Physical Volume: eg /dev/sdb\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"608bb6ff_19ea30f1","line":16,"in_reply_to":"98bc18af_be7781be","updated":"2023-11-27 18:20:02.000000000","message":"I was doign this further down (line 97ish) after the \"setup\".  I\u0027ve moved it closer to the shebang for visibility.\n\nI\u0027ve added -o pipefail","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    echo \"$(basename $0): -d [device] -g [vg name] -v [volume spec]\""},{"line_number":19,"context_line":"    echo \"      [device]: The device path to use as the Physical Volume: eg /dev/sdb\""},{"line_number":20,"context_line":"    echo \"     [vg name]: The name for the new Volume Group: eg main\""},{"line_number":21,"context_line":"    echo \" [volume spec]: A colon \u0027:\u0027 seperated specification for a volume to create.\""},{"line_number":22,"context_line":"    echo \"                This contains 3 parts\""},{"line_number":23,"context_line":"    echo \"          \u003cname\u003e: The Logical Volume name: eg afscache\""},{"line_number":24,"context_line":"    echo \"          \u003csize\u003e: The size (in extents) for the Logical Volume: eg 50%VG\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"f84128d0_c1206f2d","line":21,"range":{"start_line":21,"start_character":38,"end_line":21,"end_character":47},"updated":"2023-11-22 05:50:58.000000000","message":"separated","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    echo \"$(basename $0): -d [device] -g [vg name] -v [volume spec]\""},{"line_number":19,"context_line":"    echo \"      [device]: The device path to use as the Physical Volume: eg /dev/sdb\""},{"line_number":20,"context_line":"    echo \"     [vg name]: The name for the new Volume Group: eg main\""},{"line_number":21,"context_line":"    echo \" [volume spec]: A colon \u0027:\u0027 seperated specification for a volume to create.\""},{"line_number":22,"context_line":"    echo \"                This contains 3 parts\""},{"line_number":23,"context_line":"    echo \"          \u003cname\u003e: The Logical Volume name: eg afscache\""},{"line_number":24,"context_line":"    echo \"          \u003csize\u003e: The size (in extents) for the Logical Volume: eg 50%VG\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"b7ebe85f_c5efac1f","line":21,"range":{"start_line":21,"start_character":38,"end_line":21,"end_character":47},"in_reply_to":"f84128d0_c1206f2d","updated":"2023-11-27 18:20:02.000000000","message":"Done","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    echo \"\""},{"line_number":27,"context_line":"    echo \"NOTE: This script doesn\u0027t need to know the full size of the volume\""},{"line_number":28,"context_line":"    echo \"\""},{"line_number":29,"context_line":"    echo \"Example invokation:\""},{"line_number":30,"context_line":"    echo \"# $(basename $0) -d /dev/sdb -g main -v afscache:50%VG:/var/cache/openafs -v proxycache:50%VG:/var/cache/apache2\""},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"22d03315_6b53ae39","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":28},"updated":"2023-11-22 05:50:58.000000000","message":"invocation","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    echo \"\""},{"line_number":27,"context_line":"    echo \"NOTE: This script doesn\u0027t need to know the full size of the volume\""},{"line_number":28,"context_line":"    echo \"\""},{"line_number":29,"context_line":"    echo \"Example invokation:\""},{"line_number":30,"context_line":"    echo \"# $(basename $0) -d /dev/sdb -g main -v afscache:50%VG:/var/cache/openafs -v proxycache:50%VG:/var/cache/apache2\""},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5b1d7b92_c30e4f6d","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":28},"in_reply_to":"22d03315_6b53ae39","updated":"2023-11-27 18:20:02.000000000","message":"Done","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    ;;"},{"line_number":49,"context_line":"    *|--help)"},{"line_number":50,"context_line":"        usage"},{"line_number":51,"context_line":"        exit 0"},{"line_number":52,"context_line":"    ;;"},{"line_number":53,"context_line":"    esac"},{"line_number":54,"context_line":"    shift 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"43eaca9d_3b1e8782","line":51,"updated":"2023-11-22 05:50:58.000000000","message":"I\u0027d maybe also do \"exit 1\" here, at least for the \"*\" part, but I don\u0027t think it hurts to do it for both.","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ;;"},{"line_number":49,"context_line":"    *|--help)"},{"line_number":50,"context_line":"        usage"},{"line_number":51,"context_line":"        exit 0"},{"line_number":52,"context_line":"    ;;"},{"line_number":53,"context_line":"    esac"},{"line_number":54,"context_line":"    shift 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"13c037fa_c4e2d232","line":51,"in_reply_to":"43eaca9d_3b1e8782","updated":"2023-11-27 18:20:02.000000000","message":"Done","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":true,"context_lines":[{"line_number":73,"context_line":"fi"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"if [ \"$(id -u)\" -ne 0 ] ; then"},{"line_number":76,"context_line":"    echo \"You ned to have root permissions for this script to run.    Aborting.\""},{"line_number":77,"context_line":"    echo \"\""},{"line_number":78,"context_line":"    usage"},{"line_number":79,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"f66cbc47_716a80bc","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":17},"updated":"2023-11-22 05:50:58.000000000","message":"need","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":false,"context_lines":[{"line_number":73,"context_line":"fi"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"if [ \"$(id -u)\" -ne 0 ] ; then"},{"line_number":76,"context_line":"    echo \"You ned to have root permissions for this script to run.    Aborting.\""},{"line_number":77,"context_line":"    echo \"\""},{"line_number":78,"context_line":"    usage"},{"line_number":79,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"710efe4b_ebe77da4","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":17},"in_reply_to":"f66cbc47_716a80bc","updated":"2023-11-27 18:20:02.000000000","message":"Done","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":true,"context_lines":[{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Sanity check that we don\u0027t break anything that already has an fs."},{"line_number":83,"context_line":"if blkid | grep $PV_DEVICE ; then"},{"line_number":84,"context_line":"    echo \"$PV_DEVICE appears in blkid.   Aborting.\""},{"line_number":85,"context_line":"    blkid"},{"line_number":86,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"00a73cdc_6556cd14","line":83,"range":{"start_line":83,"start_character":11,"end_line":83,"end_character":15},"updated":"2023-11-22 05:50:58.000000000","message":"do you want to have the output of this being seen? otherwise \"grep -q\" might be better","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":false,"context_lines":[{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Sanity check that we don\u0027t break anything that already has an fs."},{"line_number":83,"context_line":"if blkid | grep $PV_DEVICE ; then"},{"line_number":84,"context_line":"    echo \"$PV_DEVICE appears in blkid.   Aborting.\""},{"line_number":85,"context_line":"    blkid"},{"line_number":86,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"193b9b1d_4cf77ba1","line":83,"range":{"start_line":83,"start_character":11,"end_line":83,"end_character":15},"in_reply_to":"00a73cdc_6556cd14","updated":"2023-11-27 18:20:02.000000000","message":"Done","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":true,"context_lines":[{"line_number":83,"context_line":"if blkid | grep $PV_DEVICE ; then"},{"line_number":84,"context_line":"    echo \"$PV_DEVICE appears in blkid.   Aborting.\""},{"line_number":85,"context_line":"    blkid"},{"line_number":86,"context_line":"    exit 1"},{"line_number":87,"context_line":"fi"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Because images may not have all the things we need."}],"source_content_type":"text/x-sh","patch_set":5,"id":"c6844576_8d85c9b1","line":86,"updated":"2023-11-22 05:50:58.000000000","message":"maybe use a different exit code here, like 2?","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":true,"context_lines":[{"line_number":83,"context_line":"if blkid | grep $PV_DEVICE ; then"},{"line_number":84,"context_line":"    echo \"$PV_DEVICE appears in blkid.   Aborting.\""},{"line_number":85,"context_line":"    blkid"},{"line_number":86,"context_line":"    exit 1"},{"line_number":87,"context_line":"fi"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Because images may not have all the things we need."}],"source_content_type":"text/x-sh","patch_set":5,"id":"ecc162c0_4ad8a9da","line":86,"in_reply_to":"c6844576_8d85c9b1","updated":"2023-11-27 18:20:02.000000000","message":"I don\u0027t think it really matters.  For now this script will be run manually and any error/exit code will be seen by the human running the script.  If we do integrate this into launch_node then any non-zero exit code is will get caught.","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04be4f184326c5a73d10666995dcf7c8782555ee","unresolved":false,"context_lines":[{"line_number":83,"context_line":"if blkid | grep $PV_DEVICE ; then"},{"line_number":84,"context_line":"    echo \"$PV_DEVICE appears in blkid.   Aborting.\""},{"line_number":85,"context_line":"    blkid"},{"line_number":86,"context_line":"    exit 1"},{"line_number":87,"context_line":"fi"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Because images may not have all the things we need."}],"source_content_type":"text/x-sh","patch_set":5,"id":"68b30d35_0d6c5a33","line":86,"in_reply_to":"ecc162c0_4ad8a9da","updated":"2023-11-30 21:17:44.000000000","message":"ok","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Because images may not have all the things we need."},{"line_number":90,"context_line":"if which apt-get ; then"},{"line_number":91,"context_line":"    apt-get update \u0026\u0026 apt-get install -y lvm2"},{"line_number":92,"context_line":"elif which yum ; then"},{"line_number":93,"context_line":"    yum -y install lvm2"},{"line_number":94,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"d7d2f018_7064f798","line":91,"updated":"2023-11-22 05:50:58.000000000","message":"what about other tools used, like perl and parted?","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04be4f184326c5a73d10666995dcf7c8782555ee","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Because images may not have all the things we need."},{"line_number":90,"context_line":"if which apt-get ; then"},{"line_number":91,"context_line":"    apt-get update \u0026\u0026 apt-get install -y lvm2"},{"line_number":92,"context_line":"elif which yum ; then"},{"line_number":93,"context_line":"    yum -y install lvm2"},{"line_number":94,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3e47c575_396e1a07","line":91,"in_reply_to":"7c8abc70_66de9093","updated":"2023-11-30 21:17:44.000000000","message":"Acknowledged","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Because images may not have all the things we need."},{"line_number":90,"context_line":"if which apt-get ; then"},{"line_number":91,"context_line":"    apt-get update \u0026\u0026 apt-get install -y lvm2"},{"line_number":92,"context_line":"elif which yum ; then"},{"line_number":93,"context_line":"    yum -y install lvm2"},{"line_number":94,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7c8abc70_66de9093","line":91,"in_reply_to":"d7d2f018_7064f798","updated":"2023-11-27 18:20:02.000000000","message":"I basically \"stole\" this from: https://opendev.org/opendev/system-config/src/branch/master/launch/src/opendev_launch/mount_volume.sh#L21-L26\n\nI am certainly not opposed to fleshing that out with the other tools or removing it in general.  For now I\u0027ll mark that work as a todo","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1da4d55c4fd7f8d078f478275892a089698c4e39","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    tune2fs -i 0 -c 0 ${VOLUME_DEVICE}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # Remove existing fstab entries for this device."},{"line_number":116,"context_line":"    perl -nle \"m,${VOLUME_DEVICE}, || print\" -i /etc/fstab"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    if [ ! -d \"$VOLUME_MOUNT\" ] ; then"},{"line_number":119,"context_line":"        mkdir -p \"$VOLUME_MOUNT\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"a7d8b21d_b36198a4","line":116,"updated":"2023-11-22 05:50:58.000000000","message":"I\u0027m unsure if we really want to silently drop these, or if it would be better to run this as a precheck and error out if we have an existing entry? Or is there a use case where we actually replace lvs?","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2a8e649633ced8084aca1f9cf81d9c71d5848361","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    tune2fs -i 0 -c 0 ${VOLUME_DEVICE}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # Remove existing fstab entries for this device."},{"line_number":116,"context_line":"    perl -nle \"m,${VOLUME_DEVICE}, || print\" -i /etc/fstab"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    if [ ! -d \"$VOLUME_MOUNT\" ] ; then"},{"line_number":119,"context_line":"        mkdir -p \"$VOLUME_MOUNT\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"f5ce79ea_86d126ef","line":116,"in_reply_to":"a7d8b21d_b36198a4","updated":"2023-11-27 18:20:02.000000000","message":"That\u0027s another fair point.  I was following the pattern from: https://opendev.org/opendev/system-config/src/branch/master/launch/src/opendev_launch/mount_volume.sh#L40","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04be4f184326c5a73d10666995dcf7c8782555ee","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    tune2fs -i 0 -c 0 ${VOLUME_DEVICE}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # Remove existing fstab entries for this device."},{"line_number":116,"context_line":"    perl -nle \"m,${VOLUME_DEVICE}, || print\" -i /etc/fstab"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    if [ ! -d \"$VOLUME_MOUNT\" ] ; then"},{"line_number":119,"context_line":"        mkdir -p \"$VOLUME_MOUNT\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"f2ce85cb_79c99550","line":116,"in_reply_to":"aebaae25_061ebb8f","updated":"2023-11-30 21:17:44.000000000","message":"makes sense, ack, so fine to drop this todo again","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ab24093007a95199cdf3218465a2e404a6d7e989","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    tune2fs -i 0 -c 0 ${VOLUME_DEVICE}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # Remove existing fstab entries for this device."},{"line_number":116,"context_line":"    perl -nle \"m,${VOLUME_DEVICE}, || print\" -i /etc/fstab"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    if [ ! -d \"$VOLUME_MOUNT\" ] ; then"},{"line_number":119,"context_line":"        mkdir -p \"$VOLUME_MOUNT\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"aebaae25_061ebb8f","line":116,"in_reply_to":"f5ce79ea_86d126ef","updated":"2023-11-27 21:47:29.000000000","message":"Ya I think the idea here is we\u0027re running this on brand new nodes so we don\u0027t have to be super cautious with data on the node itself. But we do want to be careful with the volumes because those may contain data from elsewhere we do care about.","commit_id":"59bfe3fa2b6c6162c0cc5e4fe943fe6d69f811ec"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ab24093007a95199cdf3218465a2e404a6d7e989","unresolved":true,"context_lines":[{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# Because images may not have all the things we need."},{"line_number":98,"context_line":"# TODO(tonyb): 1) Do we really care about yum here? ;"},{"line_number":99,"context_line":"#              2) Audit script for other tools perl/parted etc"},{"line_number":100,"context_line":"#              3) Also other scipts in this dir"},{"line_number":101,"context_line":"if which apt-get ; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"dd4bd9f3_cc14771a","line":98,"updated":"2023-11-27 21:47:29.000000000","message":"We stopped making centos7 control plane nodes long ago. We probably can cleanup yum but it doesn\u0027t hurt much either.","commit_id":"685af0dd48d9947d7ccdd2ea936edef7c4f2c60f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04be4f184326c5a73d10666995dcf7c8782555ee","unresolved":true,"context_lines":[{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# Because images may not have all the things we need."},{"line_number":98,"context_line":"# TODO(tonyb): 1) Do we really care about yum here? ;"},{"line_number":99,"context_line":"#              2) Audit script for other tools perl/parted etc"},{"line_number":100,"context_line":"#              3) Also other scipts in this dir"},{"line_number":101,"context_line":"if which apt-get ; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"94e0f5be_0738d09b","line":98,"in_reply_to":"dd4bd9f3_cc14771a","updated":"2023-11-30 21:17:44.000000000","message":"I\u0027d be in favor of dropping it","commit_id":"685af0dd48d9947d7ccdd2ea936edef7c4f2c60f"}]}