)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6d2149f08797278dac8d8cd1d2e49631a5e8701a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c31f3f3f_8d86f1e5","updated":"2024-05-06 06:16:13.000000000","message":"thx for the explanations","commit_id":"ba511c4d1c166520e7a4070ce2b93629fa14644b"}],"inventory/service/group_vars/meetpad.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bcec3f59abc7d29a29d1184cb1d4b896f7dbe91a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"iptables_extra_allowed_groups:"},{"line_number":8,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00275222\u0027, \u0027group\u0027: \u0027jvb\u0027}"},{"line_number":9,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00279090\u0027, \u0027group\u0027: \u0027meetpad\u0027}"},{"line_number":10,"context_line":"meetpad_jvb_xmpp_server: \"{{ hostvars[\u0027meetpad01.opendev.org\u0027].ansible_host }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"269533e0_a93afc2d","line":10,"updated":"2024-01-15 16:24:41.000000000","message":"Do we need this value in the meetpad group vars? I guess meetpad also runs a jvb so maybe we use this value to configure the jvb on the meetpad server?","commit_id":"09eb145e4b0bdbf6b7c0d3efba79e1eace817178"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6e76908ef5e563dfd6329655c564c1c337dadcb0","unresolved":true,"context_lines":[{"line_number":7,"context_line":"iptables_extra_allowed_groups:"},{"line_number":8,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00275222\u0027, \u0027group\u0027: \u0027jvb\u0027}"},{"line_number":9,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00279090\u0027, \u0027group\u0027: \u0027meetpad\u0027}"},{"line_number":10,"context_line":"meetpad_jvb_xmpp_server: \"{{ hostvars[\u0027meetpad01.opendev.org\u0027].ansible_host }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8c5b786f_91831e51","line":10,"in_reply_to":"269533e0_a93afc2d","updated":"2024-02-01 11:02:17.000000000","message":"this var is only being used in playbooks/roles/jitsi-meet/templates/jvb-env.j2 which is only getting referenced in playbooks/service-meetpad.yaml with a filter of \"hosts: \"jvb:!disabled\"\". so I\u0027d say this is not useful here and should be dropped","commit_id":"09eb145e4b0bdbf6b7c0d3efba79e1eace817178"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"cf25e849d12a1095a028a0f813dd3295b3e85c22","unresolved":false,"context_lines":[{"line_number":7,"context_line":"iptables_extra_allowed_groups:"},{"line_number":8,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00275222\u0027, \u0027group\u0027: \u0027jvb\u0027}"},{"line_number":9,"context_line":"  - {\u0027protocol\u0027: \u0027tcp\u0027, \u0027port\u0027: \u00279090\u0027, \u0027group\u0027: \u0027meetpad\u0027}"},{"line_number":10,"context_line":"meetpad_jvb_xmpp_server: \"{{ hostvars[\u0027meetpad01.opendev.org\u0027].ansible_host }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d645c883_cc5ae8c2","line":10,"in_reply_to":"8c5b786f_91831e51","updated":"2024-05-02 23:23:50.000000000","message":"Yup you\u0027re both correct.  XMPP_SERVER is \u0027localhost\u0027 on the meetpad servers\n\n\nhttps://opendev.org/opendev/system-config/src/branch/master/playbooks/roles/jitsi-meet/templates/meet-env.j2#L12\n\n\nAs a bonus, this chnage has nothing to do with PUBLIC_URL so #yay","commit_id":"09eb145e4b0bdbf6b7c0d3efba79e1eace817178"}],"playbooks/zuul/templates/group_vars/jvb.yaml.j2":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"4aa973484cc842629479e9a1166c4e4dfbb97e77","unresolved":false,"context_lines":[{"line_number":1,"context_line":"jitsi_meet_public_url: https://meetpad99.opendev.org"},{"line_number":2,"context_line":"meetpad_jvb_auth_password: 8c64807830bcc7581821d3157899e3b0"},{"line_number":3,"context_line":"meetpad_jvb_keystore_password: ateeweegoLee3aig5eish8aeraetiG"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9560a53c_b6b3a98a","line":1,"updated":"2024-01-15 03:56:58.000000000","message":"This should have been meetpad01 or perhaps meetpad.  Switching to meetpad99 should happen in the next version","commit_id":"e1f10de6bb514ca0684c29e01b2bf4305cc041c6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6e76908ef5e563dfd6329655c564c1c337dadcb0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"jitsi_meet_public_url: https://meetpad01.opendev.org"},{"line_number":2,"context_line":"meetpad_jvb_auth_password: 8c64807830bcc7581821d3157899e3b0"},{"line_number":3,"context_line":"meetpad_jvb_keystore_password: ateeweegoLee3aig5eish8aeraetiG"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5ee40026_92573d14","line":1,"updated":"2024-02-01 11:02:17.000000000","message":"why is this meetpad01 instead of plain meetpad?","commit_id":"09eb145e4b0bdbf6b7c0d3efba79e1eace817178"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"cf25e849d12a1095a028a0f813dd3295b3e85c22","unresolved":false,"context_lines":[{"line_number":1,"context_line":"jitsi_meet_public_url: https://meetpad01.opendev.org"},{"line_number":2,"context_line":"meetpad_jvb_auth_password: 8c64807830bcc7581821d3157899e3b0"},{"line_number":3,"context_line":"meetpad_jvb_keystore_password: ateeweegoLee3aig5eish8aeraetiG"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"94a1e770_af0a081b","line":1,"in_reply_to":"5ee40026_92573d14","updated":"2024-05-02 23:23:50.000000000","message":"IIUC these are only used in testing to provide placeholders for the secrets on the real bridge.   With that assumption I wanted this match the test node so we don\u0027t redirect to the production server.\n\nAlso I guess that means we\u0027d need to add a value on bridge","commit_id":"09eb145e4b0bdbf6b7c0d3efba79e1eace817178"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c1fcc282e479e58f2471d74582ca5411031b6152","unresolved":false,"context_lines":[{"line_number":1,"context_line":"jitsi_meet_public_url: https://meetpad01.opendev.org"},{"line_number":2,"context_line":"meetpad_jvb_auth_password: 8c64807830bcc7581821d3157899e3b0"},{"line_number":3,"context_line":"meetpad_jvb_keystore_password: ateeweegoLee3aig5eish8aeraetiG"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"f2ececd4_2a465de4","line":1,"in_reply_to":"94a1e770_af0a081b","updated":"2024-05-03 16:29:43.000000000","message":"I don\u0027t think we need a value on bridge because https://review.opendev.org/c/opendev/system-config/+/905510/4/playbooks/roles/jitsi-meet/defaults/main.yaml sets a value that works for production in the role defaults. We only need the override in the test environment because meetpad.o.o isn\u0027t defined there but meetpad01 is.","commit_id":"09eb145e4b0bdbf6b7c0d3efba79e1eace817178"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"195fd6106edc71fe32a6ede14027dc4bee8ac453","unresolved":false,"context_lines":[{"line_number":1,"context_line":"jitsi_meet_public_url: https://meetpad01.opendev.org"},{"line_number":2,"context_line":"meetpad_jvb_auth_password: 8c64807830bcc7581821d3157899e3b0"},{"line_number":3,"context_line":"meetpad_jvb_keystore_password: ateeweegoLee3aig5eish8aeraetiG"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1221477c_ed1a8a20","line":1,"in_reply_to":"f2ececd4_2a465de4","updated":"2024-05-03 17:03:42.000000000","message":"Ahh of course.\n\nThanks clark.","commit_id":"09eb145e4b0bdbf6b7c0d3efba79e1eace817178"}],"playbooks/zuul/templates/group_vars/meetpad.yaml.j2":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"4aa973484cc842629479e9a1166c4e4dfbb97e77","unresolved":false,"context_lines":[{"line_number":1,"context_line":"jitsi_meet_public_url: https://meetpad99.opendev.org"},{"line_number":2,"context_line":"meetpad_jvb_auth_password: 8c64807830bcc7581821d3157899e3b0"},{"line_number":3,"context_line":"meetpad_jvb_keystore_password: ateeweegoLee3aig5eish8aeraetiG"},{"line_number":4,"context_line":"meetpad_jicofo_component_secret: 3bcd6b4494d99de7ff7b64b931d394f6"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2d15535e_168d16b0","line":1,"updated":"2024-01-15 03:56:58.000000000","message":"Same comment as in the jvb.yaml.j2 file","commit_id":"e1f10de6bb514ca0684c29e01b2bf4305cc041c6"}]}