)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"55ea88e6e11449a04f9fc0e5afc24bff0556d56d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b899e31_a762bb6c","updated":"2024-05-29 15:57:20.000000000","message":"Couple of small things inline. Otherwise this looks about how I would expect it and our testing of this should be broad enough to ensure that the two commands can live peacefully side by side during a transition period.","commit_id":"ea5ee2c6bcde243769f1c4d06ca89bc5864edc75"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3eeabcf740a0983932899f9fe5aef6111eef3d60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6fea916_2a39a9f9","updated":"2024-05-31 16:17:23.000000000","message":"recheck","commit_id":"ea5ee2c6bcde243769f1c4d06ca89bc5864edc75"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d3c71f1d9fcf4b759b01f3de4df5bfb5ed88cc2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"31cd4683_dcc5a079","updated":"2024-06-13 16:25:01.000000000","message":"I think this is ready for (re)review.\n\nhttps://review.opendev.org/c/opendev/system-config/+/921764 shows that the v2 tool supports the same YAML flags as v1","commit_id":"a859079c2ece8136deda8cdec8544b44308fa0a3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"35cb138bb4543975d4c909778ead3b061d075357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75d90fe7_791b6026","updated":"2024-06-19 10:40:02.000000000","message":"recheck failure with github.com access","commit_id":"25727fab47a18dd146e63675097f376385cf3eac"}],"playbooks/roles/install-docker/tasks/distro.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"55ea88e6e11449a04f9fc0e5afc24bff0556d56d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  package:"},{"line_number":4,"context_line":"    name:"},{"line_number":5,"context_line":"      - docker.io"},{"line_number":6,"context_line":"      - docker-compose-v2"},{"line_number":7,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"916655a6_86e5f281","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"updated":"2024-05-29 15:57:20.000000000","message":"Is this package available as far back as we run containers with the install-docker role? Looking at ubuntu package search it is in focal-updates and jammy-updates as well as normal noble universe. Not sure about bionic or xenial. May need to do a quick check of where we run install-docker and install this package only when on the newer platforms.","commit_id":"ea5ee2c6bcde243769f1c4d06ca89bc5864edc75"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"6ea4755f9ed8c70752c91182331ef6c325d1eca7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  package:"},{"line_number":4,"context_line":"    name:"},{"line_number":5,"context_line":"      - docker.io"},{"line_number":6,"context_line":"      - docker-compose-v2"},{"line_number":7,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f43e477f_e3932b2a","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"in_reply_to":"916655a6_86e5f281","updated":"2024-05-29 20:13:03.000000000","message":"Good point.   I\u0027ll look at this. and address it in the next patchset","commit_id":"ea5ee2c6bcde243769f1c4d06ca89bc5864edc75"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fdb68b8e51f4faa12d3edca9c332d3cbc246bc46","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  package:"},{"line_number":4,"context_line":"    name:"},{"line_number":5,"context_line":"      - docker.io"},{"line_number":6,"context_line":"      - docker-compose-v2"},{"line_number":7,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5bfea150_76b5d9b8","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"in_reply_to":"f43e477f_e3932b2a","updated":"2024-06-19 08:06:49.000000000","message":"Done","commit_id":"ea5ee2c6bcde243769f1c4d06ca89bc5864edc75"}],"playbooks/roles/install-docker/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"55ea88e6e11449a04f9fc0e5afc24bff0556d56d","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    state: present"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Install python docker-compose if needed"},{"line_number":38,"context_line":"  when: with_python_compose|default(true)|bool"},{"line_number":39,"context_line":"  block:"},{"line_number":40,"context_line":"  - name: ensure pip3 is installed"},{"line_number":41,"context_line":"    include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e1da6e4a_62a670bd","line":38,"range":{"start_line":38,"start_character":28,"end_line":38,"end_character":41},"updated":"2024-05-29 15:57:20.000000000","message":"Nit is this default necessary? We set a value in the defaults file as well.","commit_id":"ea5ee2c6bcde243769f1c4d06ca89bc5864edc75"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fdb68b8e51f4faa12d3edca9c332d3cbc246bc46","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    state: present"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Install python docker-compose if needed"},{"line_number":38,"context_line":"  when: with_python_compose|default(true)|bool"},{"line_number":39,"context_line":"  block:"},{"line_number":40,"context_line":"  - name: ensure pip3 is installed"},{"line_number":41,"context_line":"    include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6c2a79f5_051c0421","line":38,"range":{"start_line":38,"start_character":28,"end_line":38,"end_character":41},"in_reply_to":"273390c9_9b66f15e","updated":"2024-06-19 08:06:49.000000000","message":"Done","commit_id":"ea5ee2c6bcde243769f1c4d06ca89bc5864edc75"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"6ea4755f9ed8c70752c91182331ef6c325d1eca7","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    state: present"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Install python docker-compose if needed"},{"line_number":38,"context_line":"  when: with_python_compose|default(true)|bool"},{"line_number":39,"context_line":"  block:"},{"line_number":40,"context_line":"  - name: ensure pip3 is installed"},{"line_number":41,"context_line":"    include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"273390c9_9b66f15e","line":38,"range":{"start_line":38,"start_character":28,"end_line":38,"end_character":41},"in_reply_to":"e1da6e4a_62a670bd","updated":"2024-05-29 20:13:03.000000000","message":"Probably not just overly cautious","commit_id":"ea5ee2c6bcde243769f1c4d06ca89bc5864edc75"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5b253481795dec1172306a481cbe8a6164f2463c","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  meta: reset_connection"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# We install docker-compose from pypi to get features like"},{"line_number":19,"context_line":"# stop_grace_period."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# On arm64 we need build-essential, python3-dev, libffi-dev, and"},{"line_number":22,"context_line":"# libssl-dev because wheels don\u0027t exist for all the things on arm64."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b639f97c_c9396fd5","line":19,"updated":"2024-06-11 06:09:54.000000000","message":"Is this still relevant? If yes, it could be an issue, otherwise this comment could be deleted?\n\nSeems stop_grace_period is used for gerrit, msilman3 and nodepool-builder, can we test one of those against this change?","commit_id":"a908cbbf8144b80a8de2ee90e0e599bbdc93ad2b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fdb68b8e51f4faa12d3edca9c332d3cbc246bc46","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  meta: reset_connection"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# We install docker-compose from pypi to get features like"},{"line_number":19,"context_line":"# stop_grace_period."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# On arm64 we need build-essential, python3-dev, libffi-dev, and"},{"line_number":22,"context_line":"# libssl-dev because wheels don\u0027t exist for all the things on arm64."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"31a1146f_0946e48b","line":19,"in_reply_to":"50454bf3_1bf42279","updated":"2024-06-19 08:06:49.000000000","message":"Done","commit_id":"a908cbbf8144b80a8de2ee90e0e599bbdc93ad2b"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"9e4dff65f2fa2bed1d393e19669b5d42b42603bc","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  meta: reset_connection"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# We install docker-compose from pypi to get features like"},{"line_number":19,"context_line":"# stop_grace_period."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# On arm64 we need build-essential, python3-dev, libffi-dev, and"},{"line_number":22,"context_line":"# libssl-dev because wheels don\u0027t exist for all the things on arm64."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"50454bf3_1bf42279","line":19,"in_reply_to":"b639f97c_c9396fd5","updated":"2024-06-11 13:22:27.000000000","message":"copose v2 seems to support this feature also[1,2], but I\u0027ll generate a test chnage for mailman to verify.\n\n\n[1] https://docs.docker.com/compose/compose-file/05-services/#stop_grace_period\n[2] https://github.com/ndeloof/compose-go/blob/master/schema/compose-spec.json#L356","commit_id":"a908cbbf8144b80a8de2ee90e0e599bbdc93ad2b"}]}