)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"532fc4f57ef152637ea24fc7b5dd906c2c00ccd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb5c4d6d_b4b30301","updated":"2024-06-03 19:35:31.000000000","message":"Looks good!","commit_id":"ed9aae01c329f5d134d196b79894e0cdc60677cc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4b54c8cd545b68ab350856c3f03cec1c226a0813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0dfb42e_195e8b77","updated":"2024-06-07 18:37:52.000000000","message":"anyway let\u0027s go with this as it stands to fix the issue now","commit_id":"ed9aae01c329f5d134d196b79894e0cdc60677cc"}],"playbooks/roles/install-ansible-roles/tasks/main.yaml":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e52b4379108cd42df56cb4cd4984dc494eccfadd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Mark source side of clone as safe"},{"line_number":2,"context_line":"  # This goes into a config file with many entries so we cannot set"},{"line_number":3,"context_line":"  # a creates attribute on this task. However, subsequent runs of this"},{"line_number":4,"context_line":"  # command seem to noop if the entries are already present so the impact"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"360fecb9_73e6aa67","line":1,"updated":"2024-06-03 18:45:54.000000000","message":"Don\u0027t we need a loop in this OR move the task into a file that can be included and thus do the setting and the clone at the same time.","commit_id":"95a612179364329badc07826597c67025d0d3c22"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"81899fc6672304c9ceab79e057359916d515779b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Mark source side of clone as safe"},{"line_number":2,"context_line":"  # This goes into a config file with many entries so we cannot set"},{"line_number":3,"context_line":"  # a creates attribute on this task. However, subsequent runs of this"},{"line_number":4,"context_line":"  # command seem to noop if the entries are already present so the impact"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f4ca74a0_11a3f26b","line":1,"in_reply_to":"360fecb9_73e6aa67","updated":"2024-06-03 19:26:16.000000000","message":"Yes good catch. I think it would actually work because we only ever do this role for a single role, but we loop below so should loop here.","commit_id":"95a612179364329badc07826597c67025d0d3c22"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ee6495099a4a186d84c9d4e679fb98c80c3ad1c5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Mark source side of clone as safe"},{"line_number":2,"context_line":"  # This goes into a config file with many entries so we cannot set"},{"line_number":3,"context_line":"  # a creates attribute on this task. However, subsequent runs of this"},{"line_number":4,"context_line":"  # command seem to noop if the entries are already present so the impact"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"60fa1df2_fe5b5f13","line":1,"in_reply_to":"f4ca74a0_11a3f26b","updated":"2024-06-05 09:55:18.000000000","message":"Well the `ansible_role` var would have been undefined in PS1 I think, so this variant is certainly the correct one.\n\nI\u0027m always unsure though whether doing two separate loops is good or whether one should better do a single loop and then have a block with the two tasks inside?","commit_id":"95a612179364329badc07826597c67025d0d3c22"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ee6495099a4a186d84c9d4e679fb98c80c3ad1c5","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    loop_var: ansible_role"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Install ansible roles to /etc/ansible/roles"},{"line_number":12,"context_line":"  git:"},{"line_number":13,"context_line":"    repo: \u0027{{ ansible_role_src_root }}/src/opendev.org/opendev/ansible-role-{{ ansible_role }}\u0027"},{"line_number":14,"context_line":"    dest: \u0027/etc/ansible/roles/{{ ansible_role }}\u0027"},{"line_number":15,"context_line":"    force: yes"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bc6427a7_942cd713","line":12,"updated":"2024-06-05 09:55:18.000000000","message":"Do we actually need a git clone of the repos? Maybe just copying the content without the .git stuff might be a saner solution?","commit_id":"ed9aae01c329f5d134d196b79894e0cdc60677cc"}]}