)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2b21341a4b962c13db635015aa61e51a68693be3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b064c943_9ccf21e2","updated":"2024-08-01 18:39:41.000000000","message":"The source of the job failure is: `\"msg\": \"Invalid data passed to \u0027loop\u0027, it requires a list, got this instead: install_ansible_extra_pythons. Hint: If you passed a list/dict of just one element, try adding wantlist\u003dTrue to your lookup invocation or use q/query instead of lookup.\"`. I suspect that once that is fixed you will run into the issue I\u0027ve called out inline.\n\nTreat this as a soft -1 on the inline concern if others feel that is fine to do, but probably good to get the job passing before we make any decisions on that.","commit_id":"c6fe20438b406dab79b00ee8479bf2e9af308418"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"4bcaf6082d2810a8b3c062925bb8675249ac4ecd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"489d31a7_ff6bf6fd","updated":"2024-08-01 08:38:26.000000000","message":"recheck  POST_FAILURE ... I think this was a random issue :/","commit_id":"c6fe20438b406dab79b00ee8479bf2e9af308418"}],"playbooks/roles/install-ansible/tasks/main.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"707c12ac6437553863134558483e60c728c37e52","unresolved":true,"context_lines":[{"line_number":36,"context_line":"      - python3-dev"},{"line_number":37,"context_line":"      - tzdata"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Install python-venv package"},{"line_number":40,"context_line":"  package:"},{"line_number":41,"context_line":"    name: \"{{ [\u0027python3-venv\u0027] + install_ansible_extra_pythons|list }}\""},{"line_number":42,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"62793e1e_a30a0810","line":39,"updated":"2024-07-09 01:42:59.000000000","message":"This isn\u0027t really the right description any more","commit_id":"7b20379fc06ef00c7288dcb4fac5f11ef99ef384"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"4c503e2f4a63dcbb1f7dd204a09222a53cb8f4d6","unresolved":true,"context_lines":[{"line_number":36,"context_line":"      - python3-dev"},{"line_number":37,"context_line":"      - tzdata"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Install python-venv package"},{"line_number":40,"context_line":"  package:"},{"line_number":41,"context_line":"    name: \"{{ [\u0027python3-venv\u0027] + install_ansible_extra_pythons|list }}\""},{"line_number":42,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ce0be4dd_a3b44fb2","line":39,"in_reply_to":"62793e1e_a30a0810","updated":"2024-07-09 01:44:51.000000000","message":"Fair.  I\u0027ll adjust in the next revision","commit_id":"7b20379fc06ef00c7288dcb4fac5f11ef99ef384"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0c83a8c48bf63259af22cac6adbdcf0782c1be43","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      - python3-dev"},{"line_number":37,"context_line":"      - tzdata"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Install python-venv package"},{"line_number":40,"context_line":"  package:"},{"line_number":41,"context_line":"    name: \"{{ [\u0027python3-venv\u0027] + install_ansible_extra_pythons|list }}\""},{"line_number":42,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4f06aac9_6eaf5f72","line":39,"in_reply_to":"ce0be4dd_a3b44fb2","updated":"2024-07-11 20:36:16.000000000","message":"Done","commit_id":"7b20379fc06ef00c7288dcb4fac5f11ef99ef384"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2b21341a4b962c13db635015aa61e51a68693be3","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  loop: install_ansible_extra_pythons"},{"line_number":49,"context_line":"  loop_control:"},{"line_number":50,"context_line":"    loop_var: pyver"},{"line_number":51,"context_line":"  when: install_ansible_extra_pythons|length \u003e 0"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Create venv"},{"line_number":54,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0fb34baf_7cc49e11","line":51,"updated":"2024-08-01 18:39:41.000000000","message":"ensure-python is a zuul-jobs role which is not a role available to our control plane managment ansible. I think we should probably keep things that way as the zuul-jobs roles are managed separately and focused on CI jobs not long lived bastion hosts running ansible. Maybe move this up in to the job that needs it and then set install_ansible_python_path to match below?","commit_id":"c6fe20438b406dab79b00ee8479bf2e9af308418"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"2c968a3e7d28401df47fb839db58dd04cc968220","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  loop: install_ansible_extra_pythons"},{"line_number":49,"context_line":"  loop_control:"},{"line_number":50,"context_line":"    loop_var: pyver"},{"line_number":51,"context_line":"  when: install_ansible_extra_pythons|length \u003e 0"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Create venv"},{"line_number":54,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b93055f0_531812e9","line":51,"in_reply_to":"0fb34baf_7cc49e11","updated":"2024-08-05 04:47:46.000000000","message":"Done","commit_id":"c6fe20438b406dab79b00ee8479bf2e9af308418"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ecd1561ea56a1690c30414834a58195d8904efb4","unresolved":true,"context_lines":[{"line_number":43,"context_line":"  # python interpreter then we assume that the venv module is"},{"line_number":44,"context_line":"  # already available. and we don\u0027t want to add unneeded"},{"line_number":45,"context_line":"  # packages to the system."},{"line_number":46,"context_line":"  when: install_ansible_python_path \u003d\u003d \"/usr/bin/python3\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Create venv"},{"line_number":49,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f2ad4e63_52c56f4f","line":46,"updated":"2024-08-05 23:34:08.000000000","message":"Is this change to add the when necessary? It should be safe to install this package and then separately install the other python version stuff that we want. I think having this here is maybe overly cautious and might lead to more confusion in the future?","commit_id":"a19091fb5ef335cb0d879c5eca146c58bfaf872f"}]}