)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"911c5461bd4fabca0e6323e5275abb2ce74878c6","unresolved":true,"context_lines":[{"line_number":10,"context_line":"warnings and exits \u003e1 for proper errors. The most common cause of a"},{"line_number":11,"context_line":"warning appear to be a file changing while it is backed up. This causes"},{"line_number":12,"context_line":"paste02 backups to consistently email us because our borg backup script"},{"line_number":13,"context_line":"exits 1 which we treat as a failure."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Update the script so that when borg 1.2.8 is in use we treat rc 1 as a"},{"line_number":16,"context_line":"success with warnings rather than failure with warnings. This should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"795e561d_fc7004aa","line":13,"updated":"2025-01-20 23:17:26.000000000","message":"I would say that putting the backup logs in /var, and not an ignorable directory like /var/borg/ seems more logical to me with hindsight -- but i think we do want to backup things like access logs and they\u0027ll change dynamically so the problem is more generic anyway","commit_id":"1be9fcf1cfd59a1070c6d46980a4ad2b2f8d9090"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"19f7f442a0dd64881317f52286d0d3bb74ced8e7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"warnings and exits \u003e1 for proper errors. The most common cause of a"},{"line_number":11,"context_line":"warning appear to be a file changing while it is backed up. This causes"},{"line_number":12,"context_line":"paste02 backups to consistently email us because our borg backup script"},{"line_number":13,"context_line":"exits 1 which we treat as a failure."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Update the script so that when borg 1.2.8 is in use we treat rc 1 as a"},{"line_number":16,"context_line":"success with warnings rather than failure with warnings. This should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"471340f3_1fce3567","line":13,"in_reply_to":"795e561d_fc7004aa","updated":"2025-01-21 15:59:20.000000000","message":"I suspect that on production servers we\u0027ve got other files that can update during backups. On gerrit this would be things like git repos, but on any server things like apache logs and syslog etc. So ya I think we just need to accept these rc 1 warning cases.","commit_id":"1be9fcf1cfd59a1070c6d46980a4ad2b2f8d9090"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2e8adb2b4f4ecd3888d06273a9071d03b9bf070e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f0d5fdf_3b213849","updated":"2025-01-20 21:23:44.000000000","message":"recheck trying to generate more data on how well this works","commit_id":"1be9fcf1cfd59a1070c6d46980a4ad2b2f8d9090"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b907d564d456feaf4d6dc86b04f32942518ffa55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dd530196_bcd604c5","updated":"2025-01-21 23:39:04.000000000","message":"I found a bug. Going to fix it.","commit_id":"7d78a22f661f595630cc3b1fc135bbdade5195f5"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"8f8ed273fa0c17c483ade8032cf4cbcb337464a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff871dcd_505b952a","updated":"2025-01-21 23:07:11.000000000","message":"Looks good to me.\n\nI had a few things I didn\u0027t really understand but with the application of coffee things became clear.","commit_id":"7d78a22f661f595630cc3b1fc135bbdade5195f5"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"b6f73cb5d7a0b781be119749b1b3df76d388c65b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4074ca16_42780501","updated":"2025-01-21 23:51:38.000000000","message":"Still looks good","commit_id":"37a8b1e9d01cd1d8a128f3c23a2900e607cbd791"}],"playbooks/roles/borg-backup/templates/borg-backup.j2":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"911c5461bd4fabca0e6323e5275abb2ce74878c6","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    info \"Backup finished successfully\""},{"line_number":70,"context_line":"    final_exit\u003d0"},{"line_number":71,"context_line":"elif [ ${backup_exit} -eq 1 ] \u0026\u0026 [ ${stream_exit} -eq 0 ] \u0026\u0026 \\"},{"line_number":72,"context_line":"        [ \"${BORG_VERSION}\" \u003d \"borg 1.2.8\" ] ; then"},{"line_number":73,"context_line":"    # Borg 1.2 and newer exit with rc 1 if warnings occur. The most common"},{"line_number":74,"context_line":"    # warning is for files that change while being backed up. We treat that"},{"line_number":75,"context_line":"    # as a successful backup if it occurs."}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"53242a5d_bb497061","line":72,"updated":"2025-01-20 23:17:26.000000000","message":"should this perhaps invert the logic to something along the lines of \"! \u003d~ 1.4.?\" so that we exclude \"old\" borg but all future versions will match?","commit_id":"1be9fcf1cfd59a1070c6d46980a4ad2b2f8d9090"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"4c2180671dcd0da9670741361e3b36f75ba60dbb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    info \"Backup finished successfully\""},{"line_number":70,"context_line":"    final_exit\u003d0"},{"line_number":71,"context_line":"elif [ ${backup_exit} -eq 1 ] \u0026\u0026 [ ${stream_exit} -eq 0 ] \u0026\u0026 \\"},{"line_number":72,"context_line":"        [ ! \"${BORG_VERSION}\" \\\u003c \"borg 1.2.8\" ] ; then"},{"line_number":73,"context_line":"    # Borg 1.2 and newer exit with rc 1 if warnings occur. The most common"},{"line_number":74,"context_line":"    # warning is for files that change while being backed up. We treat that"},{"line_number":75,"context_line":"    # as a successful backup if it occurs."}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"2561d10d_3a2b8093","line":72,"updated":"2025-01-21 16:16:10.000000000","message":"Does this comparison actually work the way you think? for example, will 1.2.11 be greater or less than 1.2.8? I suspect you\u0027re going to need some gymnastics with `sort -V` or one of those convoluted recipes that break up the string into component integers and then perform independent integer comparisons on each one.","commit_id":"1829aaa8f491c8df1f9ae159a07520c09aaca5bb"}]}