)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3469486b16b40b167fbfffe4bf25db3b9e928b67","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The good news is that gitea supports several backends (called adapters)"},{"line_number":17,"context_line":"for the cache. We elect to use memcached because it is relatively"},{"line_number":18,"context_line":"simple and has a FOSS license (unlike redis). The other alternative we"},{"line_number":19,"context_line":"could consider is twoqueue which also caches within memory in the Go"},{"line_number":20,"context_line":"runtime but allows for setting a size limit. I\u0027ve gone with memcached"},{"line_number":21,"context_line":"because it doesn\u0027t rely on Golang GC, but twoqueue is likely simpler if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ebd7786a_b8c07696","line":18,"updated":"2025-02-26 22:00:32.000000000","message":"Nit: Though there\u0027s a FOSS fork of redis too.","commit_id":"90d3a7f1d733dc32be20059029490cd37ab5beb2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"acf5ca263da57465ff6f9d7b8349f422f0dad1a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3a96092_6f1a095f","updated":"2025-02-26 07:19:39.000000000","message":"Actually one thing\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_bf8/942650/4/check/system-config-run-gitea/bf82e3f/gitea99.opendev.org/containers/\n\ndoesn\u0027t have the memcached log?  IIRC that\u0027s based on it being connected to a syslog driver?","commit_id":"90d3a7f1d733dc32be20059029490cd37ab5beb2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d97eb5faac2e53ca1f06d9445c749fc112d0547f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a4173e0d_b52bfb5e","updated":"2025-02-26 22:15:12.000000000","message":"oh sorry i totally missed the testinfra comment.  i did think that it would probably write out the log file even if it was blank.  We have https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_bf8/942650/4/check/system-config-run-gitea/bf82e3f/gitea99.opendev.org/docker/index.html but i think that comes from iterating over the running containers in the tests","commit_id":"90d3a7f1d733dc32be20059029490cd37ab5beb2"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"dfcf2e0a337eb428aba3fab324ad774b427a073c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a21485cd_75cb27e3","updated":"2025-02-28 15:51:51.000000000","message":"recheck docker hub rate limits","commit_id":"63ff0d263a251e260dfc0612909537bb5776e55c"}],"playbooks/roles/gitea/tasks/main.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3469486b16b40b167fbfffe4bf25db3b9e928b67","unresolved":true,"context_lines":[{"line_number":34,"context_line":"- name: Install distro packages"},{"line_number":35,"context_line":"  package:"},{"line_number":36,"context_line":"    name:"},{"line_number":37,"context_line":"      # TODO(clarkb) does the install-docker role handle these two packages?"},{"line_number":38,"context_line":"      - docker-compose"},{"line_number":39,"context_line":"      - python3-requests"},{"line_number":40,"context_line":"      # Installed to make checking memcached stats easy in testing and for"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0d82b5eb_d7da50b0","line":37,"updated":"2025-02-26 22:00:32.000000000","message":"If you mean ensure-docker from zuul-jobs, then it can install docker-compose yes: https://opendev.org/zuul/zuul-jobs/src/commit/55db214/roles/ensure-docker/tasks/main.yaml#L63-L68 (also `apt show docker-compose` on one of our production gitea backends indicates it declares a package dependency on python3-requests already).","commit_id":"90d3a7f1d733dc32be20059029490cd37ab5beb2"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"08e4a1b2907cba46fd1d4e6fdcfaaa7f3305369d","unresolved":true,"context_lines":[{"line_number":34,"context_line":"- name: Install distro packages"},{"line_number":35,"context_line":"  package:"},{"line_number":36,"context_line":"    name:"},{"line_number":37,"context_line":"      # TODO(clarkb) does the install-docker role handle these two packages?"},{"line_number":38,"context_line":"      - docker-compose"},{"line_number":39,"context_line":"      - python3-requests"},{"line_number":40,"context_line":"      # Installed to make checking memcached stats easy in testing and for"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"abb97102_6c834cec","line":37,"in_reply_to":"0d82b5eb_d7da50b0","updated":"2025-02-26 23:49:15.000000000","message":"https://opendev.org/opendev/system-config/src/branch/master/playbooks/roles/install-docker/tasks/default.yaml#L44-L59 this is what I referring to. We install docker-compose and python requests via pip which should go into /usr/local/bin and be preferred to the tools installed here which go in /usr/bin due to PATH order. Basically these packages seem unneeded and redundant.","commit_id":"90d3a7f1d733dc32be20059029490cd37ab5beb2"}],"playbooks/roles/gitea/templates/docker-compose.yaml.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"dfc98024e1573ef31892c85582aa232f567c8b44","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    network_mode: host"},{"line_number":26,"context_line":"    restart: always"},{"line_number":27,"context_line":"    command:"},{"line_number":28,"context_line":"      - -v"},{"line_number":29,"context_line":"      - --listen\u003d127.0.0.1:11211"},{"line_number":30,"context_line":"      - --memory-limit\u003d1024"},{"line_number":31,"context_line":"    logging:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"d410eef7_050f52d5","line":28,"updated":"2025-02-26 21:34:12.000000000","message":"There are four levels of memcache verbosity: no flag (default), -v, -vv, and -vvv. I was hoping for a log level that would capture client connections but not necessarily every client request. -vv seems to capture both things. -v should get us warnings and errors. And default seems to get us not much of anything. Anyway I\u0027ve set the level to -v here to get minimal output of important info like warnings.","commit_id":"90d3a7f1d733dc32be20059029490cd37ab5beb2"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3469486b16b40b167fbfffe4bf25db3b9e928b67","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    network_mode: host"},{"line_number":26,"context_line":"    restart: always"},{"line_number":27,"context_line":"    command:"},{"line_number":28,"context_line":"      - -v"},{"line_number":29,"context_line":"      - --listen\u003d127.0.0.1:11211"},{"line_number":30,"context_line":"      - --memory-limit\u003d1024"},{"line_number":31,"context_line":"    logging:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9aa607f3_1177233f","line":28,"in_reply_to":"d410eef7_050f52d5","updated":"2025-02-26 22:00:32.000000000","message":"Thanks, I didn\u0027t realize it was quiet-by-default but this makes sense.","commit_id":"90d3a7f1d733dc32be20059029490cd37ab5beb2"}],"testinfra/test_gitea.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"dfc98024e1573ef31892c85582aa232f567c8b44","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    # we don\u0027t create the file or very verbose and far too chatty for"},{"line_number":80,"context_line":"    # production (basically no logs or every set and get is logged)."},{"line_number":81,"context_line":"    #memcached_log \u003d host.file(\u0027/var/log/containers/docker-memcached.log\u0027)"},{"line_number":82,"context_line":"    #assert memcached_log.exists"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    gitea_log \u003d host.file(\u0027/var/log/containers/docker-gitea.log\u0027)"},{"line_number":85,"context_line":"    assert gitea_log.exists"}],"source_content_type":"text/x-python","patch_set":4,"id":"5c16da77_c90d06d2","line":82,"updated":"2025-02-26 21:34:12.000000000","message":"Would you prefer that I delete this block? I wanted to make it clear why one of the container log files isn\u0027t checked. I could just leave the comment and drop the commented out code I guess.","commit_id":"90d3a7f1d733dc32be20059029490cd37ab5beb2"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3469486b16b40b167fbfffe4bf25db3b9e928b67","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    # we don\u0027t create the file or very verbose and far too chatty for"},{"line_number":80,"context_line":"    # production (basically no logs or every set and get is logged)."},{"line_number":81,"context_line":"    #memcached_log \u003d host.file(\u0027/var/log/containers/docker-memcached.log\u0027)"},{"line_number":82,"context_line":"    #assert memcached_log.exists"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    gitea_log \u003d host.file(\u0027/var/log/containers/docker-gitea.log\u0027)"},{"line_number":85,"context_line":"    assert gitea_log.exists"}],"source_content_type":"text/x-python","patch_set":4,"id":"f92ffea5_4a51c6a2","line":82,"in_reply_to":"5c16da77_c90d06d2","updated":"2025-02-26 22:00:32.000000000","message":"No, it seems fine to keep there as a reminder.","commit_id":"90d3a7f1d733dc32be20059029490cd37ab5beb2"}]}