)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1bd6c2869f596f6e36ca39e613e62ce52613a8bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f5ed1952_65a83bde","updated":"2025-04-07 00:52:15.000000000","message":"Looks fine to me.\n\nI cant\u0027t verify this is what we want, but given the author I\u0027m erring on the side of trust.","commit_id":"d20a51a607927affc860638cebb2ee13b9b31938"}],"playbooks/roles/mirror-update/files/yum-puppetlabs-mirror-update":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1bd6c2869f596f6e36ca39e613e62ce52613a8bd","unresolved":true,"context_lines":[{"line_number":37,"context_line":"date --iso-8601\u003dns"},{"line_number":38,"context_line":"echo \"Running rsync...\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# We don\u0027t need cisco-wrlinux arch in OpenStack Infra."},{"line_number":41,"context_line":"$K5START rsync -rltvz \\"},{"line_number":42,"context_line":"    --delete \\"},{"line_number":43,"context_line":"    --delete-excluded \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"21bd0ae0_495d2bdd","line":40,"updated":"2025-04-07 00:52:15.000000000","message":"nit:  Perhaps it\u0027s time to update this comment more along the lines of:\n\n```\n# Only mirror $x, $y and $z\n# No need to mirror $X, $Y, and $Z, as they are not used in our infra\n```\n\nI don\u0027t actually know the correct values ${x,y,z,X,Y,Z}","commit_id":"d20a51a607927affc860638cebb2ee13b9b31938"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8bca2138e7a6b1cb3088325bfff0524e1ff47028","unresolved":false,"context_lines":[{"line_number":37,"context_line":"date --iso-8601\u003dns"},{"line_number":38,"context_line":"echo \"Running rsync...\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# We don\u0027t need cisco-wrlinux arch in OpenStack Infra."},{"line_number":41,"context_line":"$K5START rsync -rltvz \\"},{"line_number":42,"context_line":"    --delete \\"},{"line_number":43,"context_line":"    --delete-excluded \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa40d18b_249d5f6a","line":40,"in_reply_to":"21bd0ae0_495d2bdd","updated":"2025-08-22 16:11:36.000000000","message":"Done","commit_id":"d20a51a607927affc860638cebb2ee13b9b31938"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fc4cdfbcdf463fbd10a7a5b10733a7dbffe10995","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    --exclude\u003d\"*fedora*\" \\"},{"line_number":49,"context_line":"    --exclude\u003d\"*sles*\" \\"},{"line_number":50,"context_line":"    --exclude\u003d\"el/[5-8]*\" \\"},{"line_number":51,"context_line":"    --exclude\u003d\"*-el-[5-8]\\.noarch\\.rpm\" \\"},{"line_number":52,"context_line":"    $MIRROR/yum/ $BASE"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# TODO(pabelanger): Validate rsync process"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"80a51913_3fc433ee","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":35},"updated":"2025-08-22 15:29:55.000000000","message":"Reading the rsync manpage I don\u0027t think `.` is a wildcard character so I\u0027m not sure the `\\.` is necessary. Its possible that it is a noop and this rule will work just fine but we might consider removing the `\\`s to avoid confusion.","commit_id":"d20a51a607927affc860638cebb2ee13b9b31938"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"95d5abecb2880bd82d54864d3137bdd51478b4fc","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    --exclude\u003d\"*fedora*\" \\"},{"line_number":49,"context_line":"    --exclude\u003d\"*sles*\" \\"},{"line_number":50,"context_line":"    --exclude\u003d\"el/[5-8]*\" \\"},{"line_number":51,"context_line":"    --exclude\u003d\"*-el-[5-8]\\.noarch\\.rpm\" \\"},{"line_number":52,"context_line":"    $MIRROR/yum/ $BASE"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# TODO(pabelanger): Validate rsync process"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"87f904e8_482684bb","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":35},"in_reply_to":"80a51913_3fc433ee","updated":"2025-08-22 15:37:52.000000000","message":"Yes, rsync\u0027s match expressions are more akin to shell globbing patterns than regex. I agree these are unnecessary, but probably working because the shell is treating it as an escape rather than a literal backslash in the string.","commit_id":"d20a51a607927affc860638cebb2ee13b9b31938"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8bca2138e7a6b1cb3088325bfff0524e1ff47028","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    --exclude\u003d\"*fedora*\" \\"},{"line_number":49,"context_line":"    --exclude\u003d\"*sles*\" \\"},{"line_number":50,"context_line":"    --exclude\u003d\"el/[5-8]*\" \\"},{"line_number":51,"context_line":"    --exclude\u003d\"*-el-[5-8]\\.noarch\\.rpm\" \\"},{"line_number":52,"context_line":"    $MIRROR/yum/ $BASE"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# TODO(pabelanger): Validate rsync process"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"36b598ad_a01c257e","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":35},"in_reply_to":"87f904e8_482684bb","updated":"2025-08-22 16:11:36.000000000","message":"Done","commit_id":"d20a51a607927affc860638cebb2ee13b9b31938"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"519c29b0616f6932287a01d20cd16430906e3a31","unresolved":true,"context_lines":[{"line_number":58,"context_line":"$K5START rsync -rltvz \\"},{"line_number":59,"context_line":"    --delete \\"},{"line_number":60,"context_line":"    --delete-excluded \\"},{"line_number":61,"context_line":"    --exclude\u003d\"*aarch64*\" \\"},{"line_number":62,"context_line":"    --exclude\u003d\"*amazon*\" \\"},{"line_number":63,"context_line":"    --exclude\u003d\"el/[5-8]*\" \\"},{"line_number":64,"context_line":"    --exclude\u003d\"*-el-[5-8].noarch.rpm\" \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"882a4eea_c0aefa6b","line":61,"updated":"2025-08-22 16:23:43.000000000","message":"So not doing any Puppet testing on ARM, I guess?","commit_id":"d2427800c6dcf63bc0ddcbb58b420d958e207433"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"df145e003261a7ab243478966ef5915e236dc0c7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"$K5START rsync -rltvz \\"},{"line_number":59,"context_line":"    --delete \\"},{"line_number":60,"context_line":"    --delete-excluded \\"},{"line_number":61,"context_line":"    --exclude\u003d\"*aarch64*\" \\"},{"line_number":62,"context_line":"    --exclude\u003d\"*amazon*\" \\"},{"line_number":63,"context_line":"    --exclude\u003d\"el/[5-8]*\" \\"},{"line_number":64,"context_line":"    --exclude\u003d\"*-el-[5-8].noarch.rpm\" \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"d3c3a35b_0c0ba7ce","line":61,"in_reply_to":"40716db1_d92b7725","updated":"2025-08-22 17:46:16.000000000","message":"Done","commit_id":"d2427800c6dcf63bc0ddcbb58b420d958e207433"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"18f153219eec01f31e9f1e6eabbcb06e2867745d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"$K5START rsync -rltvz \\"},{"line_number":59,"context_line":"    --delete \\"},{"line_number":60,"context_line":"    --delete-excluded \\"},{"line_number":61,"context_line":"    --exclude\u003d\"*aarch64*\" \\"},{"line_number":62,"context_line":"    --exclude\u003d\"*amazon*\" \\"},{"line_number":63,"context_line":"    --exclude\u003d\"el/[5-8]*\" \\"},{"line_number":64,"context_line":"    --exclude\u003d\"*-el-[5-8].noarch.rpm\" \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"40716db1_d92b7725","line":61,"in_reply_to":"882a4eea_c0aefa6b","updated":"2025-08-22 16:26:23.000000000","message":"Yeah we have not jobs running on ARM in Puppet OpenStack.","commit_id":"d2427800c6dcf63bc0ddcbb58b420d958e207433"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"519c29b0616f6932287a01d20cd16430906e3a31","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    --delete-excluded \\"},{"line_number":61,"context_line":"    --exclude\u003d\"*aarch64*\" \\"},{"line_number":62,"context_line":"    --exclude\u003d\"*amazon*\" \\"},{"line_number":63,"context_line":"    --exclude\u003d\"el/[5-8]*\" \\"},{"line_number":64,"context_line":"    --exclude\u003d\"*-el-[5-8].noarch.rpm\" \\"},{"line_number":65,"context_line":"    --exclude\u003d\"*cisco-wrlinux*\" \\"},{"line_number":66,"context_line":"    --exclude\u003d\"*cumulus*\" \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"79f66573_e085b638","line":63,"updated":"2025-08-22 16:23:43.000000000","message":"I confirmed in the rsync manpage that it does support using square brackets for character classes in its match patterns.\n\nOh, and it does actually talk about backslashes, whether or not it treats them as an escape is dependent on the presence/absence of other globbing indicators (*, **, ?).","commit_id":"d2427800c6dcf63bc0ddcbb58b420d958e207433"}]}