)]}'
{"install_modules.sh":[{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"9e6be35f2b41b84311cbdf226fc2ad222ea4576f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"MODULES[\"puppetlabs-puppetdb\"]\u003d\"3.0.1\""},{"line_number":56,"context_line":"MODULES[\"stankevich-python\"]\u003d\"1.6.6\""},{"line_number":57,"context_line":"MODULES[\"example42-puppi\"]\u003d\"2.1.9\""},{"line_number":58,"context_line":"MODULES[\"puppetlabs-rabbitmq\"]\u003d\"3.1.0\""},{"line_number":59,"context_line":"MODULES[\"garethr-erlang\"]\u003d\"0.1.0\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"SOURCE_MODULES[\"https://github.com/nibalizer/puppet-module-puppetboard\"]\u003d\"2.4.0\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"baada198_385cec4b","line":58,"updated":"2014-08-12 01:28:44.000000000","message":"Why aren\u0027t we using the 4.0 release?","commit_id":"8e7f2039eebeda15a96e2026a9bdb53d528db137"}],"modules/openstack_project/manifests/storyboard.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c032b292129c5024e37400f48606076284412000","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  $mysql_password \u003d \u0027\u0027,"},{"line_number":6,"context_line":"  $mysql_user \u003d \u0027\u0027,"},{"line_number":7,"context_line":"  $rabbitmq_user \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $rabbitmq_password \u003d \u0027\u0027,"},{"line_number":9,"context_line":"  $sysadmins \u003d [],"},{"line_number":10,"context_line":"  $ssl_cert_file_contents \u003d undef,"},{"line_number":11,"context_line":"  $ssl_key_file_contents \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"baada198_dd05a279","line":8,"updated":"2014-08-12 00:38:38.000000000","message":"If you don\u0027t set a default value for rabbitmq password puppet forces you to provide one. I prefer this to potentially accidentally setting an empty password or a password of \u0027changeme\u0027 as in the other manifests.\n\nAlso, can we set a reasonable rabbitmq_user? Something like storyboard?","commit_id":"8e7f2039eebeda15a96e2026a9bdb53d528db137"}],"modules/storyboard/Modulefile":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c032b292129c5024e37400f48606076284412000","unresolved":false,"context_lines":[{"line_number":13,"context_line":"dependency \u0027puppetlabs/rabbitmq\u0027, \u0027\u003d 3.1.0\u0027"},{"line_number":14,"context_line":"dependency \u0027example42/puppi\u0027, \u0027\u003d 2.1.9\u0027"},{"line_number":15,"context_line":"dependency \u0027openstackci/vcsrepo\u0027, \u0027\u003d 0.0.8\u0027"},{"line_number":16,"context_line":"dependency \u0027stankevich/python\u0027, \u0027\u003d 1.6.6\u0027"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_7debb6dc","line":16,"updated":"2014-08-12 00:38:38.000000000","message":"Does this file not need the erlang module too?","commit_id":"8e7f2039eebeda15a96e2026a9bdb53d528db137"}],"modules/storyboard/manifests/application.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c032b292129c5024e37400f48606076284412000","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  $rabbitmq_port          \u003d 5672,"},{"line_number":40,"context_line":"  $rabbitmq_vhost         \u003d \u0027/\u0027,"},{"line_number":41,"context_line":"  $rabbitmq_user          \u003d \u0027storyboard\u0027,"},{"line_number":42,"context_line":"  $rabbitmq_user_password \u003d \u0027changemetoo\u0027"},{"line_number":43,"context_line":") {"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  # Dependencies"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"baada198_5d38b23a","line":42,"updated":"2014-08-12 00:38:38.000000000","message":"I am partial to leaving this unset so that puppet forces you to set it. Mysql does this though so I don\u0027t think we need to change this now.","commit_id":"8e7f2039eebeda15a96e2026a9bdb53d528db137"}],"modules/storyboard/manifests/init.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c032b292129c5024e37400f48606076284412000","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $mysql_user_password \u003d \u0027changeme\u0027,"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  $rabbitmq_user            \u003d \u0027storyboard\u0027,"},{"line_number":28,"context_line":"  $rabbitmq_user_password   \u003d \u0027changemetoo\u0027,"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  $hostname            \u003d $::fqdn,"},{"line_number":31,"context_line":"  $openid_url          \u003d \u0027https://login.launchpad.net/+openid\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"baada198_3d24de0c","line":28,"updated":"2014-08-12 00:38:38.000000000","message":"See comments about passwords in the other files.","commit_id":"8e7f2039eebeda15a96e2026a9bdb53d528db137"}],"modules/storyboard/manifests/rabbit.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c032b292129c5024e37400f48606076284412000","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  }"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  rabbitmq_user { $rabbitmq_user:"},{"line_number":32,"context_line":"    admin    \u003d\u003e true,"},{"line_number":33,"context_line":"    password \u003d\u003e $rabbitmq_user_password"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"baada198_3dc85e55","line":32,"updated":"2014-08-12 00:38:38.000000000","message":"I don\u0027t know enough about rabbitmq admin users to know if we need admin here. Typically you wouldn\u0027t give admin to the service consuming the thing though.","commit_id":"8e7f2039eebeda15a96e2026a9bdb53d528db137"}]}
