)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f36b399ad551693197723f943cb0e61a1aaa22ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6ddb8bd3_923a3557","updated":"2026-05-12 23:10:19.000000000","message":"I\u0027ve noted a few things inline mostly around potential simplifications. As noted before I think simple is good so am happy if we can simplify further.\n\nAnother thing I notice (and this is a problem with the parent prometheus change too) is that we don\u0027t have an infra-prod-service-prometheus or infra-prod-service-greptimedb job defined and set in the deployment pipelines yet. I think this is ok if we want to get everything sorted out in the test envs first then have a separate change that adds those jobs when we add nodes to the inventory. But I wanted to call it out here because if we do run prometheus and greptimedb on the same host as suggested inline then we would only need infra-prod-service-prometheus and not the separate greptimedb job.","commit_id":"123b37885419669c373f5e006fc5d37d8b02385a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bf71d44f158efaade7e27ac1d8f8500fe61eb69a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"537bcc47_f1fb6611","updated":"2026-05-26 18:11:19.000000000","message":"Needs some work with configuring the Swift/S3 endpoint","commit_id":"765af3d711a0d38a54be8823c66f0befc96092ae"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"76d3c9c90c056312b2196f716bd23e28c74f2731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"fd9d86d5_d8118c2e","in_reply_to":"537bcc47_f1fb6611","updated":"2026-05-27 05:53:48.000000000","message":"Done","commit_id":"765af3d711a0d38a54be8823c66f0befc96092ae"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8ca186a271b0fa460ab4051131672cea4d5578db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"9311d688_c506c4e5","updated":"2026-05-28 15:46:33.000000000","message":"Inline comments are mostly around variable default logistics. I don\u0027t feel strongly about any of those comments but wanted to bring some thoughts up for discussion/consideration.\n\nThen separately thinking ahead to where we add the deployment job and a node to the prometheus group we will need to provision some s3 credentials on top of swift. Currently we have access to swift in three cloud providers: rax classic, rax flex, and ovh. I don\u0027t know which of these support s3, but I want to say both rackspace clouds do? Maybe we see if rax flex does and start there since this is a new deployment?","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2add08b62e08719a64ca471b1de14cf5154571a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"408f31af_2f6e4b91","updated":"2026-06-02 16:51:42.000000000","message":"recheck what is the depends on chagne with a configuration error?","commit_id":"f33c6146f9e67eed8ed57af546815e436c883653"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4476d0f7d2d96c67a97169bb711d083d1d684a76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"e112e2d2_a8ea231b","updated":"2026-06-08 22:13:44.000000000","message":"+2 but one of the two inline comments may be worth updating for. Consider it a nit.","commit_id":"66f5b3dda5bafa1f6e9a6a91e728dddb561c9e32"}],"inventory/service/group_vars/prometheus.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f36b399ad551693197723f943cb0e61a1aaa22ee","unresolved":true,"context_lines":[{"line_number":1,"context_line":"prometheus_vhost_name: prometheus.opendev.org"},{"line_number":2,"context_line":"prometheus_remote_write_url: http://greptimedb.opendev.org:4000/v1/prometheus/write"},{"line_number":3,"context_line":"prometheus_remote_read_url: http://greptimedb.opendev.org:4000/v1/prometheus/read"},{"line_number":4,"context_line":"letsencrypt_certs:"},{"line_number":5,"context_line":"  prometheus-opendev-org-main:"},{"line_number":6,"context_line":"    - prometheus.opendev.org"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1063e413_40ba5d31","line":3,"updated":"2026-05-12 23:10:19.000000000","message":"Would it be crazy to run prometheus and greptimedb on the same host? That might simplify firewall rules and reduce the total number of servers to manage. I don\u0027t know if this is considered a bad idea to due system load, but I expect much of the traffic is network io bound and we probably have enough throughput for that?","commit_id":"123b37885419669c373f5e006fc5d37d8b02385a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4764c3b5198a0d71ac2138d2596b6e945cc9f2dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"prometheus_vhost_name: prometheus.opendev.org"},{"line_number":2,"context_line":"prometheus_remote_write_url: http://greptimedb.opendev.org:4000/v1/prometheus/write"},{"line_number":3,"context_line":"prometheus_remote_read_url: http://greptimedb.opendev.org:4000/v1/prometheus/read"},{"line_number":4,"context_line":"letsencrypt_certs:"},{"line_number":5,"context_line":"  prometheus-opendev-org-main:"},{"line_number":6,"context_line":"    - prometheus.opendev.org"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf119b4b_6fa33e7d","line":3,"in_reply_to":"1063e413_40ba5d31","updated":"2026-05-13 13:29:52.000000000","message":"Done","commit_id":"123b37885419669c373f5e006fc5d37d8b02385a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8ca186a271b0fa460ab4051131672cea4d5578db","unresolved":true,"context_lines":[{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":7,"context_line":"greptimedb_s3_access_key_id: \"{{ vault_greptimedb_s3_access_key_id | default(\u0027\u0027) }}\""},{"line_number":8,"context_line":"greptimedb_s3_secret_access_key: \"{{ vault_greptimedb_s3_secret_access_key | default(\u0027\u0027) }}\""},{"line_number":9,"context_line":"letsencrypt_certs:"},{"line_number":10,"context_line":"  prometheus-opendev-org-main:"},{"line_number":11,"context_line":"    - prometheus.opendev.org"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"04f4eb40_b70ce4c5","line":8,"updated":"2026-05-28 15:46:33.000000000","message":"See comment in greptimedb role defaults file about setting defaults for secrets. I\u0027m thinking maybe it is better to not set these at all and error if they are unset when writing the config than to have defaults that are non functional. That way if these values are not set we get a clear failure signal.","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2add08b62e08719a64ca471b1de14cf5154571a2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":7,"context_line":"greptimedb_s3_access_key_id: \"{{ vault_greptimedb_s3_access_key_id | default(\u0027\u0027) }}\""},{"line_number":8,"context_line":"greptimedb_s3_secret_access_key: \"{{ vault_greptimedb_s3_secret_access_key | default(\u0027\u0027) }}\""},{"line_number":9,"context_line":"letsencrypt_certs:"},{"line_number":10,"context_line":"  prometheus-opendev-org-main:"},{"line_number":11,"context_line":"    - prometheus.opendev.org"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"f719aa08_5e7a7f85","line":8,"in_reply_to":"04f4eb40_b70ce4c5","updated":"2026-06-02 16:51:42.000000000","message":"Done","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4476d0f7d2d96c67a97169bb711d083d1d684a76","unresolved":true,"context_lines":[{"line_number":2,"context_line":"prometheus_remote_write_url: http://localhost:4000/v1/prometheus/write"},{"line_number":3,"context_line":"prometheus_remote_read_url: http://localhost:4000/v1/prometheus/read"},{"line_number":4,"context_line":"greptimedb_storage_type: \"S3\""},{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":7,"context_line":"letsencrypt_certs:"},{"line_number":8,"context_line":"  prometheus-opendev-org-main:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"f7fe4052_fe2c9560","line":5,"updated":"2026-06-08 22:13:44.000000000","message":"Now that we\u0027re setting greptime_s3_bucket in greptimedb/defaults/main.yaml should we be overriding it to \"\" here? I think the group vars will win over role default var values.","commit_id":"66f5b3dda5bafa1f6e9a6a91e728dddb561c9e32"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ed780031445cf084e625705390d28647778c2c88","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prometheus_remote_write_url: http://localhost:4000/v1/prometheus/write"},{"line_number":3,"context_line":"prometheus_remote_read_url: http://localhost:4000/v1/prometheus/read"},{"line_number":4,"context_line":"greptimedb_storage_type: \"S3\""},{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":7,"context_line":"letsencrypt_certs:"},{"line_number":8,"context_line":"  prometheus-opendev-org-main:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"4ee5e52c_f6ebf916","line":5,"in_reply_to":"f7fe4052_fe2c9560","updated":"2026-06-09 22:14:01.000000000","message":"Done","commit_id":"66f5b3dda5bafa1f6e9a6a91e728dddb561c9e32"}],"playbooks/roles/greptimedb/defaults/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8ca186a271b0fa460ab4051131672cea4d5578db","unresolved":true,"context_lines":[{"line_number":2,"context_line":"greptimedb_http_addr: \"127.0.0.1:4000\""},{"line_number":3,"context_line":"greptimedb_data_home: \"/var/lib/greptimedb\""},{"line_number":4,"context_line":"greptimedb_storage_type: \"File\""},{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_root: \"/greptime-data\""},{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"ffe13c72_8bd60075","line":5,"updated":"2026-05-28 15:46:33.000000000","message":"If using swift\u0027s s3 middleware do we get control of the bucket/container name? If so maybe we can set a sensible default here like greptimedbbucket?","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a549a3efdb573606bcbfef01539ec394867ca3ee","unresolved":false,"context_lines":[{"line_number":2,"context_line":"greptimedb_http_addr: \"127.0.0.1:4000\""},{"line_number":3,"context_line":"greptimedb_data_home: \"/var/lib/greptimedb\""},{"line_number":4,"context_line":"greptimedb_storage_type: \"File\""},{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_root: \"/greptime-data\""},{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"a0098736_56b34212","line":5,"in_reply_to":"ffe13c72_8bd60075","updated":"2026-06-02 16:22:01.000000000","message":"Done","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8ca186a271b0fa460ab4051131672cea4d5578db","unresolved":true,"context_lines":[{"line_number":3,"context_line":"greptimedb_data_home: \"/var/lib/greptimedb\""},{"line_number":4,"context_line":"greptimedb_storage_type: \"File\""},{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_root: \"/greptime-data\""},{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""},{"line_number":9,"context_line":"greptimedb_s3_access_key_id: \"\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"f86878aa_beb3ab40","line":6,"updated":"2026-05-28 15:46:33.000000000","message":"Is this a path that will serve as a prefix for all objects in the greptimedb_s3_bucket?","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2add08b62e08719a64ca471b1de14cf5154571a2","unresolved":true,"context_lines":[{"line_number":3,"context_line":"greptimedb_data_home: \"/var/lib/greptimedb\""},{"line_number":4,"context_line":"greptimedb_storage_type: \"File\""},{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_root: \"/greptime-data\""},{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""},{"line_number":9,"context_line":"greptimedb_s3_access_key_id: \"\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"280248ea_61d9c224","line":6,"in_reply_to":"12d7d454_fbc59506","updated":"2026-06-02 16:51:42.000000000","message":"No I think this is fine.","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fa658ad17077c19de6a07b094bb7b16d191fe711","unresolved":false,"context_lines":[{"line_number":3,"context_line":"greptimedb_data_home: \"/var/lib/greptimedb\""},{"line_number":4,"context_line":"greptimedb_storage_type: \"File\""},{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_root: \"/greptime-data\""},{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""},{"line_number":9,"context_line":"greptimedb_s3_access_key_id: \"\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"793d4336_bc889199","line":6,"in_reply_to":"280248ea_61d9c224","updated":"2026-06-02 17:46:32.000000000","message":"Acknowledged","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a549a3efdb573606bcbfef01539ec394867ca3ee","unresolved":true,"context_lines":[{"line_number":3,"context_line":"greptimedb_data_home: \"/var/lib/greptimedb\""},{"line_number":4,"context_line":"greptimedb_storage_type: \"File\""},{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_root: \"/greptime-data\""},{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""},{"line_number":9,"context_line":"greptimedb_s3_access_key_id: \"\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"12d7d454_fbc59506","line":6,"in_reply_to":"f86878aa_beb3ab40","updated":"2026-06-02 16:22:01.000000000","message":"Yes - unless we want /","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8ca186a271b0fa460ab4051131672cea4d5578db","unresolved":true,"context_lines":[{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_root: \"/greptime-data\""},{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""},{"line_number":9,"context_line":"greptimedb_s3_access_key_id: \"\""},{"line_number":10,"context_line":"greptimedb_s3_secret_access_key: \"\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"61c701a2_db22594e","line":8,"updated":"2026-05-28 15:46:33.000000000","message":"Since we\u0027re unlikely to use aws s3 maybe we leave the region unset?","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a549a3efdb573606bcbfef01539ec394867ca3ee","unresolved":false,"context_lines":[{"line_number":5,"context_line":"greptimedb_s3_bucket: \"\""},{"line_number":6,"context_line":"greptimedb_s3_root: \"/greptime-data\""},{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""},{"line_number":9,"context_line":"greptimedb_s3_access_key_id: \"\""},{"line_number":10,"context_line":"greptimedb_s3_secret_access_key: \"\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"c29bbda9_bd72904b","line":8,"in_reply_to":"61c701a2_db22594e","updated":"2026-06-02 16:22:01.000000000","message":"Done","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8ca186a271b0fa460ab4051131672cea4d5578db","unresolved":true,"context_lines":[{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""},{"line_number":9,"context_line":"greptimedb_s3_access_key_id: \"\""},{"line_number":10,"context_line":"greptimedb_s3_secret_access_key: \"\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"71258f54_0b1c3b06","line":10,"updated":"2026-05-28 15:46:33.000000000","message":"Should the two secret values here not have defaults at all to force the values to be set in private vars?","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a549a3efdb573606bcbfef01539ec394867ca3ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"greptimedb_s3_endpoint: \"\""},{"line_number":8,"context_line":"greptimedb_s3_region: \"us-east-1\""},{"line_number":9,"context_line":"greptimedb_s3_access_key_id: \"\""},{"line_number":10,"context_line":"greptimedb_s3_secret_access_key: \"\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"dd523ae4_7ed63a8c","line":10,"in_reply_to":"71258f54_0b1c3b06","updated":"2026-06-02 16:22:01.000000000","message":"Done","commit_id":"0aa299f181b9cdb1d61265ba352d7754cc7a7363"}],"playbooks/roles/greptimedb/handlers/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f36b399ad551693197723f943cb0e61a1aaa22ee","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: restart greptimedb"},{"line_number":2,"context_line":"  shell:"},{"line_number":3,"context_line":"    cmd: docker-compose restart"},{"line_number":4,"context_line":"    chdir: /etc/greptimedb-docker/"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"788a7fa7_969b3414","line":1,"updated":"2026-05-12 23:10:19.000000000","message":"We don\u0027t seem to notify this handler anywhere. Can we remove it?","commit_id":"123b37885419669c373f5e006fc5d37d8b02385a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4764c3b5198a0d71ac2138d2596b6e945cc9f2dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: restart greptimedb"},{"line_number":2,"context_line":"  shell:"},{"line_number":3,"context_line":"    cmd: docker-compose restart"},{"line_number":4,"context_line":"    chdir: /etc/greptimedb-docker/"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6e633578_9d03399a","line":1,"in_reply_to":"788a7fa7_969b3414","updated":"2026-05-13 13:29:52.000000000","message":"Done","commit_id":"123b37885419669c373f5e006fc5d37d8b02385a"}],"playbooks/roles/greptimedb/templates/greptimedb.toml.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4476d0f7d2d96c67a97169bb711d083d1d684a76","unresolved":true,"context_lines":[{"line_number":1,"context_line":"data_home \u003d \"{{ greptimedb_data_home }}\""},{"line_number":2,"context_line":"enable_telemetry \u003d false"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[http]"},{"line_number":5,"context_line":"addr \u003d \"{{ greptimedb_http_addr }}\""}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"6404c759_a826e5c4","line":2,"updated":"2026-06-08 22:13:44.000000000","message":"Thank you for adding this. It never even occurred to me that this would be something to check for.","commit_id":"66f5b3dda5bafa1f6e9a6a91e728dddb561c9e32"}],"playbooks/roles/greptimedb/templates/greptimedb.vhost.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f36b399ad551693197723f943cb0e61a1aaa22ee","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  ProxyPass  / http://127.0.0.1:4000/ retry\u003d0"},{"line_number":40,"context_line":"  ProxyPassReverse / http://127.0.0.1:4000/"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7d8824e8_db988cf2","line":42,"updated":"2026-05-12 23:10:19.000000000","message":"We don\u0027t seem to configure apache in the main ansible task file for greptimedb. Can we drop this?","commit_id":"123b37885419669c373f5e006fc5d37d8b02385a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4764c3b5198a0d71ac2138d2596b6e945cc9f2dd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  ProxyPass  / http://127.0.0.1:4000/ retry\u003d0"},{"line_number":40,"context_line":"  ProxyPassReverse / http://127.0.0.1:4000/"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"11f36652_dfbe5d0b","line":42,"in_reply_to":"7d8824e8_db988cf2","updated":"2026-05-13 13:29:52.000000000","message":"Done","commit_id":"123b37885419669c373f5e006fc5d37d8b02385a"}],"playbooks/roles/letsencrypt-create-certs/handlers/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f36b399ad551693197723f943cb0e61a1aaa22ee","unresolved":true,"context_lines":[{"line_number":161,"context_line":"# GrepTimeDB"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"- name: letsencrypt updated greptimedb-opendev-org-main"},{"line_number":164,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# Codesearch (hound)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fdb7624c_8850b52c","line":164,"updated":"2026-05-12 23:10:19.000000000","message":"See comment in apache vhost file. But I think maybe we aren\u0027t using apache so we can drop this?","commit_id":"123b37885419669c373f5e006fc5d37d8b02385a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4764c3b5198a0d71ac2138d2596b6e945cc9f2dd","unresolved":false,"context_lines":[{"line_number":161,"context_line":"# GrepTimeDB"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"- name: letsencrypt updated greptimedb-opendev-org-main"},{"line_number":164,"context_line":"  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# Codesearch (hound)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c0acf978_6e96c7ec","line":164,"in_reply_to":"fdb7624c_8850b52c","updated":"2026-05-13 13:29:52.000000000","message":"Done","commit_id":"123b37885419669c373f5e006fc5d37d8b02385a"}],"playbooks/service-greptimedb.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f7deb722d49c2186f96d1cceebc55565a82d0310","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- hosts: \"greptimedb:!disabled\""},{"line_number":2,"context_line":"  name: \"Base: configure greptimedb\""},{"line_number":3,"context_line":"  roles:"},{"line_number":4,"context_line":"    - iptables"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6e58d085_6f28f39c","line":1,"range":{"start_line":1,"start_character":10,"end_line":1,"end_character":20},"updated":"2026-05-26 21:50:42.000000000","message":"This group has been dropped so while this playbook was executed by the test job it didn\u0027t apply against anything.\n\nMaybe we should have a single playbook for both prometheus and greptimedb? Similar to the zuul playbook where zuul-scheduler runs both the scheduler and web roles: https://opendev.org/opendev/system-config/src/branch/master/playbooks/service-zuul.yaml#L37-L42","commit_id":"765af3d711a0d38a54be8823c66f0befc96092ae"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"76d3c9c90c056312b2196f716bd23e28c74f2731","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: \"greptimedb:!disabled\""},{"line_number":2,"context_line":"  name: \"Base: configure greptimedb\""},{"line_number":3,"context_line":"  roles:"},{"line_number":4,"context_line":"    - iptables"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a7229190_57106781","line":1,"range":{"start_line":1,"start_character":10,"end_line":1,"end_character":20},"in_reply_to":"6e58d085_6f28f39c","updated":"2026-05-27 05:53:48.000000000","message":"Done","commit_id":"765af3d711a0d38a54be8823c66f0befc96092ae"}]}