)]}'
{"manifests/site.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7dad7c8204ce66f78e578c9267a8d480aafc2f85","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    site_admin_password \u003d\u003e hiera(\u0027groups_dev_site_admin_password\u0027, \u0027XXX\u0027),"},{"line_number":172,"context_line":"    site_mysql_host     \u003d\u003e hiera(\u0027groups_dev_site_mysql_host\u0027, \u0027localhost\u0027),"},{"line_number":173,"context_line":"    site_mysql_password \u003d\u003e hiera(\u0027groups_dev_site_mysql_password\u0027, \u0027XXX\u0027),"},{"line_number":174,"context_line":"    conf_cron_key       \u003d\u003e hiera(\u0027groups_dev_conf_cron_key\u0027, \u0027XXX\u0027),"},{"line_number":175,"context_line":"  }"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ae5cdf2_5279c691","line":174,"updated":"2014-06-19 01:12:33.000000000","message":"This one line concerns me. We don\u0027t have this key in heira and i am not sure what the key should be (drupal docs haven\u0027t helped much) and unfortunately \u0027XXX\u0027 will be used as the default which is most definitely wrong.\n\nCan you help us sort this out?","commit_id":"a33ba743992d18f0db4e15dcec924e3d56899ac3"},{"author":{"_account_id":6633,"name":"Marton Kiss","email":"marton.kiss@canonical.com","username":"marton-kiss"},"change_message_id":"32e4b0b99184b5516793b1c6cb8eef86316affe8","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    site_admin_password \u003d\u003e hiera(\u0027groups_dev_site_admin_password\u0027, \u0027XXX\u0027),"},{"line_number":172,"context_line":"    site_mysql_host     \u003d\u003e hiera(\u0027groups_dev_site_mysql_host\u0027, \u0027localhost\u0027),"},{"line_number":173,"context_line":"    site_mysql_password \u003d\u003e hiera(\u0027groups_dev_site_mysql_password\u0027, \u0027XXX\u0027),"},{"line_number":174,"context_line":"    conf_cron_key       \u003d\u003e hiera(\u0027groups_dev_conf_cron_key\u0027, \u0027XXX\u0027),"},{"line_number":175,"context_line":"  }"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ae5cdf2_827db36f","line":174,"in_reply_to":"1ae5cdf2_5279c691","updated":"2014-06-19 09:37:51.000000000","message":"You just need to generate a guid or a random string here, it will prevent access of drupal\u0027s internal cron url from outside. Drupal init.pp contains the following cron entry:\nwget -O - -q -t 1 ${$site_base_url}/cron.php?cron_key\u003d${$conf_cron_key}\n\nand also this conf_cron_key is going to Drupal\u0027s settings.php:\n$conf[\u0027cron_key\u0027] \u003d \u0027\u003c%\u003d @conf_cron_key %\u003e\u0027;\n\nSo we are set them same secure key for cron job and drupal itself. Basically Drupal documentation contains a nice section about setting up cron here: https://www.drupal.org/cron","commit_id":"a33ba743992d18f0db4e15dcec924e3d56899ac3"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"37a6920db918dcb12983b32666943b7468a4df50","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    site_admin_password \u003d\u003e hiera(\u0027groups_dev_site_admin_password\u0027, \u0027XXX\u0027),"},{"line_number":172,"context_line":"    site_mysql_host     \u003d\u003e hiera(\u0027groups_dev_site_mysql_host\u0027, \u0027localhost\u0027),"},{"line_number":173,"context_line":"    site_mysql_password \u003d\u003e hiera(\u0027groups_dev_site_mysql_password\u0027, \u0027XXX\u0027),"},{"line_number":174,"context_line":"    conf_cron_key       \u003d\u003e hiera(\u0027groups_dev_conf_cron_key\u0027, \u0027XXX\u0027),"},{"line_number":175,"context_line":"  }"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ae5cdf2_881abf6d","line":174,"in_reply_to":"1ae5cdf2_827db36f","updated":"2014-06-24 00:26:34.000000000","message":"Done and added to hiera.","commit_id":"a33ba743992d18f0db4e15dcec924e3d56899ac3"}],"modules/drupal/manifests/drush.pp":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"a0ce7774cc1aa396acabed5036aca7e4f581fb2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013  OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ae5cdf2_34c6af9a","line":1,"updated":"2014-06-13 10:32:13.000000000","message":"(nit) 2013 was a good year, but it\u0027s 2014 now ;-)","commit_id":"a33ba743992d18f0db4e15dcec924e3d56899ac3"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"37a6920db918dcb12983b32666943b7468a4df50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013  OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ae5cdf2_08078f19","line":1,"in_reply_to":"1ae5cdf2_34c6af9a","updated":"2014-06-24 00:26:34.000000000","message":"If the content of this file is mostly just copied from another which was (c) 2013, then that\u0027s probably fine. If it\u0027s mostly new content on the other hand, then it does need updating.","commit_id":"a33ba743992d18f0db4e15dcec924e3d56899ac3"}],"modules/drupal/manifests/init.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7dad7c8204ce66f78e578c9267a8d480aafc2f85","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    unless    \u003d\u003e \"/usr/bin/test -L ${site_docroot}\","},{"line_number":107,"context_line":"    logoutput \u003d\u003e \u0027on_failure\u0027,"},{"line_number":108,"context_line":"    require   \u003d\u003e File[$site_root],"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  a2mod { \u0027rewrite\u0027:"},{"line_number":112,"context_line":"    ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1ae5cdf2_6f7fbddf","line":109,"updated":"2014-06-19 01:12:33.000000000","message":"This could probably be a puppet file resource but this works.","commit_id":"a33ba743992d18f0db4e15dcec924e3d56899ac3"}],"modules/drupal/templates/aliases.drushrc.php.erb":[{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"0a30384df0d7e0cdca9a477d2e615ae63f4c8232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ae5cdf2_3f7671a4","updated":"2014-06-14 01:10:59.000000000","message":"Now I don\u0027t now php from a hole in the ground but shouldn\u0027t there be a closing tag at the end of the file?","commit_id":"a33ba743992d18f0db4e15dcec924e3d56899ac3"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"c81902b8291e2b0c431aeca3488801ebb70ac224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ae5cdf2_655730cb","in_reply_to":"1ae5cdf2_1849b460","updated":"2014-06-17 15:29:39.000000000","message":"Oh okay. Thanks.","commit_id":"a33ba743992d18f0db4e15dcec924e3d56899ac3"},{"author":{"_account_id":6633,"name":"Marton Kiss","email":"marton.kiss@canonical.com","username":"marton-kiss"},"change_message_id":"b849cbe8de681f05bb7a55d24afd0b4a646821cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ae5cdf2_1849b460","in_reply_to":"1ae5cdf2_3f7671a4","updated":"2014-06-16 08:09:35.000000000","message":"Anita, omitting php closing tags are part of drupal coding standards. it prevents accidental injection of trailing white space, that can cause non-expected behaviour of script.","commit_id":"a33ba743992d18f0db4e15dcec924e3d56899ac3"}]}