)]}'
{"config_tempest/client_manager.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"16163743fffa4516671d025593f762cbd15ecec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f96bb07_27716d0d","line":270,"updated":"2018-01-23 02:50:42.000000000","message":"please remove 1 line to fix pep8 issue.","commit_id":"a2d129ddb539116eb6f6e8a9c184a8bff446b63a"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"2d76bdc200dcaab1fdb4e1070a6a5751ba545fb8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from tempest.lib.services.volume.v2 import services_client"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class ProjectsClient(object):"},{"line_number":36,"context_line":"    \"\"\"The class is a wrapper for managing projects/tenants."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    It instantiates tempest projects_client and provides methods for creating"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_391bf61b","line":35,"updated":"2018-01-25 20:07:41.000000000","message":"the file is called client_manager, but I\u0027m seeing ProjectsClient here as well, is that intentional?","commit_id":"31467b2821017351ecab9b6ecc35a82783baca7c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"67f3762186743a36ae06bbf2f97ea0c2be8ceaec","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from tempest.lib.services.volume.v2 import services_client"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class ProjectsClient(object):"},{"line_number":36,"context_line":"    \"\"\"The class is a wrapper for managing projects/tenants."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    It instantiates tempest projects_client and provides methods for creating"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_984c719f","line":35,"in_reply_to":"5f93b717_391bf61b","updated":"2018-01-26 12:47:04.000000000","message":"ProjectsClient is a wrapper class for working with project client. It\u0027s instantiated only in ClientManager. But I see the point, maybe we can name the file clients.py?","commit_id":"31467b2821017351ecab9b6ecc35a82783baca7c"}],"config_tempest/config_tempest.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"a9d9158e84f5ab6e7cb4287c8e2fead843dbe934","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        # new way for running using accounts file"},{"line_number":160,"context_line":"        conf.set(\"auth\", \"use_dynamic_credentials\", \"False\")"},{"line_number":161,"context_line":"        conf.set(\"auth\", \"test_accounts_file\", \"etc/accounts.yaml\")"},{"line_number":162,"context_line":"    import pudb; pudb.set_trace()"},{"line_number":163,"context_line":"    credentials \u003d Credentials(conf, not args.non_admin)"},{"line_number":164,"context_line":"    clients \u003d ClientManager(conf, credentials)"},{"line_number":165,"context_line":"    swift_discover \u003d conf.get_defaulted(\u0027object-storage-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_aedcb518","line":162,"updated":"2018-01-25 02:15:50.000000000","message":"should be in 2 lines, please","commit_id":"1b3f32eab3d2b8199de54d0749d0d7fc5ef52b23"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9099da4c98922d019b5c38ae2d1e132f6a37c83f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        # new way for running using accounts file"},{"line_number":160,"context_line":"        conf.set(\"auth\", \"use_dynamic_credentials\", \"False\")"},{"line_number":161,"context_line":"        conf.set(\"auth\", \"test_accounts_file\", \"etc/accounts.yaml\")"},{"line_number":162,"context_line":"    import pudb; pudb.set_trace()"},{"line_number":163,"context_line":"    credentials \u003d Credentials(conf, not args.non_admin)"},{"line_number":164,"context_line":"    clients \u003d ClientManager(conf, credentials)"},{"line_number":165,"context_line":"    swift_discover \u003d conf.get_defaulted(\u0027object-storage-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_6852186a","line":162,"in_reply_to":"5f93b717_aedcb518","updated":"2018-01-25 09:57:49.000000000","message":"oh, in a rush I forgot to delete my debug line, thanks, fixed","commit_id":"1b3f32eab3d2b8199de54d0749d0d7fc5ef52b23"}],"config_tempest/tests/test_config_tempest.py":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"2d76bdc200dcaab1fdb4e1070a6a5751ba545fb8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            ca_certs\u003dNone, password\u003d\u0027pass\u0027, tenant_name\u003d\u0027Tname\u0027,"},{"line_number":45,"context_line":"            username\u003d\u0027name\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_get_credentials_v3(self):"},{"line_number":48,"context_line":"        mock_function \u003d mock.Mock()"},{"line_number":49,"context_line":"        function2mock \u003d \u0027config_tempest.config_tempest.auth.get_credentials\u0027"},{"line_number":50,"context_line":"        self.useFixture(MonkeyPatch(function2mock, mock_function))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_b9aaa682","side":"PARENT","line":47,"updated":"2018-01-25 20:07:41.000000000","message":"Where are these tests are now? Or is it no longer needed?","commit_id":"a0976991b3f5298246235242d49ade2673a2f8c4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"67f3762186743a36ae06bbf2f97ea0c2be8ceaec","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            ca_certs\u003dNone, password\u003d\u0027pass\u0027, tenant_name\u003d\u0027Tname\u0027,"},{"line_number":45,"context_line":"            username\u003d\u0027name\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_get_credentials_v3(self):"},{"line_number":48,"context_line":"        mock_function \u003d mock.Mock()"},{"line_number":49,"context_line":"        function2mock \u003d \u0027config_tempest.config_tempest.auth.get_credentials\u0027"},{"line_number":50,"context_line":"        self.useFixture(MonkeyPatch(function2mock, mock_function))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_180e213b","side":"PARENT","line":47,"in_reply_to":"5f93b717_b9aaa682","updated":"2018-01-26 12:47:04.000000000","message":"As credentials were decoupled and moved to credentials.py, tests related to it were moved to test_credentials.py file. I think it\u0027s better when each file has its own test file. These two tests (test_get_credentials_v3/v2) were renamed, because the method which is tested by them was renamed too (from get_credentials to set_credentials)","commit_id":"a0976991b3f5298246235242d49ade2673a2f8c4"}]}