)]}'
{"config_tempest/credentials.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4be571adcff47f7497f76f83d40ba37da73fb57e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.password \u003d self.get_credential(\u0027password\u0027)"},{"line_number":36,"context_line":"        self.tenant_name \u003d self.get_credential(\u0027tenant_name\u0027)"},{"line_number":37,"context_line":"        self.identity_version \u003d self._get_identity_version()"},{"line_number":38,"context_line":"        self.api_version \u003d 3 if self.identity_version \u003d\u003d \"v3\" else 2"},{"line_number":39,"context_line":"        self.identity_region \u003d self._conf.get_defaulted(\u0027identity\u0027, \u0027region\u0027)"},{"line_number":40,"context_line":"        self.disable_ssl_certificate_validation \u003d self._conf.get_defaulted("},{"line_number":41,"context_line":"            \u0027identity\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_f23fbeb2","line":38,"updated":"2018-04-09 11:16:05.000000000","message":"uhm, this code seems to be new, or at least I didn\u0027t find which code is replaced - shouldn\u0027t the logic be the other way (3 by default), or is it going to break the old versions?","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d79f82daeb100fc65ed8ba2b309665be7e2da94f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.password \u003d self.get_credential(\u0027password\u0027)"},{"line_number":36,"context_line":"        self.tenant_name \u003d self.get_credential(\u0027tenant_name\u0027)"},{"line_number":37,"context_line":"        self.identity_version \u003d self._get_identity_version()"},{"line_number":38,"context_line":"        self.api_version \u003d 3 if self.identity_version \u003d\u003d \"v3\" else 2"},{"line_number":39,"context_line":"        self.identity_region \u003d self._conf.get_defaulted(\u0027identity\u0027, \u0027region\u0027)"},{"line_number":40,"context_line":"        self.disable_ssl_certificate_validation \u003d self._conf.get_defaulted("},{"line_number":41,"context_line":"            \u0027identity\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_55ba146e","line":38,"in_reply_to":"bf659307_f23fbeb2","updated":"2018-04-09 12:40:04.000000000","message":"It shouldn\u0027t be the new code, the logic should be here the same as it was, it\u0027s just interpreted differently. api_version depends on the identity_version, which is set by _get_identity_version which is based on the value of identity.uri in TempestConf object - and there it\u0027s set by set_options(...) method in config_tempest/main.py.\nSo at the end, it depends on auth_url.","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"}],"config_tempest/main.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4be571adcff47f7497f76f83d40ba37da73fb57e","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            \u0027Could not load some identity options from cloud config file\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"def check_ceilometer_service(client, conf):"},{"line_number":297,"context_line":"    try:"},{"line_number":298,"context_line":"        services \u003d client.list_services(**{\u0027type\u0027: \u0027metering\u0027})"},{"line_number":299,"context_line":"    except exceptions.Forbidden:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_129272a0","line":296,"updated":"2018-04-09 11:16:05.000000000","message":"Can\u0027t those functions check_*_service be implemented using the features exposed by config_tempest/services/*.py? I thought that this was one of the requirements for the change.","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d79f82daeb100fc65ed8ba2b309665be7e2da94f","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            \u0027Could not load some identity options from cloud config file\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"def check_ceilometer_service(client, conf):"},{"line_number":297,"context_line":"    try:"},{"line_number":298,"context_line":"        services \u003d client.list_services(**{\u0027type\u0027: \u0027metering\u0027})"},{"line_number":299,"context_line":"    except exceptions.Forbidden:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_75195886","line":296,"in_reply_to":"bf659307_129272a0","updated":"2018-04-09 12:40:04.000000000","message":"yes, I think they can be moved to config_tempest/services/* somewhere. I actually don\u0027t remember why I haven\u0027t put them there yet, maybe I thought they are too small, to have each of them separately in files .. and at the end I forgot about them.\nSure, I\u0027ll have a look and will think about the right place for them.","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4be571adcff47f7497f76f83d40ba37da73fb57e","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            conf.set(\u0027volume-feature-enabled\u0027, \u0027backup\u0027, \u0027False\u0027)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"def configure_boto(conf, services):"},{"line_number":331,"context_line":"    \"\"\"Set boto URLs based on discovered APIs.\"\"\""},{"line_number":332,"context_line":"    if services.is_service(\u0027ec2\u0027):"},{"line_number":333,"context_line":"        conf.set(\u0027boto\u0027, \u0027ec2_url\u0027, services.get_service(\u0027ec2\u0027).service_url)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_b2906697","line":330,"updated":"2018-04-09 11:16:05.000000000","message":"Same for configure_* functions (see comment above); the main should be free from service-specific knowledge (apart from maybe keystone)","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d79f82daeb100fc65ed8ba2b309665be7e2da94f","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            conf.set(\u0027volume-feature-enabled\u0027, \u0027backup\u0027, \u0027False\u0027)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"def configure_boto(conf, services):"},{"line_number":331,"context_line":"    \"\"\"Set boto URLs based on discovered APIs.\"\"\""},{"line_number":332,"context_line":"    if services.is_service(\u0027ec2\u0027):"},{"line_number":333,"context_line":"        conf.set(\u0027boto\u0027, \u0027ec2_url\u0027, services.get_service(\u0027ec2\u0027).service_url)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_d5014408","line":330,"in_reply_to":"bf659307_b2906697","updated":"2018-04-09 12:40:04.000000000","message":"Yes, I agree, I answered in the comment above.","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"}],"config_tempest/tests/services/test_services.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4be571adcff47f7497f76f83d40ba37da73fb57e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestServices(BaseConfigTempestTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    # FAKE_AUTH_DATA \u003d ("},{"line_number":27,"context_line":"    #     {"},{"line_number":28,"context_line":"    #         \u0027serviceCatalog\u0027: ["},{"line_number":29,"context_line":"    #             {"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_3240d607","line":26,"updated":"2018-04-09 11:16:05.000000000","message":"couldn\u0027t those be reenabled like before the patch?","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d79f82daeb100fc65ed8ba2b309665be7e2da94f","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestServices(BaseConfigTempestTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    # FAKE_AUTH_DATA \u003d ("},{"line_number":27,"context_line":"    #     {"},{"line_number":28,"context_line":"    #         \u0027serviceCatalog\u0027: ["},{"line_number":29,"context_line":"    #             {"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_58248baf","line":26,"in_reply_to":"bf659307_3240d607","updated":"2018-04-09 12:40:04.000000000","message":"I\u0027ll check, I will either re-enable them or delete them.","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"}],"config_tempest/tests/test_clients.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4be571adcff47f7497f76f83d40ba37da73fb57e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # self.client \u003d self._get_clients(self.conf)  # ?"},{"line_number":108,"context_line":"        self.client_manager \u003d ClientManager(self.conf, self.creds)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # def test_init_manager_as_admin(self):"},{"line_number":111,"context_line":"    #     mock_function \u003d mock.Mock(return_value\u003d{\"id\": \"my_fake_id\"})"},{"line_number":112,"context_line":"    #     func2mock \u003d (\u0027config_tempest.client_manager.ProjectsClient.\u0027"},{"line_number":113,"context_line":"    #                  \u0027get_project_by_name\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_12459215","line":110,"updated":"2018-04-09 11:16:05.000000000","message":"disabled?","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d79f82daeb100fc65ed8ba2b309665be7e2da94f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # self.client \u003d self._get_clients(self.conf)  # ?"},{"line_number":108,"context_line":"        self.client_manager \u003d ClientManager(self.conf, self.creds)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # def test_init_manager_as_admin(self):"},{"line_number":111,"context_line":"    #     mock_function \u003d mock.Mock(return_value\u003d{\"id\": \"my_fake_id\"})"},{"line_number":112,"context_line":"    #     func2mock \u003d (\u0027config_tempest.client_manager.ProjectsClient.\u0027"},{"line_number":113,"context_line":"    #                  \u0027get_project_by_name\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_386f57c6","line":110,"in_reply_to":"bf659307_12459215","updated":"2018-04-09 12:40:04.000000000","message":"Methods they were testing were changed or split up into smaller pieces, so these tests need to be rewritten. Or maybe the methods they are supposed to test are already covered by different tests .. I\u0027ll check it as well","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"}],"config_tempest/tests/test_config_tempest.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4be571adcff47f7497f76f83d40ba37da73fb57e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.assertEqual(self.conf.get(\u0027service_available\u0027, \u0027ceilometer\u0027),"},{"line_number":192,"context_line":"                         \u0027True\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    # def test_configure_boto(self):"},{"line_number":195,"context_line":"    #     tool.configure_boto(self.conf, self.FAKE_SERVICES)"},{"line_number":196,"context_line":"    #     expected_url \u003d \"http://172.16.52.151:5000\""},{"line_number":197,"context_line":"    #     self.assertEqual(self.conf.get(\"boto\", \"ec2_url\"), expected_url)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_b25386e2","line":194,"updated":"2018-04-09 11:16:05.000000000","message":"disabled?","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d79f82daeb100fc65ed8ba2b309665be7e2da94f","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.assertEqual(self.conf.get(\u0027service_available\u0027, \u0027ceilometer\u0027),"},{"line_number":192,"context_line":"                         \u0027True\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    # def test_configure_boto(self):"},{"line_number":195,"context_line":"    #     tool.configure_boto(self.conf, self.FAKE_SERVICES)"},{"line_number":196,"context_line":"    #     expected_url \u003d \"http://172.16.52.151:5000\""},{"line_number":197,"context_line":"    #     self.assertEqual(self.conf.get(\"boto\", \"ec2_url\"), expected_url)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_789aafc5","line":194,"in_reply_to":"bf659307_b25386e2","updated":"2018-04-09 12:40:04.000000000","message":"The same as other comments.","commit_id":"725c19281ca92ddd4717d296bbbe7bac3ab2cb9b"}]}