)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ec82e9d5903fc544b7ab06c93aa77c8db691dd9c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-tempestconf-tempest-packstack/devstack-demo zuul job"},{"line_number":10,"context_line":"uses generate-tempestconf-file role to generate tempest.conf."},{"line_number":11,"context_line":"Since demo is a non-admin user with non-admin user we cannout use"},{"line_number":12,"context_line":"--create option but it was used since it is a bug, so we need to"},{"line_number":13,"context_line":"check for admin/demo user then enable the proper option."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf659307_c2a5e805","line":11,"range":{"start_line":11,"start_character":54,"end_line":11,"end_character":61},"updated":"2018-03-28 11:47:47.000000000","message":"a small typo: cannot","commit_id":"a9e450fcd2e1edb677ab0ec8add3cf3010318037"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ec82e9d5903fc544b7ab06c93aa77c8db691dd9c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"--create option but it was used since it is a bug, so we need to"},{"line_number":13,"context_line":"check for admin/demo user then enable the proper option."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Used Jinja templates for creating tempest configure script"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I727a6cfd154cb3f95c33da02440f25ae1765153f"},{"line_number":18,"context_line":"Story: #2001695"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf659307_2288646f","line":15,"range":{"start_line":15,"start_character":42,"end_line":15,"end_character":51},"updated":"2018-03-28 11:47:47.000000000","message":"Probably it should be \"configuration\"","commit_id":"a9e450fcd2e1edb677ab0ec8add3cf3010318037"}],"playbooks/python-tempestconf-tempest-packstack.yaml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"4be7796429da17b405ce1108d81e088d8316cd85","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    test_demo_user: \"{{ test_demo is defined }}\""},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - debug:"},{"line_number":6,"context_line":"        msg: \"{{ test_demo_user }}\""},{"line_number":7,"context_line":"    # packstack-integration-tempest role is inherited from"},{"line_number":8,"context_line":"    # openstack/packstack project"},{"line_number":9,"context_line":"    - name: Install packstack allinone"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"9f6a8fd7_61fbaa78","line":6,"updated":"2018-04-20 08:08:09.000000000","message":"Can it be a meaningful message here? Just print the user doesn\u0027t seems functional (if it\u0027s even necessary do this)","commit_id":"a04393049647359bb4dc36577f9952912a526e61"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9c4229190d4d032462cbec66cd56037f22333382","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    test_demo_user: \"{{ test_demo is defined }}\""},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - debug:"},{"line_number":6,"context_line":"        msg: \"{{ test_demo_user }}\""},{"line_number":7,"context_line":"    # packstack-integration-tempest role is inherited from"},{"line_number":8,"context_line":"    # openstack/packstack project"},{"line_number":9,"context_line":"    - name: Install packstack allinone"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"9f6a8fd7_9843baaf","line":6,"in_reply_to":"9f6a8fd7_61fbaa78","updated":"2018-04-20 21:16:30.000000000","message":"You\u0027re right, it\u0027s not useful anymore.","commit_id":"a04393049647359bb4dc36577f9952912a526e61"}],"roles/generate-tempestconf-file/tasks/generate-tempestconf.sh.j2":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ec82e9d5903fc544b7ab06c93aa77c8db691dd9c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"discover-tempest-config \\"},{"line_number":8,"context_line":"--debug \\"},{"line_number":9,"context_line":"-v \\"},{"line_number":10,"context_line":"{% if {{ user }} \u003d\u003d \"admin\" %}"},{"line_number":11,"context_line":"--create \\"},{"line_number":12,"context_line":"{% else %}"},{"line_number":13,"context_line":"--non-admin \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bf659307_f73eacd8","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":8},"updated":"2018-03-28 11:47:47.000000000","message":"delete the brackets around user variable and it will work","commit_id":"a9e450fcd2e1edb677ab0ec8add3cf3010318037"}],"roles/generate-tempestconf-file/tasks/main.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ec82e9d5903fc544b7ab06c93aa77c8db691dd9c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - name: Generate tempest configuration script"},{"line_number":38,"context_line":"    template:"},{"line_number":39,"context_line":"        src: generate-tempestconf.sh.j2"},{"line_number":40,"context_line":"        dest: \"{{ tempestconf_src_relative_path }}i/generate-tempestconf.sh\""},{"line_number":41,"context_line":"        mode: 0744"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  - name: Generate tempest configuration file"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_17dec010","line":40,"range":{"start_line":40,"start_character":50,"end_line":40,"end_character":51},"updated":"2018-03-28 11:47:47.000000000","message":"why \"i\"?","commit_id":"a9e450fcd2e1edb677ab0ec8add3cf3010318037"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ec82e9d5903fc544b7ab06c93aa77c8db691dd9c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        mode: 0744"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  - name: Generate tempest configuration file"},{"line_number":44,"context_line":"    shell: \u003e"},{"line_number":45,"context_line":"        {{ tempestconf_src_relative_path }}i/generate-tempestconf.sh"},{"line_number":46,"context_line":"    ignore_errors: True"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_0200c000","line":44,"range":{"start_line":44,"start_character":11,"end_line":44,"end_character":12},"updated":"2018-03-28 11:47:47.000000000","message":"are you sure by this? I think there should be |","commit_id":"a9e450fcd2e1edb677ab0ec8add3cf3010318037"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ec82e9d5903fc544b7ab06c93aa77c8db691dd9c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  - name: Generate tempest configuration file"},{"line_number":44,"context_line":"    shell: \u003e"},{"line_number":45,"context_line":"        {{ tempestconf_src_relative_path }}i/generate-tempestconf.sh"},{"line_number":46,"context_line":"    ignore_errors: True"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  - name: Print generated tempest.conf and copy it to tempest directory"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_227aa487","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":68},"updated":"2018-03-28 11:47:47.000000000","message":"Maybe I would add chdir and executable parameter, like this:\nshell: |\n  ./generate-tempestconf.sh\nargs:\n  chdir: \"{{ tempestconf_src_relative_path }}\"\n  executable: /bin/bash\n\nBut if this works, I have nothing against it, I only remember I had some problems with running bash commands in shell when i didn\u0027t specified the interpreter.","commit_id":"a9e450fcd2e1edb677ab0ec8add3cf3010318037"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ec82e9d5903fc544b7ab06c93aa77c8db691dd9c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  - name: Generate tempest configuration file"},{"line_number":44,"context_line":"    shell: \u003e"},{"line_number":45,"context_line":"        {{ tempestconf_src_relative_path }}i/generate-tempestconf.sh"},{"line_number":46,"context_line":"    ignore_errors: True"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  - name: Print generated tempest.conf and copy it to tempest directory"},{"line_number":49,"context_line":"    shell: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_c209682c","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":23},"updated":"2018-03-28 11:47:47.000000000","message":"why do we want to ignore errors at this point? or is it just for debug?","commit_id":"a9e450fcd2e1edb677ab0ec8add3cf3010318037"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d332906cf0126d69266a0d96ab8d6be8d1d039f6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    shell: |"},{"line_number":45,"context_line":"        ./generate-tempestconf.sh"},{"line_number":46,"context_line":"    args:"},{"line_number":47,"context_line":"      chdirs: \"{{ tempestconf_src_relative_path }}\""},{"line_number":48,"context_line":"      executable: /bin/bash"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - name: Print generated tempest.conf and copy it to tempest directory"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bf659307_8d048316","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":12},"updated":"2018-04-04 06:52:40.000000000","message":"s/chdirs/chdir","commit_id":"3397477ea03c37adb8d98f1c7e7f7f85ceb0d980"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"4be7796429da17b405ce1108d81e088d8316cd85","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  - name: Print generated tempest.conf and copy it to the specified path"},{"line_number":66,"context_line":"    become: yes"},{"line_number":67,"context_line":"    shell: |"},{"line_number":68,"context_line":"        set -x"},{"line_number":69,"context_line":"        cat {{ tempestconf_src_relative_path }}/etc/tempest.conf"},{"line_number":70,"context_line":"        cp  {{ tempestconf_src_relative_path }}/etc/tempest.conf {{ output_path }}"},{"line_number":71,"context_line":"    when: output_path is defined"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"9f6a8fd7_214db2c3","line":68,"updated":"2018-04-20 08:08:09.000000000","message":"Now this should be a debug message, but I am okay\nAlso, let\u0027s split this, print generated tempest.conf and copy tempest.conf to specified path, don\u0027t do two things in one single task","commit_id":"a04393049647359bb4dc36577f9952912a526e61"}]}