)]}'
{"config_tempest/main.py":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"4e2b9dc41619baa3bc1c1c61ee616c7fa78bdc33","unresolved":false,"context_lines":[{"line_number":515,"context_line":"    try:"},{"line_number":516,"context_line":"        services \u003d client.list_services(**{\u0027type\u0027: \u0027metering\u0027})"},{"line_number":517,"context_line":"    except exceptions.Forbidden:"},{"line_number":518,"context_line":"        LOG.error(\"User has no permissions to list services - \""},{"line_number":519,"context_line":"                  \"metering service can\u0027t be discovered.\")"},{"line_number":520,"context_line":"        return"},{"line_number":521,"context_line":"    if services and len(services[\u0027services\u0027]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_59392df0","line":518,"updated":"2018-04-05 12:15:55.000000000","message":"Do we want just to say service can\u0027t be discovered and continue? If so, why LOG.error, since it\u0027s just a warning ?","commit_id":"c0d8efe93e1f9cde3023bba12caaf06e4b17d3d4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"98650f6281e5dde0fa4b6b6f3631a0e3c154bca1","unresolved":false,"context_lines":[{"line_number":515,"context_line":"    try:"},{"line_number":516,"context_line":"        services \u003d client.list_services(**{\u0027type\u0027: \u0027metering\u0027})"},{"line_number":517,"context_line":"    except exceptions.Forbidden:"},{"line_number":518,"context_line":"        LOG.error(\"User has no permissions to list services - \""},{"line_number":519,"context_line":"                  \"metering service can\u0027t be discovered.\")"},{"line_number":520,"context_line":"        return"},{"line_number":521,"context_line":"    if services and len(services[\u0027services\u0027]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_64e568dc","line":518,"in_reply_to":"bf659307_59392df0","updated":"2018-04-05 12:48:55.000000000","message":"I think it\u0027s more clear from the log, when we say also why the service can\u0027t be discovered.\n\nI\u0027ll change it to warning.","commit_id":"c0d8efe93e1f9cde3023bba12caaf06e4b17d3d4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"093d24b70a7b803b4a4939836221b00d299782bb","unresolved":false,"context_lines":[{"line_number":533,"context_line":"        params \u003d {\u0027binary\u0027: \u0027cinder-backup\u0027}"},{"line_number":534,"context_line":"        backup_service \u003d client.list_services(**params)"},{"line_number":535,"context_line":"    except exceptions.Forbidden:"},{"line_number":536,"context_line":"        LOG.error(\"User has no perrmissions to list services - \""},{"line_number":537,"context_line":"                  \"cinder-backup service can\u0027t be discovered.\")"},{"line_number":538,"context_line":"        return"},{"line_number":539,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_a49940d1","line":536,"updated":"2018-04-05 12:26:33.000000000","message":"purrrmission","commit_id":"c0d8efe93e1f9cde3023bba12caaf06e4b17d3d4"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"c7c57036f9a16a0d790217290958c159639ac05f","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        services \u003d client.list_services(**{\u0027type\u0027: \u0027metering\u0027})"},{"line_number":517,"context_line":"    except exceptions.Forbidden:"},{"line_number":518,"context_line":"        LOG.warning(\"User has no permissions to list services - \""},{"line_number":519,"context_line":"                    \"metering service can\u0027t be discovered.\")"},{"line_number":520,"context_line":"        return"},{"line_number":521,"context_line":"    if services and len(services[\u0027services\u0027]):"},{"line_number":522,"context_line":"        metering \u003d services[\u0027services\u0027][0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_11905795","line":519,"updated":"2018-04-06 08:27:09.000000000","message":"Usually we don\u0027t use contract form in openstack, but I don\u0027t mind.","commit_id":"c1951c379e226f1ee4ea537408c166379d7808ad"}]}
