)]}'
{"config_tempest/services/image.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"55e1d96c7bbf4ec8a661fb009682980cabd373a8","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                self.client.store_image_file(image[\u0027id\u0027], data)"},{"line_number":135,"context_line":"                return image"},{"line_number":136,"context_line":"        except Exception:"},{"line_number":137,"context_line":"            LOG.error(\"Image \u0027%s\u0027 not found, but Image creation isn\u0027t \""},{"line_number":138,"context_line":"                      \"allowed. provide an existing image_ref\", name)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def _download_image(self, id, path):"},{"line_number":141,"context_line":"        \"\"\"Download image from glance."}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_1c97423c","line":138,"range":{"start_line":137,"start_character":50,"end_line":138,"end_character":30},"updated":"2018-05-16 15:30:25.000000000","message":"it can\u0027t be allowed, there is no allow_creation parameter anymore .. it\u0027s more like: no permissions to create an image?","commit_id":"a151b5f2f42f3f0542d33a92ddce62df1ea43395"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"00185dc73f839603422ca721642a64fb072a24cb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.disk_format \u003d disk_format"},{"line_number":42,"context_line":"        self.non_admin \u003d non_admin"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def set_default_tempest_options(self, conf):"},{"line_number":45,"context_line":"        # When cirros is the image, set validation.image_ssh_user to cirros."},{"line_number":46,"context_line":"        # The option is heavily used in CI and it\u0027s also usefull for refstack,"},{"line_number":47,"context_line":"        # because we don\u0027t have to specify overrides."}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_3190f7ed","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":35},"updated":"2018-06-05 16:28:50.000000000","message":"You\u0027ve found a bug, this method is called during the discovery, what is before the image preferences are set. We will probably need to rename this method, so that is not called during the discovery and call it after image preferences are set.","commit_id":"b66d93980fd5c795487e0d31137bf4049b000630"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"52fbdc73d05af24e375717d48b85984b70f5ed4d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.disk_format \u003d disk_format"},{"line_number":42,"context_line":"        self.non_admin \u003d non_admin"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def set_default_tempest_options(self, conf):"},{"line_number":45,"context_line":"        # When cirros is the image, set validation.image_ssh_user to cirros."},{"line_number":46,"context_line":"        # The option is heavily used in CI and it\u0027s also usefull for refstack,"},{"line_number":47,"context_line":"        # because we don\u0027t have to specify overrides."}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_5129f398","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":35},"in_reply_to":"5f7c97a3_3190f7ed","updated":"2018-06-05 16:34:55.000000000","message":"or just keep it as it is and call it after the discovery?","commit_id":"b66d93980fd5c795487e0d31137bf4049b000630"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"87654044ef44faaf6e86759bf64877bee4f84702","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.disk_format \u003d disk_format"},{"line_number":42,"context_line":"        self.non_admin \u003d non_admin"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def set_default_tempest_options(self, conf):"},{"line_number":45,"context_line":"        # When cirros is the image, set validation.image_ssh_user to cirros."},{"line_number":46,"context_line":"        # The option is heavily used in CI and it\u0027s also usefull for refstack,"},{"line_number":47,"context_line":"        # because we don\u0027t have to specify overrides."}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_4c45d642","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":35},"in_reply_to":"5f7c97a3_5129f398","updated":"2018-06-05 16:39:29.000000000","message":"sure, why not, but in that case initialization of variables in __init__ can\u0027t be removed.","commit_id":"b66d93980fd5c795487e0d31137bf4049b000630"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"50bde6b1d359e7e75289671fa18ff6d38e9dcce6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        # When cirros is the image, set validation.image_ssh_user to cirros."},{"line_number":46,"context_line":"        # The option is heavily used in CI and it\u0027s also usefull for refstack,"},{"line_number":47,"context_line":"        # because we don\u0027t have to specify overrides."},{"line_number":48,"context_line":"        if \u0027cirros\u0027 in conf.get_defaulted(\u0027image\u0027,"},{"line_number":49,"context_line":"                                          \u0027http_image\u0027).rsplit(\u0027/\u0027)[-1]:"},{"line_number":50,"context_line":"            conf.set(\u0027validation\u0027, \u0027image_ssh_user\u0027, \u0027cirros\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def set_versions(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_42bbfa0d","line":49,"range":{"start_line":48,"start_character":23,"end_line":49,"end_character":56},"updated":"2018-06-10 10:06:43.000000000","message":"I don\u0027t see where image.http_image is set to conf .. I\u0027d say, if we are gonna read conf for an image, let\u0027s remove image_path variable in this class. Because otherwise we have two places where the image name is set, which can lead to something unexpected. \n\nWhat I\u0027m saying is, let\u0027s store the image path defined by --image argument/image_path variable to the conf in set_options method. Then we don\u0027t need image_path variable in ImageService class and everywhere where image_path was read we can use conf.get/get_defaulted(\u0027image\u0027, \u0027http_image\u0027)","commit_id":"ec97f7ea7ea10f685b7541f7f0cc7477630ce40e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"50bde6b1d359e7e75289671fa18ff6d38e9dcce6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        LOG.info(\"Uploading image \u0027%s\u0027 from \u0027%s\u0027\","},{"line_number":141,"context_line":"                 name, os.path.abspath(path))"},{"line_number":142,"context_line":"        if self.non_admin:"},{"line_number":143,"context_line":"            visibility \u003d \u0027private\u0027"},{"line_number":144,"context_line":"        else:"},{"line_number":145,"context_line":"            visibility \u003d \u0027public\u0027"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_22659eb5","line":143,"range":{"start_line":143,"start_character":26,"end_line":143,"end_character":33},"updated":"2018-06-10 10:06:43.000000000","message":"When I set the image as **community** visible, tempest was able to find the imageon my local machine. Let\u0027s try that and see if demo gates will pass.","commit_id":"ec97f7ea7ea10f685b7541f7f0cc7477630ce40e"}],"roles/generate-tempestconf-file-cloud/tasks/main.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"50bde6b1d359e7e75289671fa18ff6d38e9dcce6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"          --create \\"},{"line_number":37,"context_line":"          --os-cloud {{ cloud_user }} \\"},{"line_number":38,"context_line":"          auth.tempest_roles Member \\"},{"line_number":39,"context_line":"          service_available.swift False \\"},{"line_number":40,"context_line":"    args:"},{"line_number":41,"context_line":"        chdir: \"{{ tempestconf_src_relative_path }}\""},{"line_number":42,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"5f7c97a3_62b87610","line":39,"range":{"start_line":39,"start_character":39,"end_line":39,"end_character":41},"updated":"2018-06-10 10:06:43.000000000","message":"I\u0027m not sure if this can cause any problems or not, but before the last line didn\u0027t have the backslash at the end and everything worked. So let\u0027s keep it that way. Remove the backslash please.","commit_id":"ec97f7ea7ea10f685b7541f7f0cc7477630ce40e"}],"roles/generate-tempestconf-file/tasks/generate-tempestconf.sh.j2":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"50bde6b1d359e7e75289671fa18ff6d38e9dcce6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"identity.uri $OS_AUTH_URL \\"},{"line_number":19,"context_line":"identity.admin_password $OS_PASSWORD \\"},{"line_number":20,"context_line":"service_available.swift False \\"},{"line_number":21,"context_line":"{{ aditional_tempestconf_params }} \\"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"5f7c97a3_023742b2","line":21,"range":{"start_line":21,"start_character":35,"end_line":21,"end_character":36},"updated":"2018-06-10 10:06:43.000000000","message":"see my other comment about the backslash","commit_id":"ec97f7ea7ea10f685b7541f7f0cc7477630ce40e"}]}